[jira] [Comment Edited] (MCHECKSTYLE-344) StringIndexOutOfBoundsException in RuleUtil

2018-11-13 Thread JIRA 


[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685579#comment-16685579
 ] 

Manuel Jesús Recena Soto edited comment on MCHECKSTYLE-344 at 11/13/18 6:31 PM:


:+1: I would like to see this fix released.


was (Author: recena):
+1 I would like to see this fix released.

> StringIndexOutOfBoundsException in RuleUtil
> ---
>
> Key: MCHECKSTYLE-344
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-344
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>  Components: checkstyle:check
>Affects Versions: 2.17
>Reporter: fdvxxii
>Assignee: Guillaume Boué
>Priority: Major
> Fix For: 3.0.1
>
>
> {{RuleUtil}} has a bug at line 95:
> {code}
>   final int end = eventSrcName.lastIndexOf('.');
>   eventSrcName = eventSrcName.substring(0, end);  
> {code}
> This code leads to a StringIndexOutOfBoundsException if the variable does not 
> contain a period. I don't know if its a convention to have a period in that 
> string, but either way the error message should me more expressive.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (MCHECKSTYLE-344) StringIndexOutOfBoundsException in RuleUtil

2018-11-13 Thread JIRA 


[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685579#comment-16685579
 ] 

Manuel Jesús Recena Soto edited comment on MCHECKSTYLE-344 at 11/13/18 6:31 PM:


(y) I would like to see this fix released.


was (Author: recena):
:+1: I would like to see this fix released.

> StringIndexOutOfBoundsException in RuleUtil
> ---
>
> Key: MCHECKSTYLE-344
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-344
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>  Components: checkstyle:check
>Affects Versions: 2.17
>Reporter: fdvxxii
>Assignee: Guillaume Boué
>Priority: Major
> Fix For: 3.0.1
>
>
> {{RuleUtil}} has a bug at line 95:
> {code}
>   final int end = eventSrcName.lastIndexOf('.');
>   eventSrcName = eventSrcName.substring(0, end);  
> {code}
> This code leads to a StringIndexOutOfBoundsException if the variable does not 
> contain a period. I don't know if its a convention to have a period in that 
> string, but either way the error message should me more expressive.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)