[jira] [Comment Edited] (MNG-8097) Validate that each dependency->type is a type registered in an artifact handler
[
https://issues.apache.org/jira/browse/MNG-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837665#comment-17837665
]
Konrad Windszus edited comment on MNG-8097 at 4/16/24 10:56 AM:
bq. when consuming just declare the dependency type of "zip" and be done with
it.
No, as then the addedToClasspath, includesDependency and default classifier
settings from the artifact handler are not considered!
was (Author: kwin):
> when consuming just declare the dependency type of "zip" and be done with it.
No, as then the addedToClasspath, includesDependency and default classifier
settings from the artifact handler are not considered!
> Validate that each dependency->type is a type registered in an artifact
> handler
> ---
>
> Key: MNG-8097
> URL: https://issues.apache.org/jira/browse/MNG-8097
> Project: Maven
> Issue Type: New Feature
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently often the dependency's type is being set to the extension and the
> resolution is lenient, i.e. if there is no artifact handler defining the
> value given in {{dependency->type}} resolution transparently uses the type as
> extension.
> That can potentially lead to two issues:
> 1. Resolution might fail with surprising error messages like
> {code}
> Could not resolve dependencies for project : The following artifacts
> could not be resolved: : Could not transfer artifact
> ::: from/to ...
> {code}
> This is an issue for all types not defined by Maven Core itself, e.g. for
> https://jackrabbit.apache.org/filevault-package-maven-plugin/index.html which
> registers an artifact handler for type {{content-package}} with extension
> {{zip}}.
> 2. The information {{addedToClasspath}} and {{includesDependencies}} from the
> artifact handler is not evaluated
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MNG-8097) Validate that each dependency->type is a type registered in an artifact handler
[
https://issues.apache.org/jira/browse/MNG-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837664#comment-17837664
]
Tamas Cservenak edited comment on MNG-8097 at 4/16/24 10:55 AM:
You again mix things:
* (dependency) type is for downstream consumers. In project, when consuming
just declare the dependency type of "zip" and be done with it.
* when building you declare packaging "content-package"
Do not try to enforce packaging on consumer side, or type on producer side as
it makes no sense.
was (Author: cstamas):
You again mix things:
* type is for consumers. In jackrabbit, when consuming just declare the
dependency type of "zip" and be done with it.
* when building you declare packaging "content-package"
Do not try to enforce packaging on consumer side, or type on producer side as
it makes no sense.
> Validate that each dependency->type is a type registered in an artifact
> handler
> ---
>
> Key: MNG-8097
> URL: https://issues.apache.org/jira/browse/MNG-8097
> Project: Maven
> Issue Type: New Feature
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently often the dependency's type is being set to the extension and the
> resolution is lenient, i.e. if there is no artifact handler defining the
> value given in {{dependency->type}} resolution transparently uses the type as
> extension.
> That can potentially lead to two issues:
> 1. Resolution might fail with surprising error messages like
> {code}
> Could not resolve dependencies for project : The following artifacts
> could not be resolved: : Could not transfer artifact
> ::: from/to ...
> {code}
> This is an issue for all types not defined by Maven Core itself, e.g. for
> https://jackrabbit.apache.org/filevault-package-maven-plugin/index.html which
> registers an artifact handler for type {{content-package}} with extension
> {{zip}}.
> 2. The information {{addedToClasspath}} and {{includesDependencies}} from the
> artifact handler is not evaluated
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
