[jira] [Comment Edited] (MSHARED-800) Remove Maven version from pom.properties
[
https://issues.apache.org/jira/browse/MSHARED-800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761992#comment-16761992
]
Michael Osipov edited comment on MSHARED-800 at 2/6/19 7:39 PM:
Sorry, my bad, but the fact remains. It is backed by a {{Hastable}}.
was (Author: michael-o):
Sorry, my bud, but the fact remains. It is backed by a {{Hastable}}.
> Remove Maven version from pom.properties
>
>
> Key: MSHARED-800
> URL: https://issues.apache.org/jira/browse/MSHARED-800
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Hervé Boutemy
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.4.0
>
>
> Currently, generated
> {{META-INF/maven/$\{groupId\}/$\{artifactId\}/pom.properties}} contains
> {{#Created by Apache Maven $\{maven.version\}}}, which is not a reproducible
> value
> we should either remove the version, either use the same value as the
> {{Created-By}} manifest entry as defined in MSHARED-799
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (MSHARED-800) Remove Maven version from pom.properties
[
https://issues.apache.org/jira/browse/MSHARED-800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761741#comment-16761741
]
Michael Osipov edited comment on MSHARED-800 at 2/6/19 1:54 PM:
The order isn't stable because, as far as I know, it backed by a hash. It
should be at most a linked hash map or a lnked tree set. At least something
stable. Let's have another ticket for that.
{code:java}
package java.util.jar;
import java.io.FilterInputStream;
import java.io.DataOutputStream;
import java.io.InputStream;
import java.io.OutputStream;
import java.io.IOException;
import java.util.Map;
import java.util.HashMap;
import java.util.Iterator;
/**
* The Manifest class is used to maintain Manifest entry names and their
* associated Attributes. There are main Manifest Attributes as well as
* per-entry Attributes. For information on the Manifest format, please
* see the
*
* Manifest format specification.
*
* @author David Connelly
* @see Attributes
* @since 1.2
*/
public class Manifest implements Cloneable {
// manifest main attributes
private Attributes attr = new Attributes();
// manifest entries
private Map entries = new HashMap<>();
{code}
was (Author: michael-o):
The order isn't stable because, as far as I know, it backed by a hash. It
should be at most a linked hash map or a lnked tree set. At least something
stable. Let's have another ticket for that.
> Remove Maven version from pom.properties
>
>
> Key: MSHARED-800
> URL: https://issues.apache.org/jira/browse/MSHARED-800
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Hervé Boutemy
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.4.0
>
>
> Currently, generated
> {{META-INF/maven/$\{groupId\}/$\{artifactId\}/pom.properties}} contains
> {{#Created by Apache Maven $\{maven.version\}}}, which is not a reproducible
> value
> we should either remove the version, either use the same value as the
> {{Created-By}} manifest entry as defined in MSHARED-799
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (MSHARED-800) Remove Maven version from pom.properties
[
https://issues.apache.org/jira/browse/MSHARED-800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761741#comment-16761741
]
Michael Osipov edited comment on MSHARED-800 at 2/6/19 1:47 PM:
The order isn't stable because, as far as I know, it backed by a hash. It
should be at most a linked hash map or a lnked tree set. At least something
stable. Let's have another ticket for that.
was (Author: michael-o):
I order isn't stable because, as far as I know, it backed by a hash. It should
be at most a linked hash map or a lnked tree set. At least something stable.
Let's have another ticket for that.
> Remove Maven version from pom.properties
>
>
> Key: MSHARED-800
> URL: https://issues.apache.org/jira/browse/MSHARED-800
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Hervé Boutemy
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-archiver-3.4.0
>
>
> Currently, generated
> {{META-INF/maven/$\{groupId\}/$\{artifactId\}/pom.properties}} contains
> {{#Created by Apache Maven $\{maven.version\}}}, which is not a reproducible
> value
> we should either remove the version, either use the same value as the
> {{Created-By}} manifest entry as defined in MSHARED-799
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (MSHARED-800) remove Maven version from pom.properties
[
https://issues.apache.org/jira/browse/MSHARED-800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761741#comment-16761741
]
Michael Osipov edited comment on MSHARED-800 at 2/6/19 1:37 PM:
I order isn't stable because, as far as I know, it backed by a hash. It should
be at most a linked hash map or a lnked tree set. At least something stable.
Let's have another ticket for that.
was (Author: michael-o):
I order isn't stable because, as far as I know, it backed by a hash. It should
be at most a linked hash map or a lnked tree set. At least something stable.
> remove Maven version from pom.properties
>
>
> Key: MSHARED-800
> URL: https://issues.apache.org/jira/browse/MSHARED-800
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Hervé Boutemy
>Priority: Major
> Fix For: maven-archiver-3.4.0
>
>
> Currently, generated
> {{META-INF/maven/$\{groupId\}/$\{artifactId\}/pom.properties}} contains
> {{#Created by Apache Maven $\{maven.version\}}}, which is not a reproducible
> value
> we should either remove the version, either use the same value as the
> {{Created-By}} manifest entry as defined in MSHARED-799
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (MSHARED-800) remove Maven version from pom.properties
[
https://issues.apache.org/jira/browse/MSHARED-800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761545#comment-16761545
]
Michael Osipov edited comment on MSHARED-800 at 2/6/19 8:27 AM:
I think we should leave {{# Created by Apache Maven}} only at most. Everything
else is duplicate information since it can be provided via {{MANIFEST.MF}}.
Though, I dislike the {{Created by}} value because it contradicts the base
value in {{MANIFEST.MF}}.
was (Author: michael-o):
I think we should leave {{# Created by Apache Maven}} only at most. Everything
else is duplicate information since it can be provided via {{MANIFEST.MF}}.
Though, I dislike the {{Created by}} value because it contradicts the prefix in
{{MANIFEST.MF}}.
> remove Maven version from pom.properties
>
>
> Key: MSHARED-800
> URL: https://issues.apache.org/jira/browse/MSHARED-800
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Hervé Boutemy
>Priority: Major
> Fix For: maven-archiver-3.4.0
>
>
> Currently, generated
> {{META-INF/maven/$\{groupId\}/$\{artifactId\}/pom.properties}} contains
> {{#Created by Apache Maven $\{maven.version\}}}, which is not a reproducible
> value
> we should either remove the version, either use the same value as the
> {{Created-By}} manifest entry as defined in MSHARED-799
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (MSHARED-800) remove Maven version from pom.properties
[
https://issues.apache.org/jira/browse/MSHARED-800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761545#comment-16761545
]
Michael Osipov edited comment on MSHARED-800 at 2/6/19 7:17 AM:
I think we should leave {{# Created by Apache Maven}} only at most. Everything
else is duplicate information since it can be provided via {{MANIFEST.MF}}.
Though, I dislike the {{Created by}} value because it contradicts the prefix in
{{MANIFEST.MF}}.
was (Author: michael-o):
I think we should leave {{# Created by Apache Maven}} only at most. Everything
else is duplicate information since it can be provided via {{MANIFEST.MF}}.
> remove Maven version from pom.properties
>
>
> Key: MSHARED-800
> URL: https://issues.apache.org/jira/browse/MSHARED-800
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-archiver
>Affects Versions: maven-archiver-3.3.0
>Reporter: Hervé Boutemy
>Priority: Major
> Fix For: maven-archiver-3.4.0
>
>
> Currently, generated
> {{META-INF/maven/$\{groupId\}/$\{artifactId\}/pom.properties}} contains
> {{#Created by Apache Maven $\{maven.version\}}}, which is not a reproducible
> value
> we should either remove the version, either use the same value as the
> {{Created-By}} manifest entry as defined in MSHARED-799
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
