[jira] [Comment Edited] (SUREFIRE-1490) Change header of the Failsafe Report

2018-03-04 Thread Ivan Fedotov (JIRA)

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385175#comment-16385175
 ] 

Ivan Fedotov edited comment on SUREFIRE-1490 at 3/4/18 3:04 PM:


[~tibor17], customized title can override this, but I meant default values, as  
[~michael-o] said.

By default, {{FailsafeReportMojo.getName}} uses {{"report.failsafe.name"}} from 
bundle.
 But by default {{SurefireReportGenerator.doGenerateReport}} uses 
{{"report.surefire.header"}} no matter what report is executed.

May be {{FailsafeReportMojo.getTitle}} should return something like 
{{"report.failsafe.header"}} from bundle by default?


was (Author: fedyafed):
[~tibor17], customized title can override this, but I meant default values, as  
[~michael-o] said.

By default, FailsafeReportMojo.getName uses "report.failsafe.name" from bundle.
 But by default SurefireReportGenerator.doGenerateReport uses 
"report.surefire.header" no matter what report is executed.

May be FailsafeReportMojo.getTitle should return something like 
"report.failsafe.header" from bundle by default?

> Change header of the Failsafe Report
> 
>
> Key: SUREFIRE-1490
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1490
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Surefire Report Plugin
>Affects Versions: 2.20.1
>Reporter: Ivan Fedotov
>Assignee: Tibor Digana
>Priority: Minor
>
> Hi!
> I noted that the Failsafe Report's header is "Surefire Report", which is 
> quite confusing.
> Can you fix this?
> Thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (SUREFIRE-1490) Change header of the Failsafe Report

2018-03-03 Thread Michael Osipov (JIRA)

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384737#comment-16384737
 ] 

Michael Osipov edited comment on SUREFIRE-1490 at 3/3/18 4:59 PM:
--

Can you create a minimal example? I think you are referring to [this 
method|https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=blob;f=maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java;h=5929f799b2e791512f0a8f44edce7d91f36dd556;hb=HEAD#l79].
 This makes not difference between Surefire and Failsafe.


was (Author: michael-o):
Can you create a minimal example. I think you are referring to [this 
method|https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=blob;f=maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java;h=5929f799b2e791512f0a8f44edce7d91f36dd556;hb=HEAD#l79].
 This makes not difference between Surefire and Failsafe.

> Change header of the Failsafe Report
> 
>
> Key: SUREFIRE-1490
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1490
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Surefire Report Plugin
>Affects Versions: 2.20.1
>Reporter: Ivan Fedotov
>Priority: Minor
>
> Hi!
> I noted that the Failsafe Report's header is "Surefire Report", which is 
> quite confusing.
> Can you fix this?
> Thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)