[jira] [Comment Edited] (WAGON-541) Command Line Not Showing ReasonPhrase for Errors
[ https://issues.apache.org/jira/browse/WAGON-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960644#comment-16960644 ] Herve Boutemy edited comment on WAGON-541 at 10/27/19 5:49 PM: --- done in [e6c8e915f4da48df10a67fd965990e5d7b7cf03f|https://gitbox.apache.org/repos/asf?p=maven-wagon.git=commit=e6c8e915f4da48df10a67fd965990e5d7b7cf03f] important notice in [372aa52c80c2f7b458c095d837e15ebeafbdf0b7|https://gitbox.apache.org/repos/asf?p=maven-wagon.git=commit=372aa52c80c2f7b458c095d837e15ebeafbdf0b7] about Reason Phrase future: MNG-6795 created was (Author: hboutemy): done in [e6c8e915f4da48df10a67fd965990e5d7b7cf03f|https://gitbox.apache.org/repos/asf?p=maven-wagon.git=commit=e6c8e915f4da48df10a67fd965990e5d7b7cf03f] important notice in [372aa52c80c2f7b458c095d837e15ebeafbdf0b7|https://gitbox.apache.org/repos/asf?p=maven-wagon.git=commit=372aa52c80c2f7b458c095d837e15ebeafbdf0b7] about Reason Phrase future > Command Line Not Showing ReasonPhrase for Errors > > > Key: WAGON-541 > URL: https://issues.apache.org/jira/browse/WAGON-541 > Project: Maven Wagon > Issue Type: Bug > Components: wagon-http >Affects Versions: 3.2.0 > Environment: Windows 10 >Reporter: Aurelie Pluche >Assignee: Herve Boutemy >Priority: Minor > Fix For: 3.3.4 > > Attachments: MvnCmdLineV339.PNG, MvnCmdLineV339V2.PNG, > MvnCmdLineV360.PNG, MvnCmdLineV360V2.PNG > > Time Spent: 20m > Remaining Estimate: 0h > > Hi, > I work in the Azure DevOps Artifacts Packaging team at Microsoft where we > provide a Maven service to our customers. We often use a Reason-Phrase to > return information on failed requests to customers. This functionality was > available in previous versions of maven but seems to have disappeared in > Maven 3.6.0. Was this intentional? > I have included screenshots of the cmd line response using two different > maven versions (3.3.9 and 3.6.0). I intentionally made a call that would > return a 405 error to be able to get an error response. I also used the same > package. > Thanks -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (WAGON-541) Command Line Not Showing ReasonPhrase for Errors
[ https://issues.apache.org/jira/browse/WAGON-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958978#comment-16958978 ] Herve Boutemy edited comment on WAGON-541 at 10/26/19 5:24 AM: --- given reason phrase will disappear in the future given http/2, we'll need a replacement for communication between Maven and repository managers: let's find a replacement (a header?) waiting for this replacement definition, its implementation by repository managers, then deployment, we should keep the old HTTP/1.1 Reason Phrase was (Author: hboutemy): since reason phrase will disappear in the future given http/2, we'll need a replacement for communication between Maven and repository managers: let's find a replacement (a header?) waiting for this replacement definition, its implementation by repository managers, then deployment, we should keep the old HTTP/1.1 Reason Phrase > Command Line Not Showing ReasonPhrase for Errors > > > Key: WAGON-541 > URL: https://issues.apache.org/jira/browse/WAGON-541 > Project: Maven Wagon > Issue Type: Bug > Components: wagon-http >Affects Versions: 3.2.0 > Environment: Windows 10 >Reporter: Aurelie Pluche >Priority: Minor > Attachments: MvnCmdLineV339.PNG, MvnCmdLineV339V2.PNG, > MvnCmdLineV360.PNG, MvnCmdLineV360V2.PNG > > Time Spent: 10m > Remaining Estimate: 0h > > Hi, > I work in the Azure DevOps Artifacts Packaging team at Microsoft where we > provide a Maven service to our customers. We often use a Reason-Phrase to > return information on failed requests to customers. This functionality was > available in previous versions of maven but seems to have disappeared in > Maven 3.6.0. Was this intentional? > I have included screenshots of the cmd line response using two different > maven versions (3.3.9 and 3.6.0). I intentionally made a call that would > return a 405 error to be able to get an error response. I also used the same > package. > Thanks -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (WAGON-541) Command Line Not Showing ReasonPhrase for Errors
[ https://issues.apache.org/jira/browse/WAGON-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958978#comment-16958978 ] Herve Boutemy edited comment on WAGON-541 at 10/24/19 3:48 PM: --- since reason phrase will disappear in the future given http/2, we'll need a replacement for communication between Maven and repository managers: let's find a replacement (a header?) waiting for this replacement definition, its implementation by repository managers, then deployment, we should keep the old HTTP/1.1 Reason Phrase was (Author: hboutemy): since reason phrase will disappear in the future given http/2, we'll need a replacement: let's find a replacement (a header?) waiting for this replacement definition, its implementation by repository managers, then deployment, we should keep the old HTTP/1.1 Reason Phrase > Command Line Not Showing ReasonPhrase for Errors > > > Key: WAGON-541 > URL: https://issues.apache.org/jira/browse/WAGON-541 > Project: Maven Wagon > Issue Type: Bug > Components: wagon-http >Affects Versions: 3.2.0 > Environment: Windows 10 >Reporter: Aurelie Pluche >Priority: Minor > Attachments: MvnCmdLineV339.PNG, MvnCmdLineV339V2.PNG, > MvnCmdLineV360.PNG, MvnCmdLineV360V2.PNG > > Time Spent: 10m > Remaining Estimate: 0h > > Hi, > I work in the Azure DevOps Artifacts Packaging team at Microsoft where we > provide a Maven service to our customers. We often use a Reason-Phrase to > return information on failed requests to customers. This functionality was > available in previous versions of maven but seems to have disappeared in > Maven 3.6.0. Was this intentional? > I have included screenshots of the cmd line response using two different > maven versions (3.3.9 and 3.6.0). I intentionally made a call that would > return a 405 error to be able to get an error response. I also used the same > package. > Thanks -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (WAGON-541) Command Line Not Showing ReasonPhrase for Errors
[
https://issues.apache.org/jira/browse/WAGON-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760200#comment-16760200
]
Michael Osipov edited comment on WAGON-541 at 2/4/19 8:45 PM:
--
bq. It seems like the main thrust of your concern was originally that so much
of the message was repetitive information. What if you instead simply truncated
the output and only showed the first 80 chars of the phrase?
Yes, I think that 90% of the users will see the very same information as the
status code provided in contrast to {{Requested item is quarantined}}. The
problem with 80 chars is that it won't simply scale. Given that almost all
standard phrases are less than 80 chars, we'd we back at the beginning of
message duplication. Having {{Access denied to: , ReasonPhrase:
Forbidden}} does not add any value to the {{Access denied}}.
I am thinking of something like
{code}
my-server
false
{code}
This may work, but I need to evaluate this. I'd be happy if someone could
provide a PR for this.
was (Author: michael-o):
bq. It seems like the main thrust of your concern was originally that so much
of the message was repetitive information. What if you instead simply truncated
the output and only showed the first 80 chars of the phrase?
Yes, I think that 90% of the users will see the very same information as the
status code provided in contrast to {{Requested item is quarantined}}. The
problem with 80 chars is that it won't simply scale. Given that almost all
standard phrases are less than 80 chars, we'd we back at the beginning of
message duplication. Having {{Access denied to: ,
ReasonPhrase: Forbidden}} does not add any value to the {{Access denied}}.
I am thinking of something like
{code}
my-server
false
{code}
This may work, but I need to evaluate this. I'd be happy if someone could
provide a PR for this.
> Command Line Not Showing ReasonPhrase for Errors
>
>
> Key: WAGON-541
> URL: https://issues.apache.org/jira/browse/WAGON-541
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-http
>Affects Versions: 3.2.0
> Environment: Windows 10
>Reporter: Aurelie Pluche
>Priority: Minor
> Attachments: MvnCmdLineV339.PNG, MvnCmdLineV339V2.PNG,
> MvnCmdLineV360.PNG, MvnCmdLineV360V2.PNG
>
>
> Hi,
> I work in the Azure DevOps Artifacts Packaging team at Microsoft where we
> provide a Maven service to our customers. We often use a Reason-Phrase to
> return information on failed requests to customers. This functionality was
> available in previous versions of maven but seems to have disappeared in
> Maven 3.6.0. Was this intentional?
> I have included screenshots of the cmd line response using two different
> maven versions (3.3.9 and 3.6.0). I intentionally made a call that would
> return a 405 error to be able to get an error response. I also used the same
> package.
> Thanks
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (WAGON-541) Command Line Not Showing ReasonPhrase for Errors
[
https://issues.apache.org/jira/browse/WAGON-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734730#comment-16734730
]
Brian Fox edited comment on WAGON-541 at 1/5/19 1:59 AM:
-
We've also experienced this as a regression. When the server chooses to provide
additional context, it is not helpful to the user that we squash it. Maven
should pass this information on in the error so someone has a chance of
understanding what happened.
Here is a more salient example of how this handling regressed:
Maven build failures due to firewalled component before Maven 3.6.0 printed a
message like
{quote}
Access denied to: , ReasonPhrase:*Requested item is
quarantined*
{quote}
With Wagon release 3.2.0 ( Maven 3.6.0 ), the reason phrase is no longer
printed - it now looks simply like this:
{quote}
Access denied to:
{quote}
was (Author: brianf):
We've also experienced this as a regression. When the server chooses to provide
additional context, it is not helpful to the user that we squash it. Maven
should pass this information on in the error so someone has a chance of
understanding what happened.
> Command Line Not Showing ReasonPhrase for Errors
>
>
> Key: WAGON-541
> URL: https://issues.apache.org/jira/browse/WAGON-541
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-http
>Affects Versions: 3.2.0
> Environment: Windows 10
>Reporter: Aurelie Pluche
>Priority: Minor
> Attachments: MvnCmdLineV339.PNG, MvnCmdLineV339V2.PNG,
> MvnCmdLineV360.PNG, MvnCmdLineV360V2.PNG
>
>
> Hi,
> I work in the Azure DevOps Artifacts Packaging team at Microsoft where we
> provide a Maven service to our customers. We often use a Reason-Phrase to
> return information on failed requests to customers. This functionality was
> available in previous versions of maven but seems to have disappeared in
> Maven 3.6.0. Was this intentional?
> I have included screenshots of the cmd line response using two different
> maven versions (3.3.9 and 3.6.0). I intentionally made a call that would
> return a 405 error to be able to get an error response. I also used the same
> package.
> Thanks
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (WAGON-541) Command Line Not Showing ReasonPhrase for Errors
[ https://issues.apache.org/jira/browse/WAGON-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708963#comment-16708963 ] Michael Osipov edited comment on WAGON-541 at 12/4/18 4:58 PM: --- The reason phrase handling has been removed altogether. Looking at your sample screenshots doesn't reveal any beneficial information, how do "Internal Error Occured" (which is wrong for 4xx) and two UUIDs add more value that the 400 itself? Infact, those two UUIDs should rather be response headers or part of the body. Citing from RFC 7230, chapter 3.1.2: "The reason-phrase element exists for the sole purpose of providing a textual description associated with the numeric status code, mostly out of deference to earlier Internet application protocols that were more frequently used with interactive text clients.". I fail to see the textual representation of the status code here. Here is the same fun with an unhelpful message: https://www.dotnetcatch.com/2017/03/03/tfs-checkout-issue-tf400898/ was (Author: michael-o): The reason phrase handling has been removed altogether. Looking at your sample screenshots doesn't reveal any beneficial information, how do "Internal Error Occured" and two UUIDs add more value that the 400 itself? Infact, those two UUIDs should rather be response headers or part of the body. Citing from RFC 7230, chapter 3.1.2: "The reason-phrase element exists for the sole purpose of providing a textual description associated with the numeric status code, mostly out of deference to earlier Internet application protocols that were more frequently used with interactive text clients.". I fail to see the textual representation of the status code here. Here is the same fun with an unhelpful message: https://www.dotnetcatch.com/2017/03/03/tfs-checkout-issue-tf400898/ > Command Line Not Showing ReasonPhrase for Errors > > > Key: WAGON-541 > URL: https://issues.apache.org/jira/browse/WAGON-541 > Project: Maven Wagon > Issue Type: Bug > Components: wagon-http >Affects Versions: 3.2.0 > Environment: Windows 10 >Reporter: Aurelie Pluche >Priority: Minor > Attachments: MvnCmdLineV339.PNG, MvnCmdLineV339V2.PNG, > MvnCmdLineV360.PNG, MvnCmdLineV360V2.PNG > > > Hi, > I work in the Azure DevOps Artifacts Packaging team at Microsoft where we > provide a Maven service to our customers. We often use a Reason-Phrase to > return information on failed requests to customers. This functionality was > available in previous versions of maven but seems to have disappeared in > Maven 3.6.0. Was this intentional? > I have included screenshots of the cmd line response using two different > maven versions (3.3.9 and 3.6.0). I intentionally made a call that would > return a 405 error to be able to get an error response. I also used the same > package. > Thanks -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (WAGON-541) Command Line Not Showing ReasonPhrase for Errors
[ https://issues.apache.org/jira/browse/WAGON-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708963#comment-16708963 ] Michael Osipov edited comment on WAGON-541 at 12/4/18 4:33 PM: --- The reason phrase handling has been removed altogether. Looking at your sample screenshots doesn't reveal any beneficial information, how do "Internal Error Occured" and two UUIDs add more value that the 400 itself? Infact, those two UUIDs should rather be response headers or part of the body. Citing from RFC 7230, chapter 3.1.2: "The reason-phrase element exists for the sole purpose of providing a textual description associated with the numeric status code, mostly out of deference to earlier Internet application protocols that were more frequently used with interactive text clients.". I fail to see the textual representation of the status code here. was (Author: michael-o): The reason phrase handling has been removed altogether. Looking at your sample screenshots doesn't reveal any beneficial information, how does "Internal Error Occured" and two UUIDs add more value that the 400 itself. Infact Those two UUIDs should rather be response headers or part of the body. Citing from RFC 7230, chapter 3.1.2: "The reason-phrase element exists for the sole purpose of providing a textual description associated with the numeric status code, mostly out of deference to earlier Internet application protocols that were more frequently used with interactive text clients.". I fail to see the textucal representation of the status code here. > Command Line Not Showing ReasonPhrase for Errors > > > Key: WAGON-541 > URL: https://issues.apache.org/jira/browse/WAGON-541 > Project: Maven Wagon > Issue Type: Bug > Components: wagon-http >Affects Versions: 3.2.0 > Environment: Windows 10 >Reporter: Aurelie Pluche >Priority: Minor > Attachments: MvnCmdLineV339.PNG, MvnCmdLineV339V2.PNG, > MvnCmdLineV360.PNG, MvnCmdLineV360V2.PNG > > > Hi, > I work in the Azure DevOps Artifacts Packaging team at Microsoft where we > provide a Maven service to our customers. We often use a Reason-Phrase to > return information on failed requests to customers. This functionality was > available in previous versions of maven but seems to have disappeared in > Maven 3.6.0. Was this intentional? > I have included screenshots of the cmd line response using two different > maven versions (3.3.9 and 3.6.0). I intentionally made a call that would > return a 405 error to be able to get an error response. I also used the same > package. > Thanks -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (WAGON-541) Command Line Not Showing ReasonPhrase for Errors
[ https://issues.apache.org/jira/browse/WAGON-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708963#comment-16708963 ] Michael Osipov edited comment on WAGON-541 at 12/4/18 4:35 PM: --- The reason phrase handling has been removed altogether. Looking at your sample screenshots doesn't reveal any beneficial information, how do "Internal Error Occured" and two UUIDs add more value that the 400 itself? Infact, those two UUIDs should rather be response headers or part of the body. Citing from RFC 7230, chapter 3.1.2: "The reason-phrase element exists for the sole purpose of providing a textual description associated with the numeric status code, mostly out of deference to earlier Internet application protocols that were more frequently used with interactive text clients.". I fail to see the textual representation of the status code here. Here is the same fun with an unhelpful message: https://www.dotnetcatch.com/2017/03/03/tfs-checkout-issue-tf400898/ was (Author: michael-o): The reason phrase handling has been removed altogether. Looking at your sample screenshots doesn't reveal any beneficial information, how do "Internal Error Occured" and two UUIDs add more value that the 400 itself? Infact, those two UUIDs should rather be response headers or part of the body. Citing from RFC 7230, chapter 3.1.2: "The reason-phrase element exists for the sole purpose of providing a textual description associated with the numeric status code, mostly out of deference to earlier Internet application protocols that were more frequently used with interactive text clients.". I fail to see the textual representation of the status code here. > Command Line Not Showing ReasonPhrase for Errors > > > Key: WAGON-541 > URL: https://issues.apache.org/jira/browse/WAGON-541 > Project: Maven Wagon > Issue Type: Bug > Components: wagon-http >Affects Versions: 3.2.0 > Environment: Windows 10 >Reporter: Aurelie Pluche >Priority: Minor > Attachments: MvnCmdLineV339.PNG, MvnCmdLineV339V2.PNG, > MvnCmdLineV360.PNG, MvnCmdLineV360V2.PNG > > > Hi, > I work in the Azure DevOps Artifacts Packaging team at Microsoft where we > provide a Maven service to our customers. We often use a Reason-Phrase to > return information on failed requests to customers. This functionality was > available in previous versions of maven but seems to have disappeared in > Maven 3.6.0. Was this intentional? > I have included screenshots of the cmd line response using two different > maven versions (3.3.9 and 3.6.0). I intentionally made a call that would > return a 405 error to be able to get an error response. I also used the same > package. > Thanks -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (WAGON-541) Command Line Not Showing ReasonPhrase for Errors
[ https://issues.apache.org/jira/browse/WAGON-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706971#comment-16706971 ] Michael Osipov edited comment on WAGON-541 at 12/3/18 10:43 AM: This happened in WAGON-529, see the [commit|https://github.com/apache/maven-wagon/commit/53bdf1c2f1907868787fcdb2686e99eecbcc602a]. "Method Not Allowed" gives no further benefit over the status code. Do you provide custom messages which deviate from the current RFCs? It especially happened because stuff like ""Not authorized " + reasonPhrase" duplicated the output, just adding clutter and the reason phrase is optional anyway. was (Author: michael-o): This happened in WAGON-529, see the [commit|https://github.com/apache/maven-wagon/commit/53bdf1c2f1907868787fcdb2686e99eecbcc602a]. "Method Not Allowed" gives no further benefit over the status code. Do you provide custom messages which deviate from the current RFCs? > Command Line Not Showing ReasonPhrase for Errors > > > Key: WAGON-541 > URL: https://issues.apache.org/jira/browse/WAGON-541 > Project: Maven Wagon > Issue Type: Bug > Components: wagon-http >Affects Versions: 3.2.0 > Environment: Windows 10 >Reporter: Aurelie Pluche >Priority: Minor > Attachments: MvnCmdLineV339.PNG, MvnCmdLineV360.PNG > > > Hi, > I work in the Azure DevOps Artifacts Packaging team at Microsoft where we > provide a Maven service to our customers. We often use a Reason-Phrase to > return information on failed requests to customers. This functionality was > available in previous versions of maven but seems to have disappeared in > Maven 3.6.0. Was this intentional? > I have included screenshots of the cmd line response using two different > maven versions (3.3.9 and 3.6.0). I intentionally made a call that would > return a 405 error to be able to get an error response. I also used the same > package. > Thanks -- This message was sent by Atlassian JIRA (v7.6.3#76005)
