[jira] [Commented] (DOXIASITETOOLS-334) Pass basedir relative source path to Parser.parse(...) as reference argument

2024-04-02 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833267#comment-17833267
 ] 

Konrad Windszus commented on DOXIASITETOOLS-334:


I don't see how 
[https://github.com/apache/maven-doxia-sitetools/blob/96e245055fa90689ab5464a39b2bea5d4477cedf/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L584-L585]
 is related to this issue.

> Pass basedir relative source path to Parser.parse(...) as reference argument
> 
>
> Key: DOXIASITETOOLS-334
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-334
> Project: Maven Doxia Sitetools
>  Issue Type: Improvement
>  Components: Site renderer
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 2.0.0-M18
>
>
> Currently only the file name (without its path) is passed in 
> https://github.com/apache/maven-doxia-sitetools/blob/96e245055fa90689ab5464a39b2bea5d4477cedf/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L369.
>  In order to ease identifying the file the relative path should be passed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (DOXIASITETOOLS-334) Pass basedir relative source path to Parser.parse(...) as reference argument

2024-04-02 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833265#comment-17833265
 ] 

Michael Osipov commented on DOXIASITETOOLS-334:
---

Makes sense, but that change would be incomplete because 
https://github.com/apache/maven-doxia-sitetools/blob/96e245055fa90689ab5464a39b2bea5d4477cedf/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L584-L585
 needs to change as well, no?

> Pass basedir relative source path to Parser.parse(...) as reference argument
> 
>
> Key: DOXIASITETOOLS-334
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-334
> Project: Maven Doxia Sitetools
>  Issue Type: Improvement
>  Components: Site renderer
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 2.0.0-M18
>
>
> Currently only the file name (without its path) is passed in 
> https://github.com/apache/maven-doxia-sitetools/blob/96e245055fa90689ab5464a39b2bea5d4477cedf/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L369.
>  In order to ease identifying the file the relative path should be passed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (DOXIASITETOOLS-334) Pass basedir relative source path to Parser.parse(...) as reference argument

2024-04-02 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833263#comment-17833263
 ] 

Konrad Windszus commented on DOXIASITETOOLS-334:


Because the parser does otherwise not know the basedir and since DOXIA-723 uses 
the reference argument to emit log messages you see logs like
{code}
[WARNING] analyze-classes-mojo.xml, line 7, column 56: Anchor name "myanchor" 
used more than once
{code}
instead of 
{code}
[WARNING] target/generated-site/xdoc/analyze-classes-mojo.xml, line 7, column 
56: Anchor name "myanchor" used more than once
{code}

> Pass basedir relative source path to Parser.parse(...) as reference argument
> 
>
> Key: DOXIASITETOOLS-334
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-334
> Project: Maven Doxia Sitetools
>  Issue Type: Improvement
>  Components: Site renderer
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 2.0.0-M18
>
>
> Currently only the file name (without its path) is passed in 
> https://github.com/apache/maven-doxia-sitetools/blob/96e245055fa90689ab5464a39b2bea5d4477cedf/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L369.
>  In order to ease identifying the file the relative path should be passed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (DOXIASITETOOLS-334) Pass basedir relative source path to Parser.parse(...) as reference argument

2024-04-02 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833261#comment-17833261
 ] 

Michael Osipov commented on DOXIASITETOOLS-334:
---

Why? Please explain.

> Pass basedir relative source path to Parser.parse(...) as reference argument
> 
>
> Key: DOXIASITETOOLS-334
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-334
> Project: Maven Doxia Sitetools
>  Issue Type: Improvement
>  Components: Site renderer
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 2.0.0-M18
>
>
> Currently only the file name (without its path) is passed in 
> https://github.com/apache/maven-doxia-sitetools/blob/96e245055fa90689ab5464a39b2bea5d4477cedf/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L369.
>  In order to ease identifying the file the relative path should be passed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (DOXIASITETOOLS-334) Pass basedir relative source path to Parser.parse(...) as reference argument

2024-04-02 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833259#comment-17833259
 ] 

Michael Osipov commented on DOXIASITETOOLS-334:
---

For locale {{de_DE}} two files:

{noformat}
index.html, index.html, ., 
/var/osipovmi/Projekte/maven-site-plugin/target/it/template-skin/src/site/de_DE/apt,
 index.apt, index.html, ., src/site/de_DE/apt, src/site/de_DE/apt/index.apt
{noformat}
and
{noformat}
../foo/index.html, foo/index.html, .., 
/var/osipovmi/Projekte/maven-site-plugin/target/it/template-skin/src/site/de_DE/apt,
 foo/index.apt, foo/index.html, .., src/site/de_DE/apt, 
src/site/de_DE/apt/foo/index.apt
{noformat}


> Pass basedir relative source path to Parser.parse(...) as reference argument
> 
>
> Key: DOXIASITETOOLS-334
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-334
> Project: Maven Doxia Sitetools
>  Issue Type: Improvement
>  Components: Site renderer
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 2.0.0-M18
>
>
> Currently only the file name (without its path) is passed in 
> https://github.com/apache/maven-doxia-sitetools/blob/96e245055fa90689ab5464a39b2bea5d4477cedf/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L369.
>  In order to ease identifying the file the relative path should be passed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)