[jira] [Commented] (MASSEMBLY-883) Transitive dependencies with scope provided are included with jar-with-dependencies descriptor

2024-03-20 Thread Slawomir Jaranowski (Jira) 


[ 
https://issues.apache.org/jira/browse/MASSEMBLY-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828662#comment-17828662
 ] 

Slawomir Jaranowski commented on MASSEMBLY-883:
---

[~stoty] thanks for testing ... so I close it

> Transitive dependencies with scope provided are included with 
> jar-with-dependencies descriptor
> --
>
> Key: MASSEMBLY-883
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-883
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>  Components: predefined descriptors
>Affects Versions: 3.1.0
>Reporter: Francois Armand
>Priority: Major
> Fix For: 3.1.1
>
>
> In the following case as shown by {{mvn dependency:tree}}, with the 
> predifined descriptor {{jar-with-dependencies}}:
>  
> {{[INFO] +- com.jayway.jsonpath:json-path:jar:2.2.0:compile}}
> {{[INFO] | +- net.minidev:json-smart:jar:2.2.1:compile}}
> {{[INFO] | | - net.minidev:accessors-smart:jar:1.1:compile}}
> {{[INFO] | - org.slf4j:slf4j-api:jar:1.7.16:provided}}
>   
> {{json-path}}, {{json-smart}}, {{accessors-smart}} are included, as expected. 
> {{But slf4j-api}} is also included in the resulting jar.
> Other direct dependencies with scope `provided` are correctly excluded from 
> the final jar.
> If this is the intendented behavior, which is highly surprising, could you 
> document it in the corresponding descriptor documentation 
> ([http://maven.apache.org/plugins/maven-assembly-plugin/descriptor-refs.html#jar-with-dependencies).]
>  Could you also explain what descriptor would allow to achieve the desired 
> behavior (or point to a resource explaining it, I wasn't able to find one).
> Thanks.
>   



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MASSEMBLY-883) Transitive dependencies with scope provided are included with jar-with-dependencies descriptor

2024-03-19 Thread Istvan Toth (Jira) 


[ 
https://issues.apache.org/jira/browse/MASSEMBLY-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828314#comment-17828314
 ] 

Istvan Toth commented on MASSEMBLY-883:
---

I have just tested both 3.1.0 and 3.1.1 with the above repo, and the problem is 
indeed fixed with 3.1.1 (and also the latest version)

> Transitive dependencies with scope provided are included with 
> jar-with-dependencies descriptor
> --
>
> Key: MASSEMBLY-883
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-883
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>  Components: predefined descriptors
>Affects Versions: 3.1.0
>Reporter: Francois Armand
>Priority: Major
>
> In the following case as shown by {{mvn dependency:tree}}, with the 
> predifined descriptor {{jar-with-dependencies}}:
>  
> {{[INFO] +- com.jayway.jsonpath:json-path:jar:2.2.0:compile}}
> {{[INFO] | +- net.minidev:json-smart:jar:2.2.1:compile}}
> {{[INFO] | | - net.minidev:accessors-smart:jar:1.1:compile}}
> {{[INFO] | - org.slf4j:slf4j-api:jar:1.7.16:provided}}
>   
> {{json-path}}, {{json-smart}}, {{accessors-smart}} are included, as expected. 
> {{But slf4j-api}} is also included in the resulting jar.
> Other direct dependencies with scope `provided` are correctly excluded from 
> the final jar.
> If this is the intendented behavior, which is highly surprising, could you 
> document it in the corresponding descriptor documentation 
> ([http://maven.apache.org/plugins/maven-assembly-plugin/descriptor-refs.html#jar-with-dependencies).]
>  Could you also explain what descriptor would allow to achieve the desired 
> behavior (or point to a resource explaining it, I wasn't able to find one).
> Thanks.
>   



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MASSEMBLY-883) Transitive dependencies with scope provided are included with jar-with-dependencies descriptor

2018-12-27 Thread Enrico Olivelli (JIRA) 


[ 
https://issues.apache.org/jira/browse/MASSEMBLY-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729724#comment-16729724
 ] 

Enrico Olivelli commented on MASSEMBLY-883:
---

[~fanf42] this should have been fixed in current master (3.1.1-SNAPSHOT).

Can you try it ?

just clone the repo from Github and build it locally
{code:java}
mvn clean install -DskipTests{code}
 

> Transitive dependencies with scope provided are included with 
> jar-with-dependencies descriptor
> --
>
> Key: MASSEMBLY-883
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-883
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>  Components: predefined descriptors
>Affects Versions: 3.1.0
>Reporter: Francois Armand
>Priority: Major
>
> In the following case as shown by {{mvn dependency:tree}}, with the 
> predifined descriptor {{jar-with-dependencies}}:
>  
> {{[INFO] +- com.jayway.jsonpath:json-path:jar:2.2.0:compile}}
> {{[INFO] | +- net.minidev:json-smart:jar:2.2.1:compile}}
> {{[INFO] | | - net.minidev:accessors-smart:jar:1.1:compile}}
> {{[INFO] | - org.slf4j:slf4j-api:jar:1.7.16:provided}}
>   
> {{json-path}}, {{json-smart}}, {{accessors-smart}} are included, as expected. 
> {{But slf4j-api}} is also included in the resulting jar.
> Other direct dependencies with scope `provided` are correctly excluded from 
> the final jar.
> If this is the intendented behavior, which is highly surprising, could you 
> document it in the corresponding descriptor documentation 
> ([http://maven.apache.org/plugins/maven-assembly-plugin/descriptor-refs.html#jar-with-dependencies).]
>  Could you also explain what descriptor would allow to achieve the desired 
> behavior (or point to a resource explaining it, I wasn't able to find one).
> Thanks.
>   



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MASSEMBLY-883) Transitive dependencies with scope provided are included with jar-with-dependencies descriptor

2018-04-16 Thread Francois Armand (JIRA) 

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439439#comment-16439439
 ] 

Francois Armand commented on MASSEMBLY-883:
---

As explained here: 
[https://stackoverflow.com/questions/49784429/how-to-exclude-transitive-dependencies-with-scope-provided-with-maven-assembly-p]
 I believe it's a bug. I now use maven-shade-plugin whose behavior is ok.

> Transitive dependencies with scope provided are included with 
> jar-with-dependencies descriptor
> --
>
> Key: MASSEMBLY-883
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-883
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>  Components: predefined descriptors
>Affects Versions: 3.1.0
>Reporter: Francois Armand
>Priority: Major
>
> In the following case as shown by {{mvn dependency:tree}}, with the 
> predifined descriptor {{jar-with-dependencies}}:
>  
> {{[INFO] +- com.jayway.jsonpath:json-path:jar:2.2.0:compile}}
> {{[INFO] | +- net.minidev:json-smart:jar:2.2.1:compile}}
> {{[INFO] | | - net.minidev:accessors-smart:jar:1.1:compile}}
> {{[INFO] | - org.slf4j:slf4j-api:jar:1.7.16:provided}}
>   
> {{json-path}}, {{json-smart}}, {{accessors-smart}} are included, as expected. 
> {{But slf4j-api}} is also included in the resulting jar.
> Other direct dependencies with scope `provided` are correctly excluded from 
> the final jar.
> If this is the intendented behavior, which is highly surprising, could you 
> document it in the corresponding descriptor documentation 
> ([http://maven.apache.org/plugins/maven-assembly-plugin/descriptor-refs.html#jar-with-dependencies).]
>  Could you also explain what descriptor would allow to achieve the desired 
> behavior (or point to a resource explaining it, I wasn't able to find one).
> Thanks.
>   



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MASSEMBLY-883) Transitive dependencies with scope provided are included with jar-with-dependencies descriptor

2018-04-13 Thread Francois Armand (JIRA) 

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437486#comment-16437486
 ] 

Francois Armand commented on MASSEMBLY-883:
---

I added a minimal reproduction project here: 
https://github.com/fanf/test-maven-assembly/blob/master/readme.md

> Transitive dependencies with scope provided are included with 
> jar-with-dependencies descriptor
> --
>
> Key: MASSEMBLY-883
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-883
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>  Components: predefined descriptors
>Affects Versions: 3.1.0
>Reporter: Francois Armand
>Priority: Major
>
> In the following case as shown by {{mvn dependency:tree}}, with the 
> predifined descriptor {{jar-with-dependencies}}:
>  
> {{[INFO] +- com.jayway.jsonpath:json-path:jar:2.2.0:compile}}
> {{[INFO] | +- net.minidev:json-smart:jar:2.2.1:compile}}
> {{[INFO] | | - net.minidev:accessors-smart:jar:1.1:compile}}
> {{[INFO] | - org.slf4j:slf4j-api:jar:1.7.16:provided}}
>   
> {{json-path}}, {{json-smart}}, {{accessors-smart}} are included, as expected. 
> {{But slf4j-api}} is also included in the resulting jar.
> Other direct dependencies with scope `provided` are correctly excluded from 
> the final jar.
> If this is the intendented behavior, which is highly surprising, could you 
> document it in the corresponding descriptor documentation 
> ([http://maven.apache.org/plugins/maven-assembly-plugin/descriptor-refs.html#jar-with-dependencies).]
>  Could you also explain what descriptor would allow to achieve the desired 
> behavior (or point to a resource explaining it, I wasn't able to find one).
> Thanks.
>   



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)