[jira] [Commented] (MCHECKSTYLE-357) also allow inline configuration for reporting
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786031#comment-17786031 ] ASF GitHub Bot commented on MCHECKSTYLE-357: slachiewicz closed pull request #77: Bump checkstyle from 8.15 to 8.29 in /src/it/MCHECKSTYLE-357-with-header-override URL: https://github.com/apache/maven-checkstyle-plugin/pull/77 > also allow inline configuration for reporting > - > > Key: MCHECKSTYLE-357 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-357 > Project: Maven Checkstyle Plugin > Issue Type: Improvement > Components: checkstyle:checkstyle, checkstyle:checkstyle-aggregate >Affects Versions: 3.0.0 >Reporter: Peter Lamby >Assignee: Enrico Olivelli >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > MCHECKSTYLE-211 allows the inline configuration of checkstyle rules. This is > extremly helpful when you want to inherit the checkstyle configuration from a > parent pom. > Sadly it is not possible to configure the report targets this way. It would > be great if the same handling added in MCHECKSTYLE-211 would be added to the > reporting goals. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCHECKSTYLE-357) also allow inline configuration for reporting
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786032#comment-17786032 ] ASF GitHub Bot commented on MCHECKSTYLE-357: dependabot[bot] commented on PR #77: URL: https://github.com/apache/maven-checkstyle-plugin/pull/77#issuecomment-1810976914 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. > also allow inline configuration for reporting > - > > Key: MCHECKSTYLE-357 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-357 > Project: Maven Checkstyle Plugin > Issue Type: Improvement > Components: checkstyle:checkstyle, checkstyle:checkstyle-aggregate >Affects Versions: 3.0.0 >Reporter: Peter Lamby >Assignee: Enrico Olivelli >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > MCHECKSTYLE-211 allows the inline configuration of checkstyle rules. This is > extremly helpful when you want to inherit the checkstyle configuration from a > parent pom. > Sadly it is not possible to configure the report targets this way. It would > be great if the same handling added in MCHECKSTYLE-211 would be added to the > reporting goals. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCHECKSTYLE-357) also allow inline configuration for reporting
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726308#comment-16726308 ] Enrico Olivelli commented on MCHECKSTYLE-357: - Yep! Thank you > also allow inline configuration for reporting > - > > Key: MCHECKSTYLE-357 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-357 > Project: Maven Checkstyle Plugin > Issue Type: Improvement > Components: checkstyle:checkstyle, checkstyle:checkstyle-aggregate >Affects Versions: 3.0.0 >Reporter: Peter Lamby >Assignee: Enrico Olivelli >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > MCHECKSTYLE-211 allows the inline configuration of checkstyle rules. This is > extremly helpful when you want to inherit the checkstyle configuration from a > parent pom. > Sadly it is not possible to configure the report targets this way. It would > be great if the same handling added in MCHECKSTYLE-211 would be added to the > reporting goals. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MCHECKSTYLE-357) also allow inline configuration for reporting
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723967#comment-16723967 ] Peter Lamby commented on MCHECKSTYLE-357: - This can be closed now I guess. > also allow inline configuration for reporting > - > > Key: MCHECKSTYLE-357 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-357 > Project: Maven Checkstyle Plugin > Issue Type: Improvement > Components: checkstyle:checkstyle, checkstyle:checkstyle-aggregate >Affects Versions: 3.0.0 >Reporter: Peter Lamby >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > MCHECKSTYLE-211 allows the inline configuration of checkstyle rules. This is > extremly helpful when you want to inherit the checkstyle configuration from a > parent pom. > Sadly it is not possible to configure the report targets this way. It would > be great if the same handling added in MCHECKSTYLE-211 would be added to the > reporting goals. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MCHECKSTYLE-357) also allow inline configuration for reporting
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723422#comment-16723422 ] Hudson commented on MCHECKSTYLE-357: Build succeeded in Jenkins: Maven TLP » maven-checkstyle-plugin » master #41 See https://builds.apache.org/job/maven-box/job/maven-checkstyle-plugin/job/master/41/ > also allow inline configuration for reporting > - > > Key: MCHECKSTYLE-357 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-357 > Project: Maven Checkstyle Plugin > Issue Type: Improvement > Components: checkstyle:checkstyle, checkstyle:checkstyle-aggregate >Affects Versions: 3.0.0 >Reporter: Peter Lamby >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > MCHECKSTYLE-211 allows the inline configuration of checkstyle rules. This is > extremly helpful when you want to inherit the checkstyle configuration from a > parent pom. > Sadly it is not possible to configure the report targets this way. It would > be great if the same handling added in MCHECKSTYLE-211 would be added to the > reporting goals. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MCHECKSTYLE-357) also allow inline configuration for reporting
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722582#comment-16722582 ] Peter Lamby commented on MCHECKSTYLE-357: - We are waiting for documentation to be added before closing. > also allow inline configuration for reporting > - > > Key: MCHECKSTYLE-357 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-357 > Project: Maven Checkstyle Plugin > Issue Type: Improvement > Components: checkstyle:checkstyle, checkstyle:checkstyle-aggregate >Affects Versions: 3.0.0 >Reporter: Peter Lamby >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > MCHECKSTYLE-211 allows the inline configuration of checkstyle rules. This is > extremly helpful when you want to inherit the checkstyle configuration from a > parent pom. > Sadly it is not possible to configure the report targets this way. It would > be great if the same handling added in MCHECKSTYLE-211 would be added to the > reporting goals. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MCHECKSTYLE-357) also allow inline configuration for reporting
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722536#comment-16722536 ] Hudson commented on MCHECKSTYLE-357: Build succeeded in Jenkins: Maven TLP » maven-checkstyle-plugin » master #40 See https://builds.apache.org/job/maven-box/job/maven-checkstyle-plugin/job/master/40/ > also allow inline configuration for reporting > - > > Key: MCHECKSTYLE-357 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-357 > Project: Maven Checkstyle Plugin > Issue Type: Improvement > Components: checkstyle:checkstyle, checkstyle:checkstyle-aggregate >Affects Versions: 3.0.0 >Reporter: Peter Lamby >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > MCHECKSTYLE-211 allows the inline configuration of checkstyle rules. This is > extremly helpful when you want to inherit the checkstyle configuration from a > parent pom. > Sadly it is not possible to configure the report targets this way. It would > be great if the same handling added in MCHECKSTYLE-211 would be added to the > reporting goals. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MCHECKSTYLE-357) also allow inline configuration for reporting
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718733#comment-16718733 ] ASF GitHub Bot commented on MCHECKSTYLE-357: Serranya commented on issue #7: [MCHECKSTYLE-357] - Allow inline configuration for reporting URL: https://github.com/apache/maven-checkstyle-plugin/pull/7#issuecomment-446535667 I don't really understand why the CI build failed. I looked into the console log and it seems like the maven build succeeded: ``` [...] [windows-jdk9-m3.5.x_build] [INFO] multimoduleproject\pom.xml ... SUCCESS (8.7 s) [windows-jdk9-m3.5.x_build] [INFO] [windows-jdk9-m3.5.x_build] [INFO] --- maven-checkstyle-plugin:3.0.0:check (checkstyle-check) @ maven-checkstyle-plugin --- [windows-jdk9-m3.5.x_build] [INFO] There is 1 error reported by Checkstyle 6.18 with config/maven_checks.xml ruleset. [windows-jdk9-m3.5.x_build] [INFO] Ignored 1 error, 0 violation remaining. [windows-jdk9-m3.5.x_build] [INFO] [windows-jdk9-m3.5.x_build] [INFO] --- maven-invoker-plugin:3.1.0:verify (integration-test) @ maven-checkstyle-plugin --- [windows-jdk9-m3.5.x_build] [INFO] - [windows-jdk9-m3.5.x_build] [INFO] Build Summary: [windows-jdk9-m3.5.x_build] [INFO] Passed: 41, Failed: 0, Errors: 0, Skipped: 0 [windows-jdk9-m3.5.x_build] [INFO] - [windows-jdk9-m3.5.x_build] [INFO] [windows-jdk9-m3.5.x_build] [INFO] BUILD SUCCESS [windows-jdk9-m3.5.x_build] [INFO] [windows-jdk9-m3.5.x_build] [INFO] Total time: 10:12 min [windows-jdk9-m3.5.x_build] [INFO] Finished at: 2018-12-12T00:04:31-08:00 [windows-jdk9-m3.5.x_build] [INFO] Final Memory: 51M/169M ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > also allow inline configuration for reporting > - > > Key: MCHECKSTYLE-357 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-357 > Project: Maven Checkstyle Plugin > Issue Type: Improvement > Components: checkstyle:checkstyle, checkstyle:checkstyle-aggregate >Affects Versions: 3.0.0 >Reporter: Peter Lamby >Priority: Major > > MCHECKSTYLE-211 allows the inline configuration of checkstyle rules. This is > extremly helpful when you want to inherit the checkstyle configuration from a > parent pom. > Sadly it is not possible to configure the report targets this way. It would > be great if the same handling added in MCHECKSTYLE-211 would be added to the > reporting goals. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MCHECKSTYLE-357) also allow inline configuration for reporting
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718573#comment-16718573 ] ASF GitHub Bot commented on MCHECKSTYLE-357: eolivelli commented on issue #7: [MCHECKSTYLE-357] - Allow inline configuration for reporting URL: https://github.com/apache/maven-checkstyle-plugin/pull/7#issuecomment-446495043 https://builds.apache.org/job/maven-box/job/maven-checkstyle-plugin/job/MCHECKSTYLE-357/1/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > also allow inline configuration for reporting > - > > Key: MCHECKSTYLE-357 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-357 > Project: Maven Checkstyle Plugin > Issue Type: Improvement > Components: checkstyle:checkstyle, checkstyle:checkstyle-aggregate >Affects Versions: 3.0.0 >Reporter: Peter Lamby >Priority: Major > > MCHECKSTYLE-211 allows the inline configuration of checkstyle rules. This is > extremly helpful when you want to inherit the checkstyle configuration from a > parent pom. > Sadly it is not possible to configure the report targets this way. It would > be great if the same handling added in MCHECKSTYLE-211 would be added to the > reporting goals. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MCHECKSTYLE-357) also allow inline configuration for reporting
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718564#comment-16718564 ] ASF GitHub Bot commented on MCHECKSTYLE-357: eolivelli commented on issue #7: [MCHECKSTYLE-357] - also allow inline configuration for reporting URL: https://github.com/apache/maven-checkstyle-plugin/pull/7#issuecomment-446491029 Sorry for late reply. The patch looks good to me. Let's see CI results This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > also allow inline configuration for reporting > - > > Key: MCHECKSTYLE-357 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-357 > Project: Maven Checkstyle Plugin > Issue Type: Improvement > Components: checkstyle:checkstyle, checkstyle:checkstyle-aggregate >Affects Versions: 3.0.0 >Reporter: Peter Lamby >Priority: Major > > MCHECKSTYLE-211 allows the inline configuration of checkstyle rules. This is > extremly helpful when you want to inherit the checkstyle configuration from a > parent pom. > Sadly it is not possible to configure the report targets this way. It would > be great if the same handling added in MCHECKSTYLE-211 would be added to the > reporting goals. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MCHECKSTYLE-357) also allow inline configuration for reporting
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718560#comment-16718560 ] ASF GitHub Bot commented on MCHECKSTYLE-357: Serranya commented on issue #7: [MCHECKSTYLE-357] - also allow inline configuration for reporting URL: https://github.com/apache/maven-checkstyle-plugin/pull/7#issuecomment-446489371 Is there anything I can do to accelerate acceptance of this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > also allow inline configuration for reporting > - > > Key: MCHECKSTYLE-357 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-357 > Project: Maven Checkstyle Plugin > Issue Type: Improvement > Components: checkstyle:checkstyle, checkstyle:checkstyle-aggregate >Affects Versions: 3.0.0 >Reporter: Peter Lamby >Priority: Major > > MCHECKSTYLE-211 allows the inline configuration of checkstyle rules. This is > extremly helpful when you want to inherit the checkstyle configuration from a > parent pom. > Sadly it is not possible to configure the report targets this way. It would > be great if the same handling added in MCHECKSTYLE-211 would be added to the > reporting goals. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MCHECKSTYLE-357) also allow inline configuration for reporting
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714667#comment-16714667 ] ASF GitHub Bot commented on MCHECKSTYLE-357: eolivelli commented on issue #7: [MCHECKSTYLE-357] - also allow inline configuration for reporting URL: https://github.com/apache/maven-checkstyle-plugin/pull/7#issuecomment-445802078 @hboutemy this patch looks good to me. Can you give your opinion? I would like to try to run CI by my self and then commit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > also allow inline configuration for reporting > - > > Key: MCHECKSTYLE-357 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-357 > Project: Maven Checkstyle Plugin > Issue Type: Improvement > Components: checkstyle:checkstyle, checkstyle:checkstyle-aggregate >Affects Versions: 3.0.0 >Reporter: Peter Lamby >Priority: Major > > MCHECKSTYLE-211 allows the inline configuration of checkstyle rules. This is > extremly helpful when you want to inherit the checkstyle configuration from a > parent pom. > Sadly it is not possible to configure the report targets this way. It would > be great if the same handling added in MCHECKSTYLE-211 would be added to the > reporting goals. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MCHECKSTYLE-357) also allow inline configuration for reporting
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711435#comment-16711435 ] ASF GitHub Bot commented on MCHECKSTYLE-357: Serranya opened a new pull request #7: [MCHECKSTYLE-357] - also allow inline configuration for reporting URL: https://github.com/apache/maven-checkstyle-plugin/pull/7 As described in MCHECKSTYLE-357 this allowes the use of the inline configuration for the reports. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > also allow inline configuration for reporting > - > > Key: MCHECKSTYLE-357 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-357 > Project: Maven Checkstyle Plugin > Issue Type: Improvement > Components: checkstyle:checkstyle, checkstyle:checkstyle-aggregate >Affects Versions: 3.0.0 >Reporter: Peter Lamby >Priority: Minor > > MCHECKSTYLE-211 allows the inline configuration of checkstyle rules. This is > extremly helpful when you want to inherit the checkstyle configuration from a > parent pom. > Sadly it is not possible to configure the report targets this way. It would > be great if the same handling added in MCHECKSTYLE-211 would be added to the > reporting goals. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
