[jira] [Commented] (MCOMPILER-582) Release option without profile for JDK 8
[ https://issues.apache.org/jira/browse/MCOMPILER-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17826863#comment-17826863 ] ASF GitHub Bot commented on MCOMPILER-582: -- slawekjaranowski commented on PR #228: URL: https://github.com/apache/maven-compiler-plugin/pull/228#issuecomment-1995741984 @kwin - ok, I prepare a final commit - please look if was squashed ok > Release option without profile for JDK 8 > > > Key: MCOMPILER-582 > URL: https://issues.apache.org/jira/browse/MCOMPILER-582 > Project: Maven Compiler Plugin > Issue Type: New Feature >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.13.0 > > > Since plexus-compiler 2.15.0 `--release` options is automatically disregarded > for javac version < 9 > (https://github.com/codehaus-plexus/plexus-compiler/issues/140). It is no > longer necessary to guard that parameter with a profile. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCOMPILER-582) Release option without profile for JDK 8
[ https://issues.apache.org/jira/browse/MCOMPILER-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17826843#comment-17826843 ] ASF GitHub Bot commented on MCOMPILER-582: -- kwin commented on code in PR #228: URL: https://github.com/apache/maven-compiler-plugin/pull/228#discussion_r1523808841 ## src/site/apt/examples/set-compiler-release.apt.vm: ## @@ -106,3 +111,34 @@ Setting the <<<--release>>> of the Java Compiler [...] +- + +* Usage on JDK 8 - automatic detection + + Since version <<<3.13.0>>> of the Compiler Plugin and default <<>> compilerId you can skip special profile. Review Comment: ```suggestion Since version <<<3.13.0>>> of the Compiler Plugin together with the default <<>> compilerId you don't need conditional parametrisation of `release`. ``` > Release option without profile for JDK 8 > > > Key: MCOMPILER-582 > URL: https://issues.apache.org/jira/browse/MCOMPILER-582 > Project: Maven Compiler Plugin > Issue Type: New Feature >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.13.0 > > > Since plexus-compiler 2.15.0 `--release` options is automatically disregarded > for javac version < 9 > (https://github.com/codehaus-plexus/plexus-compiler/issues/140). It is no > longer necessary to guard that parameter with a profile. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCOMPILER-582) Release option without profile for JDK 8
[ https://issues.apache.org/jira/browse/MCOMPILER-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17826842#comment-17826842 ] ASF GitHub Bot commented on MCOMPILER-582: -- kwin commented on code in PR #228: URL: https://github.com/apache/maven-compiler-plugin/pull/228#discussion_r1523807553 ## src/site/apt/examples/set-compiler-release.apt.vm: ## @@ -106,3 +111,34 @@ Setting the <<<--release>>> of the Java Compiler [...] +- + +* Usage on JDK 8 - automatic detection + + Since version <<<3.13.0>>> of the Compiler Plugin and default <<>> compilerId you can skip special profile. + The <<<--release>>> option will be automatically used according to JDK used for compilation. Review Comment: ```suggestion The <<>> parameter will only be effective for Java 9 or above, otherwise the <<>> and <<>> will be passed to the compiler. ``` > Release option without profile for JDK 8 > > > Key: MCOMPILER-582 > URL: https://issues.apache.org/jira/browse/MCOMPILER-582 > Project: Maven Compiler Plugin > Issue Type: New Feature >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.13.0 > > > Since plexus-compiler 2.15.0 `--release` options is automatically disregarded > for javac version < 9 > (https://github.com/codehaus-plexus/plexus-compiler/issues/140). It is no > longer necessary to guard that parameter with a profile. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCOMPILER-582) Release option without profile for JDK 8
[ https://issues.apache.org/jira/browse/MCOMPILER-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17826841#comment-17826841 ] ASF GitHub Bot commented on MCOMPILER-582: -- kwin commented on code in PR #228: URL: https://github.com/apache/maven-compiler-plugin/pull/228#discussion_r1523805676 ## src/site/apt/examples/set-compiler-release.apt.vm: ## @@ -106,3 +111,34 @@ Setting the <<<--release>>> of the Java Compiler [...] +- + +* Usage on JDK 8 - automatic detection Review Comment: I would remove this line, as this is not really restricted to JDK8 > Release option without profile for JDK 8 > > > Key: MCOMPILER-582 > URL: https://issues.apache.org/jira/browse/MCOMPILER-582 > Project: Maven Compiler Plugin > Issue Type: New Feature >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.13.0 > > > Since plexus-compiler 2.15.0 `--release` options is automatically disregarded > for javac version < 9 > (https://github.com/codehaus-plexus/plexus-compiler/issues/140). It is no > longer necessary to guard that parameter with a profile. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCOMPILER-582) Release option without profile for JDK 8
[ https://issues.apache.org/jira/browse/MCOMPILER-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17826840#comment-17826840 ] ASF GitHub Bot commented on MCOMPILER-582: -- kwin commented on code in PR #228: URL: https://github.com/apache/maven-compiler-plugin/pull/228#discussion_r1523805011 ## src/site/apt/examples/set-compiler-release.apt.vm: ## @@ -85,7 +85,12 @@ Setting the <<<--release>>> of the Java Compiler The <<<--release>>> option is not supported using JDK 8. To enable a project that targets Java 8 to be built using JDK 8 and also JDK 9 or later requires the conditional usage of the - <<<--release>>> option. This may be done through the use of a profile: + <<<--release>>> option. + + Conditional profile is required for the Compiler Plugin version below <<<3.13.0>>> Review Comment: ```suggestion Conditional parametrization is required for the Compiler Plugin version below <<<3.13.0>>> ``` > Release option without profile for JDK 8 > > > Key: MCOMPILER-582 > URL: https://issues.apache.org/jira/browse/MCOMPILER-582 > Project: Maven Compiler Plugin > Issue Type: New Feature >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.13.0 > > > Since plexus-compiler 2.15.0 `--release` options is automatically disregarded > for javac version < 9 > (https://github.com/codehaus-plexus/plexus-compiler/issues/140). It is no > longer necessary to guard that parameter with a profile. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCOMPILER-582) Release option without profile for JDK 8
[ https://issues.apache.org/jira/browse/MCOMPILER-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17826837#comment-17826837 ] ASF GitHub Bot commented on MCOMPILER-582: -- slawekjaranowski commented on PR #228: URL: https://github.com/apache/maven-compiler-plugin/pull/228#issuecomment-1995464997 What do you think about commit subject and jira title - like: `Automatic detection of release option for JDK < 9` of course commit message will contain description what is added. My purpose of this change is to show new feature in release notes. > Release option without profile for JDK 8 > > > Key: MCOMPILER-582 > URL: https://issues.apache.org/jira/browse/MCOMPILER-582 > Project: Maven Compiler Plugin > Issue Type: New Feature >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.13.0 > > > Since plexus-compiler 2.15.0 `--release` options is automatically disregarded > for javac version < 9 > (https://github.com/codehaus-plexus/plexus-compiler/issues/140). It is no > longer necessary to guard that parameter with a profile. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCOMPILER-582) Release option without profile for JDK 8
[ https://issues.apache.org/jira/browse/MCOMPILER-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17826836#comment-17826836 ] ASF GitHub Bot commented on MCOMPILER-582: -- slawekjaranowski commented on code in PR #228: URL: https://github.com/apache/maven-compiler-plugin/pull/228#discussion_r1523800364 ## src/site/apt/examples/set-compiler-release.apt.vm: ## @@ -106,3 +106,29 @@ Setting the <<<--release>>> of the Java Compiler [...] +- + + <> since plugin version <<<3.13.0>>> you can skip special profile and simply configure as: Review Comment: next version of documentation added - please look > Release option without profile for JDK 8 > > > Key: MCOMPILER-582 > URL: https://issues.apache.org/jira/browse/MCOMPILER-582 > Project: Maven Compiler Plugin > Issue Type: New Feature >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.13.0 > > > Since plexus-compiler 2.15.0 `--release` options is automatically disregarded > for javac version < 9 > (https://github.com/codehaus-plexus/plexus-compiler/issues/140). It is no > longer necessary to guard that parameter with a profile. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCOMPILER-582) Release option without profile for JDK 8
[ https://issues.apache.org/jira/browse/MCOMPILER-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17826819#comment-17826819 ] ASF GitHub Bot commented on MCOMPILER-582: -- kwin commented on code in PR #228: URL: https://github.com/apache/maven-compiler-plugin/pull/228#discussion_r1523721789 ## src/site/apt/examples/set-compiler-release.apt.vm: ## @@ -106,3 +106,29 @@ Setting the <<<--release>>> of the Java Compiler [...] +- + + <> since plugin version <<<3.13.0>>> you can skip special profile and simply configure as: Review Comment: Also probably worth mentioning that this automatic detection only works for compiler `javac`! > Release option without profile for JDK 8 > > > Key: MCOMPILER-582 > URL: https://issues.apache.org/jira/browse/MCOMPILER-582 > Project: Maven Compiler Plugin > Issue Type: New Feature >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.13.0 > > > Since plexus-compiler 2.15.0 `--release` options is automatically disregarded > for javac version < 9 > (https://github.com/codehaus-plexus/plexus-compiler/issues/140). It is no > longer necessary to guard that parameter with a profile. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCOMPILER-582) Release option without profile for JDK 8
[ https://issues.apache.org/jira/browse/MCOMPILER-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17826818#comment-17826818 ] ASF GitHub Bot commented on MCOMPILER-582: -- kwin commented on code in PR #228: URL: https://github.com/apache/maven-compiler-plugin/pull/228#discussion_r1523714568 ## src/site/apt/examples/set-compiler-release.apt.vm: ## @@ -106,3 +106,29 @@ Setting the <<<--release>>> of the Java Compiler [...] +- + + <> since plugin version <<<3.13.0>>> you can skip special profile and simply configure as: Review Comment: I would add a note to line 86 as well that this is only necessary for plugin version < 3.13 > Release option without profile for JDK 8 > > > Key: MCOMPILER-582 > URL: https://issues.apache.org/jira/browse/MCOMPILER-582 > Project: Maven Compiler Plugin > Issue Type: New Feature >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.13.0 > > > Since plexus-compiler 2.15.0 --release options is automatically detected - we > need not to use profile -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCOMPILER-582) Release option without profile for JDK 8
[ https://issues.apache.org/jira/browse/MCOMPILER-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825396#comment-17825396 ] ASF GitHub Bot commented on MCOMPILER-582: -- slawekjaranowski opened a new pull request, #228: URL: https://github.com/apache/maven-compiler-plugin/pull/228 https://issues.apache.org/jira/browse/MCOMPILER-582 > Release option without profile for JDK 8 > > > Key: MCOMPILER-582 > URL: https://issues.apache.org/jira/browse/MCOMPILER-582 > Project: Maven Compiler Plugin > Issue Type: New Feature >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.13.0 > > > Since plexus-compiler 2.15.0 --release options is automatically detected - we > need not to use profile -- This message was sent by Atlassian Jira (v8.20.10#820010)
