[jira] [Commented] (MENFORCER-281) RequirePluginVersions broken with "CI Friendly versions"
[
https://issues.apache.org/jira/browse/MENFORCER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772663#comment-16772663
]
Tobias Schöneberg commented on MENFORCER-281:
-
I think i have the same problem that [~johnathan.gilday] has...just without
using --projects. Had so switch back to M1
> RequirePluginVersions broken with "CI Friendly versions"
>
>
> Key: MENFORCER-281
> URL: https://issues.apache.org/jira/browse/MENFORCER-281
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 1.4.1, 3.0.0-M1
>Reporter: James Nord
>Assignee: Karl Heinz Marbaise
>Priority: Critical
> Fix For: 3.0.0-M2, 3.0.0
>
>
> Maven
> [3.5.0|https://maven.apache.org/docs/3.5.0/release-notes.html#Overview_about_the_changes]
> [introduced CI friendly
> versions|https://maven.apache.org/maven-ci-friendly.html].
> However when used with [multi module
> project|https://maven.apache.org/maven-ci-friendly.html#Multi_Module_Setup]
> the enforcer fails the build as it can not resolve the parent.
> The bug is that the parent resolution of a module in the reactor is
> attempting to use the untransposed version.
> e.g.
> {noformat}
> INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (display-info) @ sub-module
> ---
> [WARNING] Rule 1: org.apache.maven.plugins.enforcer.RequirePluginVersions
> failed with message:
> Failure to find com.acme.product:parent:pom:0.9.8-${revision}SNAPSHOT in
> https://repo.acme.com/content/groups/all was cached in the local repository,
> resolution will not be reattempted until the update interval of acme-internal
> has elapsed or updates are forced
> com.acme.product:parent:pom:0.9.8-${revision}SNAPSHOT
> from the specified remote repositories:
> acme-internal (https://repo.acme.com/content/groups/all, releases=true,
> snapshots=true)
> {noformat}
> to reproduce create a new multi module project as per the linked page above.
> Add the enforcer plugin and rule to the build
> run {{mvn -Drevision=1.2.3-SNAPSHOT}} and watch the build fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MENFORCER-281) RequirePluginVersions broken with "CI Friendly versions"
[
https://issues.apache.org/jira/browse/MENFORCER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707744#comment-16707744
]
Johnathan Gilday commented on MENFORCER-281:
This issue appears to describe a problem I'm having with maven-enforcer-plugin
3.0.0-M2, ci-friendly versions, and the {{requirePluginVersions}} rule. Most of
the versions for the plugins my multi-module project uses are configured in the
parent project's {{pluginManagement}}. When I include the parent module in the
reactor, everything works as expected, but if I use the {{--projects}} flag to
build a specific module which inherits from this parent, the
{{requirePluginVersions}} rule fails. [~khmarbaise] does this make sense?
> RequirePluginVersions broken with "CI Friendly versions"
>
>
> Key: MENFORCER-281
> URL: https://issues.apache.org/jira/browse/MENFORCER-281
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 1.4.1, 3.0.0-M1
>Reporter: James Nord
>Assignee: Karl Heinz Marbaise
>Priority: Critical
> Fix For: 3.0.0-M2, 3.0.0
>
>
> Maven
> [3.5.0|https://maven.apache.org/docs/3.5.0/release-notes.html#Overview_about_the_changes]
> [introduced CI friendly
> versions|https://maven.apache.org/maven-ci-friendly.html].
> However when used with [multi module
> project|https://maven.apache.org/maven-ci-friendly.html#Multi_Module_Setup]
> the enforcer fails the build as it can not resolve the parent.
> The bug is that the parent resolution of a module in the reactor is
> attempting to use the untransposed version.
> e.g.
> {noformat}
> INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (display-info) @ sub-module
> ---
> [WARNING] Rule 1: org.apache.maven.plugins.enforcer.RequirePluginVersions
> failed with message:
> Failure to find com.acme.product:parent:pom:0.9.8-${revision}SNAPSHOT in
> https://repo.acme.com/content/groups/all was cached in the local repository,
> resolution will not be reattempted until the update interval of acme-internal
> has elapsed or updates are forced
> com.acme.product:parent:pom:0.9.8-${revision}SNAPSHOT
> from the specified remote repositories:
> acme-internal (https://repo.acme.com/content/groups/all, releases=true,
> snapshots=true)
> {noformat}
> to reproduce create a new multi module project as per the linked page above.
> Add the enforcer plugin and rule to the build
> run {{mvn -Drevision=1.2.3-SNAPSHOT}} and watch the build fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MENFORCER-281) RequirePluginVersions broken with "CI Friendly versions"
[
https://issues.apache.org/jira/browse/MENFORCER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444384#comment-16444384
]
ASF GitHub Bot commented on MENFORCER-281:
--
jglick commented on issue #28: [MENFORCER-281] added IT to show the issue.
URL: https://github.com/apache/maven-enforcer/pull/28#issuecomment-382808112
As 5311c5742da760e2910eda39698c62f7cfb3e46e specifically, with
ad0a84368f97a335a9455f04ec04bfbbb10ac49e being the fix AFAICT.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> RequirePluginVersions broken with "CI Friendly versions"
>
>
> Key: MENFORCER-281
> URL: https://issues.apache.org/jira/browse/MENFORCER-281
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 1.4.1, 3.0.0-M1
>Reporter: James Nord
>Assignee: Karl Heinz Marbaise
>Priority: Critical
> Fix For: 3.0.0
>
>
> Maven
> [3.5.0|https://maven.apache.org/docs/3.5.0/release-notes.html#Overview_about_the_changes]
> [introduced CI friendly
> versions|https://maven.apache.org/maven-ci-friendly.html].
> However when used with [multi module
> project|https://maven.apache.org/maven-ci-friendly.html#Multi_Module_Setup]
> the enforcer fails the build as it can not resolve the parent.
> The bug is that the parent resolution of a module in the reactor is
> attempting to use the untransposed version.
> e.g.
> {noformat}
> INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (display-info) @ sub-module
> ---
> [WARNING] Rule 1: org.apache.maven.plugins.enforcer.RequirePluginVersions
> failed with message:
> Failure to find com.acme.product:parent:pom:0.9.8-${revision}SNAPSHOT in
> https://repo.acme.com/content/groups/all was cached in the local repository,
> resolution will not be reattempted until the update interval of acme-internal
> has elapsed or updates are forced
> com.acme.product:parent:pom:0.9.8-${revision}SNAPSHOT
> from the specified remote repositories:
> acme-internal (https://repo.acme.com/content/groups/all, releases=true,
> snapshots=true)
> {noformat}
> to reproduce create a new multi module project as per the linked page above.
> Add the enforcer plugin and rule to the build
> run {{mvn -Drevision=1.2.3-SNAPSHOT}} and watch the build fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MENFORCER-281) RequirePluginVersions broken with "CI Friendly versions"
[
https://issues.apache.org/jira/browse/MENFORCER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315339#comment-16315339
]
ASF GitHub Bot commented on MENFORCER-281:
--
khmarbaise commented on issue #28: [MENFORCER-281] added IT to show the issue.
URL: https://github.com/apache/maven-enforcer/pull/28#issuecomment-355830138
Integrated. You can close the PR..
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> RequirePluginVersions broken with "CI Friendly versions"
>
>
> Key: MENFORCER-281
> URL: https://issues.apache.org/jira/browse/MENFORCER-281
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 1.4.1, 3.0.0-M1
>Reporter: James Nord
>Assignee: Karl Heinz Marbaise
>Priority: Critical
> Fix For: 3.0.0
>
>
> Maven
> [3.5.0|https://maven.apache.org/docs/3.5.0/release-notes.html#Overview_about_the_changes]
> [introduced CI friendly
> versions|https://maven.apache.org/maven-ci-friendly.html].
> However when used with [multi module
> project|https://maven.apache.org/maven-ci-friendly.html#Multi_Module_Setup]
> the enforcer fails the build as it can not resolve the parent.
> The bug is that the parent resolution of a module in the reactor is
> attempting to use the untransposed version.
> e.g.
> {noformat}
> INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (display-info) @ sub-module
> ---
> [WARNING] Rule 1: org.apache.maven.plugins.enforcer.RequirePluginVersions
> failed with message:
> Failure to find com.acme.product:parent:pom:0.9.8-${revision}SNAPSHOT in
> https://repo.acme.com/content/groups/all was cached in the local repository,
> resolution will not be reattempted until the update interval of acme-internal
> has elapsed or updates are forced
> com.acme.product:parent:pom:0.9.8-${revision}SNAPSHOT
> from the specified remote repositories:
> acme-internal (https://repo.acme.com/content/groups/all, releases=true,
> snapshots=true)
> {noformat}
> to reproduce create a new multi module project as per the linked page above.
> Add the enforcer plugin and rule to the build
> run {{mvn -Drevision=1.2.3-SNAPSHOT}} and watch the build fail.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MENFORCER-281) RequirePluginVersions broken with "CI Friendly versions"
[
https://issues.apache.org/jira/browse/MENFORCER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314900#comment-16314900
]
Hudson commented on MENFORCER-281:
--
Build succeeded in Jenkins: Maven TLP » maven-enforcer » master #9
See https://builds.apache.org/job/maven-box/job/maven-enforcer/job/master/9/
> RequirePluginVersions broken with "CI Friendly versions"
>
>
> Key: MENFORCER-281
> URL: https://issues.apache.org/jira/browse/MENFORCER-281
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 1.4.1, 3.0.0-M1
>Reporter: James Nord
>Assignee: Karl Heinz Marbaise
>Priority: Critical
> Fix For: 3.0.0
>
>
> Maven
> [3.5.0|https://maven.apache.org/docs/3.5.0/release-notes.html#Overview_about_the_changes]
> [introduced CI friendly
> versions|https://maven.apache.org/maven-ci-friendly.html].
> However when used with [multi module
> project|https://maven.apache.org/maven-ci-friendly.html#Multi_Module_Setup]
> the enforcer fails the build as it can not resolve the parent.
> The bug is that the parent resolution of a module in the reactor is
> attempting to use the untransposed version.
> e.g.
> {noformat}
> INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (display-info) @ sub-module
> ---
> [WARNING] Rule 1: org.apache.maven.plugins.enforcer.RequirePluginVersions
> failed with message:
> Failure to find com.acme.product:parent:pom:0.9.8-${revision}SNAPSHOT in
> https://repo.acme.com/content/groups/all was cached in the local repository,
> resolution will not be reattempted until the update interval of acme-internal
> has elapsed or updates are forced
> com.acme.product:parent:pom:0.9.8-${revision}SNAPSHOT
> from the specified remote repositories:
> acme-internal (https://repo.acme.com/content/groups/all, releases=true,
> snapshots=true)
> {noformat}
> to reproduce create a new multi module project as per the linked page above.
> Add the enforcer plugin and rule to the build
> run {{mvn -Drevision=1.2.3-SNAPSHOT}} and watch the build fail.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MENFORCER-281) RequirePluginVersions broken with "CI Friendly versions"
[
https://issues.apache.org/jira/browse/MENFORCER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314820#comment-16314820
]
Karl Heinz Marbaise commented on MENFORCER-281:
---
Thanks [~jnord_cbs] for your PR with the integration test that helps a lot.
> RequirePluginVersions broken with "CI Friendly versions"
>
>
> Key: MENFORCER-281
> URL: https://issues.apache.org/jira/browse/MENFORCER-281
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 1.4.1, 3.0.0-M1
>Reporter: James Nord
>Assignee: Karl Heinz Marbaise
>Priority: Critical
> Fix For: 3.0.0
>
>
> Maven
> [3.5.0|https://maven.apache.org/docs/3.5.0/release-notes.html#Overview_about_the_changes]
> [introduced CI friendly
> versions|https://maven.apache.org/maven-ci-friendly.html].
> However when used with [multi module
> project|https://maven.apache.org/maven-ci-friendly.html#Multi_Module_Setup]
> the enforcer fails the build as it can not resolve the parent.
> The bug is that the parent resolution of a module in the reactor is
> attempting to use the untransposed version.
> e.g.
> {noformat}
> INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (display-info) @ sub-module
> ---
> [WARNING] Rule 1: org.apache.maven.plugins.enforcer.RequirePluginVersions
> failed with message:
> Failure to find com.acme.product:parent:pom:0.9.8-${revision}SNAPSHOT in
> https://repo.acme.com/content/groups/all was cached in the local repository,
> resolution will not be reattempted until the update interval of acme-internal
> has elapsed or updates are forced
> com.acme.product:parent:pom:0.9.8-${revision}SNAPSHOT
> from the specified remote repositories:
> acme-internal (https://repo.acme.com/content/groups/all, releases=true,
> snapshots=true)
> {noformat}
> to reproduce create a new multi module project as per the linked page above.
> Add the enforcer plugin and rule to the build
> run {{mvn -Drevision=1.2.3-SNAPSHOT}} and watch the build fail.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MENFORCER-281) RequirePluginVersions broken with "CI Friendly versions"
[
https://issues.apache.org/jira/browse/MENFORCER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239045#comment-16239045
]
Simon Tunnat commented on MENFORCER-281:
Thank you for your e-mail.
I will be back from vacation on 05-11-2017.
Your e-mail will not be forwarded. So it will be personally replied after my
return.
For urgent matters please contact: Stefan Schulte (stefanit.schu...@viega.de)
Kind regards
Simon Tunnat
==
Sehr geehrte Damen und Herren,
ich befinde mich zurzeit im Urlaub und werde ab dem 05.11.2017 wieder im Büro
sein.
Ihre E-Mail bleibt in meinem Postfach und wird nach meiner Rückkehr bearbeitet.
In dringenden Fällen wenden Sie sich bitte an: Stefan Schulte
(stefanit.schu...@viega.de)
Mit Freundliche Grüßen
Simon Tunnat
> RequirePluginVersions broken with "CI Friendly versions"
>
>
> Key: MENFORCER-281
> URL: https://issues.apache.org/jira/browse/MENFORCER-281
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 1.4.1, 3.0.0-M1
>Reporter: James Nord
>Priority: Critical
>
> Maven
> [3.5.0|https://maven.apache.org/docs/3.5.0/release-notes.html#Overview_about_the_changes]
> [introduced CI friendly
> versions|https://maven.apache.org/maven-ci-friendly.html].
> However when used with [multi module
> project|https://maven.apache.org/maven-ci-friendly.html#Multi_Module_Setup]
> the enforcer fails the build as it can not resolve the parent.
> The bug is that the parent resolution of a module in the reactor is
> attempting to use the untransposed version.
> e.g.
> {noformat}
> INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (display-info) @ sub-module
> ---
> [WARNING] Rule 1: org.apache.maven.plugins.enforcer.RequirePluginVersions
> failed with message:
> Failure to find com.acme.product:parent:pom:0.9.8-${revision}SNAPSHOT in
> https://repo.acme.com/content/groups/all was cached in the local repository,
> resolution will not be reattempted until the update interval of acme-internal
> has elapsed or updates are forced
> com.acme.product:parent:pom:0.9.8-${revision}SNAPSHOT
> from the specified remote repositories:
> acme-internal (https://repo.acme.com/content/groups/all, releases=true,
> snapshots=true)
> {noformat}
> to reproduce create a new multi module project as per the linked page above.
> Add the enforcer plugin and rule to the build
> run {{mvn -Drevision=1.2.3-SNAPSHOT}} and watch the build fail.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MENFORCER-281) RequirePluginVersions broken with "CI Friendly versions"
[
https://issues.apache.org/jira/browse/MENFORCER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239042#comment-16239042
]
ASF GitHub Bot commented on MENFORCER-281:
--
jtnord opened a new pull request #28: [MENFORCER-281] added IT to show the
issue.
URL: https://github.com/apache/maven-enforcer/pull/28
Added an IT to demonstrate
[MENFORCER-281](https://issues.apache.org/jira/browse/MENFORCER-281)
Fails with the following which is slightly different to what is observed in
the real project, but is at least a starter for 10
```
[ERROR]
/org/apache/maven/its/enforcer/menforcer281-parent/$%7Brevision%7D/menforcer281-parent-$%7Brevision%7D.pom
java.lang.IllegalArgumentException: Illegal character in path at index 110:
https://X/org/apache/maven/its/enforcer/m
enforcer281-parent/${revision}/maven-metadata.xml
at java.net.URI.create(URI.java:852)
at
org.apache.maven.wagon.providers.http.httpclient.client.methods.HttpGet.(HttpGet.java:69)
at
org.apache.maven.wagon.providers.http.AbstractHttpClientWagon.fillInputData(AbstractHttpClientWagon.java:972)
at
org.apache.maven.wagon.providers.http.AbstractHttpClientWagon.fillInputData(AbstractHttpClientWagon.java:962)
at
org.apache.maven.wagon.StreamWagon.getInputStream(StreamWagon.java:126)
at org.apache.maven.wagon.StreamWagon.getIfNewer(StreamWagon.java:88)
at org.apache.maven.wagon.StreamWagon.get(StreamWagon.java:61)
at
org.apache.maven.repository.legacy.DefaultWagonManager.getRemoteFile(DefaultWagonManager.java:413)
at
org.apache.maven.repository.legacy.DefaultWagonManager.getArtifactMetadata(DefaultWagonManager.java:233)
at
org.apache.maven.artifact.repository.metadata.DefaultRepositoryMetadataManager.resolve(DefaultRepositoryMetadataManager.java:132)
at
org.apache.maven.artifact.repository.metadata.DefaultRepositoryMetadataManager.resolve(DefaultRepositoryMetadataManager.java:71)
at
org.codehaus.mojo.mrm.maven.ProxyArtifactStore.getMetadata(ProxyArtifactStore.java:480)
at
org.codehaus.mojo.mrm.maven.ProxyArtifactStore.getMetadataLastModified(ProxyArtifactStore.java:536)
at
org.codehaus.mojo.mrm.impl.maven.CompositeArtifactStore.getMetadataLastModified(CompositeArtifactStore.java:339)
at
org.codehaus.mojo.mrm.impl.maven.ArtifactStoreFileSystem.listEntries(ArtifactStoreFileSystem.java:147)
at
org.codehaus.mojo.mrm.impl.digest.AutoDigestFileSystem.listEntries(AutoDigestFileSystem.java:100)
at
org.codehaus.mojo.mrm.api.BaseFileSystem.get(BaseFileSystem.java:89)
at
org.codehaus.mojo.mrm.impl.digest.AutoDigestFileSystem.get(AutoDigestFileSystem.java:185)
at
org.codehaus.mojo.mrm.servlet.FileSystemServlet.doGet(FileSystemServlet.java:157)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at
org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487)
at
org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:362)
at
org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
at
org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:712)
at
org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:139)
at org.mortbay.jetty.Server.handle(Server.java:313)
at
org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:506)
at
org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:830)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:514)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:211)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:381)
at
org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:227)
at
org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:442)
Caused by: java.net.URISyntaxException: Illegal character in path at index
110: https://XX/org/apache/maven/its/enforc
er/menforcer281-parent/${revision}/maven-metadata.xml
at java.net.URI$Parser.fail(URI.java:2848)
at java.net.URI$Parser.checkChars(URI.java:3021)
at java.net.URI$Parser.parseHierarchical(URI.java:3105)
at java.net.URI$Parser.parse(URI.java:3053)
at java.net.URI.(URI.java:588)
at java.net.URI.create(URI.java:850)
... 33 more
[INFO] ..FAILED (5.7 s)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to
[jira] [Commented] (MENFORCER-281) RequirePluginVersions broken with "CI Friendly versions"
[
https://issues.apache.org/jira/browse/MENFORCER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220107#comment-16220107
]
ASF GitHub Bot commented on MENFORCER-281:
--
asfgit closed pull request #28: [MENFORCER-281] added IT to show the issue.
URL: https://github.com/apache/maven-enforcer/pull/28
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/maven-enforcer-plugin/src/it/projects/require-plugin-versions-mm-ci-friendly/invoker.properties
b/maven-enforcer-plugin/src/it/projects/require-plugin-versions-mm-ci-friendly/invoker.properties
new file mode 100644
index 000..a07d2f1
--- /dev/null
+++
b/maven-enforcer-plugin/src/it/projects/require-plugin-versions-mm-ci-friendly/invoker.properties
@@ -0,0 +1,17 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+invoker.goals = install -Drevision=0.10.0-SNAPSHOT
\ No newline at end of file
diff --git
a/maven-enforcer-plugin/src/it/projects/require-plugin-versions-mm-ci-friendly/menforcer281-module/pom.xml
b/maven-enforcer-plugin/src/it/projects/require-plugin-versions-mm-ci-friendly/menforcer281-module/pom.xml
new file mode 100644
index 000..a6807af
--- /dev/null
+++
b/maven-enforcer-plugin/src/it/projects/require-plugin-versions-mm-ci-friendly/menforcer281-module/pom.xml
@@ -0,0 +1,36 @@
+
+
+
+
+
+ 4.0.0
+
+org.apache.maven.its.enforcer
+menforcer281-parent
+${revision}
+
+
+ menforcer281-module
+ pom
+
+
+
+
+
diff --git
a/maven-enforcer-plugin/src/it/projects/require-plugin-versions-mm-ci-friendly/pom.xml
b/maven-enforcer-plugin/src/it/projects/require-plugin-versions-mm-ci-friendly/pom.xml
new file mode 100644
index 000..e9d613b
--- /dev/null
+++
b/maven-enforcer-plugin/src/it/projects/require-plugin-versions-mm-ci-friendly/pom.xml
@@ -0,0 +1,115 @@
+
+
+
+
+
+ 4.0.0
+
+ org.apache.maven.its.enforcer
+ menforcer281-parent
+ ${revision}
+ pom
+
+
+
+
+
+0.0.1-SNAPSHOT
+
+
+
+
+
+
+ org.apache.maven.plugins
+ maven-clean-plugin
+ 2.5
+
+
+ org.apache.maven.plugins
+ maven-resources-plugin
+ 2.6
+
+
+ org.apache.maven.plugins
+ maven-compiler-plugin
+ 2.5.1
+
+
+ org.apache.maven.plugins
+ maven-surefire-plugin
+ 2.12.4
+
+
+ org.apache.maven.plugins
+ maven-jar-plugin
+ 2.4
+
+
+ org.apache.maven.plugins
+ maven-install-plugin
+ 2.4
+
+
+ org.apache.maven.plugins
+ maven-deploy-plugin
+ 2.7
+
+
+ org.apache.maven.plugins
+ maven-site-plugin
+ 3.2
+
+
+ org.apache.maven.plugins
+ maven-enforcer-plugin
+ @project.version@
+
+
+ test
+
+enforce
+
+
+
+
+false
+
+
+
+
+
+
+
+
+
+
+
+org.apache.maven.plugins
+maven-enforcer-plugin
+@project.version@
+
+
+
+
+
+menforcer281-module
+
+
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> RequirePluginVersions broken with "CI Friendly versions"
>
>
> Key: MENFORCER-281
> URL: https://issues.apache.org/jira/browse/MENFORCER-281
> Project: Maven Enforcer Plugin
>
[jira] [Commented] (MENFORCER-281) RequirePluginVersions broken with "CI Friendly versions"
[
https://issues.apache.org/jira/browse/MENFORCER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161247#comment-16161247
]
James Nord commented on MENFORCER-281:
--
This likely hits many other enforcer rules that use
{{org.apache.maven.plugins.enforcer.utils.EnforcerRuleUtils.getModelsRecursively(String,
String, String, File)}}
> RequirePluginVersions broken with "CI Friendly versions"
>
>
> Key: MENFORCER-281
> URL: https://issues.apache.org/jira/browse/MENFORCER-281
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 1.4.1, 3.0.0-M1
>Reporter: James Nord
>Priority: Critical
>
> Maven
> [3.5.0|https://maven.apache.org/docs/3.5.0/release-notes.html#Overview_about_the_changes]
> [introduced CI friendly
> versions|https://maven.apache.org/maven-ci-friendly.html].
> However when used with [multi module
> project|https://maven.apache.org/maven-ci-friendly.html#Multi_Module_Setup]
> the enforcer fails the build as it can not resolve the parent.
> The bug is that the parent resolution of a module in the reactor is
> attempting to use the untransposed version.
> e.g.
> {noformat}
> INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (display-info) @ sub-module
> ---
> [WARNING] Rule 1: org.apache.maven.plugins.enforcer.RequirePluginVersions
> failed with message:
> Failure to find com.acme.product:parent:pom:0.9.8-${revision}SNAPSHOT in
> https://repo.acme.com/content/groups/all was cached in the local repository,
> resolution will not be reattempted until the update interval of acme-internal
> has elapsed or updates are forced
> com.acme.product:parent:pom:0.9.8-${revision}SNAPSHOT
> from the specified remote repositories:
> acme-internal (https://repo.acme.com/content/groups/all, releases=true,
> snapshots=true)
> {noformat}
> to reproduce create a new multi module project as per the linked page above.
> Add the enforcer plugin and rule to the build
> run {{mvn -Drevision=1.2.3-SNAPSHOT}} and watch the build fail.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MENFORCER-281) RequirePluginVersions broken with "CI Friendly versions"
[
https://issues.apache.org/jira/browse/MENFORCER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161233#comment-16161233
]
ASF GitHub Bot commented on MENFORCER-281:
--
GitHub user jtnord opened a pull request:
https://github.com/apache/maven-enforcer/pull/28
[MENFORCER-281] added IT to show the issue.
Added an IT to demonstrate
[MENFORCER-281](https://issues.apache.org/jira/browse/MENFORCER-281)
Fails with the following which is slightly different to what is observed in
the real project, but is at least a starter for 10
```
[ERROR]
/org/apache/maven/its/enforcer/menforcer281-parent/$%7Brevision%7D/menforcer281-parent-$%7Brevision%7D.pom
java.lang.IllegalArgumentException: Illegal character in path at index 110:
https://X/org/apache/maven/its/enforcer/m
enforcer281-parent/${revision}/maven-metadata.xml
at java.net.URI.create(URI.java:852)
at
org.apache.maven.wagon.providers.http.httpclient.client.methods.HttpGet.(HttpGet.java:69)
at
org.apache.maven.wagon.providers.http.AbstractHttpClientWagon.fillInputData(AbstractHttpClientWagon.java:972)
at
org.apache.maven.wagon.providers.http.AbstractHttpClientWagon.fillInputData(AbstractHttpClientWagon.java:962)
at
org.apache.maven.wagon.StreamWagon.getInputStream(StreamWagon.java:126)
at
org.apache.maven.wagon.StreamWagon.getIfNewer(StreamWagon.java:88)
at org.apache.maven.wagon.StreamWagon.get(StreamWagon.java:61)
at
org.apache.maven.repository.legacy.DefaultWagonManager.getRemoteFile(DefaultWagonManager.java:413)
at
org.apache.maven.repository.legacy.DefaultWagonManager.getArtifactMetadata(DefaultWagonManager.java:233)
at
org.apache.maven.artifact.repository.metadata.DefaultRepositoryMetadataManager.resolve(DefaultRepositoryMetadataManager.java:132)
at
org.apache.maven.artifact.repository.metadata.DefaultRepositoryMetadataManager.resolve(DefaultRepositoryMetadataManager.java:71)
at
org.codehaus.mojo.mrm.maven.ProxyArtifactStore.getMetadata(ProxyArtifactStore.java:480)
at
org.codehaus.mojo.mrm.maven.ProxyArtifactStore.getMetadataLastModified(ProxyArtifactStore.java:536)
at
org.codehaus.mojo.mrm.impl.maven.CompositeArtifactStore.getMetadataLastModified(CompositeArtifactStore.java:339)
at
org.codehaus.mojo.mrm.impl.maven.ArtifactStoreFileSystem.listEntries(ArtifactStoreFileSystem.java:147)
at
org.codehaus.mojo.mrm.impl.digest.AutoDigestFileSystem.listEntries(AutoDigestFileSystem.java:100)
at
org.codehaus.mojo.mrm.api.BaseFileSystem.get(BaseFileSystem.java:89)
at
org.codehaus.mojo.mrm.impl.digest.AutoDigestFileSystem.get(AutoDigestFileSystem.java:185)
at
org.codehaus.mojo.mrm.servlet.FileSystemServlet.doGet(FileSystemServlet.java:157)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at
org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487)
at
org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:362)
at
org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
at
org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:712)
at
org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:139)
at org.mortbay.jetty.Server.handle(Server.java:313)
at
org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:506)
at
org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:830)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:514)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:211)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:381)
at
org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:227)
at
org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:442)
Caused by: java.net.URISyntaxException: Illegal character in path at index
110: https://XX/org/apache/maven/its/enforc
er/menforcer281-parent/${revision}/maven-metadata.xml
at java.net.URI$Parser.fail(URI.java:2848)
at java.net.URI$Parser.checkChars(URI.java:3021)
at java.net.URI$Parser.parseHierarchical(URI.java:3105)
at java.net.URI$Parser.parse(URI.java:3053)
at java.net.URI.(URI.java:588)
at java.net.URI.create(URI.java:850)
... 33 more
[INFO] ..FAILED (5.7 s)
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jtnord/maven-enforcer MENFORCER-281
