[jira] [Commented] (MINVOKER-224) Unable to set cloneProjectsTo to null
[
https://issues.apache.org/jira/browse/MINVOKER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475719#comment-16475719
]
Tomer Cohen commented on MINVOKER-224:
--
[~olamy] Is there an ETA for when the version (which I see right now is stamped
as 3.1.0) is to be released? Thanks!
> Unable to set cloneProjectsTo to null
> -
>
> Key: MINVOKER-224
> URL: https://issues.apache.org/jira/browse/MINVOKER-224
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Phillip Webb
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Major
> Fix For: 3.1.0
>
>
> [MINVOKER-219|https://issues.apache.org/jira/browse/MINVOKER-219] changed the
> default value of {{cloneProjectsTo}} to {{target/its}}. This change
> unfortunately now makes it impossible to have a {{null}} value, meaning that
> in-place invocation is no longer supported. From the Javadoc:
> {quote}Directory to which projects should be cloned prior to execution. If
> set to null, each integration test will be run in the directory in which the
> corresponding IT POM was found. In this case, you most likely want to
> configure your SCM to ignore target and build.log in the test's base
> directory.{quote}
> Is it possible to revert this change, or to provide a alternative property to
> allow cloning to be skipped?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINVOKER-224) Unable to set cloneProjectsTo to null
[
https://issues.apache.org/jira/browse/MINVOKER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419758#comment-16419758
]
Phillip Webb commented on MINVOKER-224:
---
Thanks [~olamy]
> Unable to set cloneProjectsTo to null
> -
>
> Key: MINVOKER-224
> URL: https://issues.apache.org/jira/browse/MINVOKER-224
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Phillip Webb
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Major
> Fix For: 3.0.2
>
>
> [MINVOKER-219|https://issues.apache.org/jira/browse/MINVOKER-219] changed the
> default value of {{cloneProjectsTo}} to {{target/its}}. This change
> unfortunately now makes it impossible to have a {{null}} value, meaning that
> in-place invocation is no longer supported. From the Javadoc:
> {quote}Directory to which projects should be cloned prior to execution. If
> set to null, each integration test will be run in the directory in which the
> corresponding IT POM was found. In this case, you most likely want to
> configure your SCM to ignore target and build.log in the test's base
> directory.{quote}
> Is it possible to revert this change, or to provide a alternative property to
> allow cloning to be skipped?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINVOKER-224) Unable to set cloneProjectsTo to null
[
https://issues.apache.org/jira/browse/MINVOKER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418407#comment-16418407
]
Hudson commented on MINVOKER-224:
-
Build succeeded in Jenkins: Maven TLP » maven-invoker-plugin » master #7
See
https://builds.apache.org/job/maven-box/job/maven-invoker-plugin/job/master/7/
> Unable to set cloneProjectsTo to null
> -
>
> Key: MINVOKER-224
> URL: https://issues.apache.org/jira/browse/MINVOKER-224
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Phillip Webb
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Major
> Fix For: 3.0.2
>
>
> [MINVOKER-219|https://issues.apache.org/jira/browse/MINVOKER-219] changed the
> default value of {{cloneProjectsTo}} to {{target/its}}. This change
> unfortunately now makes it impossible to have a {{null}} value, meaning that
> in-place invocation is no longer supported. From the Javadoc:
> {quote}Directory to which projects should be cloned prior to execution. If
> set to null, each integration test will be run in the directory in which the
> corresponding IT POM was found. In this case, you most likely want to
> configure your SCM to ignore target and build.log in the test's base
> directory.{quote}
> Is it possible to revert this change, or to provide a alternative property to
> allow cloning to be skipped?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINVOKER-224) Unable to set cloneProjectsTo to null
[
https://issues.apache.org/jira/browse/MINVOKER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418374#comment-16418374
]
Olivier Lamy (*$^¨%`£) commented on MINVOKER-224:
-
implemented and tested with [~pwebb] project.
All good mate!
> Unable to set cloneProjectsTo to null
> -
>
> Key: MINVOKER-224
> URL: https://issues.apache.org/jira/browse/MINVOKER-224
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Phillip Webb
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Major
> Fix For: 3.0.2
>
>
> [MINVOKER-219|https://issues.apache.org/jira/browse/MINVOKER-219] changed the
> default value of {{cloneProjectsTo}} to {{target/its}}. This change
> unfortunately now makes it impossible to have a {{null}} value, meaning that
> in-place invocation is no longer supported. From the Javadoc:
> {quote}Directory to which projects should be cloned prior to execution. If
> set to null, each integration test will be run in the directory in which the
> corresponding IT POM was found. In this case, you most likely want to
> configure your SCM to ignore target and build.log in the test's base
> directory.{quote}
> Is it possible to revert this change, or to provide a alternative property to
> allow cloning to be skipped?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINVOKER-224) Unable to set cloneProjectsTo to null
[
https://issues.apache.org/jira/browse/MINVOKER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418372#comment-16418372
]
ASF GitHub Bot commented on MINVOKER-224:
-
olamy closed pull request #2: MINVOKER-224
URL: https://github.com/apache/maven-invoker-plugin/pull/2
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/it/clone-maven-plugin-packaging/invoker.properties
b/src/it/clone-maven-plugin-packaging/invoker.properties
new file mode 100644
index 000..f45dd01
--- /dev/null
+++ b/src/it/clone-maven-plugin-packaging/invoker.properties
@@ -0,0 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# NOTE: Don't clean here to be able to detect test failures
+invoker.goals = initialize
diff --git a/src/it/clone-maven-plugin-packaging/pom.xml
b/src/it/clone-maven-plugin-packaging/pom.xml
new file mode 100644
index 000..d3f9f85
--- /dev/null
+++ b/src/it/clone-maven-plugin-packaging/pom.xml
@@ -0,0 +1,65 @@
+
+
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;>
+ 4.0.0
+
+ org.apache.maven.plugins.invoker
+ clone-maven-plugin-packaging
+ 1.0-SNAPSHOT
+ maven-plugin
+
+ Test to check for cloned project of packaging
maven-plugin.
+
+
+UTF-8
+
+
+
+
+
+org.apache.maven.plugins
+maven-invoker-plugin
+@pom.version@
+
+ ${project.build.directory}/it
+ true
+
+*/pom.xml
+
+
+validate
+
+
+
+
+integration-test
+initialize
+
+ run
+
+
+
+
+
+
+
+
diff --git a/src/it/clone-maven-plugin-packaging/src/it/clone-clean/pom.xml
b/src/it/clone-maven-plugin-packaging/src/it/clone-clean/pom.xml
new file mode 100644
index 000..267fcdb
--- /dev/null
+++ b/src/it/clone-maven-plugin-packaging/src/it/clone-clean/pom.xml
@@ -0,0 +1,32 @@
+
+
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;>
+ 4.0.0
+ test
+ clone-clean
+ 0.1-SNAPSHOT
+ jar
+
+
+UTF-8
+
+
diff --git a/src/it/clone-maven-plugin-packaging/verify.bsh
b/src/it/clone-maven-plugin-packaging/verify.bsh
new file mode 100644
index 000..2ee7280
--- /dev/null
+++ b/src/it/clone-maven-plugin-packaging/verify.bsh
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.*;
+
+try
+{
+File itRoot = new File( basedir, "target/it/clone-clean" );
+return itRoot.exists();
+}
+catch( Throwable t )
+{
+t.printStackTrace();
+return false;
+}
diff --git a/src/it/local-repo-default/pom.xml
b/src/it/local-repo-default/pom.xml
index d993004..b601efb 100644
--- a/src/it/local-repo-default/pom.xml
+++ b/src/it/local-repo-default/pom.xml
@@ -43,6 +43,7 @@ under the License.
maven-invoker-plugin
@pom.version@
+
[jira] [Commented] (MINVOKER-224) Unable to set cloneProjectsTo to null
[
https://issues.apache.org/jira/browse/MINVOKER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418371#comment-16418371
]
Olivier Lamy (*$^¨%`£) commented on MINVOKER-224:
-
https://github.com/apache/maven-invoker-plugin/pull/2
> Unable to set cloneProjectsTo to null
> -
>
> Key: MINVOKER-224
> URL: https://issues.apache.org/jira/browse/MINVOKER-224
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Phillip Webb
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Major
> Fix For: 3.0.2
>
>
> [MINVOKER-219|https://issues.apache.org/jira/browse/MINVOKER-219] changed the
> default value of {{cloneProjectsTo}} to {{target/its}}. This change
> unfortunately now makes it impossible to have a {{null}} value, meaning that
> in-place invocation is no longer supported. From the Javadoc:
> {quote}Directory to which projects should be cloned prior to execution. If
> set to null, each integration test will be run in the directory in which the
> corresponding IT POM was found. In this case, you most likely want to
> configure your SCM to ignore target and build.log in the test's base
> directory.{quote}
> Is it possible to revert this change, or to provide a alternative property to
> allow cloning to be skipped?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINVOKER-224) Unable to set cloneProjectsTo to null
[
https://issues.apache.org/jira/browse/MINVOKER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418370#comment-16418370
]
ASF GitHub Bot commented on MINVOKER-224:
-
olamy opened a new pull request #2: MINVOKER-224
URL: https://github.com/apache/maven-invoker-plugin/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unable to set cloneProjectsTo to null
> -
>
> Key: MINVOKER-224
> URL: https://issues.apache.org/jira/browse/MINVOKER-224
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Phillip Webb
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Major
> Fix For: 3.0.2
>
>
> [MINVOKER-219|https://issues.apache.org/jira/browse/MINVOKER-219] changed the
> default value of {{cloneProjectsTo}} to {{target/its}}. This change
> unfortunately now makes it impossible to have a {{null}} value, meaning that
> in-place invocation is no longer supported. From the Javadoc:
> {quote}Directory to which projects should be cloned prior to execution. If
> set to null, each integration test will be run in the directory in which the
> corresponding IT POM was found. In this case, you most likely want to
> configure your SCM to ignore target and build.log in the test's base
> directory.{quote}
> Is it possible to revert this change, or to provide a alternative property to
> allow cloning to be skipped?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINVOKER-224) Unable to set cloneProjectsTo to null
[
https://issues.apache.org/jira/browse/MINVOKER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418187#comment-16418187
]
Olivier Lamy (*$^¨%`£) commented on MINVOKER-224:
-
LGTM I will implement the fix.
> Unable to set cloneProjectsTo to null
> -
>
> Key: MINVOKER-224
> URL: https://issues.apache.org/jira/browse/MINVOKER-224
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Phillip Webb
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Major
> Fix For: 3.0.2
>
>
> [MINVOKER-219|https://issues.apache.org/jira/browse/MINVOKER-219] changed the
> default value of {{cloneProjectsTo}} to {{target/its}}. This change
> unfortunately now makes it impossible to have a {{null}} value, meaning that
> in-place invocation is no longer supported. From the Javadoc:
> {quote}Directory to which projects should be cloned prior to execution. If
> set to null, each integration test will be run in the directory in which the
> corresponding IT POM was found. In this case, you most likely want to
> configure your SCM to ignore target and build.log in the test's base
> directory.{quote}
> Is it possible to revert this change, or to provide a alternative property to
> allow cloning to be skipped?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINVOKER-224) Unable to set cloneProjectsTo to null
[
https://issues.apache.org/jira/browse/MINVOKER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418150#comment-16418150
]
Phillip Webb commented on MINVOKER-224:
---
If I understand correctly you're suggesting only setting the default
{{closeProjectsTo}} value if you're building a Maven Plugin, otherwise it will
be {{null}}. I think that will work find for us. I basically need to be able to
run [this
build|https://github.com/spring-projects/spring-boot/blob/770cbfae0e1046eeddff31c1d9b777401b565a8d/spring-boot-samples-invoker/pom.xml#L21].
> Unable to set cloneProjectsTo to null
> -
>
> Key: MINVOKER-224
> URL: https://issues.apache.org/jira/browse/MINVOKER-224
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Phillip Webb
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.0.2
>
>
> [MINVOKER-219|https://issues.apache.org/jira/browse/MINVOKER-219] changed the
> default value of {{cloneProjectsTo}} to {{target/its}}. This change
> unfortunately now makes it impossible to have a {{null}} value, meaning that
> in-place invocation is no longer supported. From the Javadoc:
> {quote}Directory to which projects should be cloned prior to execution. If
> set to null, each integration test will be run in the directory in which the
> corresponding IT POM was found. In this case, you most likely want to
> configure your SCM to ignore target and build.log in the test's base
> directory.{quote}
> Is it possible to revert this change, or to provide a alternative property to
> allow cloning to be skipped?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINVOKER-224) Unable to set cloneProjectsTo to null
[
https://issues.apache.org/jira/browse/MINVOKER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418124#comment-16418124
]
Olivier Lamy (*$^¨%`£) commented on MINVOKER-224:
-
not sure if it helps [~pwebb] ?
> Unable to set cloneProjectsTo to null
> -
>
> Key: MINVOKER-224
> URL: https://issues.apache.org/jira/browse/MINVOKER-224
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Phillip Webb
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.0.2
>
>
> [MINVOKER-219|https://issues.apache.org/jira/browse/MINVOKER-219] changed the
> default value of {{cloneProjectsTo}} to {{target/its}}. This change
> unfortunately now makes it impossible to have a {{null}} value, meaning that
> in-place invocation is no longer supported. From the Javadoc:
> {quote}Directory to which projects should be cloned prior to execution. If
> set to null, each integration test will be run in the directory in which the
> corresponding IT POM was found. In this case, you most likely want to
> configure your SCM to ignore target and build.log in the test's base
> directory.{quote}
> Is it possible to revert this change, or to provide a alternative property to
> allow cloning to be skipped?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINVOKER-224) Unable to set cloneProjectsTo to null
[
https://issues.apache.org/jira/browse/MINVOKER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417765#comment-16417765
]
Robert Scholte commented on MINVOKER-224:
-
Hmm, I don't like the idea that we introduce just another new parameter, which
would result in a chain of parameters to match. MINVOKER-219 is best practice
for Maven plugins, so how about to only set {{cloneProjectsTo}} when the
{{"maven-plugin".equals( project.getPackaging() )}}
> Unable to set cloneProjectsTo to null
> -
>
> Key: MINVOKER-224
> URL: https://issues.apache.org/jira/browse/MINVOKER-224
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Phillip Webb
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.0.2
>
>
> [MINVOKER-219|https://issues.apache.org/jira/browse/MINVOKER-219] changed the
> default value of {{cloneProjectsTo}} to {{target/its}}. This change
> unfortunately now makes it impossible to have a {{null}} value, meaning that
> in-place invocation is no longer supported. From the Javadoc:
> {quote}Directory to which projects should be cloned prior to execution. If
> set to null, each integration test will be run in the directory in which the
> corresponding IT POM was found. In this case, you most likely want to
> configure your SCM to ignore target and build.log in the test's base
> directory.{quote}
> Is it possible to revert this change, or to provide a alternative property to
> allow cloning to be skipped?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINVOKER-224) Unable to set cloneProjectsTo to null
[
https://issues.apache.org/jira/browse/MINVOKER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416882#comment-16416882
]
Olivier Lamy (*$^¨%`£) commented on MINVOKER-224:
-
[~rfscholte] what about skipCloning property?
> Unable to set cloneProjectsTo to null
> -
>
> Key: MINVOKER-224
> URL: https://issues.apache.org/jira/browse/MINVOKER-224
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Phillip Webb
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.0.2
>
>
> [MINVOKER-219|https://issues.apache.org/jira/browse/MINVOKER-219] changed the
> default value of {{cloneProjectsTo}} to {{target/its}}. This change
> unfortunately now makes it impossible to have a {{null}} value, meaning that
> in-place invocation is no longer supported. From the Javadoc:
> {quote}Directory to which projects should be cloned prior to execution. If
> set to null, each integration test will be run in the directory in which the
> corresponding IT POM was found. In this case, you most likely want to
> configure your SCM to ignore target and build.log in the test's base
> directory.{quote}
> Is it possible to revert this change, or to provide a alternative property to
> allow cloning to be skipped?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
