[jira] [Commented] (MJAVADOC-569) javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when mixing Java modules and non-modules
[ https://issues.apache.org/jira/browse/MJAVADOC-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757619#comment-16757619 ] Robert Scholte commented on MJAVADOC-569: - It is unrelated to the description of this issue (javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when mixing Java modules and non-modules). Reopening MJAVADOC-568 makes more sense. > javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when > mixing Java modules and non-modules > - > > Key: MJAVADOC-569 > URL: https://issues.apache.org/jira/browse/MJAVADOC-569 > Project: Maven Javadoc Plugin > Issue Type: Bug > Environment: maven-javadoc-plugin 3.1.0-SNAPSHOT > Java 12-ea+28 >Reporter: Gili >Assignee: Robert Scholte >Priority: Blocker > Attachments: export-to-testcase.zip, testcase.zip > > > # Unpack testcase > # Run {{mvn clean package javadoc:aggregate -e}} > # {{javadoc:aggregate}} will fail with various errors like "(package > org.w3c.dom is declared in module java.xml, but module module2 does not read > it)" > Note that module 2 isn't really a Java Module but we are treating it as such > for the purposes of aggregating Javadoc across modularized and > non-modularized code. Module 2 has no way of declaring its intention of > reading the aforementioned package because it does not have a > {{module-info.java}} file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MJAVADOC-569) javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when mixing Java modules and non-modules
[ https://issues.apache.org/jira/browse/MJAVADOC-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757610#comment-16757610 ] Gili commented on MJAVADOC-569: --- Do you plan to reopen this issue or should I file a new bug report with the aforementioned testcase (for adding a patch-mechanism for this case)? > javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when > mixing Java modules and non-modules > - > > Key: MJAVADOC-569 > URL: https://issues.apache.org/jira/browse/MJAVADOC-569 > Project: Maven Javadoc Plugin > Issue Type: Bug > Environment: maven-javadoc-plugin 3.1.0-SNAPSHOT > Java 12-ea+28 >Reporter: Gili >Assignee: Robert Scholte >Priority: Blocker > Attachments: export-to-testcase.zip, testcase.zip > > > # Unpack testcase > # Run {{mvn clean package javadoc:aggregate -e}} > # {{javadoc:aggregate}} will fail with various errors like "(package > org.w3c.dom is declared in module java.xml, but module module2 does not read > it)" > Note that module 2 isn't really a Java Module but we are treating it as such > for the purposes of aggregating Javadoc across modularized and > non-modularized code. Module 2 has no way of declaring its intention of > reading the aforementioned package because it does not have a > {{module-info.java}} file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MJAVADOC-569) javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when mixing Java modules and non-modules
[ https://issues.apache.org/jira/browse/MJAVADOC-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757593#comment-16757593 ] Robert Scholte commented on MJAVADOC-569: - Having a closer look at it, I think you are right: we probably need the patch-mechanism here as well. > javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when > mixing Java modules and non-modules > - > > Key: MJAVADOC-569 > URL: https://issues.apache.org/jira/browse/MJAVADOC-569 > Project: Maven Javadoc Plugin > Issue Type: Bug > Environment: maven-javadoc-plugin 3.1.0-SNAPSHOT > Java 12-ea+28 >Reporter: Gili >Assignee: Robert Scholte >Priority: Blocker > Attachments: export-to-testcase.zip, testcase.zip > > > # Unpack testcase > # Run {{mvn clean package javadoc:aggregate -e}} > # {{javadoc:aggregate}} will fail with various errors like "(package > org.w3c.dom is declared in module java.xml, but module module2 does not read > it)" > Note that module 2 isn't really a Java Module but we are treating it as such > for the purposes of aggregating Javadoc across modularized and > non-modularized code. Module 2 has no way of declaring its intention of > reading the aforementioned package because it does not have a > {{module-info.java}} file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MJAVADOC-569) javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when mixing Java modules and non-modules
[ https://issues.apache.org/jira/browse/MJAVADOC-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757577#comment-16757577 ] Robert Scholte commented on MJAVADOC-569: - I missed those questions, but here are my thoughts: - I don't understand why the export to the unnamed module is required. If both module1 and module2 are available on the modulepath I would expect them to see each other. So we need to finetune that. - The plugin has the info to calculate if the {{export to}} is relevant. But if module2 has a dependency on module1, then it makes sense to add it to the modulepath, otherwise (if it had a module descriptor) it wouldn;t even compile. > javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when > mixing Java modules and non-modules > - > > Key: MJAVADOC-569 > URL: https://issues.apache.org/jira/browse/MJAVADOC-569 > Project: Maven Javadoc Plugin > Issue Type: Bug > Environment: maven-javadoc-plugin 3.1.0-SNAPSHOT > Java 12-ea+28 >Reporter: Gili >Assignee: Robert Scholte >Priority: Blocker > Attachments: export-to-testcase.zip, testcase.zip > > > # Unpack testcase > # Run {{mvn clean package javadoc:aggregate -e}} > # {{javadoc:aggregate}} will fail with various errors like "(package > org.w3c.dom is declared in module java.xml, but module module2 does not read > it)" > Note that module 2 isn't really a Java Module but we are treating it as such > for the purposes of aggregating Javadoc across modularized and > non-modularized code. Module 2 has no way of declaring its intention of > reading the aforementioned package because it does not have a > {{module-info.java}} file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MJAVADOC-569) javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when mixing Java modules and non-modules
[ https://issues.apache.org/jira/browse/MJAVADOC-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757347#comment-16757347 ] Gili commented on MJAVADOC-569: --- Wow. That is not intuitive but makes a lot of sense. Thank you for pointing this out! :) There are still 2 outstanding questions in this comment you haven't answered: https://issues.apache.org/jira/browse/MJAVADOC-569?focusedCommentId=16753250=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16753250 Any ideas? Once that's done I will consider this issue closed. Thanks. > javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when > mixing Java modules and non-modules > - > > Key: MJAVADOC-569 > URL: https://issues.apache.org/jira/browse/MJAVADOC-569 > Project: Maven Javadoc Plugin > Issue Type: Bug > Environment: maven-javadoc-plugin 3.1.0-SNAPSHOT > Java 12-ea+28 >Reporter: Gili >Assignee: Robert Scholte >Priority: Blocker > Attachments: export-to-testcase.zip, testcase.zip > > > # Unpack testcase > # Run {{mvn clean package javadoc:aggregate -e}} > # {{javadoc:aggregate}} will fail with various errors like "(package > org.w3c.dom is declared in module java.xml, but module module2 does not read > it)" > Note that module 2 isn't really a Java Module but we are treating it as such > for the purposes of aggregating Javadoc across modularized and > non-modularized code. Module 2 has no way of declaring its intention of > reading the aforementioned package because it does not have a > {{module-info.java}} file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MJAVADOC-569) javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when mixing Java modules and non-modules
[ https://issues.apache.org/jira/browse/MJAVADOC-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756453#comment-16756453 ] Robert Scholte commented on MJAVADOC-569: - I think this is by design. The module-summary shows the public or exported packages. For module1 there are none. However the pages are generated so module2 can refer to them. > javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when > mixing Java modules and non-modules > - > > Key: MJAVADOC-569 > URL: https://issues.apache.org/jira/browse/MJAVADOC-569 > Project: Maven Javadoc Plugin > Issue Type: Bug > Environment: maven-javadoc-plugin 3.1.0-SNAPSHOT > Java 12-ea+28 >Reporter: Gili >Assignee: Robert Scholte >Priority: Blocker > Attachments: export-to-testcase.zip, testcase.zip > > > # Unpack testcase > # Run {{mvn clean package javadoc:aggregate -e}} > # {{javadoc:aggregate}} will fail with various errors like "(package > org.w3c.dom is declared in module java.xml, but module module2 does not read > it)" > Note that module 2 isn't really a Java Module but we are treating it as such > for the purposes of aggregating Javadoc across modularized and > non-modularized code. Module 2 has no way of declaring its intention of > reading the aforementioned package because it does not have a > {{module-info.java}} file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MJAVADOC-569) javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when mixing Java modules and non-modules
[ https://issues.apache.org/jira/browse/MJAVADOC-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756060#comment-16756060 ] Gili commented on MJAVADOC-569: --- [~rfscholte] Sorry to nudge, but do you plan to reopen this issue or should I file a separate issue for all posts since this one was closed? > javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when > mixing Java modules and non-modules > - > > Key: MJAVADOC-569 > URL: https://issues.apache.org/jira/browse/MJAVADOC-569 > Project: Maven Javadoc Plugin > Issue Type: Bug > Environment: maven-javadoc-plugin 3.1.0-SNAPSHOT > Java 12-ea+28 >Reporter: Gili >Assignee: Robert Scholte >Priority: Blocker > Attachments: export-to-testcase.zip, testcase.zip > > > # Unpack testcase > # Run {{mvn clean package javadoc:aggregate -e}} > # {{javadoc:aggregate}} will fail with various errors like "(package > org.w3c.dom is declared in module java.xml, but module module2 does not read > it)" > Note that module 2 isn't really a Java Module but we are treating it as such > for the purposes of aggregating Javadoc across modularized and > non-modularized code. Module 2 has no way of declaring its intention of > reading the aforementioned package because it does not have a > {{module-info.java}} file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MJAVADOC-569) javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when mixing Java modules and non-modules
[ https://issues.apache.org/jira/browse/MJAVADOC-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753251#comment-16753251 ] Gili commented on MJAVADOC-569: --- export-to-testcase.zip also exposes another bug. * Run "javadoc:aggregate". * In the module listing, select "module1" * Notice that no packages or classes are visible * Go back to the module listing and select "module2" (a module), "module2" (a package), "Module2" (a class) * Notice that method createModule1() returns "Module1" (a class). Click on that class. * Notice that "module1" (a module) really does contain packages and classes. I'm not sure whether this is a bug in the Javadoc tool or the Maven plugin. If it is a bug in the Javadoc tool, I'm not sure how to generate a minimal testcase for them (without Maven). Do you generate a batch file in this case? Or maybe you are able to report it to them. > javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when > mixing Java modules and non-modules > - > > Key: MJAVADOC-569 > URL: https://issues.apache.org/jira/browse/MJAVADOC-569 > Project: Maven Javadoc Plugin > Issue Type: Bug > Environment: maven-javadoc-plugin 3.1.0-SNAPSHOT > Java 12-ea+28 >Reporter: Gili >Assignee: Robert Scholte >Priority: Blocker > Attachments: export-to-testcase.zip, testcase.zip > > > # Unpack testcase > # Run {{mvn clean package javadoc:aggregate -e}} > # {{javadoc:aggregate}} will fail with various errors like "(package > org.w3c.dom is declared in module java.xml, but module module2 does not read > it)" > Note that module 2 isn't really a Java Module but we are treating it as such > for the purposes of aggregating Javadoc across modularized and > non-modularized code. Module 2 has no way of declaring its intention of > reading the aforementioned package because it does not have a > {{module-info.java}} file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MJAVADOC-569) javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when mixing Java modules and non-modules
[ https://issues.apache.org/jira/browse/MJAVADOC-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753250#comment-16753250 ] Gili commented on MJAVADOC-569: --- I got it working (export-to-testcase.zip) but I think it's worth having a follow-up discussion about how (and why) this works: * If the root project inherits from org.sonatype.oss:oss-parent:9 then the plugin logs this extra step "[DEBUG] Added Javadoc offline link: http://nexus.sonatype.org/oss-repository-hosting.html/root/module1/apidocs for the module: testcase:module1:jar:1.0-SNAPSHOT" * This causes the plugin to add "--add-modules module1" to the "options" file. * This leads to us getting a new error message: "package module1 is declared in module module1, which does not export it to the unnamed module". * To fix this, I had to add: {code:java} --add-exports module1/module1=ALL-UNNAMED {code} to module2's plugin configuration. I want to update the FAQ with more examples so I need your help in understand what is going on. Open questions: * Why aren't we always adding "--add-modules module1"? I think we should respect "export...to" in the presence of at least one module, even if no offline links are present. Is this a bug? * Are the above options the correct way to solve this problem? Meaning, are we forced to export the package into the unnamed module space? Couldn't we use "--patch-module" to convert module2 into a named module and in so doing (1) avoid having the user needing to declare (2) avoid exposing a package to modules that should not see it? > javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when > mixing Java modules and non-modules > - > > Key: MJAVADOC-569 > URL: https://issues.apache.org/jira/browse/MJAVADOC-569 > Project: Maven Javadoc Plugin > Issue Type: Bug > Environment: maven-javadoc-plugin 3.1.0-SNAPSHOT > Java 12-ea+28 >Reporter: Gili >Assignee: Robert Scholte >Priority: Blocker > Attachments: export-to-testcase.zip, testcase.zip > > > # Unpack testcase > # Run {{mvn clean package javadoc:aggregate -e}} > # {{javadoc:aggregate}} will fail with various errors like "(package > org.w3c.dom is declared in module java.xml, but module module2 does not read > it)" > Note that module 2 isn't really a Java Module but we are treating it as such > for the purposes of aggregating Javadoc across modularized and > non-modularized code. Module 2 has no way of declaring its intention of > reading the aforementioned package because it does not have a > {{module-info.java}} file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MJAVADOC-569) javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when mixing Java modules and non-modules
[ https://issues.apache.org/jira/browse/MJAVADOC-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753197#comment-16753197 ] Gili commented on MJAVADOC-569: --- Actually, I'm not sure that this issue is fully resolved. "--add-modules" works for a simple "exports" but will fail for "exports SecretPackage to MyFriend". I tried using "--add-reads SecretPackage=MyFriend" but it seems that the Javadoc tool is mapping the automatic module to the unnamed module as opposed to the name specified by "Automatic-Module-Name". It doesn't make sense to export "SecretPackage" to the entire world (the unnamed module) because it is meant for private consumption. Any ideas? > javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when > mixing Java modules and non-modules > - > > Key: MJAVADOC-569 > URL: https://issues.apache.org/jira/browse/MJAVADOC-569 > Project: Maven Javadoc Plugin > Issue Type: Bug > Environment: maven-javadoc-plugin 3.1.0-SNAPSHOT > Java 12-ea+28 >Reporter: Gili >Assignee: Robert Scholte >Priority: Blocker > Attachments: testcase.zip > > > # Unpack testcase > # Run {{mvn clean package javadoc:aggregate -e}} > # {{javadoc:aggregate}} will fail with various errors like "(package > org.w3c.dom is declared in module java.xml, but module module2 does not read > it)" > Note that module 2 isn't really a Java Module but we are treating it as such > for the purposes of aggregating Javadoc across modularized and > non-modularized code. Module 2 has no way of declaring its intention of > reading the aforementioned package because it does not have a > {{module-info.java}} file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MJAVADOC-569) javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when mixing Java modules and non-modules
[ https://issues.apache.org/jira/browse/MJAVADOC-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753179#comment-16753179 ] Gili commented on MJAVADOC-569: --- PR for review: https://github.com/apache/maven-javadoc-plugin/pull/18 > javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when > mixing Java modules and non-modules > - > > Key: MJAVADOC-569 > URL: https://issues.apache.org/jira/browse/MJAVADOC-569 > Project: Maven Javadoc Plugin > Issue Type: Bug > Environment: maven-javadoc-plugin 3.1.0-SNAPSHOT > Java 12-ea+28 >Reporter: Gili >Assignee: Robert Scholte >Priority: Blocker > Attachments: testcase.zip > > > # Unpack testcase > # Run {{mvn clean package javadoc:aggregate -e}} > # {{javadoc:aggregate}} will fail with various errors like "(package > org.w3c.dom is declared in module java.xml, but module module2 does not read > it)" > Note that module 2 isn't really a Java Module but we are treating it as such > for the purposes of aggregating Javadoc across modularized and > non-modularized code. Module 2 has no way of declaring its intention of > reading the aforementioned package because it does not have a > {{module-info.java}} file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MJAVADOC-569) javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when mixing Java modules and non-modules
[ https://issues.apache.org/jira/browse/MJAVADOC-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750503#comment-16750503 ] Robert Scholte commented on MJAVADOC-569: - A PR for the FAQ might be useful here ;) > javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when > mixing Java modules and non-modules > - > > Key: MJAVADOC-569 > URL: https://issues.apache.org/jira/browse/MJAVADOC-569 > Project: Maven Javadoc Plugin > Issue Type: Bug > Environment: maven-javadoc-plugin 3.1.0-SNAPSHOT > Java 12-ea+28 >Reporter: Gili >Assignee: Robert Scholte >Priority: Blocker > Attachments: testcase.zip > > > # Unpack testcase > # Run {{mvn clean package javadoc:aggregate -e}} > # {{javadoc:aggregate}} will fail with various errors like "(package > org.w3c.dom is declared in module java.xml, but module module2 does not read > it)" > Note that module 2 isn't really a Java Module but we are treating it as such > for the purposes of aggregating Javadoc across modularized and > non-modularized code. Module 2 has no way of declaring its intention of > reading the aforementioned package because it does not have a > {{module-info.java}} file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MJAVADOC-569) javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when mixing Java modules and non-modules
[ https://issues.apache.org/jira/browse/MJAVADOC-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750425#comment-16750425 ] Gili commented on MJAVADOC-569: --- Fair enough. Perhaps it's worth updating the documentation to mention that when named, unnamed modules are aggregated then all entries are treated as named modules and the user is responsible for providing all module-related metadata using . Then provide an example as you did. Thanks. > javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when > mixing Java modules and non-modules > - > > Key: MJAVADOC-569 > URL: https://issues.apache.org/jira/browse/MJAVADOC-569 > Project: Maven Javadoc Plugin > Issue Type: Bug > Environment: maven-javadoc-plugin 3.1.0-SNAPSHOT > Java 12-ea+28 >Reporter: Gili >Assignee: Robert Scholte >Priority: Blocker > Attachments: testcase.zip > > > # Unpack testcase > # Run {{mvn clean package javadoc:aggregate -e}} > # {{javadoc:aggregate}} will fail with various errors like "(package > org.w3c.dom is declared in module java.xml, but module module2 does not read > it)" > Note that module 2 isn't really a Java Module but we are treating it as such > for the purposes of aggregating Javadoc across modularized and > non-modularized code. Module 2 has no way of declaring its intention of > reading the aforementioned package because it does not have a > {{module-info.java}} file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MJAVADOC-569) javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when mixing Java modules and non-modules
[ https://issues.apache.org/jira/browse/MJAVADOC-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750417#comment-16750417 ] Robert Scholte commented on MJAVADOC-569: - I've added an integration test to the project based on the attached file to confirm this solution. > javadoc:aggregate fails with 'error: package org.w3c.dom is not visible' when > mixing Java modules and non-modules > - > > Key: MJAVADOC-569 > URL: https://issues.apache.org/jira/browse/MJAVADOC-569 > Project: Maven Javadoc Plugin > Issue Type: Bug > Environment: maven-javadoc-plugin 3.1.0-SNAPSHOT > Java 12-ea+28 >Reporter: Gili >Assignee: Robert Scholte >Priority: Blocker > Attachments: testcase.zip > > > # Unpack testcase > # Run {{mvn clean package javadoc:aggregate -e}} > # {{javadoc:aggregate}} will fail with various errors like "(package > org.w3c.dom is declared in module java.xml, but module module2 does not read > it)" > Note that module 2 isn't really a Java Module but we are treating it as such > for the purposes of aggregating Javadoc across modularized and > non-modularized code. Module 2 has no way of declaring its intention of > reading the aforementioned package because it does not have a > {{module-info.java}} file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)