[jira] [Commented] (MNG-6241) Load -Dstyle.color from system properties also
[
https://issues.apache.org/jira/browse/MNG-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17381414#comment-17381414
]
Michael Osipov commented on MNG-6241:
-
Although, I did not fully understand your reply, the reason for {{MAVEN_ARGS}}
is that there is another open ticket which has a use for the new env var.
> Load -Dstyle.color from system properties also
> --
>
> Key: MNG-6241
> URL: https://issues.apache.org/jira/browse/MNG-6241
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.0
>Reporter: Thorsten Glaser
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Coloured output does not look very nice in a Jenkins logfile *and* breaks
> some plugins we use, therefore I wish to disable it programmatically.
> However, looking at the source, I find it can only be disabled by passing the
> command-line options -B or -l, but not from settings.xml or via MAVEN_OPTS in
> the environment.
> I’ve worked around this by using dpkg-divert to move the mvn binary away and
> placing this…
> {{{
> # cat /usr/share/maven/bin/mvn
> #!/bin/mksh-static
> exec /usr/share/maven/bin/mvn.dpkg-dist -B "$@"
> }}}
> … in its stead, but that’s creepy at best. Please implement a setting,
> ideally for settings.xml *and* MAVEN_OPTS, to disable colour.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6241) Load -Dstyle.color from system properties also
[
https://issues.apache.org/jira/browse/MNG-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380851#comment-17380851
]
Thorsten Glaser commented on MNG-6241:
--
I don’t need to, I’m the maintainer of a shell and see it works.
But wouldn’t you want to add {{${NO_COLOR+-B}}} instead?
> Load -Dstyle.color from system properties also
> --
>
> Key: MNG-6241
> URL: https://issues.apache.org/jira/browse/MNG-6241
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.0
>Reporter: Thorsten Glaser
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Coloured output does not look very nice in a Jenkins logfile *and* breaks
> some plugins we use, therefore I wish to disable it programmatically.
> However, looking at the source, I find it can only be disabled by passing the
> command-line options -B or -l, but not from settings.xml or via MAVEN_OPTS in
> the environment.
> I’ve worked around this by using dpkg-divert to move the mvn binary away and
> placing this…
> {{{
> # cat /usr/share/maven/bin/mvn
> #!/bin/mksh-static
> exec /usr/share/maven/bin/mvn.dpkg-dist -B "$@"
> }}}
> … in its stead, but that’s creepy at best. Please implement a setting,
> ideally for settings.xml *and* MAVEN_OPTS, to disable colour.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6241) Load -Dstyle.color from system properties also
[
https://issues.apache.org/jira/browse/MNG-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380836#comment-17380836
]
Michael Osipov commented on MNG-6241:
-
Please modify the following snippet and see whether this works for you:
{noformat}
exec "$JAVACMD" \
$MAVEN_OPTS \
$MAVEN_DEBUG_OPTS \
-classpath "${LAUNCHER_JAR}" \
$MAVENHOME_CONFIG
"-Dmaven.multiModuleProjectDirectory=${MAVEN_PROJECTBASEDIR}" \
$MAVEN_LAUNCHER "$@"
{noformat}
to
{noformat}
exec "$JAVACMD" \
$MAVEN_OPTS \
$MAVEN_DEBUG_OPTS \
-classpath "${LAUNCHER_JAR}" \
$MAVENHOME_CONFIG
"-Dmaven.multiModuleProjectDirectory=${MAVEN_PROJECTBASEDIR}" \
$MAVEN_LAUNCHER $MAVEN_ARGS "$@"
{noformat}
> Load -Dstyle.color from system properties also
> --
>
> Key: MNG-6241
> URL: https://issues.apache.org/jira/browse/MNG-6241
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.0
>Reporter: Thorsten Glaser
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Coloured output does not look very nice in a Jenkins logfile *and* breaks
> some plugins we use, therefore I wish to disable it programmatically.
> However, looking at the source, I find it can only be disabled by passing the
> command-line options -B or -l, but not from settings.xml or via MAVEN_OPTS in
> the environment.
> I’ve worked around this by using dpkg-divert to move the mvn binary away and
> placing this…
> {{{
> # cat /usr/share/maven/bin/mvn
> #!/bin/mksh-static
> exec /usr/share/maven/bin/mvn.dpkg-dist -B "$@"
> }}}
> … in its stead, but that’s creepy at best. Please implement a setting,
> ideally for settings.xml *and* MAVEN_OPTS, to disable colour.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6241) Load -Dstyle.color from system properties also
[
https://issues.apache.org/jira/browse/MNG-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380821#comment-17380821
]
Thorsten Glaser commented on MNG-6241:
--
Exactly.
> Load -Dstyle.color from system properties also
> --
>
> Key: MNG-6241
> URL: https://issues.apache.org/jira/browse/MNG-6241
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.0
>Reporter: Thorsten Glaser
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Coloured output does not look very nice in a Jenkins logfile *and* breaks
> some plugins we use, therefore I wish to disable it programmatically.
> However, looking at the source, I find it can only be disabled by passing the
> command-line options -B or -l, but not from settings.xml or via MAVEN_OPTS in
> the environment.
> I’ve worked around this by using dpkg-divert to move the mvn binary away and
> placing this…
> {{{
> # cat /usr/share/maven/bin/mvn
> #!/bin/mksh-static
> exec /usr/share/maven/bin/mvn.dpkg-dist -B "$@"
> }}}
> … in its stead, but that’s creepy at best. Please implement a setting,
> ideally for settings.xml *and* MAVEN_OPTS, to disable colour.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6241) Load -Dstyle.color from system properties also
[
https://issues.apache.org/jira/browse/MNG-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380739#comment-17380739
]
Michael Osipov commented on MNG-6241:
-
Yes, but your question was solely about colors, not other args, right?
> Load -Dstyle.color from system properties also
> --
>
> Key: MNG-6241
> URL: https://issues.apache.org/jira/browse/MNG-6241
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.0
>Reporter: Thorsten Glaser
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Coloured output does not look very nice in a Jenkins logfile *and* breaks
> some plugins we use, therefore I wish to disable it programmatically.
> However, looking at the source, I find it can only be disabled by passing the
> command-line options -B or -l, but not from settings.xml or via MAVEN_OPTS in
> the environment.
> I’ve worked around this by using dpkg-divert to move the mvn binary away and
> placing this…
> {{{
> # cat /usr/share/maven/bin/mvn
> #!/bin/mksh-static
> exec /usr/share/maven/bin/mvn.dpkg-dist -B "$@"
> }}}
> … in its stead, but that’s creepy at best. Please implement a setting,
> ideally for settings.xml *and* MAVEN_OPTS, to disable colour.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6241) Load -Dstyle.color from system properties also
[
https://issues.apache.org/jira/browse/MNG-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380593#comment-17380593
]
Thorsten Glaser commented on MNG-6241:
--
Sure. That would help with the colour option specifically, not with other
options, but that’s the one I need.
> Load -Dstyle.color from system properties also
> --
>
> Key: MNG-6241
> URL: https://issues.apache.org/jira/browse/MNG-6241
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.0
>Reporter: Thorsten Glaser
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Coloured output does not look very nice in a Jenkins logfile *and* breaks
> some plugins we use, therefore I wish to disable it programmatically.
> However, looking at the source, I find it can only be disabled by passing the
> command-line options -B or -l, but not from settings.xml or via MAVEN_OPTS in
> the environment.
> I’ve worked around this by using dpkg-divert to move the mvn binary away and
> placing this…
> {{{
> # cat /usr/share/maven/bin/mvn
> #!/bin/mksh-static
> exec /usr/share/maven/bin/mvn.dpkg-dist -B "$@"
> }}}
> … in its stead, but that’s creepy at best. Please implement a setting,
> ideally for settings.xml *and* MAVEN_OPTS, to disable colour.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6241) Load -Dstyle.color from system properties also
[
https://issues.apache.org/jira/browse/MNG-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380487#comment-17380487
]
Michael Osipov commented on MNG-6241:
-
Would it help if Maven would respect this https://no-color.org/?
> Load -Dstyle.color from system properties also
> --
>
> Key: MNG-6241
> URL: https://issues.apache.org/jira/browse/MNG-6241
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.0
>Reporter: Thorsten Glaser
>Priority: Major
> Fix For: wontfix-candidate
>
>
> Coloured output does not look very nice in a Jenkins logfile *and* breaks
> some plugins we use, therefore I wish to disable it programmatically.
> However, looking at the source, I find it can only be disabled by passing the
> command-line options -B or -l, but not from settings.xml or via MAVEN_OPTS in
> the environment.
> I’ve worked around this by using dpkg-divert to move the mvn binary away and
> placing this…
> {{{
> # cat /usr/share/maven/bin/mvn
> #!/bin/mksh-static
> exec /usr/share/maven/bin/mvn.dpkg-dist -B "$@"
> }}}
> … in its stead, but that’s creepy at best. Please implement a setting,
> ideally for settings.xml *and* MAVEN_OPTS, to disable colour.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6241) Load -Dstyle.color from system properties also
[
https://issues.apache.org/jira/browse/MNG-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17374602#comment-17374602
]
Michael Osipov commented on MNG-6241:
-
It seems so. I will close the PR meanwhile.
> Load -Dstyle.color from system properties also
> --
>
> Key: MNG-6241
> URL: https://issues.apache.org/jira/browse/MNG-6241
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.0
>Reporter: Thorsten Glaser
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.x-candidate, 3.8.x-candidate
>
>
> Coloured output does not look very nice in a Jenkins logfile *and* breaks
> some plugins we use, therefore I wish to disable it programmatically.
> However, looking at the source, I find it can only be disabled by passing the
> command-line options -B or -l, but not from settings.xml or via MAVEN_OPTS in
> the environment.
> I’ve worked around this by using dpkg-divert to move the mvn binary away and
> placing this…
> {{{
> # cat /usr/share/maven/bin/mvn
> #!/bin/mksh-static
> exec /usr/share/maven/bin/mvn.dpkg-dist -B "$@"
> }}}
> … in its stead, but that’s creepy at best. Please implement a setting,
> ideally for settings.xml *and* MAVEN_OPTS, to disable colour.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6241) Load -Dstyle.color from system properties also
[
https://issues.apache.org/jira/browse/MNG-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17374581#comment-17374581
]
Martin Kanters commented on MNG-6241:
-
As [~rfscholte] mentioned on GitHub that he does not prefer the system property
solution, perhaps we could take a look at using or introducing another
environment variable for setting Maven flags. There is a way to specify this in
the
[.mvn/maven.config|https://maven.apache.org/configure.html#mvn-maven-config-file]
file, so what if we combine that with a new env variable (e.g.
MVN_FLAGS_CONFIG or something..). I understand from the same docs that MVN_OPTS
is not a right fit for this, as it should only contain JVM options. I don't
really like introducing a new env var for this, but it seems we have a gap
here, if I understand it correctly.
> Load -Dstyle.color from system properties also
> --
>
> Key: MNG-6241
> URL: https://issues.apache.org/jira/browse/MNG-6241
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.0
>Reporter: Thorsten Glaser
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.x-candidate, 3.8.x-candidate
>
>
> Coloured output does not look very nice in a Jenkins logfile *and* breaks
> some plugins we use, therefore I wish to disable it programmatically.
> However, looking at the source, I find it can only be disabled by passing the
> command-line options -B or -l, but not from settings.xml or via MAVEN_OPTS in
> the environment.
> I’ve worked around this by using dpkg-divert to move the mvn binary away and
> placing this…
> {{{
> # cat /usr/share/maven/bin/mvn
> #!/bin/mksh-static
> exec /usr/share/maven/bin/mvn.dpkg-dist -B "$@"
> }}}
> … in its stead, but that’s creepy at best. Please implement a setting,
> ideally for settings.xml *and* MAVEN_OPTS, to disable colour.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6241) Load -Dstyle.color from system properties also
[
https://issues.apache.org/jira/browse/MNG-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17374294#comment-17374294
]
Michael Osipov commented on MNG-6241:
-
Please check the PR. Works for me.
> Load -Dstyle.color from system properties also
> --
>
> Key: MNG-6241
> URL: https://issues.apache.org/jira/browse/MNG-6241
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.0
>Reporter: Thorsten Glaser
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.x-candidate, 3.8.x-candidate
>
>
> Coloured output does not look very nice in a Jenkins logfile *and* breaks
> some plugins we use, therefore I wish to disable it programmatically.
> However, looking at the source, I find it can only be disabled by passing the
> command-line options -B or -l, but not from settings.xml or via MAVEN_OPTS in
> the environment.
> I’ve worked around this by using dpkg-divert to move the mvn binary away and
> placing this…
> {{{
> # cat /usr/share/maven/bin/mvn
> #!/bin/mksh-static
> exec /usr/share/maven/bin/mvn.dpkg-dist -B "$@"
> }}}
> … in its stead, but that’s creepy at best. Please implement a setting,
> ideally for settings.xml *and* MAVEN_OPTS, to disable colour.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
