[jira] [Commented] (MNG-6360) Maven doesn't export org.slf4j.event.Level

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464898#comment-16464898
 ] 

ASF GitHub Bot commented on MNG-6360:
-

rmannibucau closed pull request #157: [MNG-6360] adding org.slf4j.event in 
exported packages
URL: https://github.com/apache/maven/pull/157
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/maven-core/src/main/resources/META-INF/maven/extension.xml 
b/maven-core/src/main/resources/META-INF/maven/extension.xml
index 6329aaa096..6bd8369273 100644
--- a/maven-core/src/main/resources/META-INF/maven/extension.xml
+++ b/maven-core/src/main/resources/META-INF/maven/extension.xml
@@ -120,6 +120,7 @@ under the License.
 org.slf4j.*
 org.slf4j.spi.*
 org.slf4j.helpers.*
+org.slf4j.event.*
 
 
 org.fusesource.jansi.*


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Maven doesn't export org.slf4j.event.Level
> --
>
> Key: MNG-6360
> URL: https://issues.apache.org/jira/browse/MNG-6360
> Project: Maven
>  Issue Type: Task
>Reporter: Romain Manni-Bucau
>Priority: Blocker
>
> Hi
> maven doesn't export org.slf4j.event package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so this package 
> from slf4j is not usable in mojos/extensions which lead to a weird 
> classloading for slf4j users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6360) Maven doesn't export org.slf4j.event.Level

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464897#comment-16464897
 ] 

ASF GitHub Bot commented on MNG-6360:
-

rmannibucau commented on issue #157: [MNG-6360] adding org.slf4j.event in 
exported packages
URL: https://github.com/apache/maven/pull/157#issuecomment-386835055
 
 
   No more blocking


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Maven doesn't export org.slf4j.event.Level
> --
>
> Key: MNG-6360
> URL: https://issues.apache.org/jira/browse/MNG-6360
> Project: Maven
>  Issue Type: Task
>Reporter: Romain Manni-Bucau
>Priority: Blocker
>
> Hi
> maven doesn't export org.slf4j.event package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so this package 
> from slf4j is not usable in mojos/extensions which lead to a weird 
> classloading for slf4j users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6360) Maven doesn't export org.slf4j.event.Level

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464892#comment-16464892
 ] 

ASF GitHub Bot commented on MNG-6360:
-

michael-o commented on issue #157: [MNG-6360] adding org.slf4j.event in 
exported packages
URL: https://github.com/apache/maven/pull/157#issuecomment-386833261
 
 
   @rmannibucau As discussed on JIRA, this can be closed. Do you agree?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Maven doesn't export org.slf4j.event.Level
> --
>
> Key: MNG-6360
> URL: https://issues.apache.org/jira/browse/MNG-6360
> Project: Maven
>  Issue Type: Task
>Reporter: Romain Manni-Bucau
>Priority: Blocker
>
> Hi
> maven doesn't export org.slf4j.event package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so this package 
> from slf4j is not usable in mojos/extensions which lead to a weird 
> classloading for slf4j users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6360) Maven doesn't export org.slf4j.event.Level

[Romain Manni-Bucau (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460684#comment-16460684
 ] 

Romain Manni-Bucau commented on MNG-6360:
-

Hi [~michael-o], tried to reproduce it on the 3.5.3 and seems I can't anymore 
so I guess we can close it for now.

> Maven doesn't export org.slf4j.event.Level
> --
>
> Key: MNG-6360
> URL: https://issues.apache.org/jira/browse/MNG-6360
> Project: Maven
>  Issue Type: Task
>Reporter: Romain Manni-Bucau
>Priority: Blocker
>
> Hi
> maven doesn't export org.slf4j.event package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so this package 
> from slf4j is not usable in mojos/extensions which lead to a weird 
> classloading for slf4j users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6360) Maven doesn't export org.slf4j.event.Level

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459002#comment-16459002
 ] 

Michael Osipov commented on MNG-6360:
-

[~romain.manni-bucau], that's fine with me.

> Maven doesn't export org.slf4j.event.Level
> --
>
> Key: MNG-6360
> URL: https://issues.apache.org/jira/browse/MNG-6360
> Project: Maven
>  Issue Type: Task
>Reporter: Romain Manni-Bucau
>Priority: Blocker
>
> Hi
> maven doesn't export org.slf4j.event package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so this package 
> from slf4j is not usable in mojos/extensions which lead to a weird 
> classloading for slf4j users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6360) Maven doesn't export org.slf4j.event.Level

[Romain Manni-Bucau (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458862#comment-16458862
 ] 

Romain Manni-Bucau commented on MNG-6360:
-

Not sure before the 15th (holidays time here ;)) but sure, should be quite 
trivial.

> Maven doesn't export org.slf4j.event.Level
> --
>
> Key: MNG-6360
> URL: https://issues.apache.org/jira/browse/MNG-6360
> Project: Maven
>  Issue Type: Task
>Reporter: Romain Manni-Bucau
>Priority: Blocker
>
> Hi
> maven doesn't export org.slf4j.event package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so this package 
> from slf4j is not usable in mojos/extensions which lead to a weird 
> classloading for slf4j users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6360) Maven doesn't export org.slf4j.event.Level

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458680#comment-16458680
 ] 

Michael Osipov commented on MNG-6360:
-

Do you think you can create an IT for that? I would pull both.

> Maven doesn't export org.slf4j.event.Level
> --
>
> Key: MNG-6360
> URL: https://issues.apache.org/jira/browse/MNG-6360
> Project: Maven
>  Issue Type: Task
>Reporter: Romain Manni-Bucau
>Priority: Blocker
>
> Hi
> maven doesn't export org.slf4j.event package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so this package 
> from slf4j is not usable in mojos/extensions which lead to a weird 
> classloading for slf4j users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6360) Maven doesn't export org.slf4j.event.Level

[Romain Manni-Bucau (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458677#comment-16458677
 ] 

Romain Manni-Bucau commented on MNG-6360:
-

Plugins dont use that package but any code using slf4j and embedded in a mojo 
can and would fail due to maven current setup. In such cases it is either 
export all or export nothing ;).

> Maven doesn't export org.slf4j.event.Level
> --
>
> Key: MNG-6360
> URL: https://issues.apache.org/jira/browse/MNG-6360
> Project: Maven
>  Issue Type: Task
>Reporter: Romain Manni-Bucau
>Priority: Blocker
>
> Hi
> maven doesn't export org.slf4j.event package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so this package 
> from slf4j is not usable in mojos/extensions which lead to a weird 
> classloading for slf4j users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6360) Maven doesn't export org.slf4j.event.Level

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458641#comment-16458641
 ] 

Michael Osipov commented on MNG-6360:
-

Why do our plugins work? What do I miss, can you show an example?

> Maven doesn't export org.slf4j.event.Level
> --
>
> Key: MNG-6360
> URL: https://issues.apache.org/jira/browse/MNG-6360
> Project: Maven
>  Issue Type: Task
>Reporter: Romain Manni-Bucau
>Priority: Blocker
>
> Hi
> maven doesn't export org.slf4j.event package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so this package 
> from slf4j is not usable in mojos/extensions which lead to a weird 
> classloading for slf4j users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6360) Maven doesn't export org.slf4j.event.Level

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364249#comment-16364249
 ] 

ASF GitHub Bot commented on MNG-6360:
-

GitHub user rmannibucau opened a pull request:

https://github.com/apache/maven/pull/157

[MNG-6360] adding org.slf4j.event in exported packages



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rmannibucau/maven MNG-6360_export-slf4j-event

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/157.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #157


commit 05aff88aa961439315c4a9e680c89e799a8ff849
Author: Romain Manni-Bucau 
Date:   2018-02-14T15:18:10Z

adding org.slf4j.event in exported packages




> Maven doesn't export org.slf4j.event.Level
> --
>
> Key: MNG-6360
> URL: https://issues.apache.org/jira/browse/MNG-6360
> Project: Maven
>  Issue Type: Task
>Reporter: Romain Manni-Bucau
>Priority: Blocker
>
> Hi
> maven doesn't export org.slf4j.event package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so this package 
> from slf4j is not usable in mojos/extensions which lead to a weird 
> classloading for slf4j users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)