[jira] [Commented] (MNG-7505) Remove ReportingConverter

2022-12-11 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645817#comment-17645817
 ] 

ASF GitHub Bot commented on MNG-7505:
-

gnodet merged PR #906:
URL: https://github.com/apache/maven/pull/906




> Remove ReportingConverter
> -
>
> Key: MNG-7505
> URL: https://issues.apache.org/jira/browse/MNG-7505
> Project: Maven
>  Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> In m-site-p 3.7 configuration parameter {{reportPlugins}} was removed - 
> MSITE-792
> So converting from reporting sections to {{reportPlugins}} option of m-site-p 
> is not needed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7505) Remove ReportingConverter

2022-12-11 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645819#comment-17645819
 ] 

Hudson commented on MNG-7505:
-

Build failed in Jenkins: Maven » Maven TLP » maven » master #155

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/155/

> Remove ReportingConverter
> -
>
> Key: MNG-7505
> URL: https://issues.apache.org/jira/browse/MNG-7505
> Project: Maven
>  Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> In m-site-p 3.7 configuration parameter {{reportPlugins}} was removed - 
> MSITE-792
> So converting from reporting sections to {{reportPlugins}} option of m-site-p 
> is not needed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7505) Remove ReportingConverter

2022-12-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645615#comment-17645615
 ] 

ASF GitHub Bot commented on MNG-7505:
-

slawekjaranowski commented on PR #906:
URL: https://github.com/apache/maven/pull/906#issuecomment-1345265120

   > So basically the "new style" configuration is dead and the `` 
section remains?
   
   it looks like - only reporting from pom should be used
   
https://maven.apache.org/plugins/maven-site-plugin/examples/configuring-reports.html
   https://maven.apache.org/shared/maven-reporting-exec/
   
   




> Remove ReportingConverter
> -
>
> Key: MNG-7505
> URL: https://issues.apache.org/jira/browse/MNG-7505
> Project: Maven
>  Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> In m-site-p 3.7 configuration parameter {{reportPlugins}} was removed - 
> MSITE-792
> So converting from reporting sections to {{reportPlugins}} option of m-site-p 
> is not needed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7505) Remove ReportingConverter

2022-12-09 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645520#comment-17645520
 ] 

ASF GitHub Bot commented on MNG-7505:
-

michael-o commented on PR #906:
URL: https://github.com/apache/maven/pull/906#issuecomment-1344904179

   Will review 




> Remove ReportingConverter
> -
>
> Key: MNG-7505
> URL: https://issues.apache.org/jira/browse/MNG-7505
> Project: Maven
>  Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> In m-site-p 3.7 configuration parameter {{reportPlugins}} was removed - 
> MSITE-792
> So converting from reporting sections to {{reportPlugins}} option of m-site-p 
> is not needed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7505) Remove ReportingConverter

2022-12-09 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645515#comment-17645515
 ] 

ASF GitHub Bot commented on MNG-7505:
-

slawekjaranowski commented on PR #906:
URL: https://github.com/apache/maven/pull/906#issuecomment-1344891165

   Now we only move `outputDirectory` from reporting section to site plugin 
configuration ...
   but also this is not needed - plugin parameter has as default: 
`${project.reporting.outputDirectory}`




> Remove ReportingConverter
> -
>
> Key: MNG-7505
> URL: https://issues.apache.org/jira/browse/MNG-7505
> Project: Maven
>  Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> In m-site-p 3.7 configuration parameter {{reportPlugins}} was removed - 
> MSITE-792
> So converting from reporting sections to {{reportPlugins}} option of m-site-p 
> is not needed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7505) Remove ReportingConverter

2022-12-09 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645512#comment-17645512
 ] 

ASF GitHub Bot commented on MNG-7505:
-

gnodet commented on PR #906:
URL: https://github.com/apache/maven/pull/906#issuecomment-1344884879

   > It can be ...
   > but we have next workaround for plugin which was released 2017
   
   This old ? 
   @slawekjaranowski  I've updated the PR to get rid of that code completely...




> Remove ReportingConverter
> -
>
> Key: MNG-7505
> URL: https://issues.apache.org/jira/browse/MNG-7505
> Project: Maven
>  Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> In m-site-p 3.7 configuration parameter {{reportPlugins}} was removed - 
> MSITE-792
> So converting from reporting sections to {{reportPlugins}} option of m-site-p 
> is not needed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7505) Remove ReportingConverter

2022-12-09 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645341#comment-17645341
 ] 

ASF GitHub Bot commented on MNG-7505:
-

gnodet opened a new pull request, #906:
URL: https://github.com/apache/maven/pull/906

   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MNG) filed
  for the change (usually before you start working on it).  Trivial 
changes like typos do not
  require a JIRA issue. Your pull request should address just this 
issue, without
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you 
replace `MNG-XXX`
  and `SUMMARY` with the appropriate JIRA issue. Best practice is to 
use the JIRA issue
  title in the pull request title and in the first line of the commit 
message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will
  be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   




> Remove ReportingConverter
> -
>
> Key: MNG-7505
> URL: https://issues.apache.org/jira/browse/MNG-7505
> Project: Maven
>  Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> In m-site-p 3.7 configuration parameter {{reportPlugins}} was removed - 
> MSITE-792
> So converting from reporting sections to {{reportPlugins}} option of m-site-p 
> is not needed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)