[jira] [Commented] (MNG-8116) Plugin configuration can randomly fail in case of method overloading as it doesn't take into account implementation attribute
[ https://issues.apache.org/jira/browse/MNG-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17852613#comment-17852613 ] Olivier Lamy commented on MNG-8116: --- I have tested with the reproducer from [https://github.com/jetty/jetty.project/issues/11732] and couldn't reproduce the problem after a lot builds > Plugin configuration can randomly fail in case of method overloading as it > doesn't take into account implementation attribute > - > > Key: MNG-8116 > URL: https://issues.apache.org/jira/browse/MNG-8116 > Project: Maven > Issue Type: Task > Components: Plugin Requests >Affects Versions: 3.9.6 >Reporter: Olivier Lamy >Assignee: Olivier Lamy >Priority: Major > Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4 > > > Originally discovered via a Jetty bug report see > https://github.com/jetty/jetty.project/issues/11732 > The bean to configured have the following overloading method naming: > * public void setExtraClasspath(String extraClasspath) > * public void setExtraClasspath(List extraClasspath) > The plugin configuration: > > ${basedir}/config > > even forcing the implementation attribute doesn't help > >implementation="java.lang.String">${basedir}/config > > The fix is implemented via the PR > https://github.com/eclipse/sisu.plexus/pull/52 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8116) Plugin configuration can randomly fail in case of method overloading as it doesn't take into account implementation attribute
[ https://issues.apache.org/jira/browse/MNG-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17851913#comment-17851913 ] Tamas Cservenak commented on MNG-8116: -- Fixed by MNG-8136 > Plugin configuration can randomly fail in case of method overloading as it > doesn't take into account implementation attribute > - > > Key: MNG-8116 > URL: https://issues.apache.org/jira/browse/MNG-8116 > Project: Maven > Issue Type: Task > Components: Plugin Requests >Affects Versions: 3.9.6 >Reporter: Olivier Lamy >Assignee: Olivier Lamy >Priority: Major > Fix For: 3.9.8, 4.0.0-beta-4 > > > Originally discovered via a Jetty bug report see > https://github.com/jetty/jetty.project/issues/11732 > The bean to configured have the following overloading method naming: > * public void setExtraClasspath(String extraClasspath) > * public void setExtraClasspath(List extraClasspath) > The plugin configuration: > > ${basedir}/config > > even forcing the implementation attribute doesn't help > >implementation="java.lang.String">${basedir}/config > > The fix is implemented via the PR > https://github.com/eclipse/sisu.plexus/pull/52 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8116) Plugin configuration can randomly fail in case of method overloading as it doesn't take into account implementation attribute
[ https://issues.apache.org/jira/browse/MNG-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848513#comment-17848513 ] Tamas Cservenak commented on MNG-8116: -- Few comments: This issue is blocked by Eclipse Sisu release, that in turn, has own "dust removal" issues: * GH org migration and then repository consolidation [https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4652] * License change after EMO review [https://gitlab.eclipse.org/eclipsefdn/emo-team/emo/-/issues/740] * and both issues require PMC and Wayne Beaton approvals as well Moreover, this issue should be assigned to Maven 4 beta-4 as well, as same Sisu is used there, so same issue stands as well. > Plugin configuration can randomly fail in case of method overloading as it > doesn't take into account implementation attribute > - > > Key: MNG-8116 > URL: https://issues.apache.org/jira/browse/MNG-8116 > Project: Maven > Issue Type: Task > Components: Plugin Requests >Affects Versions: 3.9.6 >Reporter: Olivier Lamy >Assignee: Olivier Lamy >Priority: Major > Fix For: 3.9.8 > > > Originally discovered via a Jetty bug report see > https://github.com/jetty/jetty.project/issues/11732 > The bean to configured have the following overloading method naming: > * public void setExtraClasspath(String extraClasspath) > * public void setExtraClasspath(List extraClasspath) > The plugin configuration: > > ${basedir}/config > > even forcing the implementation attribute doesn't help > >implementation="java.lang.String">${basedir}/config > > The fix is implemented via the PR > https://github.com/eclipse/sisu.plexus/pull/52 -- This message was sent by Atlassian Jira (v8.20.10#820010)