[jira] [Commented] (MPIR-385) Emails in mailing list section of pom are improperly handled
[ https://issues.apache.org/jira/browse/MPIR-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018712#comment-17018712 ] Sylwester Lachiewicz commented on MPIR-385: --- Done in [6ec9e397b9131f786e3096d57268df12d07c5056|https://gitbox.apache.org/repos/asf?p=maven-project-info-reports-plugin.git;a=commit;h=6ec9e397b9131f786e3096d57268df12d07c5056] and [c7acb571ac57de67ba966183ff5816a063ebb96a|https://gitbox.apache.org/repos/asf?p=maven-project-info-reports-plugin.git;a=commit;h=c7acb571ac57de67ba966183ff5816a063ebb96a] > Emails in mailing list section of pom are improperly handled > > > Key: MPIR-385 > URL: https://issues.apache.org/jira/browse/MPIR-385 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: mailing-lists >Affects Versions: 3.0.0, 3.0.1 >Reporter: Sebb >Assignee: Sylwester Lachiewicz >Priority: Major > Labels: regression > Fix For: 3.1.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The generated file mailing-lists.html contains email names of the form: > Subscribe > instead of > mailto:test-subscr...@maven.apache.org;>Subscribe > Since the protocol is omitted, browsers assume it is the same as the page, > i.e. http[s]. > Easy to demonstrate: > clone the repo > mvn clean integration-test > examine target/test-harness/mailing-lists/mailing-lists.html > To show that it worked previously, checkout the tag > maven-project-info-reports-plugin-2.9 > and try the test again. > examine the file target/test-harness/mailing-lists/mail-lists.html > There don't appear to be any tests to check whether the table entries are > correctly generated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MPIR-385) Emails in mailing list section of pom are improperly handled
[ https://issues.apache.org/jira/browse/MPIR-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018702#comment-17018702 ] Hudson commented on MPIR-385: - Build succeeded in Jenkins: Maven TLP » maven-project-info-reports-plugin » master #77 See https://builds.apache.org/job/maven-box/job/maven-project-info-reports-plugin/job/master/77/ > Emails in mailing list section of pom are improperly handled > > > Key: MPIR-385 > URL: https://issues.apache.org/jira/browse/MPIR-385 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: mailing-lists >Affects Versions: 3.0.0, 3.0.1 >Reporter: Sebb >Assignee: Sylwester Lachiewicz >Priority: Major > Labels: regression > Fix For: 3.1.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The generated file mailing-lists.html contains email names of the form: > Subscribe > instead of > mailto:test-subscr...@maven.apache.org;>Subscribe > Since the protocol is omitted, browsers assume it is the same as the page, > i.e. http[s]. > Easy to demonstrate: > clone the repo > mvn clean integration-test > examine target/test-harness/mailing-lists/mailing-lists.html > To show that it worked previously, checkout the tag > maven-project-info-reports-plugin-2.9 > and try the test again. > examine the file target/test-harness/mailing-lists/mail-lists.html > There don't appear to be any tests to check whether the table entries are > correctly generated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MPIR-385) Emails in mailing list section of pom are improperly handled
[ https://issues.apache.org/jira/browse/MPIR-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018351#comment-17018351 ] Hudson commented on MPIR-385: - Build succeeded in Jenkins: Maven TLP » maven-project-info-reports-plugin » MPIR-385 #7 See https://builds.apache.org/job/maven-box/job/maven-project-info-reports-plugin/job/MPIR-385/7/ > Emails in mailing list section of pom are improperly handled > > > Key: MPIR-385 > URL: https://issues.apache.org/jira/browse/MPIR-385 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: mailing-lists >Affects Versions: 3.0.0, 3.0.1 >Reporter: Sebb >Assignee: Sylwester Lachiewicz >Priority: Major > Labels: regression > Fix For: 3.1.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The generated file mailing-lists.html contains email names of the form: > Subscribe > instead of > mailto:test-subscr...@maven.apache.org;>Subscribe > Since the protocol is omitted, browsers assume it is the same as the page, > i.e. http[s]. > Easy to demonstrate: > clone the repo > mvn clean integration-test > examine target/test-harness/mailing-lists/mailing-lists.html > To show that it worked previously, checkout the tag > maven-project-info-reports-plugin-2.9 > and try the test again. > examine the file target/test-harness/mailing-lists/mail-lists.html > There don't appear to be any tests to check whether the table entries are > correctly generated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MPIR-385) Emails in mailing list section of pom are improperly handled
[ https://issues.apache.org/jira/browse/MPIR-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017964#comment-17017964 ] Hudson commented on MPIR-385: - Build succeeded in Jenkins: Maven TLP » maven-project-info-reports-plugin » master #76 See https://builds.apache.org/job/maven-box/job/maven-project-info-reports-plugin/job/master/76/ > Emails in mailing list section of pom are improperly handled > > > Key: MPIR-385 > URL: https://issues.apache.org/jira/browse/MPIR-385 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: mailing-lists >Affects Versions: 3.0.0, 3.0.1 >Reporter: Sebb >Assignee: Sylwester Lachiewicz >Priority: Major > Labels: regression > Time Spent: 20m > Remaining Estimate: 0h > > The generated file mailing-lists.html contains email names of the form: > Subscribe > instead of > mailto:test-subscr...@maven.apache.org;>Subscribe > Since the protocol is omitted, browsers assume it is the same as the page, > i.e. http[s]. > Easy to demonstrate: > clone the repo > mvn clean integration-test > examine target/test-harness/mailing-lists/mailing-lists.html > To show that it worked previously, checkout the tag > maven-project-info-reports-plugin-2.9 > and try the test again. > examine the file target/test-harness/mailing-lists/mail-lists.html > There don't appear to be any tests to check whether the table entries are > correctly generated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MPIR-385) Emails in mailing list section of pom are improperly handled
[ https://issues.apache.org/jira/browse/MPIR-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935183#comment-16935183 ] Gabriel Belingueres commented on MPIR-385: -- I digged in the past 10 years of commits and found nothing relevant in the code related to this. May be maven-reporting-impl dependency change introduced the bug. Anyway it is fixed and now it has a unit test to avoid regressions. Perhaps adding the new method into AbstractMavenReportRenderer class may be a step forward to your suggestion. > Emails in mailing list section of pom are improperly handled > > > Key: MPIR-385 > URL: https://issues.apache.org/jira/browse/MPIR-385 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: mailing-lists >Affects Versions: 3.0.0, 3.0.1 >Reporter: Sebb >Priority: Major > Labels: regression > Time Spent: 10m > Remaining Estimate: 0h > > The generated file mailing-lists.html contains email names of the form: > Subscribe > instead of > mailto:test-subscr...@maven.apache.org;>Subscribe > Since the protocol is omitted, browsers assume it is the same as the page, > i.e. http[s]. > Easy to demonstrate: > clone the repo > mvn clean integration-test > examine target/test-harness/mailing-lists/mailing-lists.html > To show that it worked previously, checkout the tag > maven-project-info-reports-plugin-2.9 > and try the test again. > examine the file target/test-harness/mailing-lists/mail-lists.html > There don't appear to be any tests to check whether the table entries are > correctly generated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MPIR-385) Emails in mailing list section of pom are improperly handled
[ https://issues.apache.org/jira/browse/MPIR-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935007#comment-16935007 ] Sebb commented on MPIR-385: --- I see the patch fixes the code by adding a new method. However, this used to work in version 2.9, so the correct code was present then. Given that this issue has affected two parts of the pom (this and developer mails), it seems likely that there was a change that affected both. Seems to me it would be better to establish why the formatting broke for both parts and fix that. There may be other formatting issues that have yet to be found that depend on the code that was changed. > Emails in mailing list section of pom are improperly handled > > > Key: MPIR-385 > URL: https://issues.apache.org/jira/browse/MPIR-385 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: mailing-lists >Affects Versions: 3.0.0, 3.0.1 >Reporter: Sebb >Priority: Major > Labels: regression > Time Spent: 10m > Remaining Estimate: 0h > > The generated file mailing-lists.html contains email names of the form: > Subscribe > instead of > mailto:test-subscr...@maven.apache.org;>Subscribe > Since the protocol is omitted, browsers assume it is the same as the page, > i.e. http[s]. > Easy to demonstrate: > clone the repo > mvn clean integration-test > examine target/test-harness/mailing-lists/mailing-lists.html > To show that it worked previously, checkout the tag > maven-project-info-reports-plugin-2.9 > and try the test again. > examine the file target/test-harness/mailing-lists/mail-lists.html > There don't appear to be any tests to check whether the table entries are > correctly generated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MPIR-385) Emails in mailing list section of pom are improperly handled
[ https://issues.apache.org/jira/browse/MPIR-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934788#comment-16934788 ] Gabriel Belingueres commented on MPIR-385: -- I was able to reproduce the bug. I'll send a patch soon. Thanks. > Emails in mailing list section of pom are improperly handled > > > Key: MPIR-385 > URL: https://issues.apache.org/jira/browse/MPIR-385 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: mailing-lists >Affects Versions: 3.0.0, 3.0.1 >Reporter: Sebb >Priority: Major > Labels: regression > > The generated file mailing-lists.html contains email names of the form: > Subscribe > instead of > mailto:test-subscr...@maven.apache.org;>Subscribe > Since the protocol is omitted, browsers assume it is the same as the page, > i.e. http[s]. > Easy to demonstrate: > clone the repo > mvn clean integration-test > examine target/test-harness/mailing-lists/mailing-lists.html > To show that it worked previously, checkout the tag > maven-project-info-reports-plugin-2.9 > and try the test again. > examine the file target/test-harness/mailing-lists/mail-lists.html > There don't appear to be any tests to check whether the table entries are > correctly generated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
