[jira] [Commented] (MRELEASE-915) Forked execution of perform leaks source roots
[ https://issues.apache.org/jira/browse/MRELEASE-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341460#comment-15341460 ] Kariem Hussein commented on MRELEASE-915: - I am observing the same problem with the [checkstyle plugin|https://maven.apache.org/components/plugins/maven-checkstyle-plugin/] v2.17 and version 2.5.3 of the release plugin. > Forked execution of perform leaks source roots > -- > > Key: MRELEASE-915 > URL: https://issues.apache.org/jira/browse/MRELEASE-915 > Project: Maven Release Plugin > Issue Type: Bug > Components: perform >Affects Versions: 2.5.1 >Reporter: Benson Margulies > > https://github.com/bimargulies/release-root-leakage is a test case for the > following: > If you add a source root in generate-sources in a pom, that source root will > show up in the 'validate' phase in the forked execution for release:perform. > This causes checkstyle to see things that it should not, if nothing else bad. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MRELEASE-915) Forked execution of perform leaks source roots
[ https://issues.apache.org/jira/browse/MRELEASE-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14632789#comment-14632789 ] Martin Gainty commented on MRELEASE-915: possible scenario is you work in a body shop where all packages are generated by outsourcers? The build engineer requires Java Classes created from client-supplied XML document template. The build-engineer implements addCompileSourceRoot as generated-sources location from jaxb https://github.com/highsource/maven-jaxb2-plugin/wiki/Controlling-the-Output But in verify phase when checkstyle is executed you see warnings from the jaxb generated addCompileSourceRoot folder . Engineer knows that none of the code outsourcers created this code since the folder name is not the typical gov. package spec that outsources use. build-engineer wants checkstyle to bypass scanning additional source directories such as the generated source directory not specifically located in sourceDirectories attribute of maven-checkstyle-plugin Am i picturing the scenario accurately? If so I can take a look at crafting an qd algo which will bypass all source directories not specified in sourceDirectories as I have some free time this week. Thanks, Martin Forked execution of perform leaks source roots -- Key: MRELEASE-915 URL: https://issues.apache.org/jira/browse/MRELEASE-915 Project: Maven Release Plugin Issue Type: Bug Components: perform Affects Versions: 2.5.1 Reporter: Benson Margulies https://github.com/bimargulies/release-root-leakage is a test case for the following: If you add a source root in generate-sources in a pom, that source root will show up in the 'validate' phase in the forked execution for release:perform. This causes checkstyle to see things that it should not, if nothing else bad. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MRELEASE-915) Forked execution of perform leaks source roots
[ https://issues.apache.org/jira/browse/MRELEASE-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14632913#comment-14632913 ] Benson Margulies commented on MRELEASE-915: --- Martin, the scenario you describe bears no resemblance to the situation at hand. I wrote a maven plugin which generates code from an XML file and a template. The code in question is not intended to comply with our checkstyle rules. I have worked around it by configuring checkstyle to look only in src/main/java. I'd like to see someone track this down in the release plugin or the core; I'm not sure where to start or I'd do some tracking on my own. Forked execution of perform leaks source roots -- Key: MRELEASE-915 URL: https://issues.apache.org/jira/browse/MRELEASE-915 Project: Maven Release Plugin Issue Type: Bug Components: perform Affects Versions: 2.5.1 Reporter: Benson Margulies https://github.com/bimargulies/release-root-leakage is a test case for the following: If you add a source root in generate-sources in a pom, that source root will show up in the 'validate' phase in the forked execution for release:perform. This causes checkstyle to see things that it should not, if nothing else bad. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MRELEASE-915) Forked execution of perform leaks source roots
[ https://issues.apache.org/jira/browse/MRELEASE-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624013#comment-14624013 ] Benson Margulies commented on MRELEASE-915: --- mavenExecutorIdforked-path/mavenExecutorId does not change the results. Forked execution of perform leaks source roots -- Key: MRELEASE-915 URL: https://issues.apache.org/jira/browse/MRELEASE-915 Project: Maven Release Plugin Issue Type: Bug Components: perform Affects Versions: 2.5.1 Reporter: Benson Margulies https://github.com/bimargulies/release-root-leakage is a test case for the following: If you add a source root in generate-sources in a pom, that source root will show up in the 'validate' phase in the forked execution for release:perform. This causes checkstyle to see things that it should not, if nothing else bad. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
