[jira] [Commented] (MRESOLVER-9) DefaultDependencyCollector does not correctly handle dependency management
[
https://issues.apache.org/jira/browse/MRESOLVER-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859313#comment-16859313
]
Michael Osipov commented on MRESOLVER-9:
This change causes failures in Resolver, Maven, Maven ITs.
> DefaultDependencyCollector does not correctly handle dependency management
> --
>
> Key: MRESOLVER-9
> URL: https://issues.apache.org/jira/browse/MRESOLVER-9
> Project: Maven Resolver
> Issue Type: Bug
>Reporter: Christian Schulte
>Priority: Critical
> Fix For: Maven Artifact Resolver 1.2.0 pre-reset
>
>
> During dependency processing the {{DependencySelector}} is called to decide
> if a dependency is to be selected. The call to
> {{DependencySelector.selectDependency()}} is performed with the unmanaged
> dependency, but needs to be performed with the managed dependency. With the
> fix applied, the result no longer contains dependencies whose scope or
> optionality has been managed to not be part of the result (correct
> behaviour). Without the fix applied, the result contains dependencies with a
> managed scope or optionality not filtered out by the {{DependencySelector}}
> in use (incorrect behaviour).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MRESOLVER-9) DefaultDependencyCollector does not correctly handle dependency management.
[ https://issues.apache.org/jira/browse/MRESOLVER-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942043#comment-15942043 ] Christian Schulte commented on MRESOLVER-9: --- Issue is fixed in the master branch of [my private maven repository on github|https://github.com/ChristianSchulte/maven-resolver/tree/master]. When interested, you can cherry pick the commit to your own repository and create a pull request for the apache master branch with just this commit yourself from there. > DefaultDependencyCollector does not correctly handle dependency management. > --- > > Key: MRESOLVER-9 > URL: https://issues.apache.org/jira/browse/MRESOLVER-9 > Project: Maven Resolver > Issue Type: Bug >Reporter: Christian Schulte >Priority: Critical > Fix For: Maven Artifact Resolver 1.2.0 pre-reset > > > During dependency processing the 'DependencySelector' is called to decide if > a dependency is to be selected. The call to > 'DependencySelector.selectDependency( dependency )' is performed with the > unmanagement dependency but needs to be performed with the managed > dependency. With the fix applied, the result no longer contains dependencies > whose scope or optionality has been managed to not be part of the result > (correct behaviour). Without the fix applied, the result contains > dependencies with a managed scope or optionality not filtered out by the > 'DependencySelector' in use (incorrect behaviour). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (MRESOLVER-9) DefaultDependencyCollector does not correctly handle dependency management.
[ https://issues.apache.org/jira/browse/MRESOLVER-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15789889#comment-15789889 ] Hudson commented on MRESOLVER-9: SUCCESS: Integrated in Jenkins build maven-resolver #32 (See [https://builds.apache.org/job/maven-resolver/32/]) [MRESOLVER-9] DefaultDependencyCollector does not correctly handle (schulte: [http://git-wip-us.apache.org/repos/asf/?p=maven-resolver.git&a=commit&h=8cec8a788c59fd62a2c8486073412f5b3efd47a5]) * (edit) maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDependencyCollector.java > DefaultDependencyCollector does not correctly handle dependency management. > --- > > Key: MRESOLVER-9 > URL: https://issues.apache.org/jira/browse/MRESOLVER-9 > Project: Maven Resolver > Issue Type: Bug >Reporter: Christian Schulte >Assignee: Christian Schulte >Priority: Critical > Fix For: Maven Artifact Resolver 1.2.0 > > > During dependency processing the 'DependencySelector' is called to decide if > a dependency is to be selected. The call to > 'DependencySelector.selectDependency( dependency )' is performed with the > unmanagement dependency but needs to be performed with the managed > dependency. With the fix applied, the result no longer contains dependencies > whose scope or optionality has been managed to not be part of the result > (correct behaviour). Without the fix applied, the result contains > dependencies with a managed scope or optionality not filtered out by the > 'DependencySelector' in use (incorrect behaviour). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MRESOLVER-9) DefaultDependencyCollector does not correctly handle dependency management.
[ https://issues.apache.org/jira/browse/MRESOLVER-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15783802#comment-15783802 ] Hudson commented on MRESOLVER-9: UNSTABLE: Integrated in Jenkins build maven-wagon #1329 (See [https://builds.apache.org/job/maven-wagon/1329/]) [MRESOLVER-9] DefaultDependencyCollector does not correctly handle (schulte: [http://git-wip-us.apache.org/repos/asf/?p=maven-wagon.git&a=commit&h=1b318bb7b87ab260f3ff33259d547caffe575f02]) * (edit) pom.xml * (edit) wagon-providers/wagon-http-shared/pom.xml * (edit) wagon-providers/wagon-http-lightweight/pom.xml * (edit) wagon-providers/wagon-webdav-jackrabbit/pom.xml * (edit) wagon-providers/wagon-http/pom.xml * (edit) wagon-tcks/wagon-tck-http/pom.xml * (edit) wagon-provider-api/pom.xml * (edit) wagon-providers/wagon-ssh-common/pom.xml > DefaultDependencyCollector does not correctly handle dependency management. > --- > > Key: MRESOLVER-9 > URL: https://issues.apache.org/jira/browse/MRESOLVER-9 > Project: Maven Resolver > Issue Type: Bug >Reporter: Christian Schulte >Assignee: Christian Schulte >Priority: Critical > Fix For: Maven Artifact Resolver 1.2.0 > > > During dependency processing the 'DependencySelector' is called to decide if > a dependency is to be selected. The call to > 'DependencySelector.selectDependency( dependency )' is performed with the > unmanagement dependency but needs to be performed with the managed > dependency. With the fix applied, the result no longer contains dependencies > whose scope or optionality has been managed to not be part of the result > (correct behaviour). Without the fix applied, the result contains > dependencies with a managed scope or optionality not filtered out by the > 'DependencySelector' in use (incorrect behaviour). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MRESOLVER-9) DefaultDependencyCollector does not correctly handle dependency management.
[ https://issues.apache.org/jira/browse/MRESOLVER-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15767544#comment-15767544 ] Hudson commented on MRESOLVER-9: SUCCESS: Integrated in Jenkins build maven-resolver #31 (See [https://builds.apache.org/job/maven-resolver/31/]) [MRESOLVER-9] DefaultDependencyCollector does not correctly handle (schulte: rev 763cac233d37e2240e43dfaf72023ba1f8ffd139) * (edit) maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDependencyCollector.java > DefaultDependencyCollector does not correctly handle dependency management. > --- > > Key: MRESOLVER-9 > URL: https://issues.apache.org/jira/browse/MRESOLVER-9 > Project: Maven Resolver > Issue Type: Bug >Reporter: Christian Schulte >Assignee: Christian Schulte >Priority: Critical > Fix For: Maven Artifact Resolver 1.2.0 > > > During dependency processing the 'DependencySelector' is called to decide if > a dependency is to be selected. The call to > 'DependencySelector.selectDependency( dependency )' is performed with the > unmanagement dependency but needs to be performed with the managed > dependency. With the fix applied, the result no longer contains dependencies > whose scope or optionality has been managed to not be part of the result > (correct behaviour). Without the fix applied, the result contains > dependencies with a managed scope or optionality not filtered out by the > 'DependencySelector' in use (incorrect behaviour). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MRESOLVER-9) DefaultDependencyCollector does not correctly handle dependency management.
[ https://issues.apache.org/jira/browse/MRESOLVER-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746698#comment-15746698 ] Hudson commented on MRESOLVER-9: SUCCESS: Integrated in Jenkins build maven-wagon #1320 (See [https://builds.apache.org/job/maven-wagon/1320/]) [MRESOLVER-9] DefaultDependencyCollector does not correctly handle (schulte: rev f244ece2eee01500e4b1bc334b8dcd35b47f9422) * (edit) pom.xml * (edit) wagon-tcks/wagon-tck-http/pom.xml > DefaultDependencyCollector does not correctly handle dependency management. > --- > > Key: MRESOLVER-9 > URL: https://issues.apache.org/jira/browse/MRESOLVER-9 > Project: Maven Resolver > Issue Type: Bug >Reporter: Christian Schulte >Assignee: Christian Schulte >Priority: Critical > Fix For: Maven Artifact Resolver 1.2.0 > > > During dependency processing the 'DependencySelector' is called to decide if > a dependency is to be selected. The call to > 'DependencySelector.selectDependency( dependency )' is performed with the > unmanagement dependency but needs to be performed with the managed > dependency. With the fix applied, the result no longer contains dependencies > whose scope or optionality has been managed to not be part of the result > (correct behaviour). Without the fix applied, the result contains > dependencies with a managed scope or optionality not filtered out by the > 'DependencySelector' in use (incorrect behaviour). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
