[jira] [Commented] (MSHARED-1398) StringIndexOutOfBoundsException processing record classes
[ https://issues.apache.org/jira/browse/MSHARED-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847705#comment-17847705 ] ASF GitHub Bot commented on MSHARED-1398: - slawekjaranowski merged PR #121: URL: https://github.com/apache/maven-dependency-analyzer/pull/121 > StringIndexOutOfBoundsException processing record classes > - > > Key: MSHARED-1398 > URL: https://issues.apache.org/jira/browse/MSHARED-1398 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-dependency-analyzer >Affects Versions: maven-dependency-analyzer-1.14.0 >Reporter: Jared Stehler >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-dependency-analyzer-next-release > > > Processing classes with records results in an index out of bounds exception: > {code:java} > Caused by: java.lang.StringIndexOutOfBoundsException: Index 41 out of bounds > for length 41 > at > java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55) > at > java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52) > at > java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213) > at > java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210) > at > java.base@21.0.3/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98) > at > java.base@21.0.3/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:106) > at > java.base@21.0.3/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:302) > at java.base@21.0.3/java.lang.String.checkIndex(String.java:4832) > at java.base@21.0.3/java.lang.StringLatin1.charAt(StringLatin1.java:46) > at java.base@21.0.3/java.lang.String.charAt(String.java:1555) > at app//org.objectweb.asm.Type.getReturnTypeOffset(Type.java:378) > at app//org.objectweb.asm.Type.getReturnType(Type.java:355) > at > app//org.apache.maven.shared.dependency.analyzer.asm.ResultCollector.addMethodDesc(ResultCollector.java:112) > {code} > I have a reproducible test case here: > https://github.com/jaredstehler/maven-dependency-analyzer/tree/js-repro-record-error -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1398) StringIndexOutOfBoundsException processing record classes
[ https://issues.apache.org/jira/browse/MSHARED-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847603#comment-17847603 ] Jared Stehler commented on MSHARED-1398: confirmed that fixed my original issue. > StringIndexOutOfBoundsException processing record classes > - > > Key: MSHARED-1398 > URL: https://issues.apache.org/jira/browse/MSHARED-1398 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-dependency-analyzer >Affects Versions: maven-dependency-analyzer-1.14.0 >Reporter: Jared Stehler >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-dependency-analyzer-next-release > > > Processing classes with records results in an index out of bounds exception: > {code:java} > Caused by: java.lang.StringIndexOutOfBoundsException: Index 41 out of bounds > for length 41 > at > java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55) > at > java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52) > at > java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213) > at > java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210) > at > java.base@21.0.3/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98) > at > java.base@21.0.3/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:106) > at > java.base@21.0.3/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:302) > at java.base@21.0.3/java.lang.String.checkIndex(String.java:4832) > at java.base@21.0.3/java.lang.StringLatin1.charAt(StringLatin1.java:46) > at java.base@21.0.3/java.lang.String.charAt(String.java:1555) > at app//org.objectweb.asm.Type.getReturnTypeOffset(Type.java:378) > at app//org.objectweb.asm.Type.getReturnType(Type.java:355) > at > app//org.apache.maven.shared.dependency.analyzer.asm.ResultCollector.addMethodDesc(ResultCollector.java:112) > {code} > I have a reproducible test case here: > https://github.com/jaredstehler/maven-dependency-analyzer/tree/js-repro-record-error -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1398) StringIndexOutOfBoundsException processing record classes
[ https://issues.apache.org/jira/browse/MSHARED-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847506#comment-17847506 ] Slawomir Jaranowski commented on MSHARED-1398: -- [~jstehler] - fixed you can check my last commit to PR > StringIndexOutOfBoundsException processing record classes > - > > Key: MSHARED-1398 > URL: https://issues.apache.org/jira/browse/MSHARED-1398 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-dependency-analyzer >Affects Versions: maven-dependency-analyzer-1.14.0 >Reporter: Jared Stehler >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-dependency-analyzer-next-release > > > Processing classes with records results in an index out of bounds exception: > {code:java} > Caused by: java.lang.StringIndexOutOfBoundsException: Index 41 out of bounds > for length 41 > at > java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55) > at > java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52) > at > java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213) > at > java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210) > at > java.base@21.0.3/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98) > at > java.base@21.0.3/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:106) > at > java.base@21.0.3/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:302) > at java.base@21.0.3/java.lang.String.checkIndex(String.java:4832) > at java.base@21.0.3/java.lang.StringLatin1.charAt(StringLatin1.java:46) > at java.base@21.0.3/java.lang.String.charAt(String.java:1555) > at app//org.objectweb.asm.Type.getReturnTypeOffset(Type.java:378) > at app//org.objectweb.asm.Type.getReturnType(Type.java:355) > at > app//org.apache.maven.shared.dependency.analyzer.asm.ResultCollector.addMethodDesc(ResultCollector.java:112) > {code} > I have a reproducible test case here: > https://github.com/jaredstehler/maven-dependency-analyzer/tree/js-repro-record-error -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1398) StringIndexOutOfBoundsException processing record classes
[ https://issues.apache.org/jira/browse/MSHARED-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847412#comment-17847412 ] Jared Stehler commented on MSHARED-1398: created [https://github.com/apache/maven-dependency-analyzer/pull/121] with the failing test > StringIndexOutOfBoundsException processing record classes > - > > Key: MSHARED-1398 > URL: https://issues.apache.org/jira/browse/MSHARED-1398 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-dependency-analyzer >Affects Versions: maven-dependency-analyzer-1.14.0 >Reporter: Jared Stehler >Priority: Major > Fix For: maven-dependency-analyzer-next-release > > > Processing classes with records results in an index out of bounds exception: > {code:java} > Caused by: java.lang.StringIndexOutOfBoundsException: Index 41 out of bounds > for length 41 > at > java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55) > at > java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52) > at > java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213) > at > java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210) > at > java.base@21.0.3/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98) > at > java.base@21.0.3/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:106) > at > java.base@21.0.3/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:302) > at java.base@21.0.3/java.lang.String.checkIndex(String.java:4832) > at java.base@21.0.3/java.lang.StringLatin1.charAt(StringLatin1.java:46) > at java.base@21.0.3/java.lang.String.charAt(String.java:1555) > at app//org.objectweb.asm.Type.getReturnTypeOffset(Type.java:378) > at app//org.objectweb.asm.Type.getReturnType(Type.java:355) > at > app//org.apache.maven.shared.dependency.analyzer.asm.ResultCollector.addMethodDesc(ResultCollector.java:112) > {code} > I have a reproducible test case here: > https://github.com/jaredstehler/maven-dependency-analyzer/tree/js-repro-record-error -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1398) StringIndexOutOfBoundsException processing record classes
[ https://issues.apache.org/jira/browse/MSHARED-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847411#comment-17847411 ] ASF GitHub Bot commented on MSHARED-1398: - jaredstehler opened a new pull request, #121: URL: https://github.com/apache/maven-dependency-analyzer/pull/121 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHARED) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. Also be sure having selected the correct component. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MSHARED-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSHARED-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > StringIndexOutOfBoundsException processing record classes > - > > Key: MSHARED-1398 > URL: https://issues.apache.org/jira/browse/MSHARED-1398 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-dependency-analyzer >Affects Versions: maven-dependency-analyzer-1.14.0 >Reporter: Jared Stehler >Priority: Major > Fix For: maven-dependency-analyzer-next-release > > > Processing classes with records results in an index out of bounds exception: > {code:java} > Caused by: java.lang.StringIndexOutOfBoundsException: Index 41 out of bounds > for length 41 > at > java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55) > at > java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52) > at > java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213) > at > java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210) > at > java.base@21.0.3/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98) > at > java.base@21.0.3/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:106) > at > java.base@21.0.3/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:302) > at java.base@21.0.3/java.lang.String.checkIndex(String.java:4832) > at java.base@21.0.3/java.lang.StringLatin1.charAt(StringLatin1.java:46) > at java.base@21.0.3/java.lang.String.charAt(String.java:1555) > at app//org.objectweb.asm.Type.getReturnTypeOffset(Type.java:378) > at app//org.objectweb.asm.Type.getReturnType(Type.java:355) > at > app//org.apache.maven.shared.dependency.analyzer.asm.ResultCollector.addMethodDesc(ResultCollector.java:112) > {code} > I have a reproducible test case here: > https://github.com/jaredstehler/maven-dependency-analyzer/tree/js-repro-record-error -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1398) StringIndexOutOfBoundsException processing record classes
[ https://issues.apache.org/jira/browse/MSHARED-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847410#comment-17847410 ] Jared Stehler commented on MSHARED-1398: I did create a repo for reporting to ASM: [https://github.com/jaredstehler/asm-issues/blob/main/src/main/java/com/jaredstehler/scratch/asm/issues/InvalidTypeDescriptor.java] > StringIndexOutOfBoundsException processing record classes > - > > Key: MSHARED-1398 > URL: https://issues.apache.org/jira/browse/MSHARED-1398 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-dependency-analyzer >Affects Versions: maven-dependency-analyzer-1.14.0 >Reporter: Jared Stehler >Priority: Major > Fix For: maven-dependency-analyzer-next-release > > > Processing classes with records results in an index out of bounds exception: > {code:java} > Caused by: java.lang.StringIndexOutOfBoundsException: Index 41 out of bounds > for length 41 > at > java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55) > at > java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52) > at > java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213) > at > java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210) > at > java.base@21.0.3/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98) > at > java.base@21.0.3/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:106) > at > java.base@21.0.3/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:302) > at java.base@21.0.3/java.lang.String.checkIndex(String.java:4832) > at java.base@21.0.3/java.lang.StringLatin1.charAt(StringLatin1.java:46) > at java.base@21.0.3/java.lang.String.charAt(String.java:1555) > at app//org.objectweb.asm.Type.getReturnTypeOffset(Type.java:378) > at app//org.objectweb.asm.Type.getReturnType(Type.java:355) > at > app//org.apache.maven.shared.dependency.analyzer.asm.ResultCollector.addMethodDesc(ResultCollector.java:112) > {code} > I have a reproducible test case here: > https://github.com/jaredstehler/maven-dependency-analyzer/tree/js-repro-record-error -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1398) StringIndexOutOfBoundsException processing record classes
[ https://issues.apache.org/jira/browse/MSHARED-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847396#comment-17847396 ] Slawomir Jaranowski commented on MSHARED-1398: -- [~jstehler] please create a PR with your test > StringIndexOutOfBoundsException processing record classes > - > > Key: MSHARED-1398 > URL: https://issues.apache.org/jira/browse/MSHARED-1398 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-dependency-analyzer >Affects Versions: maven-dependency-analyzer-1.14.0 >Reporter: Jared Stehler >Priority: Major > > Processing classes with records results in an index out of bounds exception: > {code:java} > Caused by: java.lang.StringIndexOutOfBoundsException: Index 41 out of bounds > for length 41 > at > java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55) > at > java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52) > at > java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213) > at > java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210) > at > java.base@21.0.3/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98) > at > java.base@21.0.3/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:106) > at > java.base@21.0.3/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:302) > at java.base@21.0.3/java.lang.String.checkIndex(String.java:4832) > at java.base@21.0.3/java.lang.StringLatin1.charAt(StringLatin1.java:46) > at java.base@21.0.3/java.lang.String.charAt(String.java:1555) > at app//org.objectweb.asm.Type.getReturnTypeOffset(Type.java:378) > at app//org.objectweb.asm.Type.getReturnType(Type.java:355) > at > app//org.apache.maven.shared.dependency.analyzer.asm.ResultCollector.addMethodDesc(ResultCollector.java:112) > {code} > I have a reproducible test case here: > https://github.com/jaredstehler/maven-dependency-analyzer/tree/js-repro-record-error -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1398) StringIndexOutOfBoundsException processing record classes
[ https://issues.apache.org/jira/browse/MSHARED-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847394#comment-17847394 ] Slawomir Jaranowski commented on MSHARED-1398: -- Thanks for reporting I was dropped a simply catch such exception in [https://github.com/apache/maven-dependency-analyzer/pull/118] But you can skip problematic classes from analizes I will check where is the root of cause - maybe we should report in to ASM. > StringIndexOutOfBoundsException processing record classes > - > > Key: MSHARED-1398 > URL: https://issues.apache.org/jira/browse/MSHARED-1398 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-dependency-analyzer >Affects Versions: maven-dependency-analyzer-1.14.0 >Reporter: Jared Stehler >Priority: Major > > Processing classes with records results in an index out of bounds exception: > {code:java} > Caused by: java.lang.StringIndexOutOfBoundsException: Index 41 out of bounds > for length 41 > at > java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55) > at > java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52) > at > java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213) > at > java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210) > at > java.base@21.0.3/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98) > at > java.base@21.0.3/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:106) > at > java.base@21.0.3/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:302) > at java.base@21.0.3/java.lang.String.checkIndex(String.java:4832) > at java.base@21.0.3/java.lang.StringLatin1.charAt(StringLatin1.java:46) > at java.base@21.0.3/java.lang.String.charAt(String.java:1555) > at app//org.objectweb.asm.Type.getReturnTypeOffset(Type.java:378) > at app//org.objectweb.asm.Type.getReturnType(Type.java:355) > at > app//org.apache.maven.shared.dependency.analyzer.asm.ResultCollector.addMethodDesc(ResultCollector.java:112) > {code} > I have a reproducible test case here: > https://github.com/jaredstehler/maven-dependency-analyzer/tree/js-repro-record-error -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1398) StringIndexOutOfBoundsException processing record classes
[ https://issues.apache.org/jira/browse/MSHARED-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847390#comment-17847390 ] Jared Stehler commented on MSHARED-1398: The failing method is asm Type.getReturnType(String) In my failing test case, desc is {code:java} "Lrecordinvokedynamic/RecordInvokeDynamic;"{code} > StringIndexOutOfBoundsException processing record classes > - > > Key: MSHARED-1398 > URL: https://issues.apache.org/jira/browse/MSHARED-1398 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-dependency-analyzer >Affects Versions: maven-dependency-analyzer-1.14.0 >Reporter: Jared Stehler >Priority: Major > > Processing classes with records results in an index out of bounds exception: > {code:java} > Caused by: java.lang.StringIndexOutOfBoundsException: Index 41 out of bounds > for length 41 > at > java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55) > at > java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52) > at > java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213) > at > java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210) > at > java.base@21.0.3/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98) > at > java.base@21.0.3/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:106) > at > java.base@21.0.3/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:302) > at java.base@21.0.3/java.lang.String.checkIndex(String.java:4832) > at java.base@21.0.3/java.lang.StringLatin1.charAt(StringLatin1.java:46) > at java.base@21.0.3/java.lang.String.charAt(String.java:1555) > at app//org.objectweb.asm.Type.getReturnTypeOffset(Type.java:378) > at app//org.objectweb.asm.Type.getReturnType(Type.java:355) > at > app//org.apache.maven.shared.dependency.analyzer.asm.ResultCollector.addMethodDesc(ResultCollector.java:112) > {code} > I have a reproducible test case here: > https://github.com/jaredstehler/maven-dependency-analyzer/tree/js-repro-record-error -- This message was sent by Atlassian Jira (v8.20.10#820010)