[jira] [Commented] (MSITE-783) Bad modules links when 'distributionManagement.site.url' comes from settings.xml
[
https://issues.apache.org/jira/browse/MSITE-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15524069#comment-15524069
]
Alix Lourme commented on MSITE-783:
---
Tested on 3.6-SNAPSHOT on CI platform, works like a charm.
(FYI : Same problem found in _maven-project-info-reports-plugin_; *index*
report => MPIR-349)
> Bad modules links when 'distributionManagement.site.url' comes from
> settings.xml
>
>
> Key: MSITE-783
> URL: https://issues.apache.org/jira/browse/MSITE-783
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: multi module, property interpolation, relative links
>Affects Versions: 3.0, 3.1, 3.2, 3.3, 3.4, 3.5, 3.5.1
>Reporter: Alix Lourme
>Assignee: Hervé Boutemy
> Fix For: 3.6
>
> Attachments: variableSettingsSubLinkMenu.zip
>
>
> When the _distributionManagement.site.url_ contains a property filled in
> _settings.xml_ like :
> _pom.xml_ :
> {code}
>
>
> projectSite
> ${sitePublishLocation}/foo/${project.artifactId}
>
>
> {code}
> _settings.xml_:
> {code}
>
>
>
>
> site-location
>
>
> file://tmp/sitePublish
>
>
>
>
> site-location
>
>
> {code}
> The modules link menu in *target/site/index.html* are not interpolated:
> {code}
> ../../../../${sitePublishLocation}/foo/test-module-hierarchical/index.html
> {code}
> Problem can be reproduced with [^variableSettingsSubLinkMenu.zip] project.
> This command fails:
> {code}
> mvn site -s settings-site-location.xml
> {code}
> This command works:
> {code}
> mvn site -s settings-site-location.xml
> -DsitePublishLocation="/tmp/sitePublish"
> {code}
> Probably a link with MSITE-604, but the v3.5 doesn't fix this problem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MSITE-783) Bad modules links when 'distributionManagement.site.url' comes from settings.xml
[
https://issues.apache.org/jira/browse/MSITE-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521183#comment-15521183
]
Alix Lourme commented on MSITE-783:
---
Fully agree
> Bad modules links when 'distributionManagement.site.url' comes from
> settings.xml
>
>
> Key: MSITE-783
> URL: https://issues.apache.org/jira/browse/MSITE-783
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: multi module, property interpolation, relative links
>Affects Versions: 3.0, 3.1, 3.2, 3.3, 3.4, 3.5, 3.5.1
>Reporter: Alix Lourme
>Assignee: Hervé Boutemy
> Fix For: 3.6
>
> Attachments: variableSettingsSubLinkMenu.zip
>
>
> When the _distributionManagement.site.url_ contains a property filled in
> _settings.xml_ like :
> _pom.xml_ :
> {code}
>
>
> projectSite
> ${sitePublishLocation}/foo/${project.artifactId}
>
>
> {code}
> _settings.xml_:
> {code}
>
>
>
>
> site-location
>
>
> file://tmp/sitePublish
>
>
>
>
> site-location
>
>
> {code}
> The modules link menu in *target/site/index.html* are not interpolated:
> {code}
> ../../../../${sitePublishLocation}/foo/test-module-hierarchical/index.html
> {code}
> Problem can be reproduced with [^variableSettingsSubLinkMenu.zip] project.
> This command fails:
> {code}
> mvn site -s settings-site-location.xml
> {code}
> This command works:
> {code}
> mvn site -s settings-site-location.xml
> -DsitePublishLocation="/tmp/sitePublish"
> {code}
> Probably a link with MSITE-604, but the v3.5 doesn't fix this problem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MSITE-783) Bad modules links when 'distributionManagement.site.url' comes from settings.xml
[
https://issues.apache.org/jira/browse/MSITE-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521133#comment-15521133
]
Hervé Boutemy commented on MSITE-783:
-
not so logic: the links are there, but wrong since not interpolated. Ideally,
when Doxia reads pom.xml, it could do it without this limitation, but I could
not find any way to do it (that's why I use reactor...)
but at least, in normal use case, you don't run "-N", then I thikn we can live
with this limitation
> Bad modules links when 'distributionManagement.site.url' comes from
> settings.xml
>
>
> Key: MSITE-783
> URL: https://issues.apache.org/jira/browse/MSITE-783
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: multi module, property interpolation, relative links
>Affects Versions: 3.0, 3.1, 3.2, 3.3, 3.4, 3.5, 3.5.1
>Reporter: Alix Lourme
>Assignee: Hervé Boutemy
> Fix For: 3.6
>
> Attachments: variableSettingsSubLinkMenu.zip
>
>
> When the _distributionManagement.site.url_ contains a property filled in
> _settings.xml_ like :
> _pom.xml_ :
> {code}
>
>
> projectSite
> ${sitePublishLocation}/foo/${project.artifactId}
>
>
> {code}
> _settings.xml_:
> {code}
>
>
>
>
> site-location
>
>
> file://tmp/sitePublish
>
>
>
>
> site-location
>
>
> {code}
> The modules link menu in *target/site/index.html* are not interpolated:
> {code}
> ../../../../${sitePublishLocation}/foo/test-module-hierarchical/index.html
> {code}
> Problem can be reproduced with [^variableSettingsSubLinkMenu.zip] project.
> This command fails:
> {code}
> mvn site -s settings-site-location.xml
> {code}
> This command works:
> {code}
> mvn site -s settings-site-location.xml
> -DsitePublishLocation="/tmp/sitePublish"
> {code}
> Probably a link with MSITE-604, but the v3.5 doesn't fix this problem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MSITE-783) Bad modules links when 'distributionManagement.site.url' comes from settings.xml
[
https://issues.apache.org/jira/browse/MSITE-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521093#comment-15521093
]
Alix Lourme commented on MSITE-783:
---
@[~hboutemy] : Many thanks again for the fix. I will test it tomorrow in "real"
condition with SNAPSHOT build.
{quote}
FYI this won't fix when using "mvn -N" (a warning will be displayed)
{quote}
Logic IMO :)
> Bad modules links when 'distributionManagement.site.url' comes from
> settings.xml
>
>
> Key: MSITE-783
> URL: https://issues.apache.org/jira/browse/MSITE-783
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: multi module, property interpolation, relative links
>Affects Versions: 3.0, 3.1, 3.2, 3.3, 3.4, 3.5, 3.5.1
>Reporter: Alix Lourme
>Assignee: Hervé Boutemy
> Fix For: 3.6
>
> Attachments: variableSettingsSubLinkMenu.zip
>
>
> When the _distributionManagement.site.url_ contains a property filled in
> _settings.xml_ like :
> _pom.xml_ :
> {code}
>
>
> projectSite
> ${sitePublishLocation}/foo/${project.artifactId}
>
>
> {code}
> _settings.xml_:
> {code}
>
>
>
>
> site-location
>
>
> file://tmp/sitePublish
>
>
>
>
> site-location
>
>
> {code}
> The modules link menu in *target/site/index.html* are not interpolated:
> {code}
> ../../../../${sitePublishLocation}/foo/test-module-hierarchical/index.html
> {code}
> Problem can be reproduced with [^variableSettingsSubLinkMenu.zip] project.
> This command fails:
> {code}
> mvn site -s settings-site-location.xml
> {code}
> This command works:
> {code}
> mvn site -s settings-site-location.xml
> -DsitePublishLocation="/tmp/sitePublish"
> {code}
> Probably a link with MSITE-604, but the v3.5 doesn't fix this problem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MSITE-783) Bad modules links when 'distributionManagement.site.url' comes from settings.xml
[
https://issues.apache.org/jira/browse/MSITE-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521095#comment-15521095
]
Alix Lourme commented on MSITE-783:
---
@[~hboutemy] : Many thanks again for the fix. I will test it tomorrow in "real"
condition with SNAPSHOT build.
{quote}
FYI this won't fix when using "mvn -N" (a warning will be displayed)
{quote}
Logic IMO :)
> Bad modules links when 'distributionManagement.site.url' comes from
> settings.xml
>
>
> Key: MSITE-783
> URL: https://issues.apache.org/jira/browse/MSITE-783
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: multi module, property interpolation, relative links
>Affects Versions: 3.0, 3.1, 3.2, 3.3, 3.4, 3.5, 3.5.1
>Reporter: Alix Lourme
>Assignee: Hervé Boutemy
> Fix For: 3.6
>
> Attachments: variableSettingsSubLinkMenu.zip
>
>
> When the _distributionManagement.site.url_ contains a property filled in
> _settings.xml_ like :
> _pom.xml_ :
> {code}
>
>
> projectSite
> ${sitePublishLocation}/foo/${project.artifactId}
>
>
> {code}
> _settings.xml_:
> {code}
>
>
>
>
> site-location
>
>
> file://tmp/sitePublish
>
>
>
>
> site-location
>
>
> {code}
> The modules link menu in *target/site/index.html* are not interpolated:
> {code}
> ../../../../${sitePublishLocation}/foo/test-module-hierarchical/index.html
> {code}
> Problem can be reproduced with [^variableSettingsSubLinkMenu.zip] project.
> This command fails:
> {code}
> mvn site -s settings-site-location.xml
> {code}
> This command works:
> {code}
> mvn site -s settings-site-location.xml
> -DsitePublishLocation="/tmp/sitePublish"
> {code}
> Probably a link with MSITE-604, but the v3.5 doesn't fix this problem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MSITE-783) Bad modules links when 'distributionManagement.site.url' comes from settings.xml
[
https://issues.apache.org/jira/browse/MSITE-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15519670#comment-15519670
]
Hudson commented on MSITE-783:
--
SUCCESS: Integrated in Jenkins build maven-plugins #7309 (See
[https://builds.apache.org/job/maven-plugins/7309/])
[MSITE-783] fixed modules menu links when data comes from settings, see
DOXIASITETOOLS-166 (hboutemy:
[http://svn.apache.org/viewvc/?view=rev=1762153])
* (edit) maven-site-plugin/pom.xml
> Bad modules links when 'distributionManagement.site.url' comes from
> settings.xml
>
>
> Key: MSITE-783
> URL: https://issues.apache.org/jira/browse/MSITE-783
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: multi module, property interpolation, relative links
>Affects Versions: 3.0, 3.1, 3.2, 3.3, 3.4, 3.5, 3.5.1
>Reporter: Alix Lourme
> Attachments: variableSettingsSubLinkMenu.zip
>
>
> When the _distributionManagement.site.url_ contains a property filled in
> _settings.xml_ like :
> _pom.xml_ :
> {code}
>
>
> projectSite
> ${sitePublishLocation}/foo/${project.artifactId}
>
>
> {code}
> _settings.xml_:
> {code}
>
>
>
>
> site-location
>
>
> file://tmp/sitePublish
>
>
>
>
> site-location
>
>
> {code}
> The modules link menu in *target/site/index.html* are not interpolated:
> {code}
> ../../../../${sitePublishLocation}/foo/test-module-hierarchical/index.html
> {code}
> Problem can be reproduced with [^variableSettingsSubLinkMenu.zip] project.
> This command fails:
> {code}
> mvn site -s settings-site-location.xml
> {code}
> This command works:
> {code}
> mvn site -s settings-site-location.xml
> -DsitePublishLocation="/tmp/sitePublish"
> {code}
> Probably a link with MSITE-604, but the v3.5 doesn't fix this problem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MSITE-783) Bad modules links when 'distributionManagement.site.url' comes from settings.xml
[
https://issues.apache.org/jira/browse/MSITE-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514569#comment-15514569
]
Alix Lourme commented on MSITE-783:
---
Many thanks, If this bug is fixed in the future, I will could delete some
"hacks" in Maven & CI platform configuration, so nice ! :)
> Bad modules links when 'distributionManagement.site.url' comes from
> settings.xml
>
>
> Key: MSITE-783
> URL: https://issues.apache.org/jira/browse/MSITE-783
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: multi module, property interpolation, relative links
>Affects Versions: 3.0, 3.1, 3.2, 3.3, 3.4, 3.5, 3.5.1
>Reporter: Alix Lourme
> Attachments: variableSettingsSubLinkMenu.zip
>
>
> When the _distributionManagement.site.url_ contains a property filled in
> _settings.xml_ like :
> _pom.xml_ :
> {code}
>
>
> projectSite
> ${sitePublishLocation}/foo/${project.artifactId}
>
>
> {code}
> _settings.xml_:
> {code}
>
>
>
>
> site-location
>
>
> file://tmp/sitePublish
>
>
>
>
> site-location
>
>
> {code}
> The modules link menu in *target/site/index.html* are not interpolated:
> {code}
> ../../../../${sitePublishLocation}/foo/test-module-hierarchical/index.html
> {code}
> Problem can be reproduced with [^variableSettingsSubLinkMenu.zip] project.
> This command fails:
> {code}
> mvn site -s settings-site-location.xml
> {code}
> This command works:
> {code}
> mvn site -s settings-site-location.xml
> -DsitePublishLocation="/tmp/sitePublish"
> {code}
> Probably a link with MSITE-604, but the v3.5 doesn't fix this problem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MSITE-783) Bad modules links when 'distributionManagement.site.url' comes from settings.xml
[
https://issues.apache.org/jira/browse/MSITE-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514543#comment-15514543
]
Hervé Boutemy commented on MSITE-783:
-
I think I found the culprit:
http://maven.apache.org/doxia/doxia-sitetools/doxia-integration-tools/xref/org/apache/maven/doxia/tools/DefaultSiteTool.html#L761
I don't know why "// Not running reactor - search for the projects manually"
since we have reactor in arguments and we just ignore it
but for sure, this is like parent pom in MSITE-604: when we build a model
manually, settings is not taken into account
I'll continue tomorrow
> Bad modules links when 'distributionManagement.site.url' comes from
> settings.xml
>
>
> Key: MSITE-783
> URL: https://issues.apache.org/jira/browse/MSITE-783
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: multi module, property interpolation, relative links
>Affects Versions: 3.0, 3.1, 3.2, 3.3, 3.4, 3.5, 3.5.1
>Reporter: Alix Lourme
> Attachments: variableSettingsSubLinkMenu.zip
>
>
> When the _distributionManagement.site.url_ contains a property filled in
> _settings.xml_ like :
> _pom.xml_ :
> {code}
>
>
> projectSite
> ${sitePublishLocation}/foo/${project.artifactId}
>
>
> {code}
> _settings.xml_:
> {code}
>
>
>
>
> site-location
>
>
> file://tmp/sitePublish
>
>
>
>
> site-location
>
>
> {code}
> The modules link menu in *target/site/index.html* are not interpolated:
> {code}
> ../../../../${sitePublishLocation}/foo/test-module-hierarchical/index.html
> {code}
> Problem can be reproduced with [^variableSettingsSubLinkMenu.zip] project.
> This command fails:
> {code}
> mvn site -s settings-site-location.xml
> {code}
> This command works:
> {code}
> mvn site -s settings-site-location.xml
> -DsitePublishLocation="/tmp/sitePublish"
> {code}
> Probably a link with MSITE-604, but the v3.5 doesn't fix this problem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MSITE-783) Bad modules links when 'distributionManagement.site.url' comes from settings.xml
[
https://issues.apache.org/jira/browse/MSITE-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514518#comment-15514518
]
Alix Lourme commented on MSITE-783:
---
Hi Hervé,
Many thanks for taking this bug in consideration.
Executing _Eclipse remote debug_ on project site in attachment with
_maven-site-plugin_ code source, the root cause could be in the [module maven
model
build|https://maven.apache.org/doxia/doxia-sitetools/doxia-integration-tools/xref/org/apache/maven/doxia/tools/DefaultSiteTool.html#L781].
I don't know why, but the model contains interpolated properties from pom, but
not from settings.
Could be seen with these add in module pom :
{code}
${project.version}
${sitePublishLocation}
{code}
The result is :
{code}
{mySitePublishLocation=${sitePublishLocation}, myVersion=1.0.0-SNAPSHOT}
{code}
> Bad modules links when 'distributionManagement.site.url' comes from
> settings.xml
>
>
> Key: MSITE-783
> URL: https://issues.apache.org/jira/browse/MSITE-783
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: multi module, property interpolation, relative links
>Affects Versions: 3.0, 3.1, 3.2, 3.3, 3.4, 3.5, 3.5.1
>Reporter: Alix Lourme
> Attachments: variableSettingsSubLinkMenu.zip
>
>
> When the _distributionManagement.site.url_ contains a property filled in
> _settings.xml_ like :
> _pom.xml_ :
> {code}
>
>
> projectSite
> ${sitePublishLocation}/foo/${project.artifactId}
>
>
> {code}
> _settings.xml_:
> {code}
>
>
>
>
> site-location
>
>
> file://tmp/sitePublish
>
>
>
>
> site-location
>
>
> {code}
> The modules link menu in *target/site/index.html* are not interpolated:
> {code}
> ../../../../${sitePublishLocation}/foo/test-module-hierarchical/index.html
> {code}
> Problem can be reproduced with [^variableSettingsSubLinkMenu.zip] project.
> This command fails:
> {code}
> mvn site -s settings-site-location.xml
> {code}
> This command works:
> {code}
> mvn site -s settings-site-location.xml
> -DsitePublishLocation="/tmp/sitePublish"
> {code}
> Probably a link with MSITE-604, but the v3.5 doesn't fix this problem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MSITE-783) Bad modules links when 'distributionManagement.site.url' comes from settings.xml
[
https://issues.apache.org/jira/browse/MSITE-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514501#comment-15514501
]
Hervé Boutemy commented on MSITE-783:
-
ok, with the effective-pom, I better understand what happens: MSITE-604 was
about interpolation for parent poms, but here, it's about interpolation for
poms from modules, taken from reactor
see DefaultSiteTool.populateModulesMenuItemsFromModels(...) at
http://maven.apache.org/doxia/doxia-sitetools/doxia-integration-tools/xref/org/apache/maven/doxia/tools/DefaultSiteTool.html#L1323
investigation continues...
> Bad modules links when 'distributionManagement.site.url' comes from
> settings.xml
>
>
> Key: MSITE-783
> URL: https://issues.apache.org/jira/browse/MSITE-783
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: multi module, property interpolation, relative links
>Affects Versions: 3.0, 3.1, 3.2, 3.3, 3.4, 3.5, 3.5.1
>Reporter: Alix Lourme
> Attachments: variableSettingsSubLinkMenu.zip
>
>
> When the _distributionManagement.site.url_ contains a property filled in
> _settings.xml_ like :
> _pom.xml_ :
> {code}
>
>
> projectSite
> ${sitePublishLocation}/foo/${project.artifactId}
>
>
> {code}
> _settings.xml_:
> {code}
>
>
>
>
> site-location
>
>
> file://tmp/sitePublish
>
>
>
>
> site-location
>
>
> {code}
> The modules link menu in *target/site/index.html* are not interpolated:
> {code}
> ../../../../${sitePublishLocation}/foo/test-module-hierarchical/index.html
> {code}
> Problem can be reproduced with [^variableSettingsSubLinkMenu.zip] project.
> This command fails:
> {code}
> mvn site -s settings-site-location.xml
> {code}
> This command works:
> {code}
> mvn site -s settings-site-location.xml
> -DsitePublishLocation="/tmp/sitePublish"
> {code}
> Probably a link with MSITE-604, but the v3.5 doesn't fix this problem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MSITE-783) Bad modules links when 'distributionManagement.site.url' comes from settings.xml
[
https://issues.apache.org/jira/browse/MSITE-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514365#comment-15514365
]
Hervé Boutemy commented on MSITE-783:
-
ok, failure reproduced
your case is not the case I was chasing in MSITE-604: in MSITE-604, it was
about parent poms and fixed in DOXIASITETOOLS-145
I'll try to find why this uninterpolated model happens here: I already checked
the effective pom, which has interpolated content
{noformat}mvn -N help:effective-pom -s settings-site-location.xml | grep url
file://tmp/sitePublish/foo/test-parent
https://repo.maven.apache.org/maven2
https://repo.maven.apache.org/maven2{noformat}
I need to continue my investigations...
> Bad modules links when 'distributionManagement.site.url' comes from
> settings.xml
>
>
> Key: MSITE-783
> URL: https://issues.apache.org/jira/browse/MSITE-783
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: multi module, property interpolation, relative links
>Affects Versions: 3.0, 3.1, 3.2, 3.3, 3.4, 3.5, 3.5.1
>Reporter: Alix Lourme
> Attachments: variableSettingsSubLinkMenu.zip
>
>
> When the _distributionManagement.site.url_ contains a property filled in
> _settings.xml_ like :
> _pom.xml_ :
> {code}
>
>
> projectSite
> ${sitePublishLocation}/foo/${project.artifactId}
>
>
> {code}
> _settings.xml_:
> {code}
>
>
>
>
> site-location
>
>
> file://tmp/sitePublish
>
>
>
>
> site-location
>
>
> {code}
> The modules link menu in *target/site/index.html* are not interpolated:
> {code}
> ../../../../${sitePublishLocation}/foo/test-module-hierarchical/index.html
> {code}
> Problem can be reproduced with [^variableSettingsSubLinkMenu.zip] project.
> This command fails:
> {code}
> mvn site -s settings-site-location.xml
> {code}
> This command works:
> {code}
> mvn site -s settings-site-location.xml
> -DsitePublishLocation="/tmp/sitePublish"
> {code}
> Probably a link with MSITE-604, but the v3.5 doesn't fix this problem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
