[jira] [Commented] (SUREFIRE-1153) Take includes into account when using test/it.test property
[
https://issues.apache.org/jira/browse/SUREFIRE-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564387#comment-14564387
]
ASF GitHub Bot commented on SUREFIRE-1153:
--
Github user trohovsky closed the pull request at:
https://github.com/apache/maven-surefire/pull/88
Take includes into account when using test/it.test property
---
Key: SUREFIRE-1153
URL: https://issues.apache.org/jira/browse/SUREFIRE-1153
Project: Maven Surefire
Issue Type: Improvement
Affects Versions: 2.18.1
Reporter: Tomas Rohovsky
Attachments: failsafe-test-parameter.zip
Currently test/it.test property overrides includes and excludes parameters. I
think that it would be better to take includes into account. Lets have this
configuration as an example:
{code}
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-failsafe-plugin/artifactId
version2.18.1/version
configuration
includes
include**/*Test.java/include
/includes
/configuration
executions
execution
goals
goalintegration-test/goal
goalverify/goal
/goals
/execution
/executions
/plugin
{code}
If you execute the test with {{mvn verify -Dit.test=#testFailsafe}} you will
end up with:
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-failsafe-plugin:2.18.1:integration-test
(default) on project failsafe-test-parameter: No tests were executed! (Set
-DfailIfNoTests=false to ignore this error.) - [Help 1]
{code}
Sure, you can specify the class name: {{mvn verify
-Dit.test=ExampleTest#testFailsafe}} and it will work. But it is more
convenient to not do that.
A reproducer is attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1153) Take includes into account when using test/it.test property
[
https://issues.apache.org/jira/browse/SUREFIRE-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563723#comment-14563723
]
ASF GitHub Bot commented on SUREFIRE-1153:
--
Github user Tibor17 closed the pull request at:
https://github.com/apache/maven-surefire/pull/94
Take includes into account when using test/it.test property
---
Key: SUREFIRE-1153
URL: https://issues.apache.org/jira/browse/SUREFIRE-1153
Project: Maven Surefire
Issue Type: Improvement
Affects Versions: 2.18.1
Reporter: Tomas Rohovsky
Attachments: failsafe-test-parameter.zip
Currently test/it.test property overrides includes and excludes parameters. I
think that it would be better to take includes into account. Lets have this
configuration as an example:
{code}
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-failsafe-plugin/artifactId
version2.18.1/version
configuration
includes
include**/*Test.java/include
/includes
/configuration
executions
execution
goals
goalintegration-test/goal
goalverify/goal
/goals
/execution
/executions
/plugin
{code}
If you execute the test with {{mvn verify -Dit.test=#testFailsafe}} you will
end up with:
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-failsafe-plugin:2.18.1:integration-test
(default) on project failsafe-test-parameter: No tests were executed! (Set
-DfailIfNoTests=false to ignore this error.) - [Help 1]
{code}
Sure, you can specify the class name: {{mvn verify
-Dit.test=ExampleTest#testFailsafe}} and it will work. But it is more
convenient to not do that.
A reproducer is attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1153) Take includes into account when using test/it.test property
[
https://issues.apache.org/jira/browse/SUREFIRE-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14551448#comment-14551448
]
ASF GitHub Bot commented on SUREFIRE-1153:
--
GitHub user Tibor17 opened a pull request:
https://github.com/apache/maven-surefire/pull/94
[SUREFIRE-1153] Take includes into account when using test/it.test property
As discussed we Andreas we agreed on SUREFIRE-1153 acceptance where the
includes/excludes list is ignored as soon as test or it.test (sys.property) is
specified whatever execution phase runs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Tibor17/maven-surefire s4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-surefire/pull/94.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #94
commit c67bff883556522f855c572a8486c290dfc62c7a
Author: Tomas Rohovsky troho...@redhat.com
Date: 2015-04-10T19:49:01Z
SUREFIRE-1153 Take includes into account when using test/it.test property
commit 49676d19a7ae909dc737a5a534b8cd79b76e6f42
Author: Tomas Rohovsky troho...@redhat.com
Date: 2015-05-16T13:29:04Z
SUREFIRE-1153 Integration test
commit 517df5ffcc9041462b3603310dfe0843afb59dfc
Author: Tibor17 tibo...@lycos.com
Date: 2015-05-19T22:41:36Z
[SUREFIRE-1153] Take includes into account when using test/it.test property
Take includes into account when using test/it.test property
---
Key: SUREFIRE-1153
URL: https://issues.apache.org/jira/browse/SUREFIRE-1153
Project: Maven Surefire
Issue Type: Improvement
Affects Versions: 2.18.1
Reporter: Tomas Rohovsky
Fix For: 2.19
Attachments: failsafe-test-parameter.zip
Currently test/it.test property overrides includes and excludes parameters. I
think that it would be better to take includes into account. Lets have this
configuration as an example:
{code}
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-failsafe-plugin/artifactId
version2.18.1/version
configuration
includes
include**/*Test.java/include
/includes
/configuration
executions
execution
goals
goalintegration-test/goal
goalverify/goal
/goals
/execution
/executions
/plugin
{code}
If you execute the test with {{mvn verify -Dit.test=#testFailsafe}} you will
end up with:
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-failsafe-plugin:2.18.1:integration-test
(default) on project failsafe-test-parameter: No tests were executed! (Set
-DfailIfNoTests=false to ignore this error.) - [Help 1]
{code}
Sure, you can specify the class name: {{mvn verify
-Dit.test=ExampleTest#testFailsafe}} and it will work. But it is more
convenient to not do that.
A reproducer is attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1153) Take includes into account when using test/it.test property
[
https://issues.apache.org/jira/browse/SUREFIRE-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14501157#comment-14501157
]
Tibor Digana commented on SUREFIRE-1153:
[~agudian]
[~krosenvold]
This issue looks really annoying in users. Please have a look in my question
in https://github.com/apache/maven-surefire/pull/88. It looks like we should
make any decision about these issues because they have repeated.
For me a fix in failsafe 2.19 is doable, but surefire is bound to test phase
and thus breaking the compatibility is reasonable in 3.0.
Take includes into account when using test/it.test property
---
Key: SUREFIRE-1153
URL: https://issues.apache.org/jira/browse/SUREFIRE-1153
Project: Maven Surefire
Issue Type: Improvement
Affects Versions: 2.18.1
Reporter: Tomas Rohovsky
Fix For: 2.19
Attachments: failsafe-test-parameter.zip
Currently test/it.test property overrides includes and excludes parameters. I
think that it would be better to take includes into account. Lets have this
configuration as an example:
{code}
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-failsafe-plugin/artifactId
version2.18.1/version
configuration
includes
include**/*Test.java/include
/includes
/configuration
executions
execution
goals
goalintegration-test/goal
goalverify/goal
/goals
/execution
/executions
/plugin
{code}
If you execute the test with {{mvn verify -Dit.test=#testFailsafe}} you will
end up with:
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-failsafe-plugin:2.18.1:integration-test
(default) on project failsafe-test-parameter: No tests were executed! (Set
-DfailIfNoTests=false to ignore this error.) - [Help 1]
{code}
Sure, you can specify the class name: {{mvn verify
-Dit.test=ExampleTest#testFailsafe}} and it will work. But it is more
convenient to not do that.
A reproducer is attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1153) Take includes into account when using test/it.test property
[
https://issues.apache.org/jira/browse/SUREFIRE-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491702#comment-14491702
]
Tibor Digana commented on SUREFIRE-1153:
I think this bug was already reported.
We should find the duplicates.
Take includes into account when using test/it.test property
---
Key: SUREFIRE-1153
URL: https://issues.apache.org/jira/browse/SUREFIRE-1153
Project: Maven Surefire
Issue Type: Improvement
Affects Versions: 2.18.1
Reporter: Tomas Rohovsky
Fix For: 2.19
Attachments: failsafe-test-parameter.zip
Currently test/it.test property overrides includes and excludes parameters. I
think that it would be better to take includes into account. Lets have this
configuration as an example:
{code}
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-failsafe-plugin/artifactId
version2.18.1/version
configuration
includes
include**/*Test.java/include
/includes
/configuration
executions
execution
goals
goalintegration-test/goal
goalverify/goal
/goals
/execution
/executions
/plugin
{code}
If you execute the test with {{mvn verify -Dit.test=#testFailsafe}} you will
end up with:
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-failsafe-plugin:2.18.1:integration-test
(default) on project failsafe-test-parameter: No tests were executed! (Set
-DfailIfNoTests=false to ignore this error.) - [Help 1]
{code}
Sure, you can specify the class name: {{mvn verify
-Dit.test=ExampleTest#testFailsafe}} and it will work. But it is more
convenient to not do that.
A reproducer is attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
