[jira] [Commented] (SUREFIRE-1198) Failsafe does not allow to use target/classes anymore

[Tibor Digana (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029282#comment-15029282
 ] 

Tibor Digana commented on SUREFIRE-1198:


[~azgard]
I was too fast writing the comment. I saw my System.out logs after the timeout 
290 seconds.
This means the test hangs on WinXP before the test method starts, maybe in 
Spring Runner.
Why this is related only to old OS?
WDYT?

> Failsafe does not allow to use target/classes anymore
> -
>
> Key: SUREFIRE-1198
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1198
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Stephane Nicoll
>
> See [this Spring Boot 
> issue|https://github.com/spring-projects/spring-boot/issues/4510#issuecomment-159448634]
> It seems that SUREFIRE-855 does not allow {{target/classes}} to be used 
> anymore. Is there a reason why this behaviour was completely removed in 
> favour of only the jar file?
> It would be nice if we had an option to chose between the two (defaulting to 
> the jar)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SUREFIRE-1198) Failsafe does not allow to use target/classes anymore

[Tibor Digana (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029258#comment-15029258
 ] 

Tibor Digana commented on SUREFIRE-1198:


[~azgard]
Started the build of your project on WinXP and there really seems to be a 
problem.
The test started and timed out after 200 seconds. No idea why.
But another thing is interesteing to me. I printed std/out but I do not see 
anything in the console.
Most probably Stringboot overrides std/out when the test starts and the 
Surefire does not receive command TESTSET_FINISHED from std/in and therefore 
expects a new test class but there's only one. We are using std/in and out as 
communication channel between Maven process and Surefire forked JVM.
I don't see these logs:
{code}
@Before
public void check() {
System.out.println("# B:TIBOR ##");
assertNotNull(ctrl);
}

@After
public void after() {
System.out.println("# A:TIBOR ##");
}
{code}

> Failsafe does not allow to use target/classes anymore
> -
>
> Key: SUREFIRE-1198
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1198
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Stephane Nicoll
>
> See [this Spring Boot 
> issue|https://github.com/spring-projects/spring-boot/issues/4510#issuecomment-159448634]
> It seems that SUREFIRE-855 does not allow {{target/classes}} to be used 
> anymore. Is there a reason why this behaviour was completely removed in 
> favour of only the jar file?
> It would be nice if we had an option to chose between the two (defaulting to 
> the jar)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SUREFIRE-1198) Failsafe does not allow to use target/classes anymore

[Tibor Digana (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028713#comment-15028713
 ] 

Tibor Digana commented on SUREFIRE-1198:


[~snicoll]
How you want to continue if you close this ticket?
It is not fair if you close it without saying "I fixed it like this and 
this...".

> Failsafe does not allow to use target/classes anymore
> -
>
> Key: SUREFIRE-1198
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1198
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Stephane Nicoll
>
> See [this Spring Boot 
> issue|https://github.com/spring-projects/spring-boot/issues/4510#issuecomment-159448634]
> It seems that SUREFIRE-855 does not allow {{target/classes}} to be used 
> anymore. Is there a reason why this behaviour was completely removed in 
> favour of only the jar file?
> It would be nice if we had an option to chose between the two (defaulting to 
> the jar)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SUREFIRE-1198) Failsafe does not allow to use target/classes anymore

[JIRA]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028807#comment-15028807
 ] 

Conny Kreyßel commented on SUREFIRE-1198:
-

Hello [~tibor17],

we are inverstigating the issue in the spring boot project. 
https://github.com/spring-projects/spring-boot/issues/4510#issuecomment-159916604.

I can reproduce it now. If you have a good old windows 2003/xp maybe you can 
try my testset to reproduce the bug. 
https://github.com/kreyssel/spring-boot-failsafe-plugin-console-hang-test-set

But it looks like not an failsafe-plugin bug.


> Failsafe does not allow to use target/classes anymore
> -
>
> Key: SUREFIRE-1198
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1198
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Stephane Nicoll
>
> See [this Spring Boot 
> issue|https://github.com/spring-projects/spring-boot/issues/4510#issuecomment-159448634]
> It seems that SUREFIRE-855 does not allow {{target/classes}} to be used 
> anymore. Is there a reason why this behaviour was completely removed in 
> favour of only the jar file?
> It would be nice if we had an option to chose between the two (defaulting to 
> the jar)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SUREFIRE-1198) Failsafe does not allow to use target/classes anymore

[Tibor Digana (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028978#comment-15028978
 ] 

Tibor Digana commented on SUREFIRE-1198:


The project is successfully running with one IT on Win7 in both cases
Surefire 2.18.1 and 2.19.
I will try to run (mvn verify) on WinXP in the evening.

On Thu, Nov 26, 2015 at 2:49 PM, Conny Kreyßel (JIRA) 



> Failsafe does not allow to use target/classes anymore
> -
>
> Key: SUREFIRE-1198
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1198
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Stephane Nicoll
>
> See [this Spring Boot 
> issue|https://github.com/spring-projects/spring-boot/issues/4510#issuecomment-159448634]
> It seems that SUREFIRE-855 does not allow {{target/classes}} to be used 
> anymore. Is there a reason why this behaviour was completely removed in 
> favour of only the jar file?
> It would be nice if we had an option to chose between the two (defaulting to 
> the jar)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SUREFIRE-1198) Failsafe does not allow to use target/classes anymore

[Tibor Digana (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15027200#comment-15027200
 ] 

Tibor Digana commented on SUREFIRE-1198:


[~snicoll]
Is it now working for you?

> Failsafe does not allow to use target/classes anymore
> -
>
> Key: SUREFIRE-1198
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1198
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Stephane Nicoll
>
> See [this Spring Boot 
> issue|https://github.com/spring-projects/spring-boot/issues/4510#issuecomment-159448634]
> It seems that SUREFIRE-855 does not allow {{target/classes}} to be used 
> anymore. Is there a reason why this behaviour was completely removed in 
> favour of only the jar file?
> It would be nice if we had an option to chose between the two (defaulting to 
> the jar)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SUREFIRE-1198) Failsafe does not allow to use target/classes anymore

[Stephane Nicoll (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15027647#comment-15027647
 ] 

Stephane Nicoll commented on SUREFIRE-1198:
---

What do you mean? I confirm that if surefire allows to configure the jar to use 
we are happy. 

> Failsafe does not allow to use target/classes anymore
> -
>
> Key: SUREFIRE-1198
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1198
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Stephane Nicoll
>
> See [this Spring Boot 
> issue|https://github.com/spring-projects/spring-boot/issues/4510#issuecomment-159448634]
> It seems that SUREFIRE-855 does not allow {{target/classes}} to be used 
> anymore. Is there a reason why this behaviour was completely removed in 
> favour of only the jar file?
> It would be nice if we had an option to chose between the two (defaulting to 
> the jar)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SUREFIRE-1198) Failsafe does not allow to use target/classes anymore

[Robert Scholte (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15027677#comment-15027677
 ] 

Robert Scholte commented on SUREFIRE-1198:
--

So you want to test with another jar then the one being uploaded/deployed? 
Sounds like an unnecessary hack to me. I suggest to attach a simple project 
exposing the problem so we all understand the problem.

> Failsafe does not allow to use target/classes anymore
> -
>
> Key: SUREFIRE-1198
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1198
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Stephane Nicoll
>
> See [this Spring Boot 
> issue|https://github.com/spring-projects/spring-boot/issues/4510#issuecomment-159448634]
> It seems that SUREFIRE-855 does not allow {{target/classes}} to be used 
> anymore. Is there a reason why this behaviour was completely removed in 
> favour of only the jar file?
> It would be nice if we had an option to chose between the two (defaulting to 
> the jar)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SUREFIRE-1198) Failsafe does not allow to use target/classes anymore

[Robert Scholte (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15027517#comment-15027517
 ] 

Robert Scholte commented on SUREFIRE-1198:
--

I still think that everyone wants/expects (or should expect) the distributable 
to be tested and I'm very willing to help solving related issues. So it seems 
like the plugin must also decide if should use the adjusted pom.xml, that would 
help, right?

> Failsafe does not allow to use target/classes anymore
> -
>
> Key: SUREFIRE-1198
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1198
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Stephane Nicoll
>
> See [this Spring Boot 
> issue|https://github.com/spring-projects/spring-boot/issues/4510#issuecomment-159448634]
> It seems that SUREFIRE-855 does not allow {{target/classes}} to be used 
> anymore. Is there a reason why this behaviour was completely removed in 
> favour of only the jar file?
> It would be nice if we had an option to chose between the two (defaulting to 
> the jar)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SUREFIRE-1198) Failsafe does not allow to use target/classes anymore

[Tibor Digana (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15027554#comment-15027554
 ] 

Tibor Digana commented on SUREFIRE-1198:


[~azgard]
If you use assembly plugin, do you attach and override the artifact file with 
its default name? If you don't then two jars do not make sense since one of 
them is not testable.

> Failsafe does not allow to use target/classes anymore
> -
>
> Key: SUREFIRE-1198
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1198
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Stephane Nicoll
>
> See [this Spring Boot 
> issue|https://github.com/spring-projects/spring-boot/issues/4510#issuecomment-159448634]
> It seems that SUREFIRE-855 does not allow {{target/classes}} to be used 
> anymore. Is there a reason why this behaviour was completely removed in 
> favour of only the jar file?
> It would be nice if we had an option to chose between the two (defaulting to 
> the jar)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SUREFIRE-1198) Failsafe does not allow to use target/classes anymore

[Tibor Digana (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15027555#comment-15027555
 ] 

Tibor Digana commented on SUREFIRE-1198:


More than fixing this issue I would say we would need to have ClassLoader for 
war and ear due to currently only jar is supported in this feature. Maybe more 
archive types..

> Failsafe does not allow to use target/classes anymore
> -
>
> Key: SUREFIRE-1198
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1198
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Stephane Nicoll
>
> See [this Spring Boot 
> issue|https://github.com/spring-projects/spring-boot/issues/4510#issuecomment-159448634]
> It seems that SUREFIRE-855 does not allow {{target/classes}} to be used 
> anymore. Is there a reason why this behaviour was completely removed in 
> favour of only the jar file?
> It would be nice if we had an option to chose between the two (defaulting to 
> the jar)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SUREFIRE-1198) Failsafe does not allow to use target/classes anymore

[Tibor Digana (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15027556#comment-15027556
 ] 

Tibor Digana commented on SUREFIRE-1198:


More than fixing this issue I would say we would need to have ClassLoader for 
war and ear due to currently only jar is supported in this feature. Maybe more 
archive types..

> Failsafe does not allow to use target/classes anymore
> -
>
> Key: SUREFIRE-1198
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1198
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Stephane Nicoll
>
> See [this Spring Boot 
> issue|https://github.com/spring-projects/spring-boot/issues/4510#issuecomment-159448634]
> It seems that SUREFIRE-855 does not allow {{target/classes}} to be used 
> anymore. Is there a reason why this behaviour was completely removed in 
> favour of only the jar file?
> It would be nice if we had an option to chose between the two (defaulting to 
> the jar)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SUREFIRE-1198) Failsafe does not allow to use target/classes anymore

[Tibor Digana (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026679#comment-15026679
 ] 

Tibor Digana commented on SUREFIRE-1198:


Yes there was a reason. The Surefire fixed this as a bug in Version 2.19.
Without it unit test and integration test would not make any difference. 
The life cycle:
compile
test
package
integration-test
verify

This means classes is tested in unit test
The package is tested in the integration tests.

May I close this issue?

> Failsafe does not allow to use target/classes anymore
> -
>
> Key: SUREFIRE-1198
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1198
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Stephane Nicoll
>
> See [this Spring Boot 
> issue|https://github.com/spring-projects/spring-boot/issues/4510#issuecomment-159448634]
> It seems that SUREFIRE-855 does not allow {{target/classes}} to be used 
> anymore. Is there a reason why this behaviour was completely removed in 
> favour of only the jar file?
> It would be nice if we had an option to chose between the two (defaulting to 
> the jar)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SUREFIRE-1198) Failsafe does not allow to use target/classes anymore

[JIRA]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026712#comment-15026712
 ] 

Conny Kreyßel commented on SUREFIRE-1198:
-

At first this sounds fully correct to me.

But in second you ignore that some plugins reassemble the jar (shade-plugin or 
spring-boot-maven-plugin). That means in intergration tests is not the 
"original" jar attached and used, but the "repackaged" jar.

If you use the repackaged jar in integration test, you have also the assigned 
dependencies artifacts in classpath. This is really a bad situation.

Maybe the default should use the jar in intergration tests - but we should have 
a swicth to disable this and use target/classes instead.

> Failsafe does not allow to use target/classes anymore
> -
>
> Key: SUREFIRE-1198
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1198
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Stephane Nicoll
>
> See [this Spring Boot 
> issue|https://github.com/spring-projects/spring-boot/issues/4510#issuecomment-159448634]
> It seems that SUREFIRE-855 does not allow {{target/classes}} to be used 
> anymore. Is there a reason why this behaviour was completely removed in 
> favour of only the jar file?
> It would be nice if we had an option to chose between the two (defaulting to 
> the jar)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SUREFIRE-1198) Failsafe does not allow to use target/classes anymore

[Tibor Digana (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026848#comment-15026848
 ] 

Tibor Digana commented on SUREFIRE-1198:


You can open a pull-request on GitHub and add parameter artifactName for 
failsafe only.
We already have such things in AbstractSurefireMojo.
Notice that classes folder is taken anyway if non-jar achive is packaged. For 
instance WAR file.

> Failsafe does not allow to use target/classes anymore
> -
>
> Key: SUREFIRE-1198
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1198
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Stephane Nicoll
>
> See [this Spring Boot 
> issue|https://github.com/spring-projects/spring-boot/issues/4510#issuecomment-159448634]
> It seems that SUREFIRE-855 does not allow {{target/classes}} to be used 
> anymore. Is there a reason why this behaviour was completely removed in 
> favour of only the jar file?
> It would be nice if we had an option to chose between the two (defaulting to 
> the jar)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SUREFIRE-1198) Failsafe does not allow to use target/classes anymore

[Stephane Nicoll (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026854#comment-15026854
 ] 

Stephane Nicoll commented on SUREFIRE-1198:
---

Configuring the jar to use would work for us. I'll have a look.

> Failsafe does not allow to use target/classes anymore
> -
>
> Key: SUREFIRE-1198
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1198
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Stephane Nicoll
>
> See [this Spring Boot 
> issue|https://github.com/spring-projects/spring-boot/issues/4510#issuecomment-159448634]
> It seems that SUREFIRE-855 does not allow {{target/classes}} to be used 
> anymore. Is there a reason why this behaviour was completely removed in 
> favour of only the jar file?
> It would be nice if we had an option to chose between the two (defaulting to 
> the jar)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)