[jira] [Commented] (SUREFIRE-1247) Custom Junit Runner ignored with surefire plugin(in case of failure)

2016-09-19 Thread Tibor Digana (JIRA)

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504641#comment-15504641
 ] 

Tibor Digana commented on SUREFIRE-1247:


[~keyolce]
[~pratik.kumar]
Throwing exception in @ClassRule should not be fatal in Surefire.
Please provide stacktrace or code of the Runner including test or close the 
issue.

> Custom Junit Runner ignored with surefire plugin(in case of failure)
> 
>
> Key: SUREFIRE-1247
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1247
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Pratik kumar
>Assignee: Tibor Digana
>
> Running a Junit Test with surefire plugin ignores test class when custom 
> junit  runner throws a RuntimeException. Is this expected behaviour ? 
> How can I add a custom Runner that should stop test flow execution in case 
> the custom Junit Runner throws an exception?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SUREFIRE-1247) Custom Junit Runner ignored with surefire plugin(in case of failure)

2016-05-30 Thread Tibor Digana (JIRA)

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15306387#comment-15306387
 ] 

Tibor Digana commented on SUREFIRE-1247:


You can use surefire-testng provider as well, but TestNG runs JUnit by default.
If you use both, you should suppress JUnit running within TestNG, see 
http://maven.apache.org/surefire/maven-surefire-plugin/examples/testng.html#Running_TestNG_and_JUnit_Tests
We are running only classes which have @org.junit.Test
If you force TestNG to run your suites XML file, then JUnit would not be run 
within TestNG and you should use JUnit provider.

> Custom Junit Runner ignored with surefire plugin(in case of failure)
> 
>
> Key: SUREFIRE-1247
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1247
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Pratik kumar
>Assignee: Tibor Digana
>
> Running a Junit Test with surefire plugin ignores test class when custom 
> junit  runner throws a RuntimeException. Is this expected behaviour ? 
> How can I add a custom Runner that should stop test flow execution in case 
> the custom Junit Runner throws an exception?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SUREFIRE-1247) Custom Junit Runner ignored with surefire plugin(in case of failure)

2016-05-29 Thread Pratik kumar (JIRA)

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305905#comment-15305905
 ] 

Pratik kumar commented on SUREFIRE-1247:


But what happens when my project consists of mixture of JUnit and TestNg tests. 
Then I don't think only surefire-junit provider will be enough

> Custom Junit Runner ignored with surefire plugin(in case of failure)
> 
>
> Key: SUREFIRE-1247
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1247
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Pratik kumar
>Assignee: Tibor Digana
>
> Running a Junit Test with surefire plugin ignores test class when custom 
> junit  runner throws a RuntimeException. Is this expected behaviour ? 
> How can I add a custom Runner that should stop test flow execution in case 
> the custom Junit Runner throws an exception?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SUREFIRE-1247) Custom Junit Runner ignored with surefire plugin(in case of failure)

2016-05-29 Thread Tibor Digana (JIRA)

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305884#comment-15305884
 ] 

Tibor Digana commented on SUREFIRE-1247:


Use surefire-junit47 provider. We will deprecate the default provider 
surefire-junit4 anyway.

> Custom Junit Runner ignored with surefire plugin(in case of failure)
> 
>
> Key: SUREFIRE-1247
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1247
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Pratik kumar
>Assignee: Tibor Digana
>
> Running a Junit Test with surefire plugin ignores test class when custom 
> junit  runner throws a RuntimeException. Is this expected behaviour ? 
> How can I add a custom Runner that should stop test flow execution in case 
> the custom Junit Runner throws an exception?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SUREFIRE-1247) Custom Junit Runner ignored with surefire plugin(in case of failure)

2016-05-29 Thread Pratik kumar (JIRA)

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305846#comment-15305846
 ] 

Pratik kumar commented on SUREFIRE-1247:


The methods annotated with @ClassRule are throwing the RunTimeException. 
Although I get the stack trace reporting an error , the Test class is 
completely taken out the total test count and still the test phase continues.

> Custom Junit Runner ignored with surefire plugin(in case of failure)
> 
>
> Key: SUREFIRE-1247
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1247
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Pratik kumar
>Assignee: Tibor Digana
>
> Running a Junit Test with surefire plugin ignores test class when custom 
> junit  runner throws a RuntimeException. Is this expected behaviour ? 
> How can I add a custom Runner that should stop test flow execution in case 
> the custom Junit Runner throws an exception?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SUREFIRE-1247) Custom Junit Runner ignored with surefire plugin(in case of failure)

2016-05-09 Thread Tibor Digana (JIRA)

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15276945#comment-15276945
 ] 

Tibor Digana commented on SUREFIRE-1247:


[~keyolce]
I do not understand how I can help you since I do not see the stacktrace where 
the exception comes from.
Does it come from a test method or Runner constructor?
Please attach the log file in JIRA.

> Custom Junit Runner ignored with surefire plugin(in case of failure)
> 
>
> Key: SUREFIRE-1247
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1247
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Pratik kumar
>
> Running a Junit Test with surefire plugin ignores test class when custom 
> junit  runner throws a RuntimeException. Is this expected behaviour ? 
> How can I add a custom Runner that should stop test flow execution in case 
> the custom Junit Runner throws an exception?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)