[jira] [Commented] (SUREFIRE-1378) Nice to have systemPropertiesFile configurable by user property

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431430#comment-16431430
 ] 

ASF GitHub Bot commented on SUREFIRE-1378:
--

Tibor17 commented on issue #152: [SUREFIRE-1378] Nice to have 
systemPropertiesFile configurable by user property
URL: https://github.com/apache/maven-surefire/pull/152#issuecomment-379914271
 
 
   Now the build should not fail.
   The maven-checkstyle-plugin.
   Now try to run `mvn install` takes one hour to complete all tests.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Nice to have systemPropertiesFile configurable by user property
> ---
>
> Key: SUREFIRE-1378
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1378
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Michal Domagala
>Assignee: Tibor Digana
>Priority: Minor
>
> I would like to have option to configure my tests with property files. But 
> property file is not required, because in 95% my tests work fine with default 
> configuration.
> I used the following workaround: I configured failsafe plugin in the 
> following way
> {code:xml}
> 
>   
> 
> (...)
> maven-failsafe-plugin
> (...)
> ${my.test.props.file}
> {code}
> In 95% I call *mvn verify*, systemPropertiesFile is not found and ignored 
> -all pass
> In 5% I call *mvn verify -Dmy.test.props.file=x.props*
> The problem is in 95% I get warning about missing files. Also  configuration 
> is unnecessary complicated
> I would like drop whole connfiguration from pom.xml and use:
> In 95% *mvn verify*
> In 5% *mvn verify -Dfailsafe.systemPropertiesFile=x.props*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1378) Nice to have systemPropertiesFile configurable by user property

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431426#comment-16431426
 ] 

ASF GitHub Bot commented on SUREFIRE-1378:
--

Tibor17 commented on a change in pull request #152: [SUREFIRE-1378] Nice to 
have systemPropertiesFile configurable by user property
URL: https://github.com/apache/maven-surefire/pull/152#discussion_r180249875
 
 

 ##
 File path: 
maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java
 ##
 @@ -395,6 +398,17 @@ protected Artifact getMojoArtifact()
 return pluginArtifactMap.get( 
"org.apache.maven.plugins:maven-surefire-plugin" );
 }
 
+
+public File getSystemPropertiesFile() {
 
 Review comment:
   again


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Nice to have systemPropertiesFile configurable by user property
> ---
>
> Key: SUREFIRE-1378
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1378
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Michal Domagala
>Assignee: Tibor Digana
>Priority: Minor
>
> I would like to have option to configure my tests with property files. But 
> property file is not required, because in 95% my tests work fine with default 
> configuration.
> I used the following workaround: I configured failsafe plugin in the 
> following way
> {code:xml}
> 
>   
> 
> (...)
> maven-failsafe-plugin
> (...)
> ${my.test.props.file}
> {code}
> In 95% I call *mvn verify*, systemPropertiesFile is not found and ignored 
> -all pass
> In 5% I call *mvn verify -Dmy.test.props.file=x.props*
> The problem is in 95% I get warning about missing files. Also  configuration 
> is unnecessary complicated
> I would like drop whole connfiguration from pom.xml and use:
> In 95% *mvn verify*
> In 5% *mvn verify -Dfailsafe.systemPropertiesFile=x.props*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1378) Nice to have systemPropertiesFile configurable by user property

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431428#comment-16431428
 ] 

ASF GitHub Bot commented on SUREFIRE-1378:
--

Tibor17 commented on a change in pull request #152: [SUREFIRE-1378] Nice to 
have systemPropertiesFile configurable by user property
URL: https://github.com/apache/maven-surefire/pull/152#discussion_r180249903
 
 

 ##
 File path: 
maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java
 ##
 @@ -395,6 +398,17 @@ protected Artifact getMojoArtifact()
 return pluginArtifactMap.get( 
"org.apache.maven.plugins:maven-surefire-plugin" );
 }
 
+
+public File getSystemPropertiesFile() {
+return systemPropertiesFile;
+}
+
+
+public void setSystemPropertiesFile(File systemPropertiesFile) {
 
 Review comment:
   again


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Nice to have systemPropertiesFile configurable by user property
> ---
>
> Key: SUREFIRE-1378
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1378
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Michal Domagala
>Assignee: Tibor Digana
>Priority: Minor
>
> I would like to have option to configure my tests with property files. But 
> property file is not required, because in 95% my tests work fine with default 
> configuration.
> I used the following workaround: I configured failsafe plugin in the 
> following way
> {code:xml}
> 
>   
> 
> (...)
> maven-failsafe-plugin
> (...)
> ${my.test.props.file}
> {code}
> In 95% I call *mvn verify*, systemPropertiesFile is not found and ignored 
> -all pass
> In 5% I call *mvn verify -Dmy.test.props.file=x.props*
> The problem is in 95% I get warning about missing files. Also  configuration 
> is unnecessary complicated
> I would like drop whole connfiguration from pom.xml and use:
> In 95% *mvn verify*
> In 5% *mvn verify -Dfailsafe.systemPropertiesFile=x.props*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1378) Nice to have systemPropertiesFile configurable by user property

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431425#comment-16431425
 ] 

ASF GitHub Bot commented on SUREFIRE-1378:
--

Tibor17 commented on a change in pull request #152: [SUREFIRE-1378] Nice to 
have systemPropertiesFile configurable by user property
URL: https://github.com/apache/maven-surefire/pull/152#discussion_r180249851
 
 

 ##
 File path: 
maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java
 ##
 @@ -351,6 +351,9 @@
 @Parameter( property = "surefire.shutdown", defaultValue = "testset" )
 private String shutdown;
 
+@Parameter( property = "surefire.systemPropertiesFile")
 
 Review comment:
   end-bracket missed space


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Nice to have systemPropertiesFile configurable by user property
> ---
>
> Key: SUREFIRE-1378
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1378
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Michal Domagala
>Assignee: Tibor Digana
>Priority: Minor
>
> I would like to have option to configure my tests with property files. But 
> property file is not required, because in 95% my tests work fine with default 
> configuration.
> I used the following workaround: I configured failsafe plugin in the 
> following way
> {code:xml}
> 
>   
> 
> (...)
> maven-failsafe-plugin
> (...)
> ${my.test.props.file}
> {code}
> In 95% I call *mvn verify*, systemPropertiesFile is not found and ignored 
> -all pass
> In 5% I call *mvn verify -Dmy.test.props.file=x.props*
> The problem is in 95% I get warning about missing files. Also  configuration 
> is unnecessary complicated
> I would like drop whole connfiguration from pom.xml and use:
> In 95% *mvn verify*
> In 5% *mvn verify -Dfailsafe.systemPropertiesFile=x.props*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1378) Nice to have systemPropertiesFile configurable by user property

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431422#comment-16431422
 ] 

ASF GitHub Bot commented on SUREFIRE-1378:
--

Tibor17 commented on a change in pull request #152: [SUREFIRE-1378] Nice to 
have systemPropertiesFile configurable by user property
URL: https://github.com/apache/maven-surefire/pull/152#discussion_r180249771
 
 

 ##
 File path: 
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoTest.java
 ##
 @@ -601,5 +601,14 @@ protected Artifact getMojoArtifact()
 {
 return null;
 }
+
+@Override
+public File getSystemPropertiesFile() {
+return null;
+}
+
+@Override
+public void setSystemPropertiesFile(File systemPropertiesFile) {
 
 Review comment:
   same here


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Nice to have systemPropertiesFile configurable by user property
> ---
>
> Key: SUREFIRE-1378
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1378
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Michal Domagala
>Assignee: Tibor Digana
>Priority: Minor
>
> I would like to have option to configure my tests with property files. But 
> property file is not required, because in 95% my tests work fine with default 
> configuration.
> I used the following workaround: I configured failsafe plugin in the 
> following way
> {code:xml}
> 
>   
> 
> (...)
> maven-failsafe-plugin
> (...)
> ${my.test.props.file}
> {code}
> In 95% I call *mvn verify*, systemPropertiesFile is not found and ignored 
> -all pass
> In 5% I call *mvn verify -Dmy.test.props.file=x.props*
> The problem is in 95% I get warning about missing files. Also  configuration 
> is unnecessary complicated
> I would like drop whole connfiguration from pom.xml and use:
> In 95% *mvn verify*
> In 5% *mvn verify -Dfailsafe.systemPropertiesFile=x.props*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1378) Nice to have systemPropertiesFile configurable by user property

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431420#comment-16431420
 ] 

ASF GitHub Bot commented on SUREFIRE-1378:
--

Tibor17 commented on a change in pull request #152: [SUREFIRE-1378] Nice to 
have systemPropertiesFile configurable by user property
URL: https://github.com/apache/maven-surefire/pull/152#discussion_r180249739
 
 

 ##
 File path: 
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoTest.java
 ##
 @@ -601,5 +601,14 @@ protected Artifact getMojoArtifact()
 {
 return null;
 }
+
+@Override
+public File getSystemPropertiesFile() {
 
 Review comment:
   same here


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Nice to have systemPropertiesFile configurable by user property
> ---
>
> Key: SUREFIRE-1378
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1378
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Michal Domagala
>Assignee: Tibor Digana
>Priority: Minor
>
> I would like to have option to configure my tests with property files. But 
> property file is not required, because in 95% my tests work fine with default 
> configuration.
> I used the following workaround: I configured failsafe plugin in the 
> following way
> {code:xml}
> 
>   
> 
> (...)
> maven-failsafe-plugin
> (...)
> ${my.test.props.file}
> {code}
> In 95% I call *mvn verify*, systemPropertiesFile is not found and ignored 
> -all pass
> In 5% I call *mvn verify -Dmy.test.props.file=x.props*
> The problem is in 95% I get warning about missing files. Also  configuration 
> is unnecessary complicated
> I would like drop whole connfiguration from pom.xml and use:
> In 95% *mvn verify*
> In 5% *mvn verify -Dfailsafe.systemPropertiesFile=x.props*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1378) Nice to have systemPropertiesFile configurable by user property

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431419#comment-16431419
 ] 

ASF GitHub Bot commented on SUREFIRE-1378:
--

Tibor17 commented on a change in pull request #152: [SUREFIRE-1378] Nice to 
have systemPropertiesFile configurable by user property
URL: https://github.com/apache/maven-surefire/pull/152#discussion_r180249705
 
 

 ##
 File path: 
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoJava7PlusTest.java
 ##
 @@ -580,5 +580,14 @@ protected Artifact getMojoArtifact()
 {
 return null;
 }
+
+@Override
+public File getSystemPropertiesFile() {
+return null;
+}
+
+@Override
+public void setSystemPropertiesFile(File systemPropertiesFile) {
 
 Review comment:
   ```
   public void setSystemPropertiesFile( File systemPropertiesFile )
   {
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Nice to have systemPropertiesFile configurable by user property
> ---
>
> Key: SUREFIRE-1378
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1378
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Michal Domagala
>Assignee: Tibor Digana
>Priority: Minor
>
> I would like to have option to configure my tests with property files. But 
> property file is not required, because in 95% my tests work fine with default 
> configuration.
> I used the following workaround: I configured failsafe plugin in the 
> following way
> {code:xml}
> 
>   
> 
> (...)
> maven-failsafe-plugin
> (...)
> ${my.test.props.file}
> {code}
> In 95% I call *mvn verify*, systemPropertiesFile is not found and ignored 
> -all pass
> In 5% I call *mvn verify -Dmy.test.props.file=x.props*
> The problem is in 95% I get warning about missing files. Also  configuration 
> is unnecessary complicated
> I would like drop whole connfiguration from pom.xml and use:
> In 95% *mvn verify*
> In 5% *mvn verify -Dfailsafe.systemPropertiesFile=x.props*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1378) Nice to have systemPropertiesFile configurable by user property

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431416#comment-16431416
 ] 

ASF GitHub Bot commented on SUREFIRE-1378:
--

Tibor17 commented on a change in pull request #152: [SUREFIRE-1378] Nice to 
have systemPropertiesFile configurable by user property
URL: https://github.com/apache/maven-surefire/pull/152#discussion_r180249613
 
 

 ##
 File path: 
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/AbstractSurefireMojoJava7PlusTest.java
 ##
 @@ -580,5 +580,14 @@ protected Artifact getMojoArtifact()
 {
 return null;
 }
+
+@Override
+public File getSystemPropertiesFile() {
 
 Review comment:
   Same here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Nice to have systemPropertiesFile configurable by user property
> ---
>
> Key: SUREFIRE-1378
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1378
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Michal Domagala
>Assignee: Tibor Digana
>Priority: Minor
>
> I would like to have option to configure my tests with property files. But 
> property file is not required, because in 95% my tests work fine with default 
> configuration.
> I used the following workaround: I configured failsafe plugin in the 
> following way
> {code:xml}
> 
>   
> 
> (...)
> maven-failsafe-plugin
> (...)
> ${my.test.props.file}
> {code}
> In 95% I call *mvn verify*, systemPropertiesFile is not found and ignored 
> -all pass
> In 5% I call *mvn verify -Dmy.test.props.file=x.props*
> The problem is in 95% I get warning about missing files. Also  configuration 
> is unnecessary complicated
> I would like drop whole connfiguration from pom.xml and use:
> In 95% *mvn verify*
> In 5% *mvn verify -Dfailsafe.systemPropertiesFile=x.props*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1378) Nice to have systemPropertiesFile configurable by user property

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431411#comment-16431411
 ] 

ASF GitHub Bot commented on SUREFIRE-1378:
--

Tibor17 commented on a change in pull request #152: [SUREFIRE-1378] Nice to 
have systemPropertiesFile configurable by user property
URL: https://github.com/apache/maven-surefire/pull/152#discussion_r180249462
 
 

 ##
 File path: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
 ##
 @@ -1033,11 +1025,11 @@ private SurefireProperties setupProperties()
 SurefireProperties sysProps = null;
 try
 {
-sysProps = SurefireProperties.loadProperties( systemPropertiesFile 
);
+sysProps = 
SurefireProperties.loadProperties(getSystemPropertiesFile());
 
 Review comment:
   added spaces
   `( getSystemPropertiesFile() )`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Nice to have systemPropertiesFile configurable by user property
> ---
>
> Key: SUREFIRE-1378
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1378
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Michal Domagala
>Assignee: Tibor Digana
>Priority: Minor
>
> I would like to have option to configure my tests with property files. But 
> property file is not required, because in 95% my tests work fine with default 
> configuration.
> I used the following workaround: I configured failsafe plugin in the 
> following way
> {code:xml}
> 
>   
> 
> (...)
> maven-failsafe-plugin
> (...)
> ${my.test.props.file}
> {code}
> In 95% I call *mvn verify*, systemPropertiesFile is not found and ignored 
> -all pass
> In 5% I call *mvn verify -Dmy.test.props.file=x.props*
> The problem is in 95% I get warning about missing files. Also  configuration 
> is unnecessary complicated
> I would like drop whole connfiguration from pom.xml and use:
> In 95% *mvn verify*
> In 5% *mvn verify -Dfailsafe.systemPropertiesFile=x.props*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1378) Nice to have systemPropertiesFile configurable by user property

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431413#comment-16431413
 ] 

ASF GitHub Bot commented on SUREFIRE-1378:
--

Tibor17 commented on a change in pull request #152: [SUREFIRE-1378] Nice to 
have systemPropertiesFile configurable by user property
URL: https://github.com/apache/maven-surefire/pull/152#discussion_r180249519
 
 

 ##
 File path: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
 ##
 @@ -1033,11 +1025,11 @@ private SurefireProperties setupProperties()
 SurefireProperties sysProps = null;
 try
 {
-sysProps = SurefireProperties.loadProperties( systemPropertiesFile 
);
+sysProps = 
SurefireProperties.loadProperties(getSystemPropertiesFile());
 }
 catch ( IOException e )
 {
-String msg = "The system property file '" + 
systemPropertiesFile.getAbsolutePath() + "' can't be read.";
+String msg = "The system property file '" + 
getSystemPropertiesFile().getAbsolutePath() + "' can't be read.";
 
 Review comment:
   `+` at new line


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Nice to have systemPropertiesFile configurable by user property
> ---
>
> Key: SUREFIRE-1378
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1378
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Michal Domagala
>Assignee: Tibor Digana
>Priority: Minor
>
> I would like to have option to configure my tests with property files. But 
> property file is not required, because in 95% my tests work fine with default 
> configuration.
> I used the following workaround: I configured failsafe plugin in the 
> following way
> {code:xml}
> 
>   
> 
> (...)
> maven-failsafe-plugin
> (...)
> ${my.test.props.file}
> {code}
> In 95% I call *mvn verify*, systemPropertiesFile is not found and ignored 
> -all pass
> In 5% I call *mvn verify -Dmy.test.props.file=x.props*
> The problem is in 95% I get warning about missing files. Also  configuration 
> is unnecessary complicated
> I would like drop whole connfiguration from pom.xml and use:
> In 95% *mvn verify*
> In 5% *mvn verify -Dfailsafe.systemPropertiesFile=x.props*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1378) Nice to have systemPropertiesFile configurable by user property

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431410#comment-16431410
 ] 

ASF GitHub Bot commented on SUREFIRE-1378:
--

Tibor17 commented on a change in pull request #152: [SUREFIRE-1378] Nice to 
have systemPropertiesFile configurable by user property
URL: https://github.com/apache/maven-surefire/pull/152#discussion_r180249360
 
 

 ##
 File path: 
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
 ##
 @@ -735,6 +738,16 @@ protected void addPluginSpecificChecksumItems( 
ChecksumCalculator checksum )
 checksum.add( summaryFile );
 }
 
+@Override
+public File getSystemPropertiesFile() {
+return systemPropertiesFile;
+}
+
+@Override
+public void setSystemPropertiesFile(File systemPropertiesFile) {
 
 Review comment:
   The same here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Nice to have systemPropertiesFile configurable by user property
> ---
>
> Key: SUREFIRE-1378
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1378
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Michal Domagala
>Assignee: Tibor Digana
>Priority: Minor
>
> I would like to have option to configure my tests with property files. But 
> property file is not required, because in 95% my tests work fine with default 
> configuration.
> I used the following workaround: I configured failsafe plugin in the 
> following way
> {code:xml}
> 
>   
> 
> (...)
> maven-failsafe-plugin
> (...)
> ${my.test.props.file}
> {code}
> In 95% I call *mvn verify*, systemPropertiesFile is not found and ignored 
> -all pass
> In 5% I call *mvn verify -Dmy.test.props.file=x.props*
> The problem is in 95% I get warning about missing files. Also  configuration 
> is unnecessary complicated
> I would like drop whole connfiguration from pom.xml and use:
> In 95% *mvn verify*
> In 5% *mvn verify -Dfailsafe.systemPropertiesFile=x.props*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1378) Nice to have systemPropertiesFile configurable by user property

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431407#comment-16431407
 ] 

ASF GitHub Bot commented on SUREFIRE-1378:
--

Tibor17 commented on a change in pull request #152: [SUREFIRE-1378] Nice to 
have systemPropertiesFile configurable by user property
URL: https://github.com/apache/maven-surefire/pull/152#discussion_r180249310
 
 

 ##
 File path: 
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
 ##
 @@ -735,6 +738,16 @@ protected void addPluginSpecificChecksumItems( 
ChecksumCalculator checksum )
 checksum.add( summaryFile );
 }
 
+@Override
+public File getSystemPropertiesFile() {
 
 Review comment:
   ```
   public File getSystemPropertiesFile()
   {
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Nice to have systemPropertiesFile configurable by user property
> ---
>
> Key: SUREFIRE-1378
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1378
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Michal Domagala
>Assignee: Tibor Digana
>Priority: Minor
>
> I would like to have option to configure my tests with property files. But 
> property file is not required, because in 95% my tests work fine with default 
> configuration.
> I used the following workaround: I configured failsafe plugin in the 
> following way
> {code:xml}
> 
>   
> 
> (...)
> maven-failsafe-plugin
> (...)
> ${my.test.props.file}
> {code}
> In 95% I call *mvn verify*, systemPropertiesFile is not found and ignored 
> -all pass
> In 5% I call *mvn verify -Dmy.test.props.file=x.props*
> The problem is in 95% I get warning about missing files. Also  configuration 
> is unnecessary complicated
> I would like drop whole connfiguration from pom.xml and use:
> In 95% *mvn verify*
> In 5% *mvn verify -Dfailsafe.systemPropertiesFile=x.props*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1378) Nice to have systemPropertiesFile configurable by user property

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431405#comment-16431405
 ] 

ASF GitHub Bot commented on SUREFIRE-1378:
--

Tibor17 commented on a change in pull request #152: [SUREFIRE-1378] Nice to 
have systemPropertiesFile configurable by user property
URL: https://github.com/apache/maven-surefire/pull/152#discussion_r180249225
 
 

 ##
 File path: 
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
 ##
 @@ -372,6 +372,9 @@
 @Parameter( property = "failsafe.shutdown", defaultValue = "testset" )
 private String shutdown;
 
+@Parameter( property = "failsafe.systemPropertiesFile")
 
 Review comment:
   I have added a space
   `@Parameter( property = "failsafe.systemPropertiesFile" )`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Nice to have systemPropertiesFile configurable by user property
> ---
>
> Key: SUREFIRE-1378
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1378
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Michal Domagala
>Assignee: Tibor Digana
>Priority: Minor
>
> I would like to have option to configure my tests with property files. But 
> property file is not required, because in 95% my tests work fine with default 
> configuration.
> I used the following workaround: I configured failsafe plugin in the 
> following way
> {code:xml}
> 
>   
> 
> (...)
> maven-failsafe-plugin
> (...)
> ${my.test.props.file}
> {code}
> In 95% I call *mvn verify*, systemPropertiesFile is not found and ignored 
> -all pass
> In 5% I call *mvn verify -Dmy.test.props.file=x.props*
> The problem is in 95% I get warning about missing files. Also  configuration 
> is unnecessary complicated
> I would like drop whole connfiguration from pom.xml and use:
> In 95% *mvn verify*
> In 5% *mvn verify -Dfailsafe.systemPropertiesFile=x.props*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1378) Nice to have systemPropertiesFile configurable by user property

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431197#comment-16431197
 ] 

ASF GitHub Bot commented on SUREFIRE-1378:
--

michaldo commented on issue #152: [SUREFIRE-1378] Nice to have 
systemPropertiesFile configurable by user property
URL: https://github.com/apache/maven-surefire/pull/152#issuecomment-379887960
 
 
   I updated my pull request. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Nice to have systemPropertiesFile configurable by user property
> ---
>
> Key: SUREFIRE-1378
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1378
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Michal Domagala
>Assignee: Tibor Digana
>Priority: Minor
>
> I would like to have option to configure my tests with property files. But 
> property file is not required, because in 95% my tests work fine with default 
> configuration.
> I used the following workaround: I configured failsafe plugin in the 
> following way
> {code:xml}
> 
>   
> 
> (...)
> maven-failsafe-plugin
> (...)
> ${my.test.props.file}
> {code}
> In 95% I call *mvn verify*, systemPropertiesFile is not found and ignored 
> -all pass
> In 5% I call *mvn verify -Dmy.test.props.file=x.props*
> The problem is in 95% I get warning about missing files. Also  configuration 
> is unnecessary complicated
> I would like drop whole connfiguration from pom.xml and use:
> In 95% *mvn verify*
> In 5% *mvn verify -Dfailsafe.systemPropertiesFile=x.props*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1378) Nice to have systemPropertiesFile configurable by user property

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429011#comment-16429011
 ] 

ASF GitHub Bot commented on SUREFIRE-1378:
--

Tibor17 commented on issue #152: [SUREFIRE-1378] Nice to have 
systemPropertiesFile configurable by user property
URL: https://github.com/apache/maven-surefire/pull/152#issuecomment-379379923
 
 
   @michaldo
   Can you modify you last commit to satisfy the ASF Maven conventions?
   If you run the build you will see the errors reported by checkstyle plugin.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Nice to have systemPropertiesFile configurable by user property
> ---
>
> Key: SUREFIRE-1378
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1378
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Michal Domagala
>Assignee: Tibor Digana
>Priority: Minor
>
> I would like to have option to configure my tests with property files. But 
> property file is not required, because in 95% my tests work fine with default 
> configuration.
> I used the following workaround: I configured failsafe plugin in the 
> following way
> {code:xml}
> 
>   
> 
> (...)
> maven-failsafe-plugin
> (...)
> ${my.test.props.file}
> {code}
> In 95% I call *mvn verify*, systemPropertiesFile is not found and ignored 
> -all pass
> In 5% I call *mvn verify -Dmy.test.props.file=x.props*
> The problem is in 95% I get warning about missing files. Also  configuration 
> is unnecessary complicated
> I would like drop whole connfiguration from pom.xml and use:
> In 95% *mvn verify*
> In 5% *mvn verify -Dfailsafe.systemPropertiesFile=x.props*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1378) Nice to have systemPropertiesFile configurable by user property

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429012#comment-16429012
 ] 

ASF GitHub Bot commented on SUREFIRE-1378:
--

Tibor17 commented on issue #152: [SUREFIRE-1378] Nice to have 
systemPropertiesFile configurable by user property
URL: https://github.com/apache/maven-surefire/pull/152#issuecomment-379379923
 
 
   @michaldo
   Can you modify your last commit to satisfy the ASF Maven conventions?
   If you run the build you will see the errors reported by checkstyle plugin.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Nice to have systemPropertiesFile configurable by user property
> ---
>
> Key: SUREFIRE-1378
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1378
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Michal Domagala
>Assignee: Tibor Digana
>Priority: Minor
>
> I would like to have option to configure my tests with property files. But 
> property file is not required, because in 95% my tests work fine with default 
> configuration.
> I used the following workaround: I configured failsafe plugin in the 
> following way
> {code:xml}
> 
>   
> 
> (...)
> maven-failsafe-plugin
> (...)
> ${my.test.props.file}
> {code}
> In 95% I call *mvn verify*, systemPropertiesFile is not found and ignored 
> -all pass
> In 5% I call *mvn verify -Dmy.test.props.file=x.props*
> The problem is in 95% I get warning about missing files. Also  configuration 
> is unnecessary complicated
> I would like drop whole connfiguration from pom.xml and use:
> In 95% *mvn verify*
> In 5% *mvn verify -Dfailsafe.systemPropertiesFile=x.props*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1378) Nice to have systemPropertiesFile configurable by user property

[Tibor Digana (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033730#comment-16033730
 ] 

Tibor Digana commented on SUREFIRE-1378:


System properties are simple but we have another config parameters which are 
complicated and users have different needs. So I would like to give you chance 
with all parameter with same principle of extensions in version 3.0 and not 
partially with this parameter in current version.

> Nice to have systemPropertiesFile configurable by user property
> ---
>
> Key: SUREFIRE-1378
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1378
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Michal Domagala
>Priority: Minor
>
> I would like to have option to configure my tests with property files. But 
> property file is not required, because in 95% my tests work fine with default 
> configuration.
> I used the following workaround: I configured failsafe plugin in the 
> following way
> {code:xml}
> 
>   
> 
> (...)
> maven-failsafe-plugin
> (...)
> ${my.test.props.file}
> {code}
> In 95% I call *mvn verify*, systemPropertiesFile is not found and ignored 
> -all pass
> In 5% I call *mvn verify -Dmy.test.props.file=x.props*
> The problem is in 95% I get warning about missing files. Also  configuration 
> is unnecessary complicated
> I would like drop whole connfiguration from pom.xml and use:
> In 95% *mvn verify*
> In 5% *mvn verify -Dfailsafe.systemPropertiesFile=x.props*



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SUREFIRE-1378) Nice to have systemPropertiesFile configurable by user property

[Tibor Digana (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033701#comment-16033701
 ] 

Tibor Digana commented on SUREFIRE-1378:


[~michaldo]
This is my plan with the extension
{{}}, where 
{{UsersExtensionImpl}} is your class implementing 
{{SyrefireSystemPropertiesExtension}} interface. Maybe we would create a module 
with default implementations of interfaces.

> Nice to have systemPropertiesFile configurable by user property
> ---
>
> Key: SUREFIRE-1378
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1378
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Michal Domagala
>Priority: Minor
>
> I would like to have option to configure my tests with property files. But 
> property file is not required, because in 95% my tests work fine with default 
> configuration.
> I used the following workaround: I configured failsafe plugin in the 
> following way
> {code:xml}
> 
>   
> 
> (...)
> maven-failsafe-plugin
> (...)
> ${my.test.props.file}
> {code}
> In 95% I call *mvn verify*, systemPropertiesFile is not found and ignored 
> -all pass
> In 5% I call *mvn verify -Dmy.test.props.file=x.props*
> The problem is in 95% I get warning about missing files. Also  configuration 
> is unnecessary complicated
> I would like drop whole connfiguration from pom.xml and use:
> In 95% *mvn verify*
> In 5% *mvn verify -Dfailsafe.systemPropertiesFile=x.props*



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SUREFIRE-1378) Nice to have systemPropertiesFile configurable by user property

[Michal Domagala (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032703#comment-16032703
 ] 

Michal Domagala commented on SUREFIRE-1378:
---

SUREFIRE-1365 is similar but different. My issue refers to Java system 
property, SUREFIRE-1365 to OS environment variable. 

I'm new to Java interface in pom.xml. If you give me a link to piece of 
documentation I will check if this will solve my problem. 
(But my commit solves the problem here and now)

> Nice to have systemPropertiesFile configurable by user property
> ---
>
> Key: SUREFIRE-1378
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1378
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Michal Domagala
>Priority: Minor
>
> I would like to have option to configure my tests with property files. But 
> property file is not required, because in 95% my tests work fine with default 
> configuration.
> I used the following workaround: I configured failsafe plugin in the 
> following way
> {code:xml}
> 
>   
> 
> (...)
> maven-failsafe-plugin
> (...)
> ${my.test.props.file}
> {code}
> In 95% I call *mvn verify*, systemPropertiesFile is not found and ignored 
> -all pass
> In 5% I call *mvn verify -Dmy.test.props.file=x.props*
> The problem is in 95% I get warning about missing files. Also  configuration 
> is unnecessary complicated
> I would like drop whole connfiguration from pom.xml and use:
> In 95% *mvn verify*
> In 5% *mvn verify -Dfailsafe.systemPropertiesFile=x.props*



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SUREFIRE-1378) Nice to have systemPropertiesFile configurable by user property

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032570#comment-16032570
 ] 

ASF GitHub Bot commented on SUREFIRE-1378:
--

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/152
  
@michaldo 
Version 3.0 will have configurable via Java interface in pom.xml.
This way you can turn the behavior to file system.
Please check Jira [1] with version 3.0. Maybe we already have this request.
[1]: https://issues.apache.org/jira/browse/SUREFIRE


> Nice to have systemPropertiesFile configurable by user property
> ---
>
> Key: SUREFIRE-1378
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1378
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Michal Domagala
>Priority: Minor
>
> I would like to have option to configure my tests with property files. But 
> property file is not required, because in 95% my tests work fine with default 
> configuration.
> I used the following workaround: I configured failsafe plugin in the 
> following way
> {code:xml}
> 
>   
> 
> (...)
> maven-failsafe-plugin
> (...)
> ${my.test.props.file}
> {code}
> In 95% I call *mvn verify*, systemPropertiesFile is not found and ignored 
> -all pass
> In 5% I call *mvn verify -Dmy.test.props.file=x.props*
> The problem is in 95% I get warning about missing files. Also  configuration 
> is unnecessary complicated
> I would like drop whole connfiguration from pom.xml and use:
> In 95% *mvn verify*
> In 5% *mvn verify -Dfailsafe.systemPropertiesFile=x.props*



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SUREFIRE-1378) Nice to have systemPropertiesFile configurable by user property

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031965#comment-16031965
 ] 

ASF GitHub Bot commented on SUREFIRE-1378:
--

GitHub user michaldo opened a pull request:

https://github.com/apache/maven-surefire/pull/152

[SUREFIRE-1378] Nice to have systemPropertiesFile configurable by user 
property



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaldo/maven-surefire master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-surefire/pull/152.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #152


commit 228baaa876c7ade557224b9f57f265649798cac7
Author: michal 
Date:   2017-05-31T19:52:50Z

[SUREFIRE-1378] Nice to have systemPropertiesFile configurable by user
property




> Nice to have systemPropertiesFile configurable by user property
> ---
>
> Key: SUREFIRE-1378
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1378
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Reporter: Michal Domagala
>Priority: Minor
>
> I would like to have option to configure my tests with property files. But 
> property file is not required, because in 95% my tests work fine with default 
> configuration.
> I used the following workaround: I configured failsafe plugin in the 
> following way
> {code:xml}
> 
>   
> 
> (...)
> maven-failsafe-plugin
> (...)
> ${my.test.props.file}
> {code}
> In 95% I call *mvn verify*, systemPropertiesFile is not found and ignored 
> -all pass
> In 5% I call *mvn verify -Dmy.test.props.file=x.props*
> The problem is in 95% I get warning about missing files. Also  configuration 
> is unnecessary complicated
> I would like drop whole connfiguration from pom.xml and use:
> In 95% *mvn verify*
> In 5% *mvn verify -Dfailsafe.systemPropertiesFile=x.props*



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)