[jira] [Commented] (SUREFIRE-1712) Running tests with JDK13 fails with Unsupported class file major version 57

2019-11-09 Thread Tibor Digana (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970974#comment-16970974
 ] 

Tibor Digana commented on SUREFIRE-1712:


[~khmarbaise]
We have fixed the issues without the need to upgrade the transitive dependency 
ASM, exactly as [~rfscholte] has proposed. This way the next JDK versions will 
work without any upgrade of {{plexus-java}}.

> Running tests with JDK13 fails with Unsupported class file major version 57
> ---
>
> Key: SUREFIRE-1712
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1712
> Project: Maven Surefire
>  Issue Type: Bug
>Affects Versions: 2.22.2, 3.0.0-M2, 3.0.0-M1, 3.0.0-M3
> Environment: JDK 13+
>Reporter: Karl Heinz Marbaise
>Assignee: Tibor Digana
>Priority: Blocker
> Fix For: 3.0.0-M4
>
>
> I have a example project from [so|https://github.com/khmarbaise/so58710751] 
> the following exception occurs:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test (default-test) 
> on project oot: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test failed: 
> Unsupported class file major version 57 -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test 
> (default-test) on project oot: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test failed: 
> Unsupported class file major version 57
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:567)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
> default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test failed: 
> Unsupported class file major version 57
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:148)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at 

[jira] [Commented] (SUREFIRE-1712) Running tests with JDK13 fails with Unsupported class file major version 57

2019-11-07 Thread Karl Heinz Marbaise (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969171#comment-16969171
 ] 

Karl Heinz Marbaise commented on SUREFIRE-1712:
---

Could you simply check the given project(github repository). If you just do a 
{{mvn clean test}} on this project it works in the given state.
If you simply remove the dependency to org.ow2.asm  from maven-surefire-plugin 
the project fails with the given exception which is based on the usage of jdk 
13. 
And yes this application is a modular app ...and it's not related to running 
with higher version compiled than running with it... furthermore the stacktrace 
shows exactly:
{code}
Caused by: java.lang.IllegalArgumentException: Unsupported class file major 
version 57
at org.objectweb.asm.ClassReader. (ClassReader.java:184)
at org.objectweb.asm.ClassReader. (ClassReader.java:166)
at org.objectweb.asm.ClassReader. (ClassReader.java:152)
at org.objectweb.asm.ClassReader. (ClassReader.java:273)
at 
org.apache.maven.plugin.surefire.booterclient.ModularClasspathForkConfiguration.toModuleName
 (ModularClasspathForkConfiguration.java:230)
{code}
which is trying to get the module names via ASM ...and you need higher version 
of ASM is needed cause as you see in this example it simply fails.




> Running tests with JDK13 fails with Unsupported class file major version 57
> ---
>
> Key: SUREFIRE-1712
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1712
> Project: Maven Surefire
>  Issue Type: Bug
>Affects Versions: 2.22.2, 3.0.0-M2, 3.0.0-M1, 3.0.0-M3
> Environment: JDK 13+
>Reporter: Karl Heinz Marbaise
>Priority: Blocker
>
> I have a example project from [so|https://github.com/khmarbaise/so58710751] 
> the following exception occurs:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test (default-test) 
> on project oot: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test failed: 
> Unsupported class file major version 57 -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test 
> (default-test) on project oot: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test failed: 
> Unsupported class file major version 57
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:567)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
> default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test failed: 
> Unsupported class file major version 57
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:148)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> 

[jira] [Commented] (SUREFIRE-1712) Running tests with JDK13 fails with Unsupported class file major version 57

2019-11-07 Thread Tibor Digana (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969100#comment-16969100
 ] 

Tibor Digana commented on SUREFIRE-1712:


[~khmarbaise] PYou could bing me on Slack. This is you private project? Because 
{{Unsupported class file major version 57}} is related to when some classes are 
compiled with higher version than running. I donot know what you do. Ask 
Robert, he will tell what i already asked him, that ASM here s used only for 
modular apps with JDK 8 or 7. We run the ITs with JDK 13 and JDK 14 with no 
problems.

> Running tests with JDK13 fails with Unsupported class file major version 57
> ---
>
> Key: SUREFIRE-1712
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1712
> Project: Maven Surefire
>  Issue Type: Bug
>Affects Versions: 2.22.2, 3.0.0-M2, 3.0.0-M1, 3.0.0-M3
> Environment: JDK 13+
>Reporter: Karl Heinz Marbaise
>Priority: Blocker
>
> I have a example project from [so|https://github.com/khmarbaise/so58710751] 
> the following exception occurs:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test (default-test) 
> on project oot: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test failed: 
> Unsupported class file major version 57 -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test 
> (default-test) on project oot: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test failed: 
> Unsupported class file major version 57
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:567)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
> default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test failed: 
> Unsupported class file major version 57
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:148)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>