[jira] Commented: (DOXIA-91) Update Doxia Decoration model to actually work in reactor build.
[ http://jira.codehaus.org/browse/DOXIA-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_97287 ] Jason van Zyl commented on DOXIA-91: Tests now pass and seem fine. Update Doxia Decoration model to actually work in reactor build. Key: DOXIA-91 URL: http://jira.codehaus.org/browse/DOXIA-91 Project: doxia Issue Type: Improvement Components: Decoration Model Reporter: Henning Schmiedehausen Assignee: Jason van Zyl Fix For: 1.0 Attachments: doxia-decoration-3.patch, doxia-decoration-4.patch, doxia-decoration-5.patch, doxia-decoration.patch, doxia-decoration.patch, org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest.txt This is a major patch to the decoration model to bring some sanity in the link resolution when it is used under the reactor build. It generates breadcrumbs and item links correctly in all scenarios that I have tested (the current HEAD code does not) and passes all the unit tests that are already there. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-91) Update Doxia Decoration model to actually work in reactor build.
[ http://jira.codehaus.org/browse/DOXIA-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_92311 ] Henning Schmiedehausen commented on DOXIA-91: - Ok, you got me confused. This is only possible when a PathDescriptor contains null for both the PathUrl and the relativePath. Which can only happen when the PathDescriptor has been constructed using a 'null' path. And the only place where this is possible is in PathUtils line 47 and there is an explicit null test in front of it. Can you give some pointers on what project exactly you tried to build the sites for? Or is that some non-public site? If possible, could you put a breakpoint at PathUtils::getRelativePath(String, String) and tell me what exactly goes in there. I'd guess that oldPath is null. I'll add another patch shortly which has another minor fix and I will add some explicit testing on that. Also some unit tests. Update Doxia Decoration model to actually work in reactor build. Key: DOXIA-91 URL: http://jira.codehaus.org/browse/DOXIA-91 Project: doxia Issue Type: Improvement Components: Decoration Model Reporter: Henning Schmiedehausen Fix For: 1.0 Attachments: doxia-decoration-3.patch, doxia-decoration.patch, doxia-decoration.patch, org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest.txt This is a major patch to the decoration model to bring some sanity in the link resolution when it is used under the reactor build. It generates breadcrumbs and item links correctly in all scenarios that I have tested (the current HEAD code does not) and passes all the unit tests that are already there. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-91) Update Doxia Decoration model to actually work in reactor build.
[ http://jira.codehaus.org/browse/DOXIA-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_92323 ] Henning Schmiedehausen commented on DOXIA-91: - This patch also adds a number of unit tests. Unfortunately as I can not modify the issue, I can not change the contains unit tests field. Update Doxia Decoration model to actually work in reactor build. Key: DOXIA-91 URL: http://jira.codehaus.org/browse/DOXIA-91 Project: doxia Issue Type: Improvement Components: Decoration Model Reporter: Henning Schmiedehausen Fix For: 1.0 Attachments: doxia-decoration-3.patch, doxia-decoration-4.patch, doxia-decoration.patch, doxia-decoration.patch, org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest.txt This is a major patch to the decoration model to bring some sanity in the link resolution when it is used under the reactor build. It generates breadcrumbs and item links correctly in all scenarios that I have tested (the current HEAD code does not) and passes all the unit tests that are already there. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-91) Update Doxia Decoration model to actually work in reactor build.
[
http://jira.codehaus.org/browse/DOXIA-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_87733
]
Vincent Siveton commented on DOXIA-91:
--
I got a NPE in a multi project case without any documentation.
{noformat}
java.lang.NullPointerException
at java.io.File.init(File.java:194)
at
org.apache.maven.doxia.site.decoration.inheritance.PathUtils.getRelativeFilePath(PathUtils.java:130)
at
org.apache.maven.doxia.site.decoration.inheritance.PathUtils.getRelativePath(PathUtils.java:103)
at
org.apache.maven.doxia.site.decoration.inheritance.PathUtils.convertPath(PathUtils.java:40)
at
org.apache.maven.doxia.site.decoration.inheritance.DefaultDecorationModelInheritanceAssembler.convertPath(DefaultDecorationModelInheritanceAssembler.java:338)
at
org.apache.maven.doxia.site.decoration.inheritance.DefaultDecorationModelInheritanceAssembler.resolveBannerPaths(DefaultDecorationModelInheritanceAssembler.java:150)
at
org.apache.maven.doxia.site.decoration.inheritance.DefaultDecorationModelInheritanceAssembler.resolvePaths(DefaultDecorationModelInheritanceAssembler.java:97)
at
org.apache.maven.plugins.site.AbstractSiteRenderingMojo.getDecorationModel(AbstractSiteRenderingMojo.java:555)
...
{noformat}
Update Doxia Decoration model to actually work in reactor build.
Key: DOXIA-91
URL: http://jira.codehaus.org/browse/DOXIA-91
Project: doxia
Issue Type: Improvement
Components: Decoration Model
Reporter: Henning Schmiedehausen
Fix For: 1.0
Attachments: doxia-decoration-3.patch, doxia-decoration.patch,
doxia-decoration.patch,
org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest.txt
This is a major patch to the decoration model to bring some sanity in the
link resolution when it is used under the reactor build. It generates
breadcrumbs and item links correctly in all scenarios that I have tested (the
current HEAD code does not) and passes all the unit tests that are already
there.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-91) Update Doxia Decoration model to actually work in reactor build.
[ http://jira.codehaus.org/browse/DOXIA-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_86155 ] Henning Schmiedehausen commented on DOXIA-91: - Hm, that is a forward-slash / backward-slash issue. Will look into that. Update Doxia Decoration model to actually work in reactor build. Key: DOXIA-91 URL: http://jira.codehaus.org/browse/DOXIA-91 Project: doxia Issue Type: Improvement Components: Decoration Model Reporter: Henning Schmiedehausen Fix For: 1.0 Attachments: doxia-decoration.patch, doxia-decoration.patch, org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest.txt This is a major patch to the decoration model to bring some sanity in the link resolution when it is used under the reactor build. It generates breadcrumbs and item links correctly in all scenarios that I have tested (the current HEAD code does not) and passes all the unit tests that are already there. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-91) Update Doxia Decoration model to actually work in reactor build.
[ http://jira.codehaus.org/browse/DOXIA-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_85942 ] Henning Schmiedehausen commented on DOXIA-91: - Yep, same here. Maven 2.0.4 and 2.0.5-SNAPSHOT (do we have a release yet?). Which platform did you use? I ran my tests on Linux, I don't have a built HEAD on Windows and the process of getting the jumble of maven, plexus, doxia and everything else to get built took my fastest machines two hours. I don't want to think how long my old windows notebook would take for this... If you are on Windows, I will try to run the tests for you this weekend. Can you attach the failed test report? That would help me tremendously. Update Doxia Decoration model to actually work in reactor build. Key: DOXIA-91 URL: http://jira.codehaus.org/browse/DOXIA-91 Project: doxia Issue Type: Improvement Components: Decoration Model Reporter: Henning Schmiedehausen Fix For: 1.0 Attachments: doxia-decoration.patch, doxia-decoration.patch This is a major patch to the decoration model to bring some sanity in the link resolution when it is used under the reactor build. It generates breadcrumbs and item links correctly in all scenarios that I have tested (the current HEAD code does not) and passes all the unit tests that are already there. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-91) Update Doxia Decoration model to actually work in reactor build.
[ http://jira.codehaus.org/browse/DOXIA-91?page=comments#action_85202 ] Vincent Siveton commented on DOXIA-91: -- I tried your latest patch and actual tests failed. Could you provide us test cases or review these? Tx. Another way, as you know, we change license headers. Update Doxia Decoration model to actually work in reactor build. Key: DOXIA-91 URL: http://jira.codehaus.org/browse/DOXIA-91 Project: doxia Issue Type: Improvement Components: Decoration Model Reporter: Henning Schmiedehausen Fix For: 1.0 Attachments: doxia-decoration.patch, doxia-decoration.patch This is a major patch to the decoration model to bring some sanity in the link resolution when it is used under the reactor build. It generates breadcrumbs and item links correctly in all scenarios that I have tested (the current HEAD code does not) and passes all the unit tests that are already there. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-91) Update Doxia Decoration model to actually work in reactor build.
[ http://jira.codehaus.org/browse/DOXIA-91?page=comments#action_85203 ] Vincent Siveton commented on DOXIA-91: -- I forgot to say that I tried with maven 2.0.4 and 2.0.5 Update Doxia Decoration model to actually work in reactor build. Key: DOXIA-91 URL: http://jira.codehaus.org/browse/DOXIA-91 Project: doxia Issue Type: Improvement Components: Decoration Model Reporter: Henning Schmiedehausen Fix For: 1.0 Attachments: doxia-decoration.patch, doxia-decoration.patch This is a major patch to the decoration model to bring some sanity in the link resolution when it is used under the reactor build. It generates breadcrumbs and item links correctly in all scenarios that I have tested (the current HEAD code does not) and passes all the unit tests that are already there. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
