[jira] Commented: (MJAVADOC-268) performance problem in AbstractJavadocMojo.getModulesLinks()
[ http://jira.codehaus.org/browse/MJAVADOC-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=246872#action_246872 ] Paul Nyheim commented on MJAVADOC-268: -- Ah - just noticed that it has been linked to [MJAVADOC-286|http://jira.codehaus.org/browse/MJAVADOC-286] which is still Open and Unresolved. So we could all go over there and vote for that issue. > performance problem in AbstractJavadocMojo.getModulesLinks() > > > Key: MJAVADOC-268 > URL: http://jira.codehaus.org/browse/MJAVADOC-268 > Project: Maven 2.x Javadoc Plugin > Issue Type: Bug >Affects Versions: 2.6 > Environment: Apache Maven 2.2.0 (r788681; 2009-06-26 15:04:01+0200) > Java version: 1.6.0_13 > Java home: /home/mkleint/javatools/jdk1.6.0_13/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux" version: "2.6.29.6-desktop-2mnb" arch: "i386" Family: "unix" >Reporter: Milos Kleint >Assignee: Vincent Siveton >Priority: Critical > Fix For: 2.6.1 > > Attachments: javadoc.patch > > > The getModulesLinks() method is unacceptably slow under certain conditions: > 1. project's url is defined > 2. one or more projects in reactor do not have any java sources and are not > of "pom" packaging. > For such projects the apidocs/ output folder is never created resulting in > repeated invokation of a forked javadoc goal. It's more severe with high > number of modules in reactor and high number of modules without any java > sources. > as an example checkout "hg clone https://hg.kenai.com/hg/forceten~src"; > The immediate problem is in the apidocsFile.exists() condition that > re-triggers the forked invokation. The attached patch fixes that. However it > looks suspicitions that the method is being called repeatedly for each module > at all. Maybe the aborting condition at the start of the method body is wrong > (I was not able to decypher that) > workaround is to use 2.5 or not to specify the url in pom.xml or set the > detectOfflineLinks parameter to "false". -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJAVADOC-268) performance problem in AbstractJavadocMojo.getModulesLinks()
[ http://jira.codehaus.org/browse/MJAVADOC-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=246866#action_246866 ] Julio Argüello Fernández commented on MJAVADOC-268: --- I agree, I think this issue should be reopened. It's indeed an important thing. Hoping to find a solution, thank you very much! > performance problem in AbstractJavadocMojo.getModulesLinks() > > > Key: MJAVADOC-268 > URL: http://jira.codehaus.org/browse/MJAVADOC-268 > Project: Maven 2.x Javadoc Plugin > Issue Type: Bug >Affects Versions: 2.6 > Environment: Apache Maven 2.2.0 (r788681; 2009-06-26 15:04:01+0200) > Java version: 1.6.0_13 > Java home: /home/mkleint/javatools/jdk1.6.0_13/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux" version: "2.6.29.6-desktop-2mnb" arch: "i386" Family: "unix" >Reporter: Milos Kleint >Assignee: Vincent Siveton >Priority: Critical > Fix For: 2.6.1 > > Attachments: javadoc.patch > > > The getModulesLinks() method is unacceptably slow under certain conditions: > 1. project's url is defined > 2. one or more projects in reactor do not have any java sources and are not > of "pom" packaging. > For such projects the apidocs/ output folder is never created resulting in > repeated invokation of a forked javadoc goal. It's more severe with high > number of modules in reactor and high number of modules without any java > sources. > as an example checkout "hg clone https://hg.kenai.com/hg/forceten~src"; > The immediate problem is in the apidocsFile.exists() condition that > re-triggers the forked invokation. The attached patch fixes that. However it > looks suspicitions that the method is being called repeatedly for each module > at all. Maybe the aborting condition at the start of the method body is wrong > (I was not able to decypher that) > workaround is to use 2.5 or not to specify the url in pom.xml or set the > detectOfflineLinks parameter to "false". -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJAVADOC-268) performance problem in AbstractJavadocMojo.getModulesLinks()
[ http://jira.codehaus.org/browse/MJAVADOC-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=237387#action_237387 ] Paul Nyheim commented on MJAVADOC-268: -- I can confirm this is NOT fixed for 2.7. Is it possible to reopen this Issue, or do we need to resubmit a new one? > performance problem in AbstractJavadocMojo.getModulesLinks() > > > Key: MJAVADOC-268 > URL: http://jira.codehaus.org/browse/MJAVADOC-268 > Project: Maven 2.x Javadoc Plugin > Issue Type: Bug >Affects Versions: 2.6 > Environment: Apache Maven 2.2.0 (r788681; 2009-06-26 15:04:01+0200) > Java version: 1.6.0_13 > Java home: /home/mkleint/javatools/jdk1.6.0_13/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux" version: "2.6.29.6-desktop-2mnb" arch: "i386" Family: "unix" >Reporter: Milos Kleint >Assignee: Vincent Siveton >Priority: Critical > Fix For: 2.6.1 > > Attachments: javadoc.patch > > > The getModulesLinks() method is unacceptably slow under certain conditions: > 1. project's url is defined > 2. one or more projects in reactor do not have any java sources and are not > of "pom" packaging. > For such projects the apidocs/ output folder is never created resulting in > repeated invokation of a forked javadoc goal. It's more severe with high > number of modules in reactor and high number of modules without any java > sources. > as an example checkout "hg clone https://hg.kenai.com/hg/forceten~src"; > The immediate problem is in the apidocsFile.exists() condition that > re-triggers the forked invokation. The attached patch fixes that. However it > looks suspicitions that the method is being called repeatedly for each module > at all. Maybe the aborting condition at the start of the method body is wrong > (I was not able to decypher that) > workaround is to use 2.5 or not to specify the url in pom.xml or set the > detectOfflineLinks parameter to "false". -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJAVADOC-268) performance problem in AbstractJavadocMojo.getModulesLinks()
[ http://jira.codehaus.org/browse/MJAVADOC-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=228721#action_228721 ] Erik Brakkee commented on MJAVADOC-268: --- I can also confirm it still exists in version 2.7. Reverting back to 2.5 solves the problem, however with only drawback which is that there is no multi-module javadoc available for the overall site. At least my site generation time reduces now from 45 minutes to about 7. > performance problem in AbstractJavadocMojo.getModulesLinks() > > > Key: MJAVADOC-268 > URL: http://jira.codehaus.org/browse/MJAVADOC-268 > Project: Maven 2.x Javadoc Plugin > Issue Type: Bug >Affects Versions: 2.6 > Environment: Apache Maven 2.2.0 (r788681; 2009-06-26 15:04:01+0200) > Java version: 1.6.0_13 > Java home: /home/mkleint/javatools/jdk1.6.0_13/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux" version: "2.6.29.6-desktop-2mnb" arch: "i386" Family: "unix" >Reporter: Milos Kleint >Assignee: Vincent Siveton >Priority: Critical > Fix For: 2.6.1 > > Attachments: javadoc.patch > > > The getModulesLinks() method is unacceptably slow under certain conditions: > 1. project's url is defined > 2. one or more projects in reactor do not have any java sources and are not > of "pom" packaging. > For such projects the apidocs/ output folder is never created resulting in > repeated invokation of a forked javadoc goal. It's more severe with high > number of modules in reactor and high number of modules without any java > sources. > as an example checkout "hg clone https://hg.kenai.com/hg/forceten~src"; > The immediate problem is in the apidocsFile.exists() condition that > re-triggers the forked invokation. The attached patch fixes that. However it > looks suspicitions that the method is being called repeatedly for each module > at all. Maybe the aborting condition at the start of the method body is wrong > (I was not able to decypher that) > workaround is to use 2.5 or not to specify the url in pom.xml or set the > detectOfflineLinks parameter to "false". -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJAVADOC-268) performance problem in AbstractJavadocMojo.getModulesLinks()
[ http://jira.codehaus.org/browse/MJAVADOC-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=227733#action_227733 ] Parag Mehta commented on MJAVADOC-268: -- The issue still exists in 2.7 and does not seem to be fixed. When running in a reactor, this problem causes maven to infinitely recurse. 2.5 seems to work ok though. > performance problem in AbstractJavadocMojo.getModulesLinks() > > > Key: MJAVADOC-268 > URL: http://jira.codehaus.org/browse/MJAVADOC-268 > Project: Maven 2.x Javadoc Plugin > Issue Type: Bug >Affects Versions: 2.6 > Environment: Apache Maven 2.2.0 (r788681; 2009-06-26 15:04:01+0200) > Java version: 1.6.0_13 > Java home: /home/mkleint/javatools/jdk1.6.0_13/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux" version: "2.6.29.6-desktop-2mnb" arch: "i386" Family: "unix" >Reporter: Milos Kleint >Assignee: Vincent Siveton >Priority: Critical > Fix For: 2.6.1 > > Attachments: javadoc.patch > > > The getModulesLinks() method is unacceptably slow under certain conditions: > 1. project's url is defined > 2. one or more projects in reactor do not have any java sources and are not > of "pom" packaging. > For such projects the apidocs/ output folder is never created resulting in > repeated invokation of a forked javadoc goal. It's more severe with high > number of modules in reactor and high number of modules without any java > sources. > as an example checkout "hg clone https://hg.kenai.com/hg/forceten~src"; > The immediate problem is in the apidocsFile.exists() condition that > re-triggers the forked invokation. The attached patch fixes that. However it > looks suspicitions that the method is being called repeatedly for each module > at all. Maybe the aborting condition at the start of the method body is wrong > (I was not able to decypher that) > workaround is to use 2.5 or not to specify the url in pom.xml or set the > detectOfflineLinks parameter to "false". -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJAVADOC-268) performance problem in AbstractJavadocMojo.getModulesLinks()
[ http://jira.codehaus.org/browse/MJAVADOC-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=209574#action_209574 ] David MARTIN commented on MJAVADOC-268: --- Are you sure it's really fixed ? Version 2.6 lets appear some messages like 'goal [...] has not be previously called for the project ...', but version 2.6.1 doesn't work at all with multi-module release (through maven release plugin). > performance problem in AbstractJavadocMojo.getModulesLinks() > > > Key: MJAVADOC-268 > URL: http://jira.codehaus.org/browse/MJAVADOC-268 > Project: Maven 2.x Javadoc Plugin > Issue Type: Bug >Affects Versions: 2.6 > Environment: Apache Maven 2.2.0 (r788681; 2009-06-26 15:04:01+0200) > Java version: 1.6.0_13 > Java home: /home/mkleint/javatools/jdk1.6.0_13/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux" version: "2.6.29.6-desktop-2mnb" arch: "i386" Family: "unix" >Reporter: Milos Kleint >Assignee: Vincent Siveton >Priority: Critical > Fix For: 2.6.1 > > Attachments: javadoc.patch > > > The getModulesLinks() method is unacceptably slow under certain conditions: > 1. project's url is defined > 2. one or more projects in reactor do not have any java sources and are not > of "pom" packaging. > For such projects the apidocs/ output folder is never created resulting in > repeated invokation of a forked javadoc goal. It's more severe with high > number of modules in reactor and high number of modules without any java > sources. > as an example checkout "hg clone https://hg.kenai.com/hg/forceten~src"; > The immediate problem is in the apidocsFile.exists() condition that > re-triggers the forked invokation. The attached patch fixes that. However it > looks suspicitions that the method is being called repeatedly for each module > at all. Maybe the aborting condition at the start of the method body is wrong > (I was not able to decypher that) > workaround is to use 2.5 or not to specify the url in pom.xml or set the > detectOfflineLinks parameter to "false". -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJAVADOC-268) performance problem in AbstractJavadocMojo.getModulesLinks()
[ http://jira.codehaus.org/browse/MJAVADOC-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=20#action_20 ] Francis De Brabandere commented on MJAVADOC-268: I seem to still have this problem with 2.6.1 > performance problem in AbstractJavadocMojo.getModulesLinks() > > > Key: MJAVADOC-268 > URL: http://jira.codehaus.org/browse/MJAVADOC-268 > Project: Maven 2.x Javadoc Plugin > Issue Type: Bug >Affects Versions: 2.6 > Environment: Apache Maven 2.2.0 (r788681; 2009-06-26 15:04:01+0200) > Java version: 1.6.0_13 > Java home: /home/mkleint/javatools/jdk1.6.0_13/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux" version: "2.6.29.6-desktop-2mnb" arch: "i386" Family: "unix" >Reporter: Milos Kleint >Assignee: Vincent Siveton >Priority: Critical > Fix For: 2.6.1 > > Attachments: javadoc.patch > > > The getModulesLinks() method is unacceptably slow under certain conditions: > 1. project's url is defined > 2. one or more projects in reactor do not have any java sources and are not > of "pom" packaging. > For such projects the apidocs/ output folder is never created resulting in > repeated invokation of a forked javadoc goal. It's more severe with high > number of modules in reactor and high number of modules without any java > sources. > as an example checkout "hg clone https://hg.kenai.com/hg/forceten~src"; > The immediate problem is in the apidocsFile.exists() condition that > re-triggers the forked invokation. The attached patch fixes that. However it > looks suspicitions that the method is being called repeatedly for each module > at all. Maybe the aborting condition at the start of the method body is wrong > (I was not able to decypher that) > workaround is to use 2.5 or not to specify the url in pom.xml or set the > detectOfflineLinks parameter to "false". -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJAVADOC-268) performance problem in AbstractJavadocMojo.getModulesLinks()
[ http://jira.codehaus.org/browse/MJAVADOC-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=194532#action_194532 ] Fabrizio Giudici commented on MJAVADOC-268: --- I'm the author of forceten - please use "hg up -C 65db9b4e5077" to get a version with the 2.6, as I'm temporarily reverting the project to use 2.5. > performance problem in AbstractJavadocMojo.getModulesLinks() > > > Key: MJAVADOC-268 > URL: http://jira.codehaus.org/browse/MJAVADOC-268 > Project: Maven 2.x Javadoc Plugin > Issue Type: Bug >Affects Versions: 2.6 > Environment: Apache Maven 2.2.0 (r788681; 2009-06-26 15:04:01+0200) > Java version: 1.6.0_13 > Java home: /home/mkleint/javatools/jdk1.6.0_13/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux" version: "2.6.29.6-desktop-2mnb" arch: "i386" Family: "unix" >Reporter: Milos Kleint >Priority: Critical > Attachments: javadoc.patch > > > The getModulesLinks() method is unacceptably slow under certain conditions: > 1. project's url is defined > 2. one or more projects in reactor do not have any java sources and are not > of "pom" packaging. > For such projects the apidocs/ output folder is never created resulting in > repeated invokation of a forked javadoc goal. It's more severe with high > number of modules in reactor and high number of modules without any java > sources. > as an example checkout "hg clone https://hg.kenai.com/hg/forceten~src"; > The immediate problem is in the apidocsFile.exists() condition that > re-triggers the forked invokation. The attached patch fixes that. However it > looks suspicitions that the method is being called repeatedly for each module > at all. Maybe the aborting condition at the start of the method body is wrong > (I was not able to decypher that) > workaround is to use 2.5 or not to specify the url in pom.xml or set the > detectOfflineLinks parameter to "false". -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJAVADOC-268) performance problem in AbstractJavadocMojo.getModulesLinks()
[ http://jira.codehaus.org/browse/MJAVADOC-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=194530#action_194530 ] Milos Kleint commented on MJAVADOC-268: --- originally reported at http://forums.netbeans.org/topic18558.html > performance problem in AbstractJavadocMojo.getModulesLinks() > > > Key: MJAVADOC-268 > URL: http://jira.codehaus.org/browse/MJAVADOC-268 > Project: Maven 2.x Javadoc Plugin > Issue Type: Bug >Affects Versions: 2.6 > Environment: Apache Maven 2.2.0 (r788681; 2009-06-26 15:04:01+0200) > Java version: 1.6.0_13 > Java home: /home/mkleint/javatools/jdk1.6.0_13/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux" version: "2.6.29.6-desktop-2mnb" arch: "i386" Family: "unix" >Reporter: Milos Kleint >Priority: Critical > Attachments: javadoc.patch > > > The getModulesLinks() method is unacceptably slow under certain conditions: > 1. project's url is defined > 2. one or more projects in reactor do not have any java sources and are not > of "pom" packaging. > For such projects the apidocs/ output folder is never created resulting in > repeated invokation of a forked javadoc goal. It's more severe with high > number of modules in reactor and high number of modules without any java > sources. > as an example checkout "hg clone https://hg.kenai.com/hg/forceten~src"; > The immediate problem is in the apidocsFile.exists() condition that > re-triggers the forked invokation. The attached patch fixes that. However it > looks suspicitions that the method is being called repeatedly for each module > at all. Maybe the aborting condition at the start of the method body is wrong > (I was not able to decypher that) > workaround is to use 2.5 or not to specify the url in pom.xml or set the > detectOfflineLinks parameter to "false". -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira