[jira] Commented: (MREACTOR-11) Can't pass a parameter with a comma to -Dmake.goals

2009-08-19 Thread Henri Tremblay (JIRA)

[ 
http://jira.codehaus.org/browse/MREACTOR-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=187636#action_187636
 ] 

Henri Tremblay commented on MREACTOR-11:


Historically, it wasn't possible to have two -P in the command line. 

I just tried with maven 2.1.0 and it now seems to work. 

If that's the case, indeed there's a nice workaround to my issue.

> Can't pass a parameter with a comma to -Dmake.goals
> ---
>
> Key: MREACTOR-11
> URL: http://jira.codehaus.org/browse/MREACTOR-11
> Project: Maven 2.x Reactor Plugin
>  Issue Type: Improvement
>Affects Versions: 1.0
>Reporter: Henri Tremblay
> Attachments: comma.patch
>
>
> If tried to do
> {{mvn reactor:make -Dmake.goals=install,-Pprofile1,profile2}}
> If fails because {{-Pprofile1,profile2}} is split in two parameters.
> My solution was to be able to escape a comma by doubling it. 
> Its implementation and the test case are in attachment.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Commented: (MREACTOR-11) Can't pass a parameter with a comma to -Dmake.goals

2009-08-19 Thread Damian Carrillo (JIRA)

[ 
http://jira.codehaus.org/browse/MREACTOR-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=187634#action_187634
 ] 

Damian Carrillo commented on MREACTOR-11:
-

I think that the patch might be overkill if the gist of the problem is to 
include those two build profiles in the builds spawned by the reactor.  Instead 
of issuing the command as you have done, try using the following:

$ mvn reactor:make -Dmake.goals="install -Pprofile1 -Pprofile2"

You can even pass any combination of command line parameters this way, ie:

$ mvn reactor:make -Dmake.goals="install -Pprofile1 -Pprofile2 
-Dmaven.test.skip=true"

> Can't pass a parameter with a comma to -Dmake.goals
> ---
>
> Key: MREACTOR-11
> URL: http://jira.codehaus.org/browse/MREACTOR-11
> Project: Maven 2.x Reactor Plugin
>  Issue Type: Improvement
>Affects Versions: 1.0
>Reporter: Henri Tremblay
> Attachments: comma.patch
>
>
> If tried to do
> {{mvn reactor:make -Dmake.goals=install,-Pprofile1,profile2}}
> If fails because {{-Pprofile1,profile2}} is split in two parameters.
> My solution was to be able to escape a comma by doubling it. 
> Its implementation and the test case are in attachment.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Commented: (MREACTOR-11) Can't pass a parameter with a comma to -Dmake.goals

2009-01-20 Thread Milos Kleint (JIRA)

[ 
http://jira.codehaus.org/browse/MREACTOR-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=161706#action_161706
 ] 

Milos Kleint commented on MREACTOR-11:
--

the invoker component seems to have special setters for profiles and 
properties. I'm wondering if we shall have special parameters for those in the 
reactor:make mojo as well..

> Can't pass a parameter with a comma to -Dmake.goals
> ---
>
> Key: MREACTOR-11
> URL: http://jira.codehaus.org/browse/MREACTOR-11
> Project: Maven 2.x Reactor Plugin
>  Issue Type: Improvement
>Affects Versions: 1.0
>Reporter: Henri Tremblay
> Attachments: comma.patch
>
>
> If tried to do
> {{mvn reactor:make -Dmake.goals=install,-Pprofile1,profile2}}
> If fails because {{-Pprofile1,profile2}} is split in two parameters.
> My solution was to be able to escape a comma by doubling it. 
> Its implementation and the test case are in attachment.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira