[jira] Commented: (WAGON-297) Wagon SCM does not automatically create missing directories during deployment
[ http://jira.codehaus.org/browse/WAGON-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=248620#action_248620 ] luke w patterson commented on WAGON-297: mvn-svn-wagon is the way to go: http://code.google.com/p/maven-svn-wagon/ Wagon SCM does not automatically create missing directories during deployment - Key: WAGON-297 URL: http://jira.codehaus.org/browse/WAGON-297 Project: Maven Wagon Issue Type: Bug Components: wagon-scm Affects Versions: 1.0-beta-6 Reporter: Maria Odea Ching Attachments: WAGON-297.patch, WAGON-297.patch -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WAGON-297) Wagon SCM does not automatically create missing directories during deployment
[ http://jira.codehaus.org/browse/WAGON-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=225314#action_225314 ] Maria Odea Ching commented on WAGON-297: Hi Brett, I checked the SCM API code and currently there's no implementation for the mkdir command. I'll file a separate issue for that in Maven SCM jira and add an implementation of that command so we can use it for wagon SCM. Wagon SCM does not automatically create missing directories during deployment - Key: WAGON-297 URL: http://jira.codehaus.org/browse/WAGON-297 Project: Maven Wagon Issue Type: Bug Components: wagon-scm Affects Versions: 1.0-beta-6 Reporter: Maria Odea Ching Attachments: WAGON-297.patch -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WAGON-297) Wagon SCM does not automatically create missing directories during deployment
[ http://jira.codehaus.org/browse/WAGON-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=209414#action_209414 ] Brett Porter commented on WAGON-297: I don't think it's appropriate to checkout again from the higher directory level that you indicated in point 2. This might result in checking out a lot of content that isn't needed just to create the directory. Can the directories be created remotely using the URL in this scenario? (I'm thinking of Subversion, but I think the SCM API provides the abstraction that others can implement too). Let me know when it's updated, I'd be happy to take another look. Wagon SCM does not automatically create missing directories during deployment - Key: WAGON-297 URL: http://jira.codehaus.org/browse/WAGON-297 Project: Maven Wagon Issue Type: Bug Components: wagon-scm Affects Versions: 1.0-beta-6 Reporter: Maria Odea Ching Attachments: WAGON-297.patch -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WAGON-297) Wagon SCM does not automatically create missing directories during deployment
[
http://jira.codehaus.org/browse/WAGON-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=208796#action_208796
]
Maria Odea Ching commented on WAGON-297:
{quote}
* the multiple levels of try/catch is a bit scary
{quote}
I'll see what else I can do about this.
{quote}
* the checkOut call that fails with a TransferFailedException seems to be
called identically after calculating the missing directories. Am I misreading
it?
{quote}
Yes, it's being called again but this time using the base scm url (where the
missing directories will be added). The TransferFailedException is the one
thrown when the checkout fails because of the missing directory.
{quote}
* it might be nice to have a block comment that explains what happens (are the
directories added in the local checkout, created, remotely, etc? Is it checking
out a new base directory higher up to create the directories?)
{quote}
Ok, I'll add a block comment for what it does.
{quote}
* also, you want to make sure you don't start creating directories within the
original supplied URL - wagon doesn't do that, only create those that it tries
to put within that.
{quote}
That's what the patch does.. it only creates the missing directories where it
tried to deploy.
For example: the deployment site url is
http://svn.example.com/repos/myproject/www/docs/${project.version} whereas
docs/${project.version} does not exist yet, with this patch, what will be
created will be starting from the docs directory. Is this what you meant?
{quote}
Separately - is the test case one that is valid across all the providers? Maybe
it can be pushed up to the abstract class?
{quote}
I'll see if I can move this up to the abstract class as I just based it on the
existing test case for ScmSvnExeWagonTest.
Wagon SCM does not automatically create missing directories during deployment
-
Key: WAGON-297
URL: http://jira.codehaus.org/browse/WAGON-297
Project: Maven Wagon
Issue Type: Bug
Components: wagon-scm
Affects Versions: 1.0-beta-6
Reporter: Maria Odea Ching
Attachments: WAGON-297.patch
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WAGON-297) Wagon SCM does not automatically create missing directories during deployment
[ http://jira.codehaus.org/browse/WAGON-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=208759#action_208759 ] Brett Porter commented on WAGON-297: I'm a bit confused by it. - the multiple levels of try/catch is a bit scary - the checkOut call that fails with a TransferFailedException seems to be called identically after calculating the missing directories. Am I misreading it? - it might be nice to have a block comment that explains what happens (are the directories added in the local checkout, created, remotely, etc? Is it checking out a new base directory higher up to create the directories?) - also, you want to make sure you don't start creating directories within the original supplied URL - wagon doesn't do that, only create those that it tries to put within that. Separately - is the test case one that is valid across all the providers? Maybe it can be pushed up to the abstract class? Wagon SCM does not automatically create missing directories during deployment - Key: WAGON-297 URL: http://jira.codehaus.org/browse/WAGON-297 Project: Maven Wagon Issue Type: Bug Components: wagon-scm Affects Versions: 1.0-beta-6 Reporter: Maria Odea Ching Attachments: WAGON-297.patch -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
