[jira] Updated: (MDEP-225) Dependency plugin seems to unpack archive even, if it is already unpacked
[ http://jira.codehaus.org/browse/MDEP-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Fox updated MDEP-225: --- Fix Version/s: 2.2 Dependency plugin seems to unpack archive even, if it is already unpacked - Key: MDEP-225 URL: http://jira.codehaus.org/browse/MDEP-225 Project: Maven 2.x Dependency Plugin Issue Type: Bug Components: unpack Affects Versions: 2.1 Reporter: Jason Chaffee Assignee: Brian Fox Fix For: 2.2 Attachments: MDEP-225-plh.patch, MDEP-225-plh2.patch, MDEP-225.patch, MDEP-225.patch The plugin used to be smart about not unpacking archives if it found the archive was already unpacked (maybe I was doing something different than..not sure). However, now it unpacks the archive every time, no matter what I try to keep it from doing it, including using overwriteIfNewer. I would like to be able to run the build once to extract the archive, then not have it extracted again, unless I clean the target directory because the archive takes several minutes to unpack. Here are the steps. 1) configure unpack in pom 2) run mvn clean install -- expect unpacking 3) run mvn install -- do not expect unpacking as it is still unpaced from step (2) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MDEP-225) Dependency plugin seems to unpack archive even, if it is already unpacked
[ http://jira.codehaus.org/browse/MDEP-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phillip Hellewell updated MDEP-225: --- Attachment: MDEP-225-plh.patch Here is a patch that not only fixes this bug, but addresses the issue that the marker timestamp should reflect the timestamp of the artifact unpacked (so overwriteIfNewer will always work correctly). (You'll notice I had to slightly alter one of the unit tests, but only because it wants to modify a snapshot timestamp to be newer than the marker, and in order to do that now you of course have to modify its timestamp after creating the marker.) Dependency plugin seems to unpack archive even, if it is already unpacked - Key: MDEP-225 URL: http://jira.codehaus.org/browse/MDEP-225 Project: Maven 2.x Dependency Plugin Issue Type: Bug Components: unpack Affects Versions: 2.1 Reporter: Jason Chaffee Assignee: Brian Fox Attachments: MDEP-225-plh.patch, MDEP-225.patch, MDEP-225.patch The plugin used to be smart about not unpacking archives if it found the archive was already unpacked (maybe I was doing something different than..not sure). However, now it unpacks the archive every time, no matter what I try to keep it from doing it, including using overwriteIfNewer. I would like to be able to run the build once to extract the archive, then not have it extracted again, unless I clean the target directory because the archive takes several minutes to unpack. Here are the steps. 1) configure unpack in pom 2) run mvn clean install -- expect unpacking 3) run mvn install -- do not expect unpacking as it is still unpaced from step (2) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MDEP-225) Dependency plugin seems to unpack archive even, if it is already unpacked
[ http://jira.codehaus.org/browse/MDEP-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phillip Hellewell updated MDEP-225: --- Attachment: MDEP-225-plh2.patch My 2nd patch includes a unit test for this bug that passes with my patch. Please apply this patch, or let me know what should be changed before it can be applied. Thanks. Dependency plugin seems to unpack archive even, if it is already unpacked - Key: MDEP-225 URL: http://jira.codehaus.org/browse/MDEP-225 Project: Maven 2.x Dependency Plugin Issue Type: Bug Components: unpack Affects Versions: 2.1 Reporter: Jason Chaffee Assignee: Brian Fox Attachments: MDEP-225-plh.patch, MDEP-225-plh2.patch, MDEP-225.patch, MDEP-225.patch The plugin used to be smart about not unpacking archives if it found the archive was already unpacked (maybe I was doing something different than..not sure). However, now it unpacks the archive every time, no matter what I try to keep it from doing it, including using overwriteIfNewer. I would like to be able to run the build once to extract the archive, then not have it extracted again, unless I clean the target directory because the archive takes several minutes to unpack. Here are the steps. 1) configure unpack in pom 2) run mvn clean install -- expect unpacking 3) run mvn install -- do not expect unpacking as it is still unpaced from step (2) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MDEP-225) Dependency plugin seems to unpack archive even, if it is already unpacked
[ http://jira.codehaus.org/browse/MDEP-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruediger Dreier updated MDEP-225: - Attachment: MDEP-225.patch I detected that the SourcesFileMarkerHandler uses the same logic. I also added tests for setMarker functions in DefaultFileMarkerHandler and SourcesFileMarkerHandler. I hope they are sufficient. If not can you please give me a hint how a sufficient test should look like? I tried to simulate the command line calls mentioned earlier but failed due to the complexity of programmatic Maven usage:-( Dependency plugin seems to unpack archive even, if it is already unpacked - Key: MDEP-225 URL: http://jira.codehaus.org/browse/MDEP-225 Project: Maven 2.x Dependency Plugin Issue Type: Bug Components: unpack Affects Versions: 2.1 Reporter: Jason Chaffee Assignee: Brian Fox Attachments: MDEP-225.patch, MDEP-225.patch The plugin used to be smart about not unpacking archives if it found the archive was already unpacked (maybe I was doing something different than..not sure). However, now it unpacks the archive every time, no matter what I try to keep it from doing it, including using overwriteIfNewer. I would like to be able to run the build once to extract the archive, then not have it extracted again, unless I clean the target directory because the archive takes several minutes to unpack. Here are the steps. 1) configure unpack in pom 2) run mvn clean install -- expect unpacking 3) run mvn install -- do not expect unpacking as it is still unpaced from step (2) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MDEP-225) Dependency plugin seems to unpack archive even, if it is already unpacked
[ http://jira.codehaus.org/browse/MDEP-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruediger Dreier updated MDEP-225: - Attachment: MDEP-225.patch Patch to update marker file timestap after unpack Dependency plugin seems to unpack archive even, if it is already unpacked - Key: MDEP-225 URL: http://jira.codehaus.org/browse/MDEP-225 Project: Maven 2.x Dependency Plugin Issue Type: Bug Components: unpack Affects Versions: 2.1 Reporter: Jason Chaffee Assignee: Brian Fox Attachments: MDEP-225.patch The plugin used to be smart about not unpacking archives if it found the archive was already unpacked (maybe I was doing something different than..not sure). However, now it unpacks the archive every time, no matter what I try to keep it from doing it, including using overwriteIfNewer. I would like to be able to run the build once to extract the archive, then not have it extracted again, unless I clean the target directory because the archive takes several minutes to unpack. Here are the steps. 1) configure unpack in pom 2) run mvn clean install -- expect unpacking 3) run mvn install -- do not expect unpacking as it is still unpaced from step (2) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
