Re: [PR] [MWRAPPER-128] Drop legacy stuff [maven-wrapper]
cstamas commented on code in PR #126:
URL: https://github.com/apache/maven-wrapper/pull/126#discussion_r1567798406
##
maven-wrapper-plugin/pom.xml:
##
@@ -34,7 +34,7 @@ under the License.
The Maven Wrapper Plugin is a plugin that provides support for
the Maven Wrapper by unpacking Maven Wrapper Distribution to the current
project.
-${mavenVersion}
+3.2.5
Review Comment:
```suggestion
3.6.3
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MWRAPPER-128] Drop legacy stuff [maven-wrapper]
slawekjaranowski commented on code in PR #126:
URL: https://github.com/apache/maven-wrapper/pull/126#discussion_r1567790469
##
maven-wrapper-plugin/pom.xml:
##
@@ -34,7 +34,7 @@ under the License.
The Maven Wrapper Plugin is a plugin that provides support for
the Maven Wrapper by unpacking Maven Wrapper Distribution to the current
project.
-${mavenVersion}
+3.2.5
Review Comment:
but we should be consequential and put here 3.6.3 as we do in more of
plugins now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MWRAPPER-128] Drop legacy stuff [maven-wrapper]
cstamas commented on code in PR #126:
URL: https://github.com/apache/maven-wrapper/pull/126#discussion_r1567790763
##
maven-wrapper-plugin/pom.xml:
##
@@ -34,7 +34,7 @@ under the License.
The Maven Wrapper Plugin is a plugin that provides support for
the Maven Wrapper by unpacking Maven Wrapper Distribution to the current
project.
-${mavenVersion}
+3.2.5
Review Comment:
Yeah, but _all plugin builds_ use at least two Maven version: 3.9.6 and ...
usually 3.6.3. So what "issue in runtime" you expect? Okay, if test coverage is
poor... but then we fix and improve coverage, and life goes on...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MWRAPPER-128] Drop legacy stuff [maven-wrapper]
slawekjaranowski commented on code in PR #126:
URL: https://github.com/apache/maven-wrapper/pull/126#discussion_r1567788687
##
maven-wrapper-plugin/pom.xml:
##
@@ -34,7 +34,7 @@ under the License.
The Maven Wrapper Plugin is a plugin that provides support for
the Maven Wrapper by unpacking Maven Wrapper Distribution to the current
project.
-${mavenVersion}
+3.2.5
Review Comment:
I'm still not sure about it ... when we depend on newer version we can have
some issues in runtime which is not cover by ITs.
But from other side we have more information about depractions ...
The perfect way will be for me depends on the same version as in in
prerequisites ... but we block using plugin for older Maven
So we need a compromise on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MWRAPPER-128] Drop legacy stuff [maven-wrapper]
cstamas commented on code in PR #126:
URL: https://github.com/apache/maven-wrapper/pull/126#discussion_r1567780642
##
maven-wrapper-plugin/pom.xml:
##
@@ -34,7 +34,7 @@ under the License.
The Maven Wrapper Plugin is a plugin that provides support for
the Maven Wrapper by unpacking Maven Wrapper Distribution to the current
project.
-${mavenVersion}
+3.2.5
Review Comment:
Yeah, I did not want to change prerequisite, it was more to kill this
antipattern to "compile against eons old" that prevents noticing what is being
deprecated lately in APIs and Core... (and replaced eon old aether w/
maven-resolver)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MWRAPPER-128] Drop legacy stuff [maven-wrapper]
cstamas commented on code in PR #126:
URL: https://github.com/apache/maven-wrapper/pull/126#discussion_r1567780642
##
maven-wrapper-plugin/pom.xml:
##
@@ -34,7 +34,7 @@ under the License.
The Maven Wrapper Plugin is a plugin that provides support for
the Maven Wrapper by unpacking Maven Wrapper Distribution to the current
project.
-${mavenVersion}
+3.2.5
Review Comment:
Yeah, I did not want to change prerequisite, it was more to kill this
antipattern to "compile against eons old" maven that prevents noticing what is
being deprecated lately in APIs and Core... (and replaced eon old aether w/
maven-resolver)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MWRAPPER-128] Drop legacy stuff [maven-wrapper]
jorsol commented on code in PR #126:
URL: https://github.com/apache/maven-wrapper/pull/126#discussion_r1567426951
##
maven-wrapper-plugin/pom.xml:
##
@@ -34,7 +34,7 @@ under the License.
The Maven Wrapper Plugin is a plugin that provides support for
the Maven Wrapper by unpacking Maven Wrapper Distribution to the current
project.
-${mavenVersion}
+3.2.5
Review Comment:
Why not 3.6.3? this PR is about dropping legacy stuff ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
