[jira] [Created] (MASSEMBLY-903) Allow defining descriptors within pom.xml
Wojtek created MASSEMBLY-903: Summary: Allow defining descriptors within pom.xml Key: MASSEMBLY-903 URL: https://issues.apache.org/jira/browse/MASSEMBLY-903 Project: Maven Assembly Plugin Issue Type: Improvement Affects Versions: 3.1.1 Reporter: Wojtek It would be very handy it it were possible to define actual assembly description *within* pom.xml file, this would allow defining descriptors in the parent pom.xml and inherit it across the project with ease. To that end, facilitating `merge` inheritance would be a huge bonus. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-2751) Resource inheritance isn't additive
[ https://issues.apache.org/jira/browse/MNG-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737274#comment-16737274 ] Wojtek commented on MNG-2751: - Just to give it a nudge - I just run into this issue. Most of the time configuration is merged (or it's possibility to specify inheritance policy: merge/replace/etc). Happens in: `Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T15:41:47-03:00)` > Resource inheritance isn't additive > --- > > Key: MNG-2751 > URL: https://issues.apache.org/jira/browse/MNG-2751 > Project: Maven > Issue Type: Bug > Components: Inheritance and Interpolation >Affects Versions: 2.0.4 > Environment: All >Reporter: Jason Melnick >Priority: Major > > I have an inheritance model as such: > Parent_POM (General dependencyManagement, pluginManagement, etc) > |-->Base_POM (global dependency inclusion, default goal, default plugins, etc) > |-->Artifact_POM (declares specific artifact type functionality, > resources, profiles, etc) > |-->Project_POM (project specific dependencies, resources, etc) > I am attempting to create an hierarchy that will enable a new project to get > up and running with very little modification. The issue I am having is if > build.resources are declared in the Project_POM they are wiping the > Artifact_POM's declarations. > I think that resources should always be additive. If nothing else add an > tag a la the plugin element's tag. In lieu of that > perhaps a resourceManagement section that exposes resource id's that could be > selectively added by the child... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-903) Allow defining descriptors within pom.xml
[ https://issues.apache.org/jira/browse/MASSEMBLY-903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733534#comment-16733534 ] Wojtek commented on MASSEMBLY-903: -- Maybe a bit (in our case it's already bloated with various asciidoc configuration, which I trimmed 75% due to finally migrating to parent pom). I was considering above but couldn't make it work with parent pom (type=pom) – most likely because it's type and doesn't contain actual descriptor. Why put that in pom? Because the shared descriptor would be short (very short 2 directories so in total about 10-15 lines) and it's more convenient to maintain single project with master/parent project instead of doing that and in addition maintain additional project just to define descriptor. > Allow defining descriptors within pom.xml > - > > Key: MASSEMBLY-903 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-903 > Project: Maven Assembly Plugin > Issue Type: Improvement >Affects Versions: 3.1.1 >Reporter: Wojtek >Priority: Minor > Fix For: waiting-for-feedback > > > It would be very handy it it were possible to define actual assembly > description *within* pom.xml file, this would allow defining descriptors in > the parent pom.xml and inherit it across the project with ease. To that end, > facilitating `merge` inheritance would be a huge bonus. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (MASSEMBLY-903) Allow defining descriptors within pom.xml
[ https://issues.apache.org/jira/browse/MASSEMBLY-903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733534#comment-16733534 ] Wojtek edited comment on MASSEMBLY-903 at 1/3/19 10:28 PM: --- Maybe a bit (in our case it's already bloated with various asciidoc configuration, which I trimmed 75% due to finally migrating to parent pom). I was considering above but couldn't make it work with parent pom (type=pom) – most likely because it's type and doesn't contain actual descriptor. Why put that in pom? Because the shared descriptor would be short (very short 2 directories so in total about 10-15 lines) and it's more convenient to maintain single project with master/parent project instead of doing that and in addition maintain additional project just to define descriptor. Currently we handle this with defined (way less than ideal) but it somewhat works, however one of our projects has quite heavy resources which pointlessly bloats resulting .jar, hence the idea to move this configuration to assembly and simply inherit it. was (Author: .wojtek): Maybe a bit (in our case it's already bloated with various asciidoc configuration, which I trimmed 75% due to finally migrating to parent pom). I was considering above but couldn't make it work with parent pom (type=pom) – most likely because it's type and doesn't contain actual descriptor. Why put that in pom? Because the shared descriptor would be short (very short 2 directories so in total about 10-15 lines) and it's more convenient to maintain single project with master/parent project instead of doing that and in addition maintain additional project just to define descriptor. > Allow defining descriptors within pom.xml > - > > Key: MASSEMBLY-903 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-903 > Project: Maven Assembly Plugin > Issue Type: Improvement >Affects Versions: 3.1.1 >Reporter: Wojtek >Priority: Minor > Fix For: waiting-for-feedback > > > It would be very handy it it were possible to define actual assembly > description *within* pom.xml file, this would allow defining descriptors in > the parent pom.xml and inherit it across the project with ease. To that end, > facilitating `merge` inheritance would be a huge bonus. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MRESOLVER-324) Make the BF algorithm as the default option to speed up maven dependency resolution and downloading
[
https://issues.apache.org/jira/browse/MRESOLVER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693373#comment-17693373
]
Wojtek commented on MRESOLVER-324:
--
Can this option be enabled globally and not on per-project (via `maven.config`)
only?
> Make the BF algorithm as the default option to speed up maven dependency
> resolution and downloading
> ---
>
> Key: MRESOLVER-324
> URL: https://issues.apache.org/jira/browse/MRESOLVER-324
> Project: Maven Resolver
> Issue Type: Wish
> Components: Resolver
>Affects Versions: 1.10.0
>Reporter: wei cai
>Priority: Major
> Fix For: 1.10.0
>
>
> This is a WISH type Jira :D. So far, Maven 3.9.0 has released a BF algorithm
> which includes changes from below JIRAs along with the DF option (default).
> * MRESOLVER-228
> * MRESOLVER-247
> * MRESOLVER-7
> The BF algorithm solves:
> * Cache missing issue when comes to resolve heavy dependencies with
> different exclusions, it can help speed up dependency resolution especially
> for large scale enterprise level projects.
> * Improve download speed by:
> ** Skip downloading poms for conflict losers.
> ** Download poms in parallel.
> Below is the introduction in
> [https://maven.apache.org/docs/3.9.0/release-notes.html:]
> {noformat}
> Choice of resolver collectors: a new BF collector (with parallel POM
> downloads) has been added along the existing DF one.{noformat}
> The solution is already widely adopted at eBay. You can simply enable it by
> putting below config item into file: ${maven.projectBasedir}/.mvn/maven.config
> {code:java}
> aether.dependencyCollector.impl=bf {code}
> More introduction about this option:
> [https://maven.apache.org/resolver/configuration.html]
> Please try and tells us how much it helps by running:
> {code:java}
> 1. mvn clean install -DskipTests -Dmaven.repo.local=bf
> -Daether.dependencyCollector.impl=bf
> 2. mvn clean install -DskipTests -Dmaven.repo.local=df{code}
> With more feedback collected, we would be able to propose the changes to
> Maven team to make BF as the default.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-992) Facility to define assembly descriptor in body of POM
[
https://issues.apache.org/jira/browse/MASSEMBLY-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789681#comment-17789681
]
Wojtek commented on MASSEMBLY-992:
--
I concur that allowing inlining configuration of assembly descriptor would be
the most straightforward (and simplest to manage and maintain) giving a couple
of handy options (like defining type of inheritance). In the dup issue
(massembly-903) it was mentioned that the con to this would be making "pom file
bloated" but truth be told - they already can be quite bloated
> Facility to define assembly descriptor in body of POM
> -
>
> Key: MASSEMBLY-992
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-992
> Project: Maven Assembly Plugin
> Issue Type: New Feature
>Reporter: Garret Wilson
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> The Maven Assembly Plugin allows custom descriptors to be defined, but only
> in an external file. Please add the capability to define the descriptor in
> the body of the POM itself.
> Requiring a separate descriptor file makes it almost impossible to declare an
> assembly in a parent POM so that it can be inherited by child POMs. The
> documentation describe a way to [share
> descriptors|https://maven.apache.org/plugins/maven-assembly-plugin/examples/sharing-descriptors.html],
> but it is complex and doesn't obviously support Maven property interpolation.
> Without this facility, in order to easily inherit an assembly from a parent
> POM, I'm currently resorting to workaround involving AntRun to generate an
> assembly descriptor on the fly. See [this
> {{pom.xml}}|https://github.com/globalmentor/globalmentor-root/blob/main/pom.xml].
> It's pretty convoluted and tedious to get right. In addition, it has to be
> placed in a phase that is guaranteed to run before the execution of the Maven
> Assembly Plugin itself.
> {code:xml}
>
> org.apache.maven.plugins
> maven-antrun-plugin
>
>
>
> generate-bin-assembly-descriptor
> prepare-package
>
> run
>
>
> ${_isSkipGenerateExe}
>
> encoding="UTF-8">
>
>
>
>
>
>
>
> {code}
> This was requested and finally implemented for Versions Maven Plugin; see
> [#258|https://github.com/mojohaus/versions/issues/258] and
> [#684|https://github.com/mojohaus/versions/issues/684], along with [_Versions
> Maven Plugin rules that are
> inheritable_|https://stackoverflow.com/q/72416739] on Stack Overflow.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
