[jira] [Commented] (MESOS-1742) Remove Using Directives
[ https://issues.apache.org/jira/browse/MESOS-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113730#comment-14113730 ] Renan DelValle commented on MESOS-1742: --- I think it's important to stick to the coding standards the project set for itself. So even if not much is to be gained compilation speed-wise, it is still worth doing. Remove Using Directives --- Key: MESOS-1742 URL: https://issues.apache.org/jira/browse/MESOS-1742 Project: Mesos Issue Type: Story Components: build Reporter: Jessica Hartog Labels: build We tell developers to follow the Google C++ Style Guide (http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml) which says, Do not use a using-directive. At the moment 134 files in src/ do not conform to this practice. $ grep -r -l using namespace src | wc -l 134 Using directives increase compile time by requiring a larger lookup space for unqualified ids. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (MESOS-750) Require compilers that support c++11
[ https://issues.apache.org/jira/browse/MESOS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113982#comment-14113982 ] Patrick Reilly edited comment on MESOS-750 at 8/28/14 5:12 PM: --- (+1) for [~dhamon] suggestion. I really like the notion of having a simple suite of configure tests that exercise the C++11 features we actually care about. With this approach we can die early if they're trying to compile on a unsupported platform. We could also give them some process guidance on various platforms; for ways to fix the issue, (e.g., recommend devtoolset on CentOS, etc). was (Author: preillyme): +1 for [~dhamon] suggestion. I really like the notion of having a simple suite of configure tests that exercise the C++11 features we actually care about. With this approach we can die early if they're trying to compile on a unsupported platform. We could also give them some process guidance on various platforms; for ways to fix the issue, (e.g., recommend devtoolset on CentOS, etc). Require compilers that support c++11 Key: MESOS-750 URL: https://issues.apache.org/jira/browse/MESOS-750 Project: Mesos Issue Type: Improvement Components: technical debt Reporter: Benjamin Mahler Requiring C++11 support will provide substantial benefits to Mesos. Most notably, the lack of lambda support has resulted in a proliferation of continuation style functions scattered throughout the code. Having lambdas will allow us to reduce this clutter and simplify the code. This will require carefully documenting how to get Mesos compiling on various systems to make this transition easy. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-750) Require compilers that support c++11
[ https://issues.apache.org/jira/browse/MESOS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113982#comment-14113982 ] Patrick Reilly commented on MESOS-750: -- +1 for [~dhamon] suggestion. I really like the notion of having a simple suite of configure tests that exercise the C++11 features we actually care about. With this approach we can die early if they're trying to compile on a unsupported platform. We could also give them some process guidance on various platforms; for ways to fix the issue, (e.g., recommend devtoolset on CentOS, etc). Require compilers that support c++11 Key: MESOS-750 URL: https://issues.apache.org/jira/browse/MESOS-750 Project: Mesos Issue Type: Improvement Components: technical debt Reporter: Benjamin Mahler Requiring C++11 support will provide substantial benefits to Mesos. Most notably, the lack of lambda support has resulted in a proliferation of continuation style functions scattered throughout the code. Having lambdas will allow us to reduce this clutter and simplify the code. This will require carefully documenting how to get Mesos compiling on various systems to make this transition easy. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-1742) Remove Using Directives
[ https://issues.apache.org/jira/browse/MESOS-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114057#comment-14114057 ] Cody Maloney commented on MESOS-1742: - I definitely agree on that point. The coding standard should either be updated or things should be brought inline over time. There are arguments about of code which utilizes using statements to grab entire namespaces (bits of libprocess and stout don't use a lot of namespaces though, and there seems to be a tendency to hand-prefix things like local functions to make them not collide, rather than using the 'static' keyword in cc files and dropping things in namespaces in headers). Remove Using Directives --- Key: MESOS-1742 URL: https://issues.apache.org/jira/browse/MESOS-1742 Project: Mesos Issue Type: Story Components: build Reporter: Jessica Hartog Labels: build We tell developers to follow the Google C++ Style Guide (http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml) which says, Do not use a using-directive. At the moment 134 files in src/ do not conform to this practice. $ grep -r -l using namespace src | wc -l 134 Using directives increase compile time by requiring a larger lookup space for unqualified ids. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-1739) Add Dynamic Slave Attributes
[ https://issues.apache.org/jira/browse/MESOS-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114078#comment-14114078 ] Cody Maloney commented on MESOS-1739: - One thing to think about here though is things like the negative resource checks are already broken in a modern working environment, in that a host can have resources / attributes added to it at runtime which will invalidate it's currently running state (Get hooked up to a private network, add another storage sled, etc). If people are encouraged to write manual tasks which run on a host to evaluate it's appropriateness for a task, we can very easily invalidate things they checked for. I think one of the better options here would be to move to a API / setup so that people can't do negative tests, or if they do we have them encoded within the request so we can properly test deltas. The negative requests can still be invalidated by changes to the host, but perhaps resources on a host can be managed such that old launched things don't see the newly added resources / they aren't made available to the running executors/containers? Add Dynamic Slave Attributes Key: MESOS-1739 URL: https://issues.apache.org/jira/browse/MESOS-1739 Project: Mesos Issue Type: Improvement Reporter: Patrick Reilly Assignee: Patrick Reilly Make it so that either via a slave restart or a out of process reconfigure ping, the attributes and resources of a slave can be updated to be a superset of what they used to be. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-1742) Remove Using Directives
[ https://issues.apache.org/jira/browse/MESOS-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114085#comment-14114085 ] Dominic Hamon commented on MESOS-1742: -- from the same document: You may use a using-declaration anywhere in a .cc file, and in functions, methods or classes in .h files Remove Using Directives --- Key: MESOS-1742 URL: https://issues.apache.org/jira/browse/MESOS-1742 Project: Mesos Issue Type: Story Components: build Reporter: Jessica Hartog Labels: build We tell developers to follow the Google C++ Style Guide (http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml) which says, Do not use a using-directive. At the moment 134 files in src/ do not conform to this practice. $ grep -r -l using namespace src | wc -l 134 Using directives increase compile time by requiring a larger lookup space for unqualified ids. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-1571) Signal escalation timeout is not configurable
[ https://issues.apache.org/jira/browse/MESOS-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114119#comment-14114119 ] Till Toenshoff commented on MESOS-1571: --- [~nnielsen] Aye! Signal escalation timeout is not configurable - Key: MESOS-1571 URL: https://issues.apache.org/jira/browse/MESOS-1571 Project: Mesos Issue Type: Bug Reporter: Niklas Quarfot Nielsen Assignee: Alexander Rukletsov Even though the executor shutdown grace period is set to a larger interval, the signal escalation timeout will still be 3 seconds. It should either be configurable or dependent on EXECUTOR_SHUTDOWN_GRACE_PERIOD. Thoughts? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-1742) Remove Using Directives
[ https://issues.apache.org/jira/browse/MESOS-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114259#comment-14114259 ] Dominic Hamon commented on MESOS-1742: -- in the google c++ style guide http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Namespaces#Namespaces under Decision - Named Namespaces. Remove Using Directives --- Key: MESOS-1742 URL: https://issues.apache.org/jira/browse/MESOS-1742 Project: Mesos Issue Type: Story Components: build Reporter: Jessica Hartog Labels: build We tell developers to follow the Google C++ Style Guide (http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml) which says, Do not use a using-directive. At the moment 134 files in src/ do not conform to this practice. $ grep -r -l using namespace src | wc -l 134 Using directives increase compile time by requiring a larger lookup space for unqualified ids. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-750) Require compilers that support c++11
[ https://issues.apache.org/jira/browse/MESOS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114289#comment-14114289 ] Dominic Hamon commented on MESOS-750: - Checking our existing c++11 test, it checks the following features: * static_assert * right angle brackets * decltype * rvalue references * auto it doesn't check variadic templates but this seems like it should build on g+\+-4.4. As such, i think it is worth assuming C++11 by default and making this check fatal. We can add variadic templates next. Require compilers that support c++11 Key: MESOS-750 URL: https://issues.apache.org/jira/browse/MESOS-750 Project: Mesos Issue Type: Improvement Components: technical debt Reporter: Benjamin Mahler Requiring C++11 support will provide substantial benefits to Mesos. Most notably, the lack of lambda support has resulted in a proliferation of continuation style functions scattered throughout the code. Having lambdas will allow us to reduce this clutter and simplify the code. This will require carefully documenting how to get Mesos compiling on various systems to make this transition easy. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (MESOS-1743) mesos build looks for MAVEN_HOME
Henning Schmiedehausen created MESOS-1743: - Summary: mesos build looks for MAVEN_HOME Key: MESOS-1743 URL: https://issues.apache.org/jira/browse/MESOS-1743 Project: Mesos Issue Type: Bug Components: build Affects Versions: 0.20.0 Reporter: Henning Schmiedehausen Mesos contains in configure.ac AC_ARG_VAR([MAVEN_HOME], [looks for mvn at MAVEN_HOME/bin/mvn]) MAVEN_HOME was only used for maven 1, the current version (mvn 2 and 3) do not use this environment variable. If it is set for a maven 1 install, mesos does not build (it assumes that the mvn binary is available from this path, which it generally is not). The Mesos build should just ensure that mvn is present on the current path or expose an option from configure to set the path to the binary manually. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (MESOS-1739) Add Dynamic Slave Attributes
[ https://issues.apache.org/jira/browse/MESOS-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone updated MESOS-1739: -- Shepherd: Vinod Kone (was: Benjamin Hindman) Spoke with BenH. I'll shepherd this since I'm thinking about ways to reconfigure FrameworkInfo and I would like to drive consistency around reconfiguration in general. Add Dynamic Slave Attributes Key: MESOS-1739 URL: https://issues.apache.org/jira/browse/MESOS-1739 Project: Mesos Issue Type: Improvement Reporter: Patrick Reilly Assignee: Patrick Reilly Make it so that either via a slave restart or a out of process reconfigure ping, the attributes and resources of a slave can be updated to be a superset of what they used to be. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-750) Require compilers that support c++11
[ https://issues.apache.org/jira/browse/MESOS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114443#comment-14114443 ] Dominic Hamon commented on MESOS-750: - I can confirm that the existing C+\+11 check works for g+\+-4.4, 4.6, and 4.8 (and clang 3.4 and 3.5, for the record). However, we do have an issue with g+\+-4.7 - see MESOS-1095. Also, I haven't checked g+\+-4.5. So if it is acceptable to develop on that subset of compilers then we can move forward with requiring C+\+11 and also have a well-defined feature set as part of the configure step. Thoughts? [~vinodkone]? Require compilers that support c++11 Key: MESOS-750 URL: https://issues.apache.org/jira/browse/MESOS-750 Project: Mesos Issue Type: Improvement Components: technical debt Reporter: Benjamin Mahler Requiring C++11 support will provide substantial benefits to Mesos. Most notably, the lack of lambda support has resulted in a proliferation of continuation style functions scattered throughout the code. Having lambdas will allow us to reduce this clutter and simplify the code. This will require carefully documenting how to get Mesos compiling on various systems to make this transition easy. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-750) Require compilers that support c++11
[ https://issues.apache.org/jira/browse/MESOS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114449#comment-14114449 ] Vinod Kone commented on MESOS-750: -- SGTM. Require compilers that support c++11 Key: MESOS-750 URL: https://issues.apache.org/jira/browse/MESOS-750 Project: Mesos Issue Type: Improvement Components: technical debt Reporter: Benjamin Mahler Requiring C++11 support will provide substantial benefits to Mesos. Most notably, the lack of lambda support has resulted in a proliferation of continuation style functions scattered throughout the code. Having lambdas will allow us to reduce this clutter and simplify the code. This will require carefully documenting how to get Mesos compiling on various systems to make this transition easy. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (MESOS-1744) Switch to using compiler intrinsics for unreachable, exit, and abort
[ https://issues.apache.org/jira/browse/MESOS-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114477#comment-14114477 ] Patrick Reilly edited comment on MESOS-1744 at 8/28/14 10:21 PM: - This is currently a work in progress, (WIP): https://reviews.apache.org/r/25167/ was (Author: preillyme): https://reviews.apache.org/r/25167/ Switch to using compiler intrinsics for unreachable, exit, and abort Key: MESOS-1744 URL: https://issues.apache.org/jira/browse/MESOS-1744 Project: Mesos Issue Type: Improvement Reporter: Patrick Reilly Assignee: Patrick Reilly Priority: Minor Use compiler intrinsics for unreachable, exit, and abort Makes the functions not need to pretend to return something while still silencing the compiler warnings. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-1744) Switch to using compiler intrinsics for unreachable, exit, and abort
[ https://issues.apache.org/jira/browse/MESOS-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114477#comment-14114477 ] Patrick Reilly commented on MESOS-1744: --- https://reviews.apache.org/r/25167/ Switch to using compiler intrinsics for unreachable, exit, and abort Key: MESOS-1744 URL: https://issues.apache.org/jira/browse/MESOS-1744 Project: Mesos Issue Type: Improvement Reporter: Patrick Reilly Assignee: Patrick Reilly Priority: Minor Use compiler intrinsics for unreachable, exit, and abort Makes the functions not need to pretend to return something while still silencing the compiler warnings. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-1739) Add Dynamic Slave Attributes
[ https://issues.apache.org/jira/browse/MESOS-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114485#comment-14114485 ] Vinod Kone commented on MESOS-1739: --- [~preillyme] Not yet. I'm still thinking about it. I'll update https://issues.apache.org/jira/browse/MESOS-1719 with ideas. Add Dynamic Slave Attributes Key: MESOS-1739 URL: https://issues.apache.org/jira/browse/MESOS-1739 Project: Mesos Issue Type: Improvement Reporter: Patrick Reilly Assignee: Patrick Reilly Make it so that either via a slave restart or a out of process reconfigure ping, the attributes and resources of a slave can be updated to be a superset of what they used to be. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (MESOS-750) Require compilers that support c++11
[ https://issues.apache.org/jira/browse/MESOS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominic Hamon reassigned MESOS-750: --- Assignee: Dominic Hamon Require compilers that support c++11 Key: MESOS-750 URL: https://issues.apache.org/jira/browse/MESOS-750 Project: Mesos Issue Type: Improvement Components: technical debt Reporter: Benjamin Mahler Assignee: Dominic Hamon Requiring C++11 support will provide substantial benefits to Mesos. Most notably, the lack of lambda support has resulted in a proliferation of continuation style functions scattered throughout the code. Having lambdas will allow us to reduce this clutter and simplify the code. This will require carefully documenting how to get Mesos compiling on various systems to make this transition easy. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-750) Require compilers that support c++11
[ https://issues.apache.org/jira/browse/MESOS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114515#comment-14114515 ] Dominic Hamon commented on MESOS-750: - https://reviews.apache.org/r/25168 https://reviews.apache.org/r/25169 Require compilers that support c++11 Key: MESOS-750 URL: https://issues.apache.org/jira/browse/MESOS-750 Project: Mesos Issue Type: Improvement Components: technical debt Reporter: Benjamin Mahler Requiring C++11 support will provide substantial benefits to Mesos. Most notably, the lack of lambda support has resulted in a proliferation of continuation style functions scattered throughout the code. Having lambdas will allow us to reduce this clutter and simplify the code. This will require carefully documenting how to get Mesos compiling on various systems to make this transition easy. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-1742) Remove Using Directives
[
https://issues.apache.org/jira/browse/MESOS-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114536#comment-14114536
]
Jessica Hartog commented on MESOS-1742:
---
Right, but the ticket is referring to using-directives, not using-declarations.
This is what the style guide says under that same heading about
using-directives:
{quote}
You may not use a using-directive to make all names from a namespace available.
{noformat}
// Forbidden -- This pollutes the namespace.
using namespace foo;
{noformat}
{quote}
Remove Using Directives
---
Key: MESOS-1742
URL: https://issues.apache.org/jira/browse/MESOS-1742
Project: Mesos
Issue Type: Story
Components: build
Reporter: Jessica Hartog
Labels: build
We tell developers to follow the Google C++ Style Guide
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml) which says,
Do not use a using-directive.
At the moment 134 files in src/ do not conform to this practice.
$ grep -r -l using namespace src | wc -l
134
Using directives increase compile time by requiring a larger lookup space for
unqualified ids.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
