[jira] [Commented] (MESOS-994) Add an Optionstring os::getenv() to stout
[ https://issues.apache.org/jira/browse/MESOS-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14546925#comment-14546925 ] Greg Mann commented on MESOS-994: - Review requests submitted. We have Ben's original patch for os::getenv(): https://reviews.apache.org/r/13978/ along with changes to callers in /src, libprocess, and stout, respectively: https://reviews.apache.org/r/34317/ https://reviews.apache.org/r/34318/ https://reviews.apache.org/r/34319/ Add an Optionstring os::getenv() to stout --- Key: MESOS-994 URL: https://issues.apache.org/jira/browse/MESOS-994 Project: Mesos Issue Type: Improvement Components: stout, technical debt Reporter: Ian Downes Assignee: Greg Mann Labels: newbie This would replace the common pattern of: Optionstring = os::hasenv() ? Optionstring(os::getenv()) : None() -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2516) Move allocation-related types to mesos::master namespace
[
https://issues.apache.org/jira/browse/MESOS-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14546918#comment-14546918
]
Timothy Chen commented on MESOS-2516:
-
If you like to work on this ticket there we should be able to find a shepherd
for this.
Move allocation-related types to mesos::master namespace
Key: MESOS-2516
URL: https://issues.apache.org/jira/browse/MESOS-2516
Project: Mesos
Issue Type: Improvement
Components: allocation
Reporter: Alexander Rukletsov
Priority: Minor
Labels: easyfix, newbie
{{Allocator}}, {{Sorter}} and {{Comaprator}} types live in
{{master::allocator}} namespace. This is not consistent with the rest of the
codebase: {{Isolator}}, {{Fetcher}}, {{Containerizer}} all live in {{slave}}
namespace. Namespace {{allocator}} should be killed for consistency.
Since sorters are poorly named, they should be renamed (or namespaced) prior
to this change in order not to pollute {{master}} namespace.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (MESOS-2612) Docker containerizer does not set MESOS_DIRECTORY
[
https://issues.apache.org/jira/browse/MESOS-2612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tom Arnfeld reassigned MESOS-2612:
--
Assignee: Tom Arnfeld
Docker containerizer does not set MESOS_DIRECTORY
-
Key: MESOS-2612
URL: https://issues.apache.org/jira/browse/MESOS-2612
Project: Mesos
Issue Type: Bug
Components: containerization, docker, slave
Affects Versions: 0.22.0
Reporter: Tom Arnfeld
Assignee: Tom Arnfeld
The {{MESOS_DIRECTORY}} environment variable can be used to get the path to
the working directory of the task/executor, aka the sandbox directory.
However, a differently named environment variable is used in the Docker
containerizer, which is inconsistent with the mesos containerizer and the
external containerizer.
The variable {{MESOS_DIRECTORY}} is actually set in the containerizer utils
and is shared code, however the call to this in the docker code seems to be
wrapped in an if()
https://github.com/apache/mesos/blob/00318fc1b30fc0961c2dfa4d934c37866577d801/src/slave/containerizer/docker.hpp#L353-L361.
I can't find any other instances of {{MESOS_SANDBOX}} except inside the
docker code.
Ping [~tnachen]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-2516) Move allocation-related types to mesos::master namespace
[
https://issues.apache.org/jira/browse/MESOS-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14546980#comment-14546980
]
Colin Williams commented on MESOS-2516:
---
Alright, well I wrote a patch and put it up on the review board, but after
merging in a couple of patches using the old namespace I thought I'd step back.
If somebody steps forward to shepherd, I'm happy to resolve any additional
problems and put it back up.
Move allocation-related types to mesos::master namespace
Key: MESOS-2516
URL: https://issues.apache.org/jira/browse/MESOS-2516
Project: Mesos
Issue Type: Improvement
Components: allocation
Reporter: Alexander Rukletsov
Priority: Minor
Labels: easyfix, newbie
{{Allocator}}, {{Sorter}} and {{Comaprator}} types live in
{{master::allocator}} namespace. This is not consistent with the rest of the
codebase: {{Isolator}}, {{Fetcher}}, {{Containerizer}} all live in {{slave}}
namespace. Namespace {{allocator}} should be killed for consistency.
Since sorters are poorly named, they should be renamed (or namespaced) prior
to this change in order not to pollute {{master}} namespace.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
