[jira] [Comment Edited] (MESOS-9228) SLRP does not clean up plugin containers after it is removed.

2018-09-20 Thread Chun-Hung Hsiao (JIRA)


[ 
https://issues.apache.org/jira/browse/MESOS-9228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620105#comment-16620105
 ] 

Chun-Hung Hsiao edited comment on MESOS-9228 at 9/20/18 11:22 PM:
--

Reviews:
https://reviews.apache.org/r/68755/
https://reviews.apache.org/r/68756/
https://reviews.apache.org/r/68757/
https://reviews.apache.org/r/68777/
https://reviews.apache.org/r/68758/
https://reviews.apache.org/r/68790/
https://reviews.apache.org/r/68762/
https://reviews.apache.org/r/68763/


was (Author: chhsia0):
Reviews:
https://reviews.apache.org/r/68755/
https://reviews.apache.org/r/68756/
https://reviews.apache.org/r/68757/
https://reviews.apache.org/r/68758/
https://reviews.apache.org/r/68759/
https://reviews.apache.org/r/68760/
https://reviews.apache.org/r/68761/
https://reviews.apache.org/r/68762/
https://reviews.apache.org/r/68763/

> SLRP does not clean up plugin containers after it is removed.
> -
>
> Key: MESOS-9228
> URL: https://issues.apache.org/jira/browse/MESOS-9228
> Project: Mesos
>  Issue Type: Bug
>  Components: storage
>Affects Versions: 1.5.0, 1.6.0, 1.7.0
>Reporter: Chun-Hung Hsiao
>Assignee: Chun-Hung Hsiao
>Priority: Blocker
>  Labels: mesosphere, storage
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MESOS-9246) Verify libarchive version at configuration time.

2018-09-20 Thread James Peach (JIRA)


[ 
https://issues.apache.org/jira/browse/MESOS-9246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622567#comment-16622567
 ] 

James Peach commented on MESOS-9246:


/cc [~andschwa]

> Verify libarchive version at configuration time.
> 
>
> Key: MESOS-9246
> URL: https://issues.apache.org/jira/browse/MESOS-9246
> Project: Mesos
>  Issue Type: Bug
>Reporter: James Peach
>Priority: Major
>
> The Mesos build system doesn't verify that {{libarchive}} is a new enough 
> version to provide all the APIs that Mesos needs. For example, on CentOS 6 
> with {{libarchive}} 2.8.3, the build will fail:
> {noformat}
> ../../3rdparty/stout/include/stout/archiver.hpp: In function 'Try 
> archiver::extract(const string&, const string&, int)':
> ../../3rdparty/stout/include/stout/archiver.hpp:55:47: error: 
> 'archive_read_support_filter_all' was not declared in this scope
>archive_read_support_filter_all(reader.get());
>^
> ../../3rdparty/stout/include/stout/archiver.hpp: In lambda function:
> ../../3rdparty/stout/include/stout/archiver.hpp:61:27: error: 
> 'archive_write_free' was not declared in this scope
>archive_write_free(p);
>^
> ../../3rdparty/stout/include/stout/archiver.hpp: In function 'Try 
> archiver::extract(const string&, const string&, int)':
> ../../3rdparty/stout/include/stout/archiver.hpp:120:70: error: 
> 'archive_entry_hardlink_utf8' was not declared in this scope
>const char* hardlink_target = archive_entry_hardlink_utf8(entry);
>   ^
> ../../3rdparty/stout/include/stout/archiver.hpp:130:68: error: 
> 'archive_entry_pathname_utf8' was not declared in this scope
>path::join(destination, 
> archive_entry_pathname_utf8(entry)).c_str());
> {noformat}
> We should verify that new APIs we need are present at configuration time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MESOS-9246) Verify libarchive version at configuration time.

2018-09-20 Thread James Peach (JIRA)
James Peach created MESOS-9246:
--

 Summary: Verify libarchive version at configuration time.
 Key: MESOS-9246
 URL: https://issues.apache.org/jira/browse/MESOS-9246
 Project: Mesos
  Issue Type: Bug
Reporter: James Peach


The Mesos build system doesn't verify that {{libarchive}} is a new enough 
version to provide all the APIs that Mesos needs. For example, on CentOS 6 with 
{{libarchive}} 2.8.3, the build will fail:

{noformat}
../../3rdparty/stout/include/stout/archiver.hpp: In function 'Try 
archiver::extract(const string&, const string&, int)':
../../3rdparty/stout/include/stout/archiver.hpp:55:47: error: 
'archive_read_support_filter_all' was not declared in this scope
   archive_read_support_filter_all(reader.get());
   ^
../../3rdparty/stout/include/stout/archiver.hpp: In lambda function:
../../3rdparty/stout/include/stout/archiver.hpp:61:27: error: 
'archive_write_free' was not declared in this scope
   archive_write_free(p);
   ^
../../3rdparty/stout/include/stout/archiver.hpp: In function 'Try 
archiver::extract(const string&, const string&, int)':
../../3rdparty/stout/include/stout/archiver.hpp:120:70: error: 
'archive_entry_hardlink_utf8' was not declared in this scope
   const char* hardlink_target = archive_entry_hardlink_utf8(entry);
  ^
../../3rdparty/stout/include/stout/archiver.hpp:130:68: error: 
'archive_entry_pathname_utf8' was not declared in this scope
   path::join(destination, archive_entry_pathname_utf8(entry)).c_str());
{noformat}

We should verify that new APIs we need are present at configuration time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MESOS-9231) `docker inspect` may return an incomplete result to Docker executor due to a race condition

2018-09-20 Thread Qian Zhang (JIRA)


[ 
https://issues.apache.org/jira/browse/MESOS-9231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622099#comment-16622099
 ] 

Qian Zhang commented on MESOS-9231:
---

I added some logs in Mesos's Docker library (`src/docker/docker.cpp`) and 
reproduced this issue again, and then I found the incomplete result returned by 
`docker inspect` is the below which indeed has no Docker container ID.
{code:java}
[
{
"Driver": "rexray",
"Labels": null,
"Mountpoint": "/",
"Name": "",
"Options": {},
"Scope": "global",
"Status": {
"availabilityZone": "",
"fields": null,
"iops": 0,
"name": "",
"server": "ebs",
"service": "ebs",
"size": 0,
"type": ""
}
}
]
{code}
And I found the Docker version in the agent host is 1.13.1 which is a little 
bit old, I suspect the newer version of Docker might not have this issue.

> `docker inspect` may return an incomplete result to Docker executor due to a 
> race condition
> ---
>
> Key: MESOS-9231
> URL: https://issues.apache.org/jira/browse/MESOS-9231
> Project: Mesos
>  Issue Type: Bug
>Affects Versions: 1.4.2, 1.5.1, 1.6.1
>Reporter: Qian Zhang
>Assignee: Qian Zhang
>Priority: Major
>
> In the Docker container (`src/docker/executor`), we call `docker inspect` 
> right after `docker run` 
> ([https://github.com/apache/mesos/blob/1.6.0/src/docker/executor.cpp#L230:L242),]
>  there is a small chance for `docker inspect` to return an incomplete result 
> which does not contain the Docker container ID, so we will see an error like 
> below:
> {code:java}
> E0830 00:09:37.303499 2428 executor.cpp:385] Failed to inspect container 
> 'mesos-eaa4f455-0a2c-47ff-bf98-8bd0ad243740': Unable to create container: 
> Unable to find Id in container
> {code}
> If that happens, Docker executor will not send `TASK_RUNNING` status update, 
> so the task will be stuck at `TASK_STARTING`.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)