[ https://issues.apache.org/jira/browse/MESOS-10045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055083#comment-17055083 ]
Greg Mann commented on MESOS-10045: ----------------------------------- Patches for master-side validation: https://reviews.apache.org/r/72216/ https://reviews.apache.org/r/72217/ > Validate task’s resources limits and the `share_cgroups` field > -------------------------------------------------------------- > > Key: MESOS-10045 > URL: https://issues.apache.org/jira/browse/MESOS-10045 > Project: Mesos > Issue Type: Task > Reporter: Qian Zhang > Assignee: Greg Mann > Priority: Major > > When launching a task, we need to validate: > # Only CPU and memory are supported as resource limits. > # Resource limit must be larger than resource request. > ** We need to be careful about the command task case, in which case we add > an allowance (0.1 CPUs and 32MB memory, see > [here|https://github.com/apache/mesos/blob/1.9.0/src/slave/slave.cpp#L6663:L6677] > for details) for the executor, so we need to validate task resource limit is > larger than task resource request + this allowance, otherwise the executor > will be launched with limits < requests. > # `TaskInfo` can only include resource limits when the relevant agent > possesses the TASK_RESOURCE_LIMITS capability. > # The value of the field `share_cgroups` should be same for all the tasks > launched by a single default executor. > # It is not allowed to set resource limits for the task which has the field > `share_cgroups` set as true. > We also need to add validation to the agent which will ensure that non-debug > 2nd-or-lower-level nested containers cannot be launched via the > {{LaunchContainer}} call. -- This message was sent by Atlassian Jira (v8.3.4#803005)