[jira] [Created] (MESOS-10105) Make tests of builds with -fsanitize=address/memory/undefined/thread pass.
Andrei Sekretenko created MESOS-10105: - Summary: Make tests of builds with -fsanitize=address/memory/undefined/thread pass. Key: MESOS-10105 URL: https://issues.apache.org/jira/browse/MESOS-10105 Project: Mesos Issue Type: Wish Reporter: Andrei Sekretenko As exemplified by various C++ projects and also by targeting specific issues in Mesos (for example, MESOS-10102), running code built with clang sanitizers helps with uncovering undefined behavior and data races. Sanitizer adoption usually happens as a sequence of steps which unblock each other: 1) making local tests pass under sanitizer at least once 2) making CI regularly run sanitizer builds (so that new sanitizable bugs are not introduced and more bugs not triggered deterministically are uncovered) 3) running high-level integration tests, betas, etc. with sanitizer builds -- (3) is definitely out of scope of this wish, and it is not clear if (2) will fit into ASF CI, but (1) is definitely doable, and on its own can lead to figuring out causes of mysterious rare bugs (which might turn out to be not so rare under certain conditions). -- State of Mesos w.r.t sanitizers: - as of Mar 2020, Mesos tests built with -fsanitize=address crash due to several locations that leak one object per thread lifetime - as of Nov 2019, libprocess tests were crashing thread sanitizer; IIRC, the issues in libprocess on Linux/amd64 are also "technical", but probably could result in a very real problems on a different platform -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (MESOS-10046) Launch executor container with resource limits
[ https://issues.apache.org/jira/browse/MESOS-10046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986931#comment-16986931 ] Qian Zhang edited comment on MESOS-10046 at 3/20/20, 9:13 AM: -- RR: [https://reviews.apache.org/r/71856/] [https://reviews.apache.org/r/71858/] was (Author: qianzhang): RR: [https://reviews.apache.org/r/71856/] > Launch executor container with resource limits > -- > > Key: MESOS-10046 > URL: https://issues.apache.org/jira/browse/MESOS-10046 > Project: Mesos > Issue Type: Task >Reporter: Qian Zhang >Assignee: Qian Zhang >Priority: Major > Fix For: 1.10.0 > > > We need to add resource limits into `ContainerConfig` first, and then set the > resources limits in it according to the executor/task resource limits when > launching executor container. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (MESOS-10064) Accommodate the "Infinity" value in JSON
[ https://issues.apache.org/jira/browse/MESOS-10064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17063209#comment-17063209 ] Qian Zhang edited comment on MESOS-10064 at 3/20/20, 9:11 AM: -- commit 0b47b43d290494fc1c6a6f6241ddfbceeb686997 Author: Qian Zhang Date: Sun Feb 23 09:53:32 2020 +0800 Added patch for RapidJSON. This commit updates the writer of RapidJSON to write infinite floating point numbers as "Infinity" and "-Infinity" (i.e., with double quotes) rather than Infinity and -Infinity. This is to ensure the strings converted from JSON objects conform to the rule defined by Protobuf: [https://developers.google.com/protocol-buffers/docs/proto3#json] Review: [https://reviews.apache.org/r/72161] commit ec82a516918ebd663816cb110f73bdee6e5268be Author: Qian Zhang Date: Sun Feb 23 10:09:48 2020 +0800 Accommodated the "Infinity" value in the JSON <-> Protobuf conversion. Review: [https://reviews.apache.org/r/72162] was (Author: qianzhang): commit 0b47b43d290494fc1c6a6f6241ddfbceeb686997 Author: Qian Zhang Date: Sun Feb 23 09:53:32 2020 +0800 Added patch for RapidJSON. This commit updates the writer of RapidJSON to write infinite floating point numbers as "Infinity" and "-Infinity" (i.e., with double quotes) rather than Infinity and -Infinity. This is to ensure the strings converted from JSON objects conform to the rule defined by Protobuf: https://developers.google.com/protocol-buffers/docs/proto3#json Review: [https://reviews.apache.org/r/72161] commit ec82a516918ebd663816cb110f73bdee6e5268be Author: Qian Zhang Date: Sun Feb 23 10:09:48 2020 +0800 Accommodated the "Infinity" value in the JSON <-> Protobuf conversion. Review: [https://reviews.apache.org/r/72162] > Accommodate the "Infinity" value in JSON > > > Key: MESOS-10064 > URL: https://issues.apache.org/jira/browse/MESOS-10064 > Project: Mesos > Issue Type: Task > Components: stout >Reporter: Qian Zhang >Assignee: Qian Zhang >Priority: Major > Fix For: 1.10.0 > > > See > [here|https://docs.google.com/document/d/1iEXn2dBg07HehbNZunJWsIY6iaFezXiRsvpNw4dVQII/edit?ts=5de78977#heading=h.ejuvxat6x3eb] > for what need to be done for this ticket. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (MESOS-10064) Accommodate the "Infinity" value in JSON
[ https://issues.apache.org/jira/browse/MESOS-10064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044015#comment-17044015 ] Qian Zhang edited comment on MESOS-10064 at 3/20/20, 9:09 AM: -- RR: [https://reviews.apache.org/r/72161/] [https://reviews.apache.org/r/72161/] was (Author: qianzhang): RR: https://reviews.apache.org/r/72161/ > Accommodate the "Infinity" value in JSON > > > Key: MESOS-10064 > URL: https://issues.apache.org/jira/browse/MESOS-10064 > Project: Mesos > Issue Type: Task > Components: stout >Reporter: Qian Zhang >Assignee: Qian Zhang >Priority: Major > > See > [here|https://docs.google.com/document/d/1iEXn2dBg07HehbNZunJWsIY6iaFezXiRsvpNw4dVQII/edit?ts=5de78977#heading=h.ejuvxat6x3eb] > for what need to be done for this ticket. -- This message was sent by Atlassian Jira (v8.3.4#803005)
