[jira] [Commented] (MESOS-4610) MasterContender/MasterDetector should be loadable as modules
[ https://issues.apache.org/jira/browse/MESOS-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220250#comment-15220250 ] ANURAG SINGH commented on MESOS-4610: - Sure. I missed a space between the colon and the trailing slash. It's fixed now. > MasterContender/MasterDetector should be loadable as modules > > > Key: MESOS-4610 > URL: https://issues.apache.org/jira/browse/MESOS-4610 > Project: Mesos > Issue Type: Improvement > Components: master >Reporter: Mark Cavage >Assignee: Mark Cavage > Labels: mesosphere > > Currently mesos depends on Zookeeper for leader election and notification to > slaves, although there is a C++ hierarchy in the code to support alternatives > (e.g., unit tests use an in-memory implementation). From an operational > perspective, many organizations/users do not want to take a dependency on > Zookeeper, and use an alternative solution to implementing leader election. > Our organization in particular, very much wants this, and as a reference > there have been several requests from the community (see referenced tickets) > to replace with etcd/consul/etc. > This ticket will serve as the work effort to modularize the > MasterContender/MasterDetector APIs such that integrators can build a > pluggable solution of their choice; this ticket will not fold in any > implementations such as etcd et al., but simply move this hierarchy to be > fully pluggable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (MESOS-4610) MasterContender/MasterDetector should be loadable as modules
[ https://issues.apache.org/jira/browse/MESOS-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197665#comment-15197665 ] ANURAG SINGH edited comment on MESOS-4610 at 3/31/16 5:16 PM: -- We've proceeded further with the review and here's the updated list of changes: https://reviews.apache.org/r/44287/ : Added MasterContender and MasterDetector abstract classes. https://reviews.apache.org/r/44288/ : Changed MasterDetector/Contender namespace. https://reviews.apache.org/r/44543/ : Removed unnecessary MasterContender and MasterDetector definitions. https://reviews.apache.org/r/44544/ : Moved contender and detector definitions into separate directories. https://reviews.apache.org/r/44545/ : Instead of keeping standalone and zookeper contender/detector class definitions and implementations in the same file, separated them. Also made the necessary changes in users of class headers to point to the new locations. https://reviews.apache.org/r/44546/ : Moved functions in promises to a common header file. https://reviews.apache.org/r/44547/ : Added functions in promises to the collect header. https://reviews.apache.org/r/44289/ : Added support for contender and detector modules. https://reviews.apache.org/r/44669/ : Added createFromModule methods to MasterContender and MasterDetector. https://reviews.apache.org/r/44670/ : Added master_detector and master_contender flags. was (Author: anurag.prakash.singh): We've proceeded further with the review and here's the updated list of changes: https://reviews.apache.org/r/44287/: Added MasterContender and MasterDetector abstract classes. https://reviews.apache.org/r/44288/: Changed MasterDetector/Contender namespace. https://reviews.apache.org/r/44543/: Removed unnecessary MasterContender and MasterDetector definitions. https://reviews.apache.org/r/44544/: Moved contender and detector definitions into separate directories. https://reviews.apache.org/r/44545/: Instead of keeping standalone and zookeper contender/detector class definitions and implementations in the same file, separated them. Also made the necessary changes in users of class headers to point to the new locations. https://reviews.apache.org/r/44546/: Moved functions in promises to a common header file. https://reviews.apache.org/r/44547/: Added functions in promises to the collect header. https://reviews.apache.org/r/44289/: Added support for contender and detector modules. https://reviews.apache.org/r/44669/: Added createFromModule methods to MasterContender and MasterDetector. https://reviews.apache.org/r/44670/: Added master_detector and master_contender flags. > MasterContender/MasterDetector should be loadable as modules > > > Key: MESOS-4610 > URL: https://issues.apache.org/jira/browse/MESOS-4610 > Project: Mesos > Issue Type: Improvement > Components: master >Reporter: Mark Cavage >Assignee: Mark Cavage > Labels: mesosphere > > Currently mesos depends on Zookeeper for leader election and notification to > slaves, although there is a C++ hierarchy in the code to support alternatives > (e.g., unit tests use an in-memory implementation). From an operational > perspective, many organizations/users do not want to take a dependency on > Zookeeper, and use an alternative solution to implementing leader election. > Our organization in particular, very much wants this, and as a reference > there have been several requests from the community (see referenced tickets) > to replace with etcd/consul/etc. > This ticket will serve as the work effort to modularize the > MasterContender/MasterDetector APIs such that integrators can build a > pluggable solution of their choice; this ticket will not fold in any > implementations such as etcd et al., but simply move this hierarchy to be > fully pluggable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (MESOS-4610) MasterContender/MasterDetector should be loadable as modules
[ https://issues.apache.org/jira/browse/MESOS-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197665#comment-15197665 ] ANURAG SINGH edited comment on MESOS-4610 at 3/28/16 3:22 PM: -- We've proceeded further with the review and here's the updated list of changes: https://reviews.apache.org/r/44287/: Added MasterContender and MasterDetector abstract classes. https://reviews.apache.org/r/44288/: Changed MasterDetector/Contender namespace. https://reviews.apache.org/r/44543/: Removed unnecessary MasterContender and MasterDetector definitions. https://reviews.apache.org/r/44544/: Moved contender and detector definitions into separate directories. https://reviews.apache.org/r/44545/: Instead of keeping standalone and zookeper contender/detector class definitions and implementations in the same file, separated them. Also made the necessary changes in users of class headers to point to the new locations. https://reviews.apache.org/r/44546/: Moved functions in promises to a common header file. https://reviews.apache.org/r/44547/: Added functions in promises to the collect header. https://reviews.apache.org/r/44289/: Added support for contender and detector modules. https://reviews.apache.org/r/44669/: Added createFromModule methods to MasterContender and MasterDetector. https://reviews.apache.org/r/44670/: Added master_detector and master_contender flags. was (Author: anurag.prakash.singh): We've proceeded further with the review and here's the updated list of changes: https://reviews.apache.org/r/44287/ https://reviews.apache.org/r/44288/ https://reviews.apache.org/r/44543/ https://reviews.apache.org/r/44544/ https://reviews.apache.org/r/44545/ https://reviews.apache.org/r/44546/ https://reviews.apache.org/r/44547/ https://reviews.apache.org/r/44289/ https://reviews.apache.org/r/44669/ https://reviews.apache.org/r/44670/ > MasterContender/MasterDetector should be loadable as modules > > > Key: MESOS-4610 > URL: https://issues.apache.org/jira/browse/MESOS-4610 > Project: Mesos > Issue Type: Improvement > Components: master >Reporter: Mark Cavage >Assignee: Mark Cavage > Labels: mesosphere > > Currently mesos depends on Zookeeper for leader election and notification to > slaves, although there is a C++ hierarchy in the code to support alternatives > (e.g., unit tests use an in-memory implementation). From an operational > perspective, many organizations/users do not want to take a dependency on > Zookeeper, and use an alternative solution to implementing leader election. > Our organization in particular, very much wants this, and as a reference > there have been several requests from the community (see referenced tickets) > to replace with etcd/consul/etc. > This ticket will serve as the work effort to modularize the > MasterContender/MasterDetector APIs such that integrators can build a > pluggable solution of their choice; this ticket will not fold in any > implementations such as etcd et al., but simply move this hierarchy to be > fully pluggable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-4610) MasterContender/MasterDetector should be loadable as modules
[ https://issues.apache.org/jira/browse/MESOS-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214316#comment-15214316 ] ANURAG SINGH commented on MESOS-4610: - Done. > MasterContender/MasterDetector should be loadable as modules > > > Key: MESOS-4610 > URL: https://issues.apache.org/jira/browse/MESOS-4610 > Project: Mesos > Issue Type: Improvement > Components: master >Reporter: Mark Cavage >Assignee: Mark Cavage > Labels: mesosphere > > Currently mesos depends on Zookeeper for leader election and notification to > slaves, although there is a C++ hierarchy in the code to support alternatives > (e.g., unit tests use an in-memory implementation). From an operational > perspective, many organizations/users do not want to take a dependency on > Zookeeper, and use an alternative solution to implementing leader election. > Our organization in particular, very much wants this, and as a reference > there have been several requests from the community (see referenced tickets) > to replace with etcd/consul/etc. > This ticket will serve as the work effort to modularize the > MasterContender/MasterDetector APIs such that integrators can build a > pluggable solution of their choice; this ticket will not fold in any > implementations such as etcd et al., but simply move this hierarchy to be > fully pluggable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-4610) MasterContender/MasterDetector should be loadable as modules
[ https://issues.apache.org/jira/browse/MESOS-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204928#comment-15204928 ] ANURAG SINGH commented on MESOS-4610: - On Joseph's suggestion, I've requested for a new shepherd to be assigned to this issue. It appears that Ben may not have the bandwidth to work on this. > MasterContender/MasterDetector should be loadable as modules > > > Key: MESOS-4610 > URL: https://issues.apache.org/jira/browse/MESOS-4610 > Project: Mesos > Issue Type: Improvement > Components: master >Reporter: Mark Cavage >Assignee: Mark Cavage > > Currently mesos depends on Zookeeper for leader election and notification to > slaves, although there is a C++ hierarchy in the code to support alternatives > (e.g., unit tests use an in-memory implementation). From an operational > perspective, many organizations/users do not want to take a dependency on > Zookeeper, and use an alternative solution to implementing leader election. > Our organization in particular, very much wants this, and as a reference > there have been several requests from the community (see referenced tickets) > to replace with etcd/consul/etc. > This ticket will serve as the work effort to modularize the > MasterContender/MasterDetector APIs such that integrators can build a > pluggable solution of their choice; this ticket will not fold in any > implementations such as etcd et al., but simply move this hierarchy to be > fully pluggable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-4610) MasterContender/MasterDetector should be loadable as modules
[ https://issues.apache.org/jira/browse/MESOS-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197665#comment-15197665 ] ANURAG SINGH commented on MESOS-4610: - We've proceeded further with the review and here's the updated list of changes: https://reviews.apache.org/r/44287/ https://reviews.apache.org/r/44288/ https://reviews.apache.org/r/44543/ https://reviews.apache.org/r/44544/ https://reviews.apache.org/r/44545/ https://reviews.apache.org/r/44546/ https://reviews.apache.org/r/44547/ https://reviews.apache.org/r/44289/ https://reviews.apache.org/r/44669/ https://reviews.apache.org/r/44670/ > MasterContender/MasterDetector should be loadable as modules > > > Key: MESOS-4610 > URL: https://issues.apache.org/jira/browse/MESOS-4610 > Project: Mesos > Issue Type: Improvement > Components: master >Reporter: Mark Cavage >Assignee: Mark Cavage > > Currently mesos depends on Zookeeper for leader election and notification to > slaves, although there is a C++ hierarchy in the code to support alternatives > (e.g., unit tests use an in-memory implementation). From an operational > perspective, many organizations/users do not want to take a dependency on > Zookeeper, and use an alternative solution to implementing leader election. > Our organization in particular, very much wants this, and as a reference > there have been several requests from the community (see referenced tickets) > to replace with etcd/consul/etc. > This ticket will serve as the work effort to modularize the > MasterContender/MasterDetector APIs such that integrators can build a > pluggable solution of their choice; this ticket will not fold in any > implementations such as etcd et al., but simply move this hierarchy to be > fully pluggable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-4610) MasterContender/MasterDetector should be loadable as modules
[ https://issues.apache.org/jira/browse/MESOS-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176526#comment-15176526 ] ANURAG SINGH commented on MESOS-4610: - Hi, I work with Mark and will be continuing this effort. I've uploaded https://reviews.apache.org/r/44287/, https://reviews.apache.org/r/44288/ and https://reviews.apache.org/r/44289/ - it's essentially Mark's patch broken up into parts per Joseph's suggestions. The one addition I've made is to add master_contender and master_detector flags to allow users to specify the contender/detector modules to use. > MasterContender/MasterDetector should be loadable as modules > > > Key: MESOS-4610 > URL: https://issues.apache.org/jira/browse/MESOS-4610 > Project: Mesos > Issue Type: Improvement > Components: master >Reporter: Mark Cavage >Assignee: Mark Cavage > > Currently mesos depends on Zookeeper for leader election and notification to > slaves, although there is a C++ hierarchy in the code to support alternatives > (e.g., unit tests use an in-memory implementation). From an operational > perspective, many organizations/users do not want to take a dependency on > Zookeeper, and use an alternative solution to implementing leader election. > Our organization in particular, very much wants this, and as a reference > there have been several requests from the community (see referenced tickets) > to replace with etcd/consul/etc. > This ticket will serve as the work effort to modularize the > MasterContender/MasterDetector APIs such that integrators can build a > pluggable solution of their choice; this ticket will not fold in any > implementations such as etcd et al., but simply move this hierarchy to be > fully pluggable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
