[jira] [Commented] (MESOS-6390) Ensure Python support scripts are linted

2017-01-31 Thread Manuwela Kanade (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848064#comment-15848064
 ] 

Manuwela Kanade commented on MESOS-6390:


Hi [~klueska]: Looks like this PR is not merged yet, 
https://reviews.apache.org/r/53074/. Should I add a dependency on this JIRA, or 
can I proceed with pull request? Thanks

> Ensure Python support scripts are linted
> 
>
> Key: MESOS-6390
> URL: https://issues.apache.org/jira/browse/MESOS-6390
> Project: Mesos
>  Issue Type: Improvement
>Reporter: Benjamin Bannier
>Assignee: Manuwela Kanade
>  Labels: newbie, python
>
> Currently {{support/mesos-style.py}} does not lint files under {{support/}}. 
> This is mostly due to the fact that these scripts are too inconsistent 
> style-wise that they wouldn't even pass the linter now.
> We should clean up all Python scripts under {{support/}} so they pass the 
> Python linter, and activate that directory in the linter for future 
> additions. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (MESOS-5662) Call parent class `SetUpTestCase` function in our test fixtures.

2016-11-13 Thread Manuwela Kanade (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MESOS-5662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manuwela Kanade updated MESOS-5662:
---
Shepherd: Anand Mazumdar

> Call parent class `SetUpTestCase` function in our test fixtures.
> 
>
> Key: MESOS-5662
> URL: https://issues.apache.org/jira/browse/MESOS-5662
> Project: Mesos
>  Issue Type: Bug
>  Components: test
>Reporter: Anand Mazumdar
>Assignee: Manuwela Kanade
>  Labels: mesosphere, newbie
>
> There are some occurrences in our code where we don't invoke the parent's 
> {{SetUpTestCase}} method from a child test fixture. This can be a bit 
> problematic if someone adds the method in the parent class sometime in the 
> future. It would be good to do a sweep across the code and explicitly invoke 
> the parent class's method.
> Some examples (there are more):
> https://github.com/apache/mesos/blob/master/src/tests/mesos.cpp#L80
> https://github.com/apache/mesos/blob/master/src/tests/module_tests.cpp#L59



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (MESOS-6390) Ensure Python support scripts are linted

2016-11-03 Thread Manuwela Kanade (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MESOS-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manuwela Kanade reassigned MESOS-6390:
--

Assignee: Manuwela Kanade

> Ensure Python support scripts are linted
> 
>
> Key: MESOS-6390
> URL: https://issues.apache.org/jira/browse/MESOS-6390
> Project: Mesos
>  Issue Type: Improvement
>Reporter: Benjamin Bannier
>Assignee: Manuwela Kanade
>  Labels: newbie, python
>
> Currently {{support/mesos-style.py}} does not lint files under {{support/}}. 
> This is mostly due to the fact that these scripts are too inconsistent 
> style-wise that they wouldn't even pass the linter now.
> We should clean up all Python scripts under {{support/}} so they pass the 
> Python linter, and activate that directory in the linter for future 
> additions. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-6390) Ensure Python support scripts are linted

2016-11-03 Thread Manuwela Kanade (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632101#comment-15632101
 ] 

Manuwela Kanade commented on MESOS-6390:


Hi [~bbannier]: I would like to work on this issue. I'll assign it to myself 
for now. Thanks

> Ensure Python support scripts are linted
> 
>
> Key: MESOS-6390
> URL: https://issues.apache.org/jira/browse/MESOS-6390
> Project: Mesos
>  Issue Type: Improvement
>Reporter: Benjamin Bannier
>  Labels: newbie, python
>
> Currently {{support/mesos-style.py}} does not lint files under {{support/}}. 
> This is mostly due to the fact that these scripts are too inconsistent 
> style-wise that they wouldn't even pass the linter now.
> We should clean up all Python scripts under {{support/}} so they pass the 
> Python linter, and activate that directory in the linter for future 
> additions. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-5662) Call parent class `SetUpTestCase` function in our test fixtures.

2016-11-01 Thread Manuwela Kanade (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-5662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627820#comment-15627820
 ] 

Manuwela Kanade commented on MESOS-5662:


Hi [~anandmazumdar]: Created a pull request for this:
https://reviews.apache.org/r/53372/

> Call parent class `SetUpTestCase` function in our test fixtures.
> 
>
> Key: MESOS-5662
> URL: https://issues.apache.org/jira/browse/MESOS-5662
> Project: Mesos
>  Issue Type: Bug
>  Components: test
>Reporter: Anand Mazumdar
>Assignee: Manuwela Kanade
>  Labels: mesosphere, newbie
>
> There are some occurrences in our code where we don't invoke the parent's 
> {{SetUpTestCase}} method from a child test fixture. This can be a bit 
> problematic if someone adds the method in the parent class sometime in the 
> future. It would be good to do a sweep across the code and explicitly invoke 
> the parent class's method.
> Some examples (there are more):
> https://github.com/apache/mesos/blob/master/src/tests/mesos.cpp#L80
> https://github.com/apache/mesos/blob/master/src/tests/module_tests.cpp#L59



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (MESOS-5662) Call parent class `SetUpTestCase` function in our test fixtures.

2016-10-25 Thread Manuwela Kanade (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MESOS-5662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manuwela Kanade reassigned MESOS-5662:
--

Assignee: Manuwela Kanade

> Call parent class `SetUpTestCase` function in our test fixtures.
> 
>
> Key: MESOS-5662
> URL: https://issues.apache.org/jira/browse/MESOS-5662
> Project: Mesos
>  Issue Type: Bug
>  Components: test
>Reporter: Anand Mazumdar
>Assignee: Manuwela Kanade
>  Labels: mesosphere, newbie
>
> There are some occurrences in our code where we don't invoke the parent's 
> {{SetUpTestCase}} method from a child test fixture. This can be a bit 
> problematic if someone adds the method in the parent class sometime in the 
> future. It would be good to do a sweep across the code and explicitly invoke 
> the parent class's method.
> Some examples (there are more):
> https://github.com/apache/mesos/blob/master/src/tests/mesos.cpp#L80
> https://github.com/apache/mesos/blob/master/src/tests/module_tests.cpp#L59



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-6458) Add test to check fromString function of stout library

2016-10-24 Thread Manuwela Kanade (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-6458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601717#comment-15601717
 ] 

Manuwela Kanade commented on MESOS-6458:


Hi [~tnachen]: Created a review request for this. Can you please review. Thanks

https://reviews.apache.org/r/53128/

> Add test to check fromString function of stout library
> --
>
> Key: MESOS-6458
> URL: https://issues.apache.org/jira/browse/MESOS-6458
> Project: Mesos
>  Issue Type: Improvement
>  Components: stout
>Affects Versions: 1.0.1
>Reporter: Manuwela Kanade
>Assignee: Manuwela Kanade
>Priority: Trivial
>
> For the 3rdparty stout library, there is a testcase for checking Malformed 
> UUID. 
> But this testcase does not have a positive test for the fromString function 
> to test if it returns correct UUID when passed a correctly formatted UUID 
> string.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (MESOS-6458) Add test to check fromString function of stout library

2016-10-24 Thread Manuwela Kanade (JIRA) 
Manuwela Kanade created MESOS-6458:
--

 Summary: Add test to check fromString function of stout library
 Key: MESOS-6458
 URL: https://issues.apache.org/jira/browse/MESOS-6458
 Project: Mesos
  Issue Type: Improvement
  Components: stout
Affects Versions: 1.0.1
Reporter: Manuwela Kanade
Assignee: Manuwela Kanade
Priority: Trivial


For the 3rdparty stout library, there is a testcase for checking Malformed 
UUID. 

But this testcase does not have a positive test for the fromString function to 
test if it returns correct UUID when passed a correctly formatted UUID string.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-6212) Validate the name format of mesos-managed docker containers

2016-10-20 Thread Manuwela Kanade (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-6212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591071#comment-15591071
 ] 

Manuwela Kanade commented on MESOS-6212:


Created review https://reviews.apache.org/r/53047/

> Validate the name format of mesos-managed docker containers
> ---
>
> Key: MESOS-6212
> URL: https://issues.apache.org/jira/browse/MESOS-6212
> Project: Mesos
>  Issue Type: Improvement
>  Components: containerization
>Affects Versions: 1.0.1
>Reporter: Marc Villacorta
>Assignee: Manuwela Kanade
>Priority: Minor
>
> Validate the name format of mesos-managed docker containers in order to avoid 
> false positives when looking for orphaned mesos tasks.
> Currently names such as _'mesos-master'_, _'mesos-agent'_ and _'mesos-dns'_ 
> are wrongly terminated when {{--docker_kill_orphans}} is set to true 
> (default).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (MESOS-6212) Validate the name format of mesos-managed docker containers

2016-10-19 Thread Manuwela Kanade (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MESOS-6212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manuwela Kanade reassigned MESOS-6212:
--

Assignee: Manuwela Kanade

> Validate the name format of mesos-managed docker containers
> ---
>
> Key: MESOS-6212
> URL: https://issues.apache.org/jira/browse/MESOS-6212
> Project: Mesos
>  Issue Type: Improvement
>  Components: containerization
>Affects Versions: 1.0.1
>Reporter: Marc Villacorta
>Assignee: Manuwela Kanade
>Priority: Minor
>
> Validate the name format of mesos-managed docker containers in order to avoid 
> false positives when looking for orphaned mesos tasks.
> Currently names such as _'mesos-master'_, _'mesos-agent'_ and _'mesos-dns'_ 
> are wrongly terminated when {{--docker_kill_orphans}} is set to true 
> (default).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)