[jira] [Updated] (MESOS-3481) Add const accessor to Master flags
[ https://issues.apache.org/jira/browse/MESOS-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhou xing updated MESOS-3481: - Assignee: Jay Guo (was: zhou xing) > Add const accessor to Master flags > -- > > Key: MESOS-3481 > URL: https://issues.apache.org/jira/browse/MESOS-3481 > Project: Mesos > Issue Type: Task >Reporter: Joseph Wu >Assignee: Jay Guo >Priority: Trivial > Labels: mesosphere, newbie > > It would make sense to have an accessor to the master's flags, especially for > tests. > For example, see [this > test|https://github.com/apache/mesos/blob/2876b8c918814347dd56f6f87d461e414a90650a/src/tests/master_maintenance_tests.cpp#L1231-L1235]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-5735) Update WebUI to use v1 operator API
[ https://issues.apache.org/jira/browse/MESOS-5735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhou xing updated MESOS-5735: - Assignee: Jay Guo (was: zhou xing) > Update WebUI to use v1 operator API > --- > > Key: MESOS-5735 > URL: https://issues.apache.org/jira/browse/MESOS-5735 > Project: Mesos > Issue Type: Bug >Reporter: Vinod Kone >Assignee: Jay Guo > > Having the WebUI use the v1 API would be a good validation of it's usefulness > and correctness. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-5798) RESERVE of Resource with 0 Value Should Fail
[ https://issues.apache.org/jira/browse/MESOS-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhou xing updated MESOS-5798: - Assignee: (was: zhou xing) > RESERVE of Resource with 0 Value Should Fail > > > Key: MESOS-5798 > URL: https://issues.apache.org/jira/browse/MESOS-5798 > Project: Mesos > Issue Type: Improvement >Reporter: Gabriel Hartmann > > Due to a bug in our code we RESERVE resources with 0 value. We also attach a > label to that Resource. Then we wait forever for a Resource with that label > to be Offered to us, but that never happens. This is a little surprising. I > think it might be more intuitive for the RESERVE to fail when a request is to > reserve 0 resources. For non Scalar values, I would expect empty Ranges or > Sets to also fail. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-5333) GET /master/maintenance/schedule/ produces 404
[ https://issues.apache.org/jira/browse/MESOS-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhou xing updated MESOS-5333: - Assignee: (was: zhou xing) > GET /master/maintenance/schedule/ produces 404 > -- > > Key: MESOS-5333 > URL: https://issues.apache.org/jira/browse/MESOS-5333 > Project: Mesos > Issue Type: Bug > Components: HTTP API, libprocess >Reporter: Nathan Handler >Priority: Minor > Labels: mesosphere > > Attempts to make a GET request to /master/maintenance/schedule/ result in a > 404. However, if I make a GET request to /master/maintenance/schedule > (without the trailing /), it works. My current (untested) theory is that this > might be related to the fact that there is also a > /master/maintenance/schedule/status endpoint (an endpoint built on top of a > functioning endpoint), as requests to /help and /help/ (with and without the > trailing slash) produce the same functioning result. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5106) Improve test_http_framework so it can load master detector from modules
[
https://issues.apache.org/jira/browse/MESOS-5106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389097#comment-15389097
]
zhou xing commented on MESOS-5106:
--
Per discussion with Kapil, the framework in the future will use HTTP interface
instead, closing this ticket. Feel free to re-open the ticket if neccessary.
> Improve test_http_framework so it can load master detector from modules
> ---
>
> Key: MESOS-5106
> URL: https://issues.apache.org/jira/browse/MESOS-5106
> Project: Mesos
> Issue Type: Task
>Reporter: Shuai Lin
>Assignee: zhou xing
>
> I'm planning to restart the work of [MESOS-1806] (etcd contender/detector)
> based on [MESOS-4610]. One thing I need to address first is when writing a
> script test, I need a framework that can use a master detector loaded from a
> module. The best way to do this seems to be adding {{\-\-modules}} and
> {{\-\-master_detector}} flags to {{test_http_framework.cpp}} so we can reuse
> it in tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (MESOS-5867) Operator ReadFile API read file bugs.
zhou xing created MESOS-5867: Summary: Operator ReadFile API read file bugs. Key: MESOS-5867 URL: https://issues.apache.org/jira/browse/MESOS-5867 Project: Mesos Issue Type: Bug Reporter: zhou xing Assignee: zhou xing Priority: Minor Contains two bugs: 1. if length provided by client is bigger than `size - offset`, the result data contains blank characters 2. if `length = 0` or successfully read data from file, API will return without closing file -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MESOS-5858) Operator API should accept the request with charset specified in Content-Type
zhou xing created MESOS-5858:
Summary: Operator API should accept the request with charset
specified in Content-Type
Key: MESOS-5858
URL: https://issues.apache.org/jira/browse/MESOS-5858
Project: Mesos
Issue Type: Bug
Reporter: zhou xing
Priority: Minor
When requesting from client like WebUI, the Content-Type of the request maybe
set to
```application/json; charset=utf-8```
, the request will get 415 response code with message
```Expecting 'Content-Type' of application/json or application/x-protobuf```
The following code in http.cpp just compare the content-type of the request
directly with “application/json” or “application/x-protobuf”:
```...
if (contentType.get() == APPLICATION_PROTOBUF) {
if (!v1Call.ParseFromString(request.body)) {
return BadRequest("Failed to parse body into Call protobuf");
}
} else if (contentType.get() == APPLICATION_JSON) {
…
We need to accept a request with charset set in Content-Type
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (MESOS-5798) RESERVE of Resource with 0 Value Should Fail
[ https://issues.apache.org/jira/browse/MESOS-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhou xing reassigned MESOS-5798: Assignee: zhou xing > RESERVE of Resource with 0 Value Should Fail > > > Key: MESOS-5798 > URL: https://issues.apache.org/jira/browse/MESOS-5798 > Project: Mesos > Issue Type: Improvement >Reporter: Gabriel Hartmann >Assignee: zhou xing > > Due to a bug in our code we RESERVE resources with 0 value. We also attach a > label to that Resource. Then we wait forever for a Resource with that label > to be Offered to us, but that never happens. This is a little surprising. I > think it might be more intuitive for the RESERVE to fail when a request is to > reserve 0 resources. For non Scalar values, I would expect empty Ranges or > Sets to also fail. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5735) Update WebUI to use v1 operator API
[
https://issues.apache.org/jira/browse/MESOS-5735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356290#comment-15356290
]
zhou xing commented on MESOS-5735:
--
[~vinodkone]
• WebUI may connect to a follower master and get /state from that master, in
the code, it will use {{state.leader == state.pid}} to judge whether it is
connecting to the leader master, if not, it will redirect.
• For {{log_dir}} and {{external_log_dir}}, I think we can also get from
GetFlags?
• If we only want to only include the mutable stuff in GetState, I think client
like WebUI can be changed to call GetVersion/GetFlags/GetMaster respectively.
Considering that WebUI is periodically calling /state endpoint, I tend to think
that keep GetState simple would be better.
> Update WebUI to use v1 operator API
> ---
>
> Key: MESOS-5735
> URL: https://issues.apache.org/jira/browse/MESOS-5735
> Project: Mesos
> Issue Type: Bug
>Reporter: Vinod Kone
>Assignee: zhou xing
>
> Having the WebUI use the v1 API would be a good validation of it's usefulness
> and correctness.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-5735) Update WebUI to use v1 operator API
[
https://issues.apache.org/jira/browse/MESOS-5735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15355322#comment-15355322
]
zhou xing commented on MESOS-5735:
--
[~vinodkone], I did a primary investigation on WebUI today, here I listed the
WebUI related http api calls:
1. call to */master/state*:
most of the pages in WebUI relies on this request to get FRAMEWORK, AGENT,
OFFER, TASK and EXECUTOR objects. Our newly proposed GetState message can
satisfy almost all the requirements from these pages, except for the following
fields:
• {{state.leader}} and {{state.pid}}: these fields are used to decide
whether current master is leading master, if not, ui will redirect
• {{clustername}}, {{version}}, {{build_time}}, {{start_time}},
{{elected_time}}: these fields will be shown on WebUI.
• {{log_dir}} && {{external_log_dir}}: these fields will be used when user
clicks the LOG link on the home page.
2. call to */slave/state*:
when browsing a single agent information on WebUI(select to open one single
Agent on Agents page), WebUI will call */slave/state* endpoint to get the
detail information of that slave, I think we still need to work out how slave's
{{GetState}} message look like. There should be differences between master's
{{GetState}} message and slave's {{GetState}} message. e.g. the executor
information returned by slave's */state* endpoint now will return three more
fields: {{queued_tasks}}, {{active_tasks}} and {{completed_tasks}}, these three
fields are not in master's executor message.
3. call to */files/browse* and */files/read*
The new two operator v1 files API should have the same functionality with the
previous http api.
4. call to */metrics/snapshot* for both master and agent
The metrics api should have same set of metrics.
5. call to slave's */monitor/statistics* endpoint
I happened to see this endpoint in current WebUI's code, but when I tried to
visit WebUI by launching master, agent and long-lived-framework, I can not see
this endpoint call in HTTP call history. Also, operator V1 API epic does not
contain a ticket for this endpoint, are we still using this API now?
> Update WebUI to use v1 operator API
> ---
>
> Key: MESOS-5735
> URL: https://issues.apache.org/jira/browse/MESOS-5735
> Project: Mesos
> Issue Type: Bug
>Reporter: Vinod Kone
>Assignee: zhou xing
>
> Having the WebUI use the v1 API would be a good validation of it's usefulness
> and correctness.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-5735) Update WebUI to use v1 operator API
[ https://issues.apache.org/jira/browse/MESOS-5735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354391#comment-15354391 ] zhou xing commented on MESOS-5735: -- Given that the response of v1 operator API is different from the previous HTTP endpoints, let me go through the endpoints that WebUI are using now, and then may change the endpoints one by one. > Update WebUI to use v1 operator API > --- > > Key: MESOS-5735 > URL: https://issues.apache.org/jira/browse/MESOS-5735 > Project: Mesos > Issue Type: Bug >Reporter: Vinod Kone >Assignee: zhou xing > > Having the WebUI use the v1 API would be a good validation of it's usefulness > and correctness. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MESOS-5735) Update WebUI to use v1 operator API
[ https://issues.apache.org/jira/browse/MESOS-5735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhou xing reassigned MESOS-5735: Assignee: zhou xing > Update WebUI to use v1 operator API > --- > > Key: MESOS-5735 > URL: https://issues.apache.org/jira/browse/MESOS-5735 > Project: Mesos > Issue Type: Bug >Reporter: Vinod Kone >Assignee: zhou xing > > Having the WebUI use the v1 API would be a good validation of it's usefulness > and correctness. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MESOS-5709) Authorization for /roles
[ https://issues.apache.org/jira/browse/MESOS-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhou xing reassigned MESOS-5709: Assignee: zhou xing > Authorization for /roles > > > Key: MESOS-5709 > URL: https://issues.apache.org/jira/browse/MESOS-5709 > Project: Mesos > Issue Type: Task > Components: security >Reporter: Adam B >Assignee: zhou xing >Priority: Minor > Labels: mesosphere, security > Fix For: 1.0.0 > > > The /roles endpoint exposes the list of all roles and their weights, as well > as the list of all frameworkIds registered with each role. This is a superset > of the information exposed on GET /weights, which we already protect. We > should protect the data in /roles the same way. > - Should we reuse VIEW_FRAMEWORK with role (from /state)? > - Should we add a new VIEW_ROLE and adapt GET_WEIGHTS to use it? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MESOS-5333) GET /master/maintenance/schedule/ produces 404
[ https://issues.apache.org/jira/browse/MESOS-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhou xing reassigned MESOS-5333: Assignee: zhou xing > GET /master/maintenance/schedule/ produces 404 > -- > > Key: MESOS-5333 > URL: https://issues.apache.org/jira/browse/MESOS-5333 > Project: Mesos > Issue Type: Bug > Components: HTTP API, libprocess >Reporter: Nathan Handler >Assignee: zhou xing >Priority: Minor > Labels: mesosphere > > Attempts to make a GET request to /master/maintenance/schedule/ result in a > 404. However, if I make a GET request to /master/maintenance/schedule > (without the trailing /), it works. My current (untested) theory is that this > might be related to the fact that there is also a > /master/maintenance/schedule/status endpoint (an endpoint built on top of a > functioning endpoint), as requests to /help and /help/ (with and without the > trailing slash) produce the same functioning result. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5491) Implement GET_AGENTS Call in v1 master API.
[ https://issues.apache.org/jira/browse/MESOS-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335541#comment-15335541 ] zhou xing commented on MESOS-5491: -- two RRs: https://reviews.apache.org/r/48841/ & https://reviews.apache.org/r/48438/ > Implement GET_AGENTS Call in v1 master API. > --- > > Key: MESOS-5491 > URL: https://issues.apache.org/jira/browse/MESOS-5491 > Project: Mesos > Issue Type: Task >Reporter: Vinod Kone >Assignee: zhou xing > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5491) Implement GET_AGENTS Call in v1 master API.
[ https://issues.apache.org/jira/browse/MESOS-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321440#comment-15321440 ] zhou xing commented on MESOS-5491: -- One review request submitted: https://reviews.apache.org/r/48438/ > Implement GET_AGENTS Call in v1 master API. > --- > > Key: MESOS-5491 > URL: https://issues.apache.org/jira/browse/MESOS-5491 > Project: Mesos > Issue Type: Task >Reporter: Vinod Kone >Assignee: zhou xing > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MESOS-5515) Implement READ_FILE Call in v1 agent API.
[ https://issues.apache.org/jira/browse/MESOS-5515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhou xing reassigned MESOS-5515: Assignee: zhou xing > Implement READ_FILE Call in v1 agent API. > - > > Key: MESOS-5515 > URL: https://issues.apache.org/jira/browse/MESOS-5515 > Project: Mesos > Issue Type: Task >Reporter: Vinod Kone >Assignee: zhou xing > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MESOS-5534) Change WebUI Pailer to not send length=-1 to get the length of file
zhou xing created MESOS-5534: Summary: Change WebUI Pailer to not send length=-1 to get the length of file Key: MESOS-5534 URL: https://issues.apache.org/jira/browse/MESOS-5534 Project: Mesos Issue Type: Bug Reporter: zhou xing Assignee: zhou xing Priority: Minor Pur discussion in RR: https://reviews.apache.org/r/46373/, now we just want to use positive number in files/read endpoint's length field, need to change pailer request from WebUI which is now still sending length = -1 in the request. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5496) Implement UPDATE_WEIGHTS Call in v1 master API.
[ https://issues.apache.org/jira/browse/MESOS-5496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15306418#comment-15306418 ] zhou xing commented on MESOS-5496: -- [~vinodkone], the old update_weights endpoint can return 3 kinds of http response: OK, Forbidden and BadRequest. For v1 API, I did not see the support of those different response code in v1::response, do we need to implement them first or can we just re-use the traditional HTTP response? > Implement UPDATE_WEIGHTS Call in v1 master API. > --- > > Key: MESOS-5496 > URL: https://issues.apache.org/jira/browse/MESOS-5496 > Project: Mesos > Issue Type: Task >Reporter: Vinod Kone >Assignee: zhou xing > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MESOS-5496) Implement UPDATE_WEIGHTS Call in v1 master API.
[ https://issues.apache.org/jira/browse/MESOS-5496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhou xing reassigned MESOS-5496: Assignee: zhou xing > Implement UPDATE_WEIGHTS Call in v1 master API. > --- > > Key: MESOS-5496 > URL: https://issues.apache.org/jira/browse/MESOS-5496 > Project: Mesos > Issue Type: Task >Reporter: Vinod Kone >Assignee: zhou xing > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MESOS-5492) Implement GET_FRAMEWORKS Call in v1 master API.
[ https://issues.apache.org/jira/browse/MESOS-5492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhou xing reassigned MESOS-5492: Assignee: zhou xing > Implement GET_FRAMEWORKS Call in v1 master API. > --- > > Key: MESOS-5492 > URL: https://issues.apache.org/jira/browse/MESOS-5492 > Project: Mesos > Issue Type: Task >Reporter: Vinod Kone >Assignee: zhou xing > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MESOS-5495) Implement GET_WEIGHTS Call in v1 master API.
[ https://issues.apache.org/jira/browse/MESOS-5495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhou xing reassigned MESOS-5495: Assignee: zhou xing > Implement GET_WEIGHTS Call in v1 master API. > > > Key: MESOS-5495 > URL: https://issues.apache.org/jira/browse/MESOS-5495 > Project: Mesos > Issue Type: Task >Reporter: Vinod Kone >Assignee: zhou xing > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MESOS-5491) Implement GET_AGENTS Call in v1 master API.
[ https://issues.apache.org/jira/browse/MESOS-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhou xing reassigned MESOS-5491: Assignee: zhou xing > Implement GET_AGENTS Call in v1 master API. > --- > > Key: MESOS-5491 > URL: https://issues.apache.org/jira/browse/MESOS-5491 > Project: Mesos > Issue Type: Task >Reporter: Vinod Kone >Assignee: zhou xing > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5390) v1 Executor Protos not included in maven jar
[
https://issues.apache.org/jira/browse/MESOS-5390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290574#comment-15290574
]
zhou xing commented on MESOS-5390:
--
Review Request submitted at: https://reviews.apache.org/r/47582/
> v1 Executor Protos not included in maven jar
>
>
> Key: MESOS-5390
> URL: https://issues.apache.org/jira/browse/MESOS-5390
> Project: Mesos
> Issue Type: Bug
> Components: HTTP API
>Affects Versions: 0.28.0, 0.28.1
>Reporter: Ben Whitehead
>Assignee: zhou xing
> Labels: mesosphere
> Fix For: 0.29.0
>
>
> According to MESOS-4793 the Executor v1 HTTP API was released in Mesos 0.28.0
> however the corresponding protos are not included in the maven jar for
> version 0.28.0 or 0.28.1.
> Script to verify
> {code}
> wget
> https://repo.maven.apache.org/maven2/org/apache/mesos/mesos/0.28.1/mesos-0.28.1.jar
> && unzip -lf mesos-0.28.1.jar | grep "v1\/executor" | wc -l
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-5060) Requesting /files/read.json with a negative length value causes subsequent /files requests to 404.
[ https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288196#comment-15288196 ] zhou xing commented on MESOS-5060: -- have updated the patch, thanks Greg for your time:) > Requesting /files/read.json with a negative length value causes subsequent > /files requests to 404. > -- > > Key: MESOS-5060 > URL: https://issues.apache.org/jira/browse/MESOS-5060 > Project: Mesos > Issue Type: Bug >Affects Versions: 0.23.0 > Environment: Mesos 0.23.0 on CentOS 6, also Mesos 0.28.0 on OSX >Reporter: Tom Petr >Assignee: zhou xing >Priority: Minor > Fix For: 0.29.0 > > > I accidentally hit a slave's /files/read.json endpoint with a negative length > (ex. http://hostname:5051/files/read.json?path=XXX=0=-100). The > HTTP request timed out after 30 seconds with nothing relevant in the slave > logs, and subsequent calls to any of the /files endpoints on that slave > immediately returned a HTTP 404 response. We ultimately got things working > again by restarting the mesos-slave process (checkpointing FTW!), but it'd be > wise to guard against negative lengths on the slave's end too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5060) Requesting /files/read.json with a negative length value causes subsequent /files requests to 404.
[ https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288151#comment-15288151 ] zhou xing commented on MESOS-5060: -- Have updated the patch, [~greggomann], please take a look > Requesting /files/read.json with a negative length value causes subsequent > /files requests to 404. > -- > > Key: MESOS-5060 > URL: https://issues.apache.org/jira/browse/MESOS-5060 > Project: Mesos > Issue Type: Bug >Affects Versions: 0.23.0 > Environment: Mesos 0.23.0 on CentOS 6, also Mesos 0.28.0 on OSX >Reporter: Tom Petr >Assignee: zhou xing >Priority: Minor > Fix For: 0.29.0 > > > I accidentally hit a slave's /files/read.json endpoint with a negative length > (ex. http://hostname:5051/files/read.json?path=XXX=0=-100). The > HTTP request timed out after 30 seconds with nothing relevant in the slave > logs, and subsequent calls to any of the /files endpoints on that slave > immediately returned a HTTP 404 response. We ultimately got things working > again by restarting the mesos-slave process (checkpointing FTW!), but it'd be > wise to guard against negative lengths on the slave's end too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5060) Requesting /files/read.json with a negative length value causes subsequent /files requests to 404.
[ https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284386#comment-15284386 ] zhou xing commented on MESOS-5060: -- [~greggomann], sorry about the late response, I'm now busy with the etcd module related stuff, but I will try to update the patch according to your suggestions ASAP, thanks > Requesting /files/read.json with a negative length value causes subsequent > /files requests to 404. > -- > > Key: MESOS-5060 > URL: https://issues.apache.org/jira/browse/MESOS-5060 > Project: Mesos > Issue Type: Bug >Affects Versions: 0.23.0 > Environment: Mesos 0.23.0 on CentOS 6, also Mesos 0.28.0 on OSX >Reporter: Tom Petr >Assignee: zhou xing >Priority: Minor > Fix For: 0.29.0 > > > I accidentally hit a slave's /files/read.json endpoint with a negative length > (ex. http://hostname:5051/files/read.json?path=XXX=0=-100). The > HTTP request timed out after 30 seconds with nothing relevant in the slave > logs, and subsequent calls to any of the /files endpoints on that slave > immediately returned a HTTP 404 response. We ultimately got things working > again by restarting the mesos-slave process (checkpointing FTW!), but it'd be > wise to guard against negative lengths on the slave's end too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5060) Requesting /files/read.json with a negative length value causes subsequent /files requests to 404.
[ https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273636#comment-15273636 ] zhou xing commented on MESOS-5060: -- [~bmahler], I have rebased the code, would you please take a look at the patch? thanks > Requesting /files/read.json with a negative length value causes subsequent > /files requests to 404. > -- > > Key: MESOS-5060 > URL: https://issues.apache.org/jira/browse/MESOS-5060 > Project: Mesos > Issue Type: Bug >Affects Versions: 0.23.0 > Environment: Mesos 0.23.0 on CentOS 6, also Mesos 0.28.0 on OSX >Reporter: Tom Petr >Assignee: zhou xing >Priority: Minor > Fix For: 0.29.0 > > > I accidentally hit a slave's /files/read.json endpoint with a negative length > (ex. http://hostname:5051/files/read.json?path=XXX=0=-100). The > HTTP request timed out after 30 seconds with nothing relevant in the slave > logs, and subsequent calls to any of the /files endpoints on that slave > immediately returned a HTTP 404 response. We ultimately got things working > again by restarting the mesos-slave process (checkpointing FTW!), but it'd be > wise to guard against negative lengths on the slave's end too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5060) Requesting /files/read.json with a negative length value causes subsequent /files requests to 404.
[ https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273634#comment-15273634 ] zhou xing commented on MESOS-5060: -- Added MESOS-5334 to further resolve the code logic issue. > Requesting /files/read.json with a negative length value causes subsequent > /files requests to 404. > -- > > Key: MESOS-5060 > URL: https://issues.apache.org/jira/browse/MESOS-5060 > Project: Mesos > Issue Type: Bug >Affects Versions: 0.23.0 > Environment: Mesos 0.23.0 on CentOS 6, also Mesos 0.28.0 on OSX >Reporter: Tom Petr >Assignee: zhou xing >Priority: Minor > Fix For: 0.29.0 > > > I accidentally hit a slave's /files/read.json endpoint with a negative length > (ex. http://hostname:5051/files/read.json?path=XXX=0=-100). The > HTTP request timed out after 30 seconds with nothing relevant in the slave > logs, and subsequent calls to any of the /files endpoints on that slave > immediately returned a HTTP 404 response. We ultimately got things working > again by restarting the mesos-slave process (checkpointing FTW!), but it'd be > wise to guard against negative lengths on the slave's end too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MESOS-5334) Rework the '/files/read.json' length and offset logic
zhou xing created MESOS-5334: Summary: Rework the '/files/read.json' length and offset logic Key: MESOS-5334 URL: https://issues.apache.org/jira/browse/MESOS-5334 Project: Mesos Issue Type: Improvement Reporter: zhou xing Assignee: zhou xing Priority: Minor At present, the code logic of parameter 'length' and 'offset' of endponit '/files/read.json' is not very clear. In the code, -1 and other negative number stands for different meanings. Please see the comments in MESOS-5060 for more details -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-3779) Slave/Agent Rename Phase I - Update terms in Web UI.
[ https://issues.apache.org/jira/browse/MESOS-3779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhou xing updated MESOS-3779: - Summary: Slave/Agent Rename Phase I - Update terms in Web UI. (was: Slave/Agent Rename Phase I - Update webui) > Slave/Agent Rename Phase I - Update terms in Web UI. > > > Key: MESOS-3779 > URL: https://issues.apache.org/jira/browse/MESOS-3779 > Project: Mesos > Issue Type: Task >Reporter: Diana Arroyo >Assignee: zhou xing > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3778) Slave/Agent Rename Phase I - Add duplicate HTTP endpoints
[ https://issues.apache.org/jira/browse/MESOS-3778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259773#comment-15259773 ] zhou xing commented on MESOS-3778: -- [~vi...@twitter.com], so do we need to close this one? or transfer the owner to you? > Slave/Agent Rename Phase I - Add duplicate HTTP endpoints > - > > Key: MESOS-3778 > URL: https://issues.apache.org/jira/browse/MESOS-3778 > Project: Mesos > Issue Type: Task >Reporter: Diana Arroyo >Assignee: zhou xing > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MESOS-5290) WebUI shows the active task is launched 46 years ago
zhou xing created MESOS-5290: Summary: WebUI shows the active task is launched 46 years ago Key: MESOS-5290 URL: https://issues.apache.org/jira/browse/MESOS-5290 Project: Mesos Issue Type: Bug Components: webui Reporter: zhou xing Assignee: zhou xing Priority: Minor When running the long-lived-framework, the active tasks column on webUI shows the task is launched 46 years ago, which should be launched just now -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-3778) Slave/Agent Rename Phase I - Add duplicate HTTP endpoints
[ https://issues.apache.org/jira/browse/MESOS-3778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhou xing updated MESOS-3778: - Summary: Slave/Agent Rename Phase I - Add duplicate HTTP endpoints (was: Replace Master/Slave Terminology Phase I - Add duplicate HTTP endpoints) > Slave/Agent Rename Phase I - Add duplicate HTTP endpoints > - > > Key: MESOS-3778 > URL: https://issues.apache.org/jira/browse/MESOS-3778 > Project: Mesos > Issue Type: Task >Reporter: Diana Arroyo >Assignee: zhou xing > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-3779) Slave/Agent Rename Phase I - Update webui
[ https://issues.apache.org/jira/browse/MESOS-3779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhou xing updated MESOS-3779: - Summary: Slave/Agent Rename Phase I - Update webui (was: Replace Master/Slave Terminology Phase I - Update webui) > Slave/Agent Rename Phase I - Update webui > - > > Key: MESOS-3779 > URL: https://issues.apache.org/jira/browse/MESOS-3779 > Project: Mesos > Issue Type: Task >Reporter: Diana Arroyo >Assignee: zhou xing > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-5057) Slave/Agent Rename Phase I - Update strings in error messages and other strings
[ https://issues.apache.org/jira/browse/MESOS-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhou xing updated MESOS-5057: - Summary: Slave/Agent Rename Phase I - Update strings in error messages and other strings (was: Replace Master/Slave Terminology Phase I - Update strings in error messages and other strings) > Slave/Agent Rename Phase I - Update strings in error messages and other > strings > --- > > Key: MESOS-5057 > URL: https://issues.apache.org/jira/browse/MESOS-5057 > Project: Mesos > Issue Type: Task >Reporter: zhou xing >Assignee: zhou xing > Fix For: 0.29.0 > > Original Estimate: 1m > Remaining Estimate: 1m > > This is a sub ticket of MESOS-3780. In this ticket, we will update all the > slave to agent in the error messages and other strings in the code -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-5055) Slave/Agent Rename Phase I - Update strings in the log message and standard output
[ https://issues.apache.org/jira/browse/MESOS-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhou xing updated MESOS-5055: - Summary: Slave/Agent Rename Phase I - Update strings in the log message and standard output (was: Replace Master/Slave Terminology Phase I - Update strings in the log message and standard output) > Slave/Agent Rename Phase I - Update strings in the log message and standard > output > -- > > Key: MESOS-5055 > URL: https://issues.apache.org/jira/browse/MESOS-5055 > Project: Mesos > Issue Type: Task >Reporter: zhou xing >Assignee: zhou xing > Fix For: 0.29.0 > > > This is a sub ticket of MESOS-3780. In this ticket, we will rename all the > slave to agent in the log messages and standard output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5060) Requesting /files/read.json with a negative length value causes subsequent /files requests to 404.
[ https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15249323#comment-15249323 ] zhou xing commented on MESOS-5060: -- [~greggomann], sure, have updated the review request to only fix the length issue. Do you think we need to open a new ticket to track the fix of those parameters' logic? > Requesting /files/read.json with a negative length value causes subsequent > /files requests to 404. > -- > > Key: MESOS-5060 > URL: https://issues.apache.org/jira/browse/MESOS-5060 > Project: Mesos > Issue Type: Bug >Affects Versions: 0.23.0 > Environment: Mesos 0.23.0 on CentOS 6, also Mesos 0.28.0 on OSX >Reporter: Tom Petr >Assignee: zhou xing >Priority: Minor > Fix For: 0.29.0 > > > I accidentally hit a slave's /files/read.json endpoint with a negative length > (ex. http://hostname:5051/files/read.json?path=XXX=0=-100). The > HTTP request timed out after 30 seconds with nothing relevant in the slave > logs, and subsequent calls to any of the /files endpoints on that slave > immediately returned a HTTP 404 response. We ultimately got things working > again by restarting the mesos-slave process (checkpointing FTW!), but it'd be > wise to guard against negative lengths on the slave's end too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (MESOS-5060) Requesting /files/read.json with a negative length value causes subsequent /files requests to 404.
[ https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15247354#comment-15247354 ] zhou xing edited comment on MESOS-5060 at 4/19/16 8:09 AM: --- [~greggomann] and [~bmahler], I submitted a draft review request based on my previous comments, if you have any comments, please let me know, thanks. https://reviews.apache.org/r/46373/ was (Author: dongdong): [~greggomann] and [~bmahler], I submitted a draft review request based on my previous comments, if you have any comments, please let me know, thanks. > Requesting /files/read.json with a negative length value causes subsequent > /files requests to 404. > -- > > Key: MESOS-5060 > URL: https://issues.apache.org/jira/browse/MESOS-5060 > Project: Mesos > Issue Type: Bug >Affects Versions: 0.23.0 > Environment: Mesos 0.23.0 on CentOS 6, also Mesos 0.28.0 on OSX >Reporter: Tom Petr >Assignee: zhou xing >Priority: Minor > Fix For: 0.29.0 > > > I accidentally hit a slave's /files/read.json endpoint with a negative length > (ex. http://hostname:5051/files/read.json?path=XXX=0=-100). The > HTTP request timed out after 30 seconds with nothing relevant in the slave > logs, and subsequent calls to any of the /files endpoints on that slave > immediately returned a HTTP 404 response. We ultimately got things working > again by restarting the mesos-slave process (checkpointing FTW!), but it'd be > wise to guard against negative lengths on the slave's end too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5060) Requesting /files/read.json with a negative length value causes subsequent /files requests to 404.
[ https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15247354#comment-15247354 ] zhou xing commented on MESOS-5060: -- [~greggomann] and [~bmahler], I submitted a draft review request based on my previous comments, if you have any comments, please let me know, thanks. > Requesting /files/read.json with a negative length value causes subsequent > /files requests to 404. > -- > > Key: MESOS-5060 > URL: https://issues.apache.org/jira/browse/MESOS-5060 > Project: Mesos > Issue Type: Bug >Affects Versions: 0.23.0 > Environment: Mesos 0.23.0 on CentOS 6, also Mesos 0.28.0 on OSX >Reporter: Tom Petr >Assignee: zhou xing >Priority: Minor > Fix For: 0.29.0 > > > I accidentally hit a slave's /files/read.json endpoint with a negative length > (ex. http://hostname:5051/files/read.json?path=XXX=0=-100). The > HTTP request timed out after 30 seconds with nothing relevant in the slave > logs, and subsequent calls to any of the /files endpoints on that slave > immediately returned a HTTP 404 response. We ultimately got things working > again by restarting the mesos-slave process (checkpointing FTW!), but it'd be > wise to guard against negative lengths on the slave's end too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3782) Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create symlinks)
[ https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246883#comment-15246883 ] zhou xing commented on MESOS-3782: -- [~klueska], Added MESOS-5230 to track this one > Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create > symlinks) > -- > > Key: MESOS-3782 > URL: https://issues.apache.org/jira/browse/MESOS-3782 > Project: Mesos > Issue Type: Task >Reporter: Diana Arroyo >Assignee: zhou xing > Fix For: 0.29.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MESOS-5230) Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder
zhou xing created MESOS-5230: Summary: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder Key: MESOS-5230 URL: https://issues.apache.org/jira/browse/MESOS-5230 Project: Mesos Issue Type: Bug Components: general Reporter: zhou xing Assignee: zhou xing Priority: Minor During the implementation of MESOS-3782, we thought it would be good to open a new ticket to track the rename of folder "/include/mesos/slave". Please refer to the discussion in review https://reviews.apache.org/r/45806/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (MESOS-5060) Requesting /files/read.json with a negative length value causes subsequent /files requests to 404.
[
https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245232#comment-15245232
]
zhou xing edited comment on MESOS-5060 at 4/18/16 7:16 AM:
---
Hi [~greggomann], I took a look at the code today and based on your
suggestions, I'm thinking whether we can change the logic as the followings:
* for {{length}}:
(1). if user provides a non-negative number, then keep current code logic,
set {{length=min(length, pageSize*16)}}
(2). if user provides a negative number, set {{length=pageSize * 1}}. Log a
warning message on this.
(3). if user does not provide this argument, I tend to think that this means
user wants to view the content after {{offset}}, which means {{length=min(size
- offset, pageSize * 16)}}. Log a message on this.
* for {{offset}}:
(1). if user provides a non-negative number, then keep current code logic,
set the offset as what user provides.
(2). if user provides a negative number, then set {{offset=size}} (note that,
now, if user gives a negative offset in the argument, it will lead to a reading
file failure error). Log a warning message for this.
(3). if user does not provide this argument, I tend to think this means user
wants to view the whole file, set {{offset=0}}. Log a message for this.
If you think the above logic is ok, then I'll submit a patch on this. Thanks
for your time on reviewing this!
was (Author: dongdong):
Hi Greg, I took a look at the code today and based on your suggestions, I'm
thinking whether we can change the logic as the followings:
* for {{length}}:
(1). if user provides a non-negative number, then keep current code logic,
set {{length=min(length, pageSize*16)}}
(2). if user provides a negative number, set {{length=pageSize * 1}}. Log a
warning message on this.
(3). if user does not provide this argument, I tend to think that this means
user wants to view the content after {{offset}}, which means {{length=min(size
- offset, pageSize * 16)}}. Log a message on this.
* for {{offset}}:
(1). if user provides a non-negative number, then keep current code logic,
set the offset as what user provides.
(2). if user provides a negative number, then set {{offset=size}} (note that,
now, if user gives a negative offset in the argument, it will lead to a reading
file failure error). Log a warning message for this.
(3). if user does not provide this argument, I tend to think this means user
wants to view the whole file, set {{offset=0}}. Log a message for this.
If you think the above logic is ok, then I'll submit a patch on this. Thanks
for your time on reviewing this!
> Requesting /files/read.json with a negative length value causes subsequent
> /files requests to 404.
> --
>
> Key: MESOS-5060
> URL: https://issues.apache.org/jira/browse/MESOS-5060
> Project: Mesos
> Issue Type: Bug
>Affects Versions: 0.23.0
> Environment: Mesos 0.23.0 on CentOS 6, also Mesos 0.28.0 on OSX
>Reporter: Tom Petr
>Assignee: zhou xing
>Priority: Minor
> Fix For: 0.29.0
>
>
> I accidentally hit a slave's /files/read.json endpoint with a negative length
> (ex. http://hostname:5051/files/read.json?path=XXX=0=-100). The
> HTTP request timed out after 30 seconds with nothing relevant in the slave
> logs, and subsequent calls to any of the /files endpoints on that slave
> immediately returned a HTTP 404 response. We ultimately got things working
> again by restarting the mesos-slave process (checkpointing FTW!), but it'd be
> wise to guard against negative lengths on the slave's end too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-5060) Requesting /files/read.json with a negative length value causes subsequent /files requests to 404.
[
https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245232#comment-15245232
]
zhou xing commented on MESOS-5060:
--
Hi Greg, I took a look at the code today and based on your suggestions, I'm
thinking whether we can change the logic as the followings:
* for {{length}}:
(1). if user provides a non-negative number, then keep current code logic,
set {{length=min(length, pageSize*16)}}
(2). if user provides a negative number, set {{length=pageSize * 1}}. Log a
warning message on this.
(3). if user does not provide this argument, I tend to think that this means
user wants to view the content after {{offset}}, which means {{length=min(size
- offset, pageSize * 16)}}. Log a message on this.
* for {{offset}}:
(1). if user provides a non-negative number, then keep current code logic,
set the offset as what user provides.
(2). if user provides a negative number, then set {{offset=size}} (note that,
now, if user gives a negative offset in the argument, it will lead to a reading
file failure error). Log a warning message for this.
(3). if user does not provide this argument, I tend to think this means user
wants to view the whole file, set {{offset=0}}. Log a message for this.
If you think the above logic is ok, then I'll submit a patch on this. Thanks
for your time on reviewing this!
> Requesting /files/read.json with a negative length value causes subsequent
> /files requests to 404.
> --
>
> Key: MESOS-5060
> URL: https://issues.apache.org/jira/browse/MESOS-5060
> Project: Mesos
> Issue Type: Bug
>Affects Versions: 0.23.0
> Environment: Mesos 0.23.0 on CentOS 6, also Mesos 0.28.0 on OSX
>Reporter: Tom Petr
>Assignee: zhou xing
>Priority: Minor
> Fix For: 0.29.0
>
>
> I accidentally hit a slave's /files/read.json endpoint with a negative length
> (ex. http://hostname:5051/files/read.json?path=XXX=0=-100). The
> HTTP request timed out after 30 seconds with nothing relevant in the slave
> logs, and subsequent calls to any of the /files endpoints on that slave
> immediately returned a HTTP 404 response. We ultimately got things working
> again by restarting the mesos-slave process (checkpointing FTW!), but it'd be
> wise to guard against negative lengths on the slave's end too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-5060) Requesting /files/read.json with a negative length value causes subsequent /files requests to 404.
[ https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15244474#comment-15244474 ] zhou xing commented on MESOS-5060: -- Hi Greg, thanks a lot for the information! it's really a helpful hint for newbie developers like us:). I'm now working on the slave->agent rename epic and will work on this ticket on next Monday. Thanks for the help and support! > Requesting /files/read.json with a negative length value causes subsequent > /files requests to 404. > -- > > Key: MESOS-5060 > URL: https://issues.apache.org/jira/browse/MESOS-5060 > Project: Mesos > Issue Type: Bug >Affects Versions: 0.23.0 > Environment: Mesos 0.23.0 on CentOS 6, also Mesos 0.28.0 on OSX >Reporter: Tom Petr >Assignee: zhou xing >Priority: Minor > Fix For: 0.29.0 > > > I accidentally hit a slave's /files/read.json endpoint with a negative length > (ex. http://hostname:5051/files/read.json?path=XXX=0=-100). The > HTTP request timed out after 30 seconds with nothing relevant in the slave > logs, and subsequent calls to any of the /files endpoints on that slave > immediately returned a HTTP 404 response. We ultimately got things working > again by restarting the mesos-slave process (checkpointing FTW!), but it'd be > wise to guard against negative lengths on the slave's end too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3782) Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create symlinks)
[ https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238498#comment-15238498 ] zhou xing commented on MESOS-3782: -- submitted the second patch to make changes in lib process make: https://reviews.apache.org/r/46134/ > Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create > symlinks) > -- > > Key: MESOS-3782 > URL: https://issues.apache.org/jira/browse/MESOS-3782 > Project: Mesos > Issue Type: Task >Reporter: Diana Arroyo >Assignee: zhou xing > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5060) Requesting /files/read.json with a negative length value causes subsequent /files requests to 404.
[ https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236611#comment-15236611 ] zhou xing commented on MESOS-5060: -- Hi Greg, thanks for your reminder! Is that ok for you to help shepherd this ticket? or I will send a mail in the mailing thread to find one > Requesting /files/read.json with a negative length value causes subsequent > /files requests to 404. > -- > > Key: MESOS-5060 > URL: https://issues.apache.org/jira/browse/MESOS-5060 > Project: Mesos > Issue Type: Bug >Affects Versions: 0.23.0 > Environment: Mesos 0.23.0 on CentOS 6, also Mesos 0.28.0 on OSX >Reporter: Tom Petr >Assignee: zhou xing >Priority: Minor > Fix For: 0.29.0 > > > I accidentally hit a slave's /files/read.json endpoint with a negative length > (ex. http://hostname:5051/files/read.json?path=XXX=0=-100). The > HTTP request timed out after 30 seconds with nothing relevant in the slave > logs, and subsequent calls to any of the /files endpoints on that slave > immediately returned a HTTP 404 response. We ultimately got things working > again by restarting the mesos-slave process (checkpointing FTW!), but it'd be > wise to guard against negative lengths on the slave's end too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MESOS-5060) Requesting /files/read.json with a negative length value causes subsequent /files requests to 404.
[ https://issues.apache.org/jira/browse/MESOS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhou xing reassigned MESOS-5060: Assignee: zhou xing > Requesting /files/read.json with a negative length value causes subsequent > /files requests to 404. > -- > > Key: MESOS-5060 > URL: https://issues.apache.org/jira/browse/MESOS-5060 > Project: Mesos > Issue Type: Bug >Affects Versions: 0.23.0 > Environment: Mesos 0.23.0 on CentOS 6, also Mesos 0.28.0 on OSX >Reporter: Tom Petr >Assignee: zhou xing >Priority: Minor > > I accidentally hit a slave's /files/read.json endpoint with a negative length > (ex. http://hostname:5051/files/read.json?path=XXX=0=-100). The > HTTP request timed out after 30 seconds with nothing relevant in the slave > logs, and subsequent calls to any of the /files endpoints on that slave > immediately returned a HTTP 404 response. We ultimately got things working > again by restarting the mesos-slave process (checkpointing FTW!), but it'd be > wise to guard against negative lengths on the slave's end too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3782) Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create symlinks)
[ https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227944#comment-15227944 ] zhou xing commented on MESOS-3782: -- Submitted review request at: https://reviews.apache.org/r/45806/ > Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create > symlinks) > -- > > Key: MESOS-3782 > URL: https://issues.apache.org/jira/browse/MESOS-3782 > Project: Mesos > Issue Type: Task >Reporter: Diana Arroyo >Assignee: zhou xing > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3782) Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create symlinks)
[ https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221173#comment-15221173 ] zhou xing commented on MESOS-3782: -- yes, will do that > Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create > symlinks) > -- > > Key: MESOS-3782 > URL: https://issues.apache.org/jira/browse/MESOS-3782 > Project: Mesos > Issue Type: Task >Reporter: Diana Arroyo >Assignee: zhou xing > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3782) Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create symlinks)
[ https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221166#comment-15221166 ] zhou xing commented on MESOS-3782: -- yeap, that could also be a solution > Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create > symlinks) > -- > > Key: MESOS-3782 > URL: https://issues.apache.org/jira/browse/MESOS-3782 > Project: Mesos > Issue Type: Task >Reporter: Diana Arroyo >Assignee: zhou xing > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5055) Replace Master/Slave Terminology Phase I - Update strings in the log message and standard output
[ https://issues.apache.org/jira/browse/MESOS-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221155#comment-15221155 ] zhou xing commented on MESOS-5055: -- [~darroyo], sure, will send a mail to collect the feedbacks > Replace Master/Slave Terminology Phase I - Update strings in the log message > and standard output > > > Key: MESOS-5055 > URL: https://issues.apache.org/jira/browse/MESOS-5055 > Project: Mesos > Issue Type: Task >Reporter: zhou xing >Assignee: zhou xing > > This is a sub ticket of MESOS-3780. In this ticket, we will rename all the > slave to agent in the log messages and standard output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3782) Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create symlinks)
[ https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221154#comment-15221154 ] zhou xing commented on MESOS-3782: -- [~vinodkone], those scripts are not very big, if we just duplicate the shell script the only disadvantage here is that if we need to change sth in the shell scripts, we need to copy the changes to the mess-agent.sh as well. For now, I will just duplicate everything and submit a patch then > Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create > symlinks) > -- > > Key: MESOS-3782 > URL: https://issues.apache.org/jira/browse/MESOS-3782 > Project: Mesos > Issue Type: Task >Reporter: Diana Arroyo >Assignee: zhou xing > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3780) Replace Master/Slave Terminology Phase I - Update all strings output
[ https://issues.apache.org/jira/browse/MESOS-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15215489#comment-15215489 ] zhou xing commented on MESOS-3780: -- Based on comment #3, we break this ticket into three sub-tickets: - MESOS-5055 - MESOS-5056 - MESOS-5057 please goto these tickets to check the details. > Replace Master/Slave Terminology Phase I - Update all strings output > > > Key: MESOS-3780 > URL: https://issues.apache.org/jira/browse/MESOS-3780 > Project: Mesos > Issue Type: Task >Reporter: Diana Arroyo >Assignee: zhou xing > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MESOS-5057) Replace Master/Slave Terminology Phase I - Update strings in error messages and other strings
zhou xing created MESOS-5057: Summary: Replace Master/Slave Terminology Phase I - Update strings in error messages and other strings Key: MESOS-5057 URL: https://issues.apache.org/jira/browse/MESOS-5057 Project: Mesos Issue Type: Task Reporter: zhou xing Assignee: zhou xing This is a sub ticket of MESOS-3780. In this ticket, we will update all the slave to agent in the error messages and other strings in the code -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MESOS-5056) Replace Master/Slave Terminology Phase I - Update strings in the shell scripts outputs
zhou xing created MESOS-5056: Summary: Replace Master/Slave Terminology Phase I - Update strings in the shell scripts outputs Key: MESOS-5056 URL: https://issues.apache.org/jira/browse/MESOS-5056 Project: Mesos Issue Type: Task Reporter: zhou xing Assignee: zhou xing This is a sub ticket of MESOS-3780. In this ticket, we will rename slave to agent in the shell script outputs -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-5055) Replace Master/Slave Terminology Phase I - Update strings in the log message and standard output
[ https://issues.apache.org/jira/browse/MESOS-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15215485#comment-15215485 ] zhou xing commented on MESOS-5055: -- review request has been submitted at: https://reviews.apache.org/r/45213/ > Replace Master/Slave Terminology Phase I - Update strings in the log message > and standard output > > > Key: MESOS-5055 > URL: https://issues.apache.org/jira/browse/MESOS-5055 > Project: Mesos > Issue Type: Task >Reporter: zhou xing >Assignee: zhou xing > > This is a sub ticket of MESOS-3780. In this ticket, we will rename all the > slave to agent in the log messages and standard output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MESOS-5055) Replace Master/Slave Terminology Phase I - Update strings in the log message and standard output
zhou xing created MESOS-5055: Summary: Replace Master/Slave Terminology Phase I - Update strings in the log message and standard output Key: MESOS-5055 URL: https://issues.apache.org/jira/browse/MESOS-5055 Project: Mesos Issue Type: Task Reporter: zhou xing Assignee: zhou xing This is a sub ticket of MESOS-3780. In this ticket, we will rename all the slave to agent in the log messages and standard output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3782) Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create symlinks)
[
https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15213741#comment-15213741
]
zhou xing commented on MESOS-3782:
--
[~klueska], here is a plan that we want to try:
1. Add a new program named {{mesos-agent}} in {{mesos/src/Makefile.am}} which
has the similar make rules to {{mess-slave}}. This will generate a duplicate
executable file named {{mesos-agent}} in {{mesos/build/.libs}} after {{make}}
(or in {{/usr/local/sbin}} after {{make install}})
2. For the shell scripts in {{mesos/bin}} or {{mesos/src/deploy}}, firstly, we
can rename them to use the word "agent", e.g. {{mesos-slave.sh}} to
{{mesos-agent.sh}}; secondly, change the invocation of all the {{mesos-slave}}
call to {{mesos-agent}} call in the shell scripts content.
3. Change the {{mesos/configure.ac}} and add symlink creation to create link
files named like **mesos-slave.sh** to link them to the **mesos-agent.sh**.
After step 3, there will be **mesos-slave.sh** and **mesos-agent.sh** in the
{{mesos/build/bin}} folder at the same time, so use can both use
{{mesos-slave.sh}} or {{mesos-agent.sh}} to start the slave node
> Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create
> symlinks)
> --
>
> Key: MESOS-3782
> URL: https://issues.apache.org/jira/browse/MESOS-3782
> Project: Mesos
> Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: zhou xing
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-3780) Replace Master/Slave Terminology Phase I - Update all strings output
[ https://issues.apache.org/jira/browse/MESOS-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208379#comment-15208379 ] zhou xing commented on MESOS-3780: -- Submitted the first patch of this ticket, to resolve item #1 of comment #1, at: https://reviews.apache.org/r/45213/ > Replace Master/Slave Terminology Phase I - Update all strings output > > > Key: MESOS-3780 > URL: https://issues.apache.org/jira/browse/MESOS-3780 > Project: Mesos > Issue Type: Task >Reporter: Diana Arroyo >Assignee: zhou xing > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3780) Replace Master/Slave Terminology Phase I - Update all strings output
[ https://issues.apache.org/jira/browse/MESOS-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208378#comment-15208378 ] zhou xing commented on MESOS-3780: -- we break this ticket into several parts: 1. change the log messages and standard outputs 2. change the shell script message outputs 3. change error messages and other messages > Replace Master/Slave Terminology Phase I - Update all strings output > > > Key: MESOS-3780 > URL: https://issues.apache.org/jira/browse/MESOS-3780 > Project: Mesos > Issue Type: Task >Reporter: Diana Arroyo >Assignee: zhou xing > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3779) Replace Master/Slave Terminology Phase I - Update webui
[ https://issues.apache.org/jira/browse/MESOS-3779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208241#comment-15208241 ] zhou xing commented on MESOS-3779: -- Need to change the term from the following aspects: (1). The labels used on Webui pages (2). The labels used on Webui urls (3). The field used in the fields of json objects. for #1 and #2, we can submit a patch. For #3, as many fields in the json objects are directly copied from the server response message(e.g. like /master/state call), now the fix for #3 is blocked by server side changes which should be made in MESOS-3778 > Replace Master/Slave Terminology Phase I - Update webui > --- > > Key: MESOS-3779 > URL: https://issues.apache.org/jira/browse/MESOS-3779 > Project: Mesos > Issue Type: Task >Reporter: Diana Arroyo >Assignee: zhou xing > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MESOS-3782) Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create symlinks)
[ https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhou xing reassigned MESOS-3782: Assignee: zhou xing > Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create > symlinks) > -- > > Key: MESOS-3782 > URL: https://issues.apache.org/jira/browse/MESOS-3782 > Project: Mesos > Issue Type: Task >Reporter: Diana Arroyo >Assignee: zhou xing > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MESOS-3780) Replace Master/Slave Terminology Phase I - Update all strings output
[ https://issues.apache.org/jira/browse/MESOS-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhou xing reassigned MESOS-3780: Assignee: zhou xing > Replace Master/Slave Terminology Phase I - Update all strings output > > > Key: MESOS-3780 > URL: https://issues.apache.org/jira/browse/MESOS-3780 > Project: Mesos > Issue Type: Task >Reporter: Diana Arroyo >Assignee: zhou xing > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3778) Replace Master/Slave Terminology Phase I - Add duplicate HTTP endpoints
[
https://issues.apache.org/jira/browse/MESOS-3778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203849#comment-15203849
]
zhou xing commented on MESOS-3778:
--
We took some investigation on this ticket and to change to use 'Agent' in
endpoint seems include the change of the following 3 aspects:
- change path prefix autocompletion: e.g. url {{/state}} is autocompleted as
{{/slave(1)/state}}, which should be {{/agent(1)/state}}, where *agent* is
inferred from process pid
- change endpoint that contains slave: e.g. {{/master/slaves}} endpoint need to
be modified to {{/master/agents}}
- change the fields of the endpoints that contain slave: e.g.
{{/master/create-volumes}} requires a parameter named {{slaveId}}, which needs
to be changed to {{agentId}}
we are planning to submit 2 independent patches for #2 and #3, which duplicate
current endpoint/fields with no compatibility issue. Whereas #1 *REPLACES*
current path prefix, which is going to compromise compatibility.
> Replace Master/Slave Terminology Phase I - Add duplicate HTTP endpoints
> ---
>
> Key: MESOS-3778
> URL: https://issues.apache.org/jira/browse/MESOS-3778
> Project: Mesos
> Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: zhou xing
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-4580) Consider returning `202` (Accepted) for /reserve and related endpoints
[
https://issues.apache.org/jira/browse/MESOS-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188621#comment-15188621
]
zhou xing commented on MESOS-4580:
--
Dear Neil and Vinod, we have submitted the patch at
https://reviews.apache.org/r/44606/, please take a review, thanks!
> Consider returning `202` (Accepted) for /reserve and related endpoints
> --
>
> Key: MESOS-4580
> URL: https://issues.apache.org/jira/browse/MESOS-4580
> Project: Mesos
> Issue Type: Bug
> Components: master
>Reporter: Neil Conway
>Assignee: Jay Guo
> Labels: mesosphere
>
> We currently return {{200}} (OK) when a POST to {{/reserve}}, {{/unreserve}},
> {{/create-volumes}}, and {{/destroy-volumes}} is validated successfully. This
> is misleading, because the underlying operation is still dispatched
> asynchronously and might subsequently fail. It would be more accurate to
> return {{202}} (Accepted) instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (MESOS-3481) Add const accessor to Master flags
[ https://issues.apache.org/jira/browse/MESOS-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhou xing reassigned MESOS-3481: Assignee: zhou xing > Add const accessor to Master flags > -- > > Key: MESOS-3481 > URL: https://issues.apache.org/jira/browse/MESOS-3481 > Project: Mesos > Issue Type: Task >Reporter: Joseph Wu >Assignee: zhou xing >Priority: Trivial > Labels: mesosphere, newbie > > It would make sense to have an accessor to the master's flags, especially for > tests. > For example, see [this > test|https://github.com/apache/mesos/blob/2876b8c918814347dd56f6f87d461e414a90650a/src/tests/master_maintenance_tests.cpp#L1231-L1235]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
