[jira] [Comment Edited] (MESOS-10224) [test] CSIVersion/StorageLocalResourceProviderTest.OperationUpdate fails.
[
https://issues.apache.org/jira/browse/MESOS-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367775#comment-17367775
]
Saad Ur Rahman edited comment on MESOS-10224 at 6/23/21, 4:51 PM:
--
[~cf.natali], I am finally getting around to patching the issue here.
My understanding of the routine is that it parses the linker library to
generate a vector of library names and paths. It does this by casting memory
blocks into structs to give them parsable structure.
The failing conditional on line _#227_ is because of the droppings Ubuntu
leaves at the end of the file. The data pointer should point to the end of the
file to indicate complete parsing. The following conditional on line _#235_
ensures NUL termination.
The solutions I can think of are to adjust for the end of data specifically for
Ubuntu (if we can) by setting:
{code:java}
data = buffer->size();
{code}
Or we can do this if the data pointer is not at the end:
{code:java}
if ((size_t)(data - buffer->data()) < buffer->size())
{code}
Another thing we can is let it slide if the data pointer is less than or equal
to the buffer size on line _#227_:
{code:java}
if ((size_t)(data - buffer->data()) > buffer->size()) {
return Error("Invalid format");
}
{code}
What are your thoughts? All of the above are quick adjustments but they weaken
the original checks.
was (Author: surahman):
[~cf.natali], I am finally getting around to patching the issue here.
My understanding of the routine is that it parses the linker library to
generate a vector of library names and paths. It does this by casting memory
blocks into structs to give them parsable structure.
The failing conditional on line _#227_ is because of the droppings Ubuntu
leaves at the end of the file. The data pointer should point to the end of the
file to indicate complete parsing. The following conditional on line _#235_
ensures NUL termination.
The solutions I can think of are to adjust for the end of data specifically for
Ubuntu (if we can) by setting:
{code:java}
data = buffer->size();
{code}
Or we can do this if the data pointer is not at the end:
{code:java}
if ((size_t)(data - buffer->data()) < buffer->size())
{code}
Another thing we can is let it slide if the data pointer is strictly less than
the buffer size on line _#227_:
{code:java}
if ((size_t)(data - buffer->data()) > buffer->size()) {
return Error("Invalid format");
}
{code}
What are your thoughts? All of the above are quick adjustments.
> [test] CSIVersion/StorageLocalResourceProviderTest.OperationUpdate fails.
> -
>
> Key: MESOS-10224
> URL: https://issues.apache.org/jira/browse/MESOS-10224
> Project: Mesos
> Issue Type: Bug
> Components: test
>Affects Versions: 1.11.0
>Reporter: Saad Ur Rahman
>Priority: Major
> Attachments: ld.so.cache
>
>
> *OS:* Ubuntu 21.04
> *Command:*
> {code:java}
> make -j 6 V=0 check{code}
> Fails during the build and test suite run on two different machines with the
> same OS.
> {code:java}
> 3: [ OK ] CSIVersion/StorageLocalResourceProviderTest.Update/v0 (479 ms)
> 3: [--] 14 tests from CSIVersion/StorageLocalResourceProviderTest
> (27011 ms total)
> 3:
> 3: [--] Global test environment tear-down
> 3: [==] 575 tests from 178 test cases ran. (202572 ms total)
> 3: [ PASSED ] 573 tests.
> 3: [ FAILED ] 2 tests, listed below:
> 3: [ FAILED ] LdcacheTest.Parse
> 3: [ FAILED ]
> CSIVersion/StorageLocalResourceProviderTest.OperationUpdate/v0, where
> GetParam() = "v0"
> 3:
> 3: 2 FAILED TESTS
> 3: YOU HAVE 34 DISABLED TESTS
> 3:
> 3:
> 3:
> 3: [FAIL]: 4 shard(s) have failed tests
> 3/3 Test #3: MesosTests ...***Failed 1173.43 sec
> {code}
> Are there any pre-requisites required to get the build/tests to pass? I am
> trying to get all the tests to pass to make sure my build environment is
> setup correctly for development.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MESOS-10224) [test] CSIVersion/StorageLocalResourceProviderTest.OperationUpdate fails.
[
https://issues.apache.org/jira/browse/MESOS-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367567#comment-17367567
]
Saad Ur Rahman edited comment on MESOS-10224 at 6/22/21, 6:07 PM:
--
[~qianzhang] thanks for getting back to me. My upstream is up to date and I am
building on the main branch - still no joy. I ran a clean git clone, build, and
then test with the same error. I am attaching my [^ld.so.cache] for inspection,
if it helps.
was (Author: surahman):
[~qianzhang] thanks for getting back to me. My upstream is up to date and I am
building on the main branch - still no joy. I ran a clean git clone, build, and
then test with the same error. I am attaching my [^ld.so.cache] for inspection,
if it helps.
> [test] CSIVersion/StorageLocalResourceProviderTest.OperationUpdate fails.
> -
>
> Key: MESOS-10224
> URL: https://issues.apache.org/jira/browse/MESOS-10224
> Project: Mesos
> Issue Type: Bug
> Components: test
>Affects Versions: 1.11.0
>Reporter: Saad Ur Rahman
>Priority: Major
> Attachments: ld.so.cache
>
>
> *OS:* Ubuntu 21.04
> *Command:*
> {code:java}
> make -j 6 V=0 check{code}
> Fails during the build and test suite run on two different machines with the
> same OS.
> {code:java}
> 3: [ OK ] CSIVersion/StorageLocalResourceProviderTest.Update/v0 (479 ms)
> 3: [--] 14 tests from CSIVersion/StorageLocalResourceProviderTest
> (27011 ms total)
> 3:
> 3: [--] Global test environment tear-down
> 3: [==] 575 tests from 178 test cases ran. (202572 ms total)
> 3: [ PASSED ] 573 tests.
> 3: [ FAILED ] 2 tests, listed below:
> 3: [ FAILED ] LdcacheTest.Parse
> 3: [ FAILED ]
> CSIVersion/StorageLocalResourceProviderTest.OperationUpdate/v0, where
> GetParam() = "v0"
> 3:
> 3: 2 FAILED TESTS
> 3: YOU HAVE 34 DISABLED TESTS
> 3:
> 3:
> 3:
> 3: [FAIL]: 4 shard(s) have failed tests
> 3/3 Test #3: MesosTests ...***Failed 1173.43 sec
> {code}
> Are there any pre-requisites required to get the build/tests to pass? I am
> trying to get all the tests to pass to make sure my build environment is
> setup correctly for development.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MESOS-10224) [test] CSIVersion/StorageLocalResourceProviderTest.OperationUpdate fails.
[
https://issues.apache.org/jira/browse/MESOS-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366900#comment-17366900
]
Saad Ur Rahman edited comment on MESOS-10224 at 6/22/21, 12:16 AM:
---
Hi [~qianzhang], thanks for checking on this:
{code:java}
-
We cannot run any aufs tests because:
aufs is not supported on your systems
-
-
We cannot run any cgroups tests that require mounting
hierarchies because you have the following hierarchies mounted:
/sys/fs/cgroup/blkio, /sys/fs/cgroup/cpu,cpuacct, /sys/fs/cgroup/cpuset,
/sys/fs/cgroup/devices, /sys/fs/cgroup/freezer, /sys/fs/cgroup/hugetlb,
/sys/fs/cgroup/memory, /sys/fs/cgroup/net_cls,net_prio,
/sys/fs/cgroup/perf_event, /sys/fs/cgroup/pids, /sys/fs/cgroup/rdma,
/sys/fs/cgroup/systemd
We'll disable the CgroupsNoHierarchyTest test fixture for now.
-
-
We cannot run any Docker tests because:
Failed to get docker version: Failed to execute 'docker -H
unix:///var/run/docker.sock --version': exited with status 127
-
PING google.com (172.217.165.14) 56(84) bytes of data.
64 bytes from yyz12s06-in-f14.1e100.net (172.217.165.14): icmp_seq=1 ttl=115
time=5.62 ms--- google.com ping statistics ---
1 packets transmitted, 1 received, 0% packet loss, time 0ms
rtt min/avg/max/mdev = 5.617/5.617/5.617/0.000 ms
# Warning: iptables-legacy tables present, use iptables-legacy to see them
-
We cannot run any overlayfs tests because:
overlayfs is not supported on your systems
-
E0621 19:40:00.390394 8397 perf.cpp:251] Failed to get perf version: Failed to
execute perf: exited with status 2
-
Could not find the 'perf' command or its version lower that 2.6.39 so tests
using it to sample the 'cpu-cycles' hardware event will not be run.
-
E0621 19:40:00.489571 8397 perf.cpp:251] Failed to get perf version: Failed to
execute perf: exited with status 2
-
require 'perf' version >= 2.6.39 so no 'perf' tests will be run
-
-
We can't run any VETH tests:
iproute2 version is not an integer
-
-
We cannot run any xfs tests because:
xfs is not supported on your systems
-
Note: Google Test filter =
[jira] [Comment Edited] (MESOS-10224) [test] CSIVersion/StorageLocalResourceProviderTest.OperationUpdate fails.
[
https://issues.apache.org/jira/browse/MESOS-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366900#comment-17366900
]
Saad Ur Rahman edited comment on MESOS-10224 at 6/22/21, 12:11 AM:
---
Hi [~qianzhang], thanks for checking on this:
{code:java}
-
We cannot run any aufs tests because:
aufs is not supported on your systems
-
-
We cannot run any cgroups tests that require mounting
hierarchies because you have the following hierarchies mounted:
/sys/fs/cgroup/blkio, /sys/fs/cgroup/cpu,cpuacct, /sys/fs/cgroup/cpuset,
/sys/fs/cgroup/devices, /sys/fs/cgroup/freezer, /sys/fs/cgroup/hugetlb,
/sys/fs/cgroup/memory, /sys/fs/cgroup/net_cls,net_prio,
/sys/fs/cgroup/perf_event, /sys/fs/cgroup/pids, /sys/fs/cgroup/rdma,
/sys/fs/cgroup/systemd
We'll disable the CgroupsNoHierarchyTest test fixture for now.
-
-
We cannot run any Docker tests because:
Failed to get docker version: Failed to execute 'docker -H
unix:///var/run/docker.sock --version': exited with status 127
-
PING google.com (172.217.165.14) 56(84) bytes of data.
64 bytes from yyz12s06-in-f14.1e100.net (172.217.165.14): icmp_seq=1 ttl=115
time=5.62 ms--- google.com ping statistics ---
1 packets transmitted, 1 received, 0% packet loss, time 0ms
rtt min/avg/max/mdev = 5.617/5.617/5.617/0.000 ms
# Warning: iptables-legacy tables present, use iptables-legacy to see them
-
We cannot run any overlayfs tests because:
overlayfs is not supported on your systems
-
E0621 19:40:00.390394 8397 perf.cpp:251] Failed to get perf version: Failed to
execute perf: exited with status 2
-
Could not find the 'perf' command or its version lower that 2.6.39 so tests
using it to sample the 'cpu-cycles' hardware event will not be run.
-
E0621 19:40:00.489571 8397 perf.cpp:251] Failed to get perf version: Failed to
execute perf: exited with status 2
-
require 'perf' version >= 2.6.39 so no 'perf' tests will be run
-
-
We can't run any VETH tests:
iproute2 version is not an integer
-
-
We cannot run any xfs tests because:
xfs is not supported on your systems
-
Note: Google Test filter =
[jira] [Comment Edited] (MESOS-10224) [test] CSIVersion/StorageLocalResourceProviderTest.OperationUpdate fails.
[
https://issues.apache.org/jira/browse/MESOS-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366900#comment-17366900
]
Saad Ur Rahman edited comment on MESOS-10224 at 6/22/21, 12:10 AM:
---
Hi [~qianzhang], thanks for checking on this:
{code:java}
-
We cannot run any aufs tests because:
aufs is not supported on your systems
-
-
We cannot run any cgroups tests that require mounting
hierarchies because you have the following hierarchies mounted:
/sys/fs/cgroup/blkio, /sys/fs/cgroup/cpu,cpuacct, /sys/fs/cgroup/cpuset,
/sys/fs/cgroup/devices, /sys/fs/cgroup/freezer, /sys/fs/cgroup/hugetlb,
/sys/fs/cgroup/memory, /sys/fs/cgroup/net_cls,net_prio,
/sys/fs/cgroup/perf_event, /sys/fs/cgroup/pids, /sys/fs/cgroup/rdma,
/sys/fs/cgroup/systemd
We'll disable the CgroupsNoHierarchyTest test fixture for now.
-
-
We cannot run any Docker tests because:
Failed to get docker version: Failed to execute 'docker -H
unix:///var/run/docker.sock --version': exited with status 127
-
PING google.com (172.217.165.14) 56(84) bytes of data.
64 bytes from yyz12s06-in-f14.1e100.net (172.217.165.14): icmp_seq=1 ttl=115
time=5.62 ms--- google.com ping statistics ---
1 packets transmitted, 1 received, 0% packet loss, time 0ms
rtt min/avg/max/mdev = 5.617/5.617/5.617/0.000 ms
# Warning: iptables-legacy tables present, use iptables-legacy to see them
-
We cannot run any overlayfs tests because:
overlayfs is not supported on your systems
-
E0621 19:40:00.390394 8397 perf.cpp:251] Failed to get perf version: Failed to
execute perf: exited with status 2
-
Could not find the 'perf' command or its version lower that 2.6.39 so tests
using it to sample the 'cpu-cycles' hardware event will not be run.
-
E0621 19:40:00.489571 8397 perf.cpp:251] Failed to get perf version: Failed to
execute perf: exited with status 2
-
require 'perf' version >= 2.6.39 so no 'perf' tests will be run
-
-
We can't run any VETH tests:
iproute2 version is not an integer
-
-
We cannot run any xfs tests because:
xfs is not supported on your systems
-
Note: Google Test filter =
[jira] [Comment Edited] (MESOS-10224) [test] CSIVersion/StorageLocalResourceProviderTest.OperationUpdate fails.
[
https://issues.apache.org/jira/browse/MESOS-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366893#comment-17366893
]
Qian Zhang edited comment on MESOS-10224 at 6/21/21, 11:34 PM:
---
[~surahman] Thanks for reporting the issue!
Can you please run the following command to get the detailed error messages for
the failed tests?
{code:java}
sudo ./bin/mesos-tests.sh --gtest_filter="" --verbose{code}
was (Author: qianzhang):
[~surahman] Thanks for reporting the issue!
Can you please run the following command to get the detailed error messages for
the failed test?
{code:java}
sudo ./bin/mesos-tests.sh --gtest_filter="" --verbose{code}
> [test] CSIVersion/StorageLocalResourceProviderTest.OperationUpdate fails.
> -
>
> Key: MESOS-10224
> URL: https://issues.apache.org/jira/browse/MESOS-10224
> Project: Mesos
> Issue Type: Bug
> Components: test
>Affects Versions: 1.11.0
>Reporter: Saad Ur Rahman
>Priority: Major
>
> *OS:* Ubuntu 21.04
> *Command:*
> {code:java}
> make -j 6 V=0 check{code}
> Fails during the build and test suite run on two different machines with the
> same OS.
> {code:java}
> 3: [ OK ] CSIVersion/StorageLocalResourceProviderTest.Update/v0 (479 ms)
> 3: [--] 14 tests from CSIVersion/StorageLocalResourceProviderTest
> (27011 ms total)
> 3:
> 3: [--] Global test environment tear-down
> 3: [==] 575 tests from 178 test cases ran. (202572 ms total)
> 3: [ PASSED ] 573 tests.
> 3: [ FAILED ] 2 tests, listed below:
> 3: [ FAILED ] LdcacheTest.Parse
> 3: [ FAILED ]
> CSIVersion/StorageLocalResourceProviderTest.OperationUpdate/v0, where
> GetParam() = "v0"
> 3:
> 3: 2 FAILED TESTS
> 3: YOU HAVE 34 DISABLED TESTS
> 3:
> 3:
> 3:
> 3: [FAIL]: 4 shard(s) have failed tests
> 3/3 Test #3: MesosTests ...***Failed 1173.43 sec
> {code}
> Are there any pre-requisites required to get the build/tests to pass? I am
> trying to get all the tests to pass to make sure my build environment is
> setup correctly for development.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
