[jira] [Comment Edited] (MESOS-4907) ClangTidy Integration
[
https://issues.apache.org/jira/browse/MESOS-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456320#comment-15456320
]
Michael Park edited comment on MESOS-4907 at 9/2/16 6:52 AM:
-
{noformat}
commit e90752d408713a174630d8b80dff194707a4
Author: Benjamin Bannier
Date: Thu Sep 1 20:43:11 2016 +0200
Added tooling to execute Mesos-specific clang-tidy checks.
This commit adds tooling to both build and execute Mesos-specific
clang-tidy checks. We use a docker container for the execution, and
also provide a script to further streamline the tooling.
Review: https://reviews.apache.org/r/51525/
{noformat}
was (Author: mcypark):
{noformat}
commit b817e82235c65fa7044de60c9ca31fe6e4d60c48
Author: Benjamin Bannier
Date: Thu Sep 1 20:43:11 2016 +0200
Added tooling to execute Mesos-specific clang-tidy checks.
This commit adds tooling to both build and execute Mesos-specific
clang-tidy checks. We use a docker container for the execution, and
also provide a script to further streamline the tooling.
Review: https://reviews.apache.org/r/51525/
{noformat}
> ClangTidy Integration
> -
>
> Key: MESOS-4907
> URL: https://issues.apache.org/jira/browse/MESOS-4907
> Project: Mesos
> Issue Type: Epic
> Components: technical debt
>Reporter: Michael Park
> Labels: gsoc, gsoc2016, mentor, mesosphere
>
> While {{cpplint}} has been a useful tool as a C++ linter for quite some time,
> It carries limitations since it does its best without actually parsing C++.
> [ClangTidy|http://clang.llvm.org/extra/clang-tidy/] is a clang tool that is
> based
> off of Clang, and has the advantage that it has access to a full AST.
> There are many checks that come built-in with {{clang-tidy}} which are very
> useful,
> but we can extend it to fit Mesos coding style and patterns as well.
> The initial phase of the project will be to create a basis with which to
> leverage
> the existing checks as applicable to Mesos, then to create a scaffolding to
> add
> custom checks, and ways to integrate the custom checks to infrastructure such
> as Mesos ReviewBot, or Apache CI.
> I've done some preliminary, experimental work for this for a Hackathon project
> and have given a
> [presentation|https://docs.google.com/presentation/d/1z_qGzpY7Mt46TXxuLRW6M5HcCWBLRz6UJfd4bPknYeg/edit?usp=sharing]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (MESOS-4907) ClangTidy Integration
[
https://issues.apache.org/jira/browse/MESOS-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192206#comment-15192206
]
Shuai Lin edited comment on MESOS-4907 at 3/13/16 8:05 AM:
---
Maybe not related to the initial phase of the project: one situation to
consider is clang-tidy need the header files to catch errors, but some of the
headers are generated at compile time, for example {{mesos.pb.h}}. If during
development one changes a {{.proto}} file, then one need to re-run the {{make}}
command to regenerate pb headers. Otherwise clang-tidy may output false alarms.
was (Author: lins05):
Maybe not related to the initial phase of the project: one situation to
consider is clang-tidy need the header files to catch errors, but some of the
headers are generated at compile time, for example {{mesos.pb.h}. If during
development one changes a {{.proto}} file, then one need to re-run the {{make}}
command to regenerate pb headers. Otherwise clang-tidy may output false alarms.
> ClangTidy Integration
> -
>
> Key: MESOS-4907
> URL: https://issues.apache.org/jira/browse/MESOS-4907
> Project: Mesos
> Issue Type: Epic
> Components: technical debt
>Reporter: Michael Park
> Labels: gsoc, gsoc2016, mentor, mesosphere
>
> While {{cpplint}} has been a useful tool as a C++ linter for quite some time,
> It carries limitations since it does its best without actually parsing C++.
> [ClangTidy|http://clang.llvm.org/extra/clang-tidy/] is a clang tool that is
> based
> off of Clang, and has the advantage that it has access to a full AST.
> There are many checks that come built-in with {{clang-tidy}} which are very
> useful,
> but we can extend it to fit Mesos coding style and patterns as well.
> The initial phase of the project will be to create a basis with which to
> leverage
> the existing checks as applicable to Mesos, then to create a scaffolding to
> add
> custom checks, and ways to integrate the custom checks to infrastructure such
> as Mesos ReviewBot, or Apache CI.
> I've done some preliminary, experimental work for this for a Hackathon project
> and have given a
> [presentation|https://docs.google.com/presentation/d/1z_qGzpY7Mt46TXxuLRW6M5HcCWBLRz6UJfd4bPknYeg/edit?usp=sharing]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (MESOS-4907) ClangTidy Integration
[
https://issues.apache.org/jira/browse/MESOS-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189593#comment-15189593
]
Sachith Senarathne edited comment on MESOS-4907 at 3/10/16 5:29 PM:
Thanks [~haosd...@gmail.com], I will go through the documentation and reach you
if I need any further clarification.
was (Author: sachiths):
Thanks [~haosdent], I will go through the documentation and reach you if I need
any further clarification.
> ClangTidy Integration
> -
>
> Key: MESOS-4907
> URL: https://issues.apache.org/jira/browse/MESOS-4907
> Project: Mesos
> Issue Type: Epic
> Components: technical debt
>Reporter: Michael Park
> Labels: gsoc, gsoc2016, mentor, mesosphere
>
> While {{cpplint}} has been a useful tool as a C++ linter for quite some time,
> It carries limitations since it does its best without actually parsing C++.
> [ClangTidy|http://clang.llvm.org/extra/clang-tidy/] is a clang tool that is
> based
> off of Clang, and has the advantage that it has access to a full AST.
> There are many checks that come built-in with {{clang-tidy}} which are very
> useful,
> but we can extend it to fit Mesos coding style and patterns as well.
> The initial phase of the project will be to create a basis with which to
> leverage
> the existing checks as applicable to Mesos, then to create a scaffolding to
> add
> custom checks, and ways to integrate the custom checks to infrastructure such
> as Mesos ReviewBot, or Apache CI.
> I've done some preliminary, experimental work for this for a Hackathon project
> and have given a
> [presentation|https://docs.google.com/presentation/d/1z_qGzpY7Mt46TXxuLRW6M5HcCWBLRz6UJfd4bPknYeg/edit?usp=sharing]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
