[ 
https://issues.apache.org/jira/browse/MESOS-5218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15590385#comment-15590385
 ] 

Yan Xu edited comment on MESOS-5218 at 10/20/16 12:54 AM:
----------------------------------------------------------

{noformat:title=}
commit e65b40d48b25ecf45805c8a740a412074da00d1f
Author: Megha Sharma <mshar...@apple.com>
Date:   Wed Oct 19 17:34:19 2016 -0700

    Fixed a bug that causes the fetcher to not chown the sandbox.
    
    Moved the `uri.size() == 0` check in fetcher so that the chown to
    task user of stdout/stderr in sandbox directory happens even when
    there is no uri to be fetched.
    
    Review: https://reviews.apache.org/r/52828/

commit 09a1cd10278992360c63a77d2712b9d047ce0e67
Author: Megha Sharma <mshar...@apple.com>
Date:   Wed Oct 19 17:37:16 2016 -0700

    Fixed fetcher to not recursively chown the entire sandbox.
    
    Fetcher currently changes the ownership of entire sandbox directory
    recursively to the task user and as a result also changes the
    ownership of files laid down by other entities in the sandbox, which
    leads to unintended side-effects.
    
    Review: https://reviews.apache.org/r/52058/
{noformat}


was (Author: xujyan):
{noformat:title=}
commit 09a1cd10278992360c63a77d2712b9d047ce0e67
Author: Megha Sharma <mshar...@apple.com>
Date:   Wed Oct 19 17:37:16 2016 -0700

    Fixed fetcher to not recursively chown the entire sandbox.
    
    Fetcher currently changes the ownership of entire sandbox directory
    recursively to the task user and as a result also changes the
    ownership of files laid down by other entities in the sandbox, which
    leads to unintended side-effects.
    
    Review: https://reviews.apache.org/r/52058/
{noformat}

> Fetcher should not chown the entire sandbox.
> --------------------------------------------
>
>                 Key: MESOS-5218
>                 URL: https://issues.apache.org/jira/browse/MESOS-5218
>             Project: Mesos
>          Issue Type: Bug
>          Components: fetcher
>            Reporter: Yan Xu
>            Assignee: Megha
>             Fix For: 1.2.0
>
>
> The real intention for this action is to make sure all decompressed files are 
> chowned to the task user but this has side effects if there are other things 
> are laid down in the sandbox.
> The fetcher should only chown the individual files if they are not to be 
> extracted or it should run the extraction commands as the task user so the 
> files get extracted with the task user as the owner.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to