[jira] [Commented] (MESOS-10073) Implement SSL downgrade on the native SSL socket

2019-12-18 Thread Joseph Wu (Jira)


[ 
https://issues.apache.org/jira/browse/MESOS-10073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16999554#comment-16999554
 ] 

Joseph Wu commented on MESOS-10073:
---

This is just the guard against using the feature tracked by this JIRA
{code}
commit 34bac34419ebec8441e69d3a5684381468352399
Author: Joseph Wu 
Date:   Tue Dec 17 15:23:27 2019 -0800

SSL Socket: Guarded against downgrade while unimplemented.

The SSL downgrade feature present in our libevent-SSL socket
is currently not supported on the plain-OpenSSL socket.

For this reason, we make sure to check the related flag and
prevent the related tests from running.

Review: https://reviews.apache.org/r/71923
{code}

> Implement SSL downgrade on the native SSL socket
> 
>
> Key: MESOS-10073
> URL: https://issues.apache.org/jira/browse/MESOS-10073
> Project: Mesos
>  Issue Type: Task
>Reporter: Joseph Wu
>Priority: Minor
>  Labels: foundations, ssl
>
> The new SSL socket implementation (the non-libevent one) does not currently 
> implement the SSL downgrade hack.  We could probably use {{peek}} to achieve 
> the same result, or modify our socket BIO to look at the first few bytes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (MESOS-10073) Implement SSL downgrade on the native SSL socket

2019-12-17 Thread Joseph Wu (Jira)


[ 
https://issues.apache.org/jira/browse/MESOS-10073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16998672#comment-16998672
 ] 

Joseph Wu commented on MESOS-10073:
---

Review guarding against usage of this feature, until we implement downgrade:
https://reviews.apache.org/r/71923/

> Implement SSL downgrade on the native SSL socket
> 
>
> Key: MESOS-10073
> URL: https://issues.apache.org/jira/browse/MESOS-10073
> Project: Mesos
>  Issue Type: Task
>Reporter: Joseph Wu
>Priority: Minor
>  Labels: foundations, ssl
>
> The new SSL socket implementation (the non-libevent one) does not currently 
> implement the SSL downgrade hack.  We could probably use {{peek}} to achieve 
> the same result, or modify our socket BIO to look at the first few bytes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)