[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[ https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15520500#comment-15520500 ] Deshi Xiao commented on MESOS-1104: --- Thanks for your hints, done. > Move linux/fs.hpp out of `mesos` namespace in linux/fs.h > > > Key: MESOS-1104 > URL: https://issues.apache.org/jira/browse/MESOS-1104 > Project: Mesos > Issue Type: Improvement >Reporter: Archana kumari > Labels: mesosphere, newbie > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[
https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508185#comment-15508185
]
Greg Mann commented on MESOS-1104:
--
[~xds2000], sorry for the confusion! And thanks for your patch :)
I think that this issue still makes sense - [~mcypark], I don't think the
intention was to consolidate implementations. Rather, as Deshi suggested, I
think the TODO indicates that a namespace nested within {{mesos::}} doesn't
make sense for a header which provides generic Linux functionality that isn't
Mesos-specific. Looking at the namespaces declared within {{src/linux/}}, it's
not entirely consistent, but in most cases we do not use the {{mesos::}} prefix.
Deshi, if you want to pick this back up, we could try to find a shepherd for
the ticket and continue. If you're busy with other things and don't have time,
would you mind discarding the review request? We can always reopen it in the
future.
> Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
>
>
> Key: MESOS-1104
> URL: https://issues.apache.org/jira/browse/MESOS-1104
> Project: Mesos
> Issue Type: Improvement
>Reporter: Archana kumari
>Assignee: Deshi Xiao
> Labels: mesosphere, newbie
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[ https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385126#comment-15385126 ] Deshi Xiao commented on MESOS-1104: --- hi, anyone can guide the reason to moving the linux/fs.hpp? i actually don't know what reason, just fee this is newbie issue, and follow the comments to do it. but [~mcypark] mentioned above, we need a reasonable demand to answer the quesiton first. if not, please remove the ACCEPT status thanks. > Move linux/fs.hpp out of `mesos` namespace in linux/fs.h > > > Key: MESOS-1104 > URL: https://issues.apache.org/jira/browse/MESOS-1104 > Project: Mesos > Issue Type: Improvement >Reporter: Archana kumari >Assignee: Deshi Xiao > Labels: mesosphere, newbie > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[ https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268119#comment-15268119 ] Deshi Xiao commented on MESOS-1104: --- Thanks [~mcypark], i guess the mesos::internal prefix namespace is not suitable for fs. this patch is based on above comments. the original TODO's information is very confuse on me. ping [~adam-mesos] [~idownes] [~benjaminhindman] could you please give some comments? > Move linux/fs.hpp out of `mesos` namespace in linux/fs.h > > > Key: MESOS-1104 > URL: https://issues.apache.org/jira/browse/MESOS-1104 > Project: Mesos > Issue Type: Improvement >Reporter: Archana kumari >Assignee: Deshi Xiao > Labels: mesosphere, newbie > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[
https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261404#comment-15261404
]
Michael Park commented on MESOS-1104:
-
[~xds2000] It looks like this patch is simply moving everything in
{{mesos::internal::fs}} to {{fs}}. That is, it doesn't look like we're
consolidating multiple implementations. Again, what are we trying to accomplish
here? Is there some place where we want access to these functions but for some
reason, are not accessible or something?
> Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
>
>
> Key: MESOS-1104
> URL: https://issues.apache.org/jira/browse/MESOS-1104
> Project: Mesos
> Issue Type: Improvement
>Reporter: Archana kumari
>Assignee: Deshi Xiao
> Labels: mesosphere, newbie
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[ https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253559#comment-15253559 ] Deshi Xiao commented on MESOS-1104: --- sure. i think this is another purpose to handle not this issue's concerns. Maybe the Shepherd can guide it. let it go. > Move linux/fs.hpp out of `mesos` namespace in linux/fs.h > > > Key: MESOS-1104 > URL: https://issues.apache.org/jira/browse/MESOS-1104 > Project: Mesos > Issue Type: Improvement >Reporter: Archana kumari >Assignee: Deshi Xiao > Labels: mesosphere, newbie > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[
https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253054#comment-15253054
]
haosdent commented on MESOS-1104:
-
[~xds2000] I think the reason to keep it in current folder is those functions
now only can be used in Linux, just like {{src/linux/ns.hpp}}. But if we want
to support them in osx or windows in the future, I think move to stout would be
better because it places the generic utilities.
> Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
>
>
> Key: MESOS-1104
> URL: https://issues.apache.org/jira/browse/MESOS-1104
> Project: Mesos
> Issue Type: Improvement
>Reporter: Archana kumari
>Assignee: Deshi Xiao
> Labels: mesosphere, newbie
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[ https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252990#comment-15252990 ] Deshi Xiao commented on MESOS-1104: --- i think the file convention is follow the current folder. if move it to stout, also need consider what benefit on the action. Could you please list some concerns let me understand your think? > Move linux/fs.hpp out of `mesos` namespace in linux/fs.h > > > Key: MESOS-1104 > URL: https://issues.apache.org/jira/browse/MESOS-1104 > Project: Mesos > Issue Type: Improvement >Reporter: Archana kumari >Assignee: Deshi Xiao > Labels: mesosphere, newbie > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[
https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252351#comment-15252351
]
haosdent commented on MESOS-1104:
-
Thank you very much for your patch, it looks to me basically besides I am not
sure whether keep it in current folder or move it to {{stout}}.
> Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
>
>
> Key: MESOS-1104
> URL: https://issues.apache.org/jira/browse/MESOS-1104
> Project: Mesos
> Issue Type: Improvement
>Reporter: Archana kumari
>Assignee: Deshi Xiao
> Labels: mesosphere, newbie
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[ https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252296#comment-15252296 ] Deshi Xiao commented on MESOS-1104: --- [~haosdent] [~mcypark] could you please reive it again.https://reviews.apache.org/r/45500/ > Move linux/fs.hpp out of `mesos` namespace in linux/fs.h > > > Key: MESOS-1104 > URL: https://issues.apache.org/jira/browse/MESOS-1104 > Project: Mesos > Issue Type: Improvement >Reporter: Archana kumari >Assignee: Deshi Xiao > Labels: mesosphere, newbie > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[ https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15240584#comment-15240584 ] Deshi Xiao commented on MESOS-1104: --- [~mcypark] what's your feedback. https://reviews.apache.org/r/45500/ > Move linux/fs.hpp out of `mesos` namespace in linux/fs.h > > > Key: MESOS-1104 > URL: https://issues.apache.org/jira/browse/MESOS-1104 > Project: Mesos > Issue Type: Improvement >Reporter: Archana kumari > Labels: mesosphere, newbie > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[ https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234929#comment-15234929 ] Deshi Xiao commented on MESOS-1104: --- https://reviews.apache.org/r/45500/ update again. > Move linux/fs.hpp out of `mesos` namespace in linux/fs.h > > > Key: MESOS-1104 > URL: https://issues.apache.org/jira/browse/MESOS-1104 > Project: Mesos > Issue Type: Improvement >Reporter: Archana kumari > Labels: mesosphere, newbie > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[ https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234611#comment-15234611 ] Deshi Xiao commented on MESOS-1104: --- Michael Hi, Thanks for your guide, i have update based on above comments recap. i have update the description. I think the changed is reason with consolidated with other file's convention. > Move linux/fs.hpp out of `mesos` namespace in linux/fs.h > > > Key: MESOS-1104 > URL: https://issues.apache.org/jira/browse/MESOS-1104 > Project: Mesos > Issue Type: Improvement >Reporter: Archana kumari > Labels: mesosphere, newbie > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[ https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229321#comment-15229321 ] Michael Park commented on MESOS-1104: - [~xds2000] Could you add some context and goal in the description section? The title also doesn't seem to make sense. Beyond that, what are we trying to accomplish here? Does this ticket allow something that we couldn't do before? Are we trying to make these filesystem utilities public...? Based on [~adam-mesos] said above, are we trying to consolidate something into stout? I'd be up for shepherding this, but I don't understand what we're trying to do. > Move linux/fs.hpp out of `mesos` namespace in linux/fs.h > > > Key: MESOS-1104 > URL: https://issues.apache.org/jira/browse/MESOS-1104 > Project: Mesos > Issue Type: Improvement >Reporter: Archana kumari > Labels: mesosphere, newbie > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[ https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221179#comment-15221179 ] Deshi Xiao commented on MESOS-1104: --- patch updated, anyone can testing it? https://reviews.apache.org/r/45500/ > Move linux/fs.hpp out of `mesos` namespace in linux/fs.h > > > Key: MESOS-1104 > URL: https://issues.apache.org/jira/browse/MESOS-1104 > Project: Mesos > Issue Type: Improvement >Reporter: Archana kumari > Labels: mesosphere, newbie > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[ https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219557#comment-15219557 ] Deshi Xiao commented on MESOS-1104: --- have no linux to testing on it. please hold on on patched code udpate. > Move linux/fs.hpp out of `mesos` namespace in linux/fs.h > > > Key: MESOS-1104 > URL: https://issues.apache.org/jira/browse/MESOS-1104 > Project: Mesos > Issue Type: Improvement >Reporter: Archana kumari > Labels: mesosphere, newbie > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[ https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219186#comment-15219186 ] Deshi Xiao commented on MESOS-1104: --- thanks a lot. > Move linux/fs.hpp out of `mesos` namespace in linux/fs.h > > > Key: MESOS-1104 > URL: https://issues.apache.org/jira/browse/MESOS-1104 > Project: Mesos > Issue Type: Improvement >Reporter: Archana kumari > Labels: mesosphere, newbie > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[ https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219175#comment-15219175 ] haosdent commented on MESOS-1104: - [~xds2000] I add my basic review comments on it now. For further review, you could send email to dev mailing list and find a committer shepherd you in this ticket. > Move linux/fs.hpp out of `mesos` namespace in linux/fs.h > > > Key: MESOS-1104 > URL: https://issues.apache.org/jira/browse/MESOS-1104 > Project: Mesos > Issue Type: Improvement >Reporter: Archana kumari > Labels: mesosphere, newbie > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[ https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218547#comment-15218547 ] Deshi Xiao commented on MESOS-1104: --- patch: https://reviews.apache.org/r/45500/ > Move linux/fs.hpp out of `mesos` namespace in linux/fs.h > > > Key: MESOS-1104 > URL: https://issues.apache.org/jira/browse/MESOS-1104 > Project: Mesos > Issue Type: Improvement >Reporter: Archana kumari > Labels: mesosphere, newbie > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[ https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218534#comment-15218534 ] Deshi Xiao commented on MESOS-1104: --- hi haosdent, could you please shepherd this issue? > Move linux/fs.hpp out of `mesos` namespace in linux/fs.h > > > Key: MESOS-1104 > URL: https://issues.apache.org/jira/browse/MESOS-1104 > Project: Mesos > Issue Type: Improvement >Reporter: Archana kumari > Labels: mesosphere, newbie > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[
https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217700#comment-15217700
]
haosdent commented on MESOS-1104:
-
[~xds2000] I think just move the code in {{./src/linux/fs.hpp}} and
{{./src/linux/cpp}} to
{{./3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp}}. Note that we
support both windows and posix in {{stout/fs.hpp}}. And all functions related
to {{./src/linux/fs.hpp}} are only available in Linux. Maybe add something like
{{stout/linux/fs.hpp}} is a possible approach.
> Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
>
>
> Key: MESOS-1104
> URL: https://issues.apache.org/jira/browse/MESOS-1104
> Project: Mesos
> Issue Type: Improvement
>Reporter: Archana kumari
> Labels: mesosphere, newbie
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[ https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217688#comment-15217688 ] Deshi Xiao commented on MESOS-1104: --- dont' know howto start. anyone can do me a favor? > Move linux/fs.hpp out of `mesos` namespace in linux/fs.h > > > Key: MESOS-1104 > URL: https://issues.apache.org/jira/browse/MESOS-1104 > Project: Mesos > Issue Type: Improvement >Reporter: Archana kumari > Labels: mesosphere, newbie > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[ https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072487#comment-15072487 ] Abhishek Dasgupta commented on MESOS-1104: -- Can you please be more elaborate on this issue.?There is no file called linux/fs.h in mesos 0.26 version. Is the issue resolved? > Move linux/fs.hpp out of `mesos` namespace in linux/fs.h > > > Key: MESOS-1104 > URL: https://issues.apache.org/jira/browse/MESOS-1104 > Project: Mesos > Issue Type: Improvement >Reporter: Archana kumari > Labels: mesosphere, newbie > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1104) Move linux/fs.hpp out of `mesos` namespace in linux/fs.h
[ https://issues.apache.org/jira/browse/MESOS-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14594954#comment-14594954 ] Adam B commented on MESOS-1104: --- This JIRA refers to this TODO from [~benjaminhindman]: https://github.com/apache/mesos/blob/0.22.1/src/linux/cgroups.cpp#L64 Furthermore, [~idownes] suggests that These three variations on mount information should be consolidated and moved to stout, along with mount and umount.: https://github.com/apache/mesos/blob/master/src/linux/fs.hpp#L40 Perhaps one of them would like to Accept this issue and volunteer as Shepherd? It would also be great if we turned the pseudo-doxygen formatting into proper doxygen/javadoc style. Move linux/fs.hpp out of `mesos` namespace in linux/fs.h Key: MESOS-1104 URL: https://issues.apache.org/jira/browse/MESOS-1104 Project: Mesos Issue Type: Improvement Reporter: Archana kumari Assignee: Jojy Varghese Labels: mesosphere, newbie -- This message was sent by Atlassian JIRA (v6.3.4#6332)
