[jira] [Commented] (MESOS-1662) Mesos doesn't limit swap
[ https://issues.apache.org/jira/browse/MESOS-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14139176#comment-14139176 ] Chi Hoang commented on MESOS-1662: -- Wondering what happened with this fix. Status says fixed, but it wasn't included in 0.20.0. Mesos doesn't limit swap Key: MESOS-1662 URL: https://issues.apache.org/jira/browse/MESOS-1662 Project: Mesos Issue Type: Bug Components: isolation Affects Versions: 0.19.1 Reporter: Andrew Forgue Assignee: Anton Lindström When using control groups, mesos will limit memory usage, but if the CONFIG_MEMCG_SWAP config option is enabled swap usage is not limited. This means that if a task that asked for 1G and allocated 4G, it will fill 3G of swap. The expected behavior is that the cgroup should have OOMed. The control group key for limiting both Memory+Swap is memory.memsw.limit_in_bytes (not memory.limit_in_bytes). It looks like CONFIG_MEMCG_SWAP showed up in Kernel 3.6. Mesos should limit swap+memory if possible. I can't imagine when you'd want to limit memory but not swap, but there may be some situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1662) Mesos doesn't limit swap
[ https://issues.apache.org/jira/browse/MESOS-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14139289#comment-14139289 ] Chi Hoang commented on MESOS-1662: -- awesome! thanks! Mesos doesn't limit swap Key: MESOS-1662 URL: https://issues.apache.org/jira/browse/MESOS-1662 Project: Mesos Issue Type: Bug Components: isolation Affects Versions: 0.19.1 Reporter: Andrew Forgue Assignee: Anton Lindström Fix For: 0.20.0 When using control groups, mesos will limit memory usage, but if the CONFIG_MEMCG_SWAP config option is enabled swap usage is not limited. This means that if a task that asked for 1G and allocated 4G, it will fill 3G of swap. The expected behavior is that the cgroup should have OOMed. The control group key for limiting both Memory+Swap is memory.memsw.limit_in_bytes (not memory.limit_in_bytes). It looks like CONFIG_MEMCG_SWAP showed up in Kernel 3.6. Mesos should limit swap+memory if possible. I can't imagine when you'd want to limit memory but not swap, but there may be some situations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1662) Mesos doesn't limit swap
[ https://issues.apache.org/jira/browse/MESOS-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086440#comment-14086440 ] Anton Lindström commented on MESOS-1662: Messed up the previous review (I think), here's a new one: https://reviews.apache.org/r/24316/ Mesos doesn't limit swap Key: MESOS-1662 URL: https://issues.apache.org/jira/browse/MESOS-1662 Project: Mesos Issue Type: Bug Components: isolation Affects Versions: 0.19.1 Reporter: Andrew Forgue Assignee: Anton Lindström When using control groups, mesos will limit memory usage, but if the CONFIG_MEMCG_SWAP config option is enabled swap usage is not limited. This means that if a task that asked for 1G and allocated 4G, it will fill 3G of swap. The expected behavior is that the cgroup should have OOMed. The control group key for limiting both Memory+Swap is memory.memsw.limit_in_bytes (not memory.limit_in_bytes). It looks like CONFIG_MEMCG_SWAP showed up in Kernel 3.6. Mesos should limit swap+memory if possible. I can't imagine when you'd want to limit memory but not swap, but there may be some situations. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-1662) Mesos doesn't limit swap
[ https://issues.apache.org/jira/browse/MESOS-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14085116#comment-14085116 ] Jie Yu commented on MESOS-1662: --- I am wondering can we set both memory.limit_in_bytes and memory.memsw.limit_in_bytes (if available since it may not be available on some kernels)? Mesos doesn't limit swap Key: MESOS-1662 URL: https://issues.apache.org/jira/browse/MESOS-1662 Project: Mesos Issue Type: Bug Components: isolation Affects Versions: 0.19.1 Reporter: Andrew Forgue Assignee: Anton Lindström When using control groups, mesos will limit memory usage, but if the CONFIG_MEMCG_SWAP config option is enabled swap usage is not limited. This means that if a task that asked for 1G and allocated 4G, it will fill 3G of swap. The expected behavior is that the cgroup should have OOMed. The control group key for limiting both Memory+Swap is memory.memsw.limit_in_bytes (not memory.limit_in_bytes). It looks like CONFIG_MEMCG_SWAP showed up in Kernel 3.6. Mesos should limit swap+memory if possible. I can't imagine when you'd want to limit memory but not swap, but there may be some situations. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-1662) Mesos doesn't limit swap
[ https://issues.apache.org/jira/browse/MESOS-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14085145#comment-14085145 ] Ian Downes commented on MESOS-1662: --- I tend to agree that Mesos should be able to limit memory+swap but this change needs some consideration because users may be running jobs that do use swap and which would now OOM unexpectedly. I can imagine users limiting memory and swap independently so perhaps this needs some discussion? Mesos doesn't limit swap Key: MESOS-1662 URL: https://issues.apache.org/jira/browse/MESOS-1662 Project: Mesos Issue Type: Bug Components: isolation Affects Versions: 0.19.1 Reporter: Andrew Forgue Assignee: Anton Lindström When using control groups, mesos will limit memory usage, but if the CONFIG_MEMCG_SWAP config option is enabled swap usage is not limited. This means that if a task that asked for 1G and allocated 4G, it will fill 3G of swap. The expected behavior is that the cgroup should have OOMed. The control group key for limiting both Memory+Swap is memory.memsw.limit_in_bytes (not memory.limit_in_bytes). It looks like CONFIG_MEMCG_SWAP showed up in Kernel 3.6. Mesos should limit swap+memory if possible. I can't imagine when you'd want to limit memory but not swap, but there may be some situations. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-1662) Mesos doesn't limit swap
[ https://issues.apache.org/jira/browse/MESOS-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14085146#comment-14085146 ] Ian Downes commented on MESOS-1662: --- IIUC memory.memsw.limit_in_bytes has been around for a long time, it's only CONFIG_MEMCG_SWAP which is recent. Mesos doesn't limit swap Key: MESOS-1662 URL: https://issues.apache.org/jira/browse/MESOS-1662 Project: Mesos Issue Type: Bug Components: isolation Affects Versions: 0.19.1 Reporter: Andrew Forgue Assignee: Anton Lindström When using control groups, mesos will limit memory usage, but if the CONFIG_MEMCG_SWAP config option is enabled swap usage is not limited. This means that if a task that asked for 1G and allocated 4G, it will fill 3G of swap. The expected behavior is that the cgroup should have OOMed. The control group key for limiting both Memory+Swap is memory.memsw.limit_in_bytes (not memory.limit_in_bytes). It looks like CONFIG_MEMCG_SWAP showed up in Kernel 3.6. Mesos should limit swap+memory if possible. I can't imagine when you'd want to limit memory but not swap, but there may be some situations. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (MESOS-1662) Mesos doesn't limit swap
[ https://issues.apache.org/jira/browse/MESOS-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14085160#comment-14085160 ] Jie Yu commented on MESOS-1662: --- because users may be running jobs that do use swap and which would now OOM unexpectedly. For this case, I prefer OOM those jobs because they are actually using more memory than requested. Mesos doesn't limit swap Key: MESOS-1662 URL: https://issues.apache.org/jira/browse/MESOS-1662 Project: Mesos Issue Type: Bug Components: isolation Affects Versions: 0.19.1 Reporter: Andrew Forgue Assignee: Anton Lindström When using control groups, mesos will limit memory usage, but if the CONFIG_MEMCG_SWAP config option is enabled swap usage is not limited. This means that if a task that asked for 1G and allocated 4G, it will fill 3G of swap. The expected behavior is that the cgroup should have OOMed. The control group key for limiting both Memory+Swap is memory.memsw.limit_in_bytes (not memory.limit_in_bytes). It looks like CONFIG_MEMCG_SWAP showed up in Kernel 3.6. Mesos should limit swap+memory if possible. I can't imagine when you'd want to limit memory but not swap, but there may be some situations. -- This message was sent by Atlassian JIRA (v6.2#6252)
