[jira] [Commented] (MESOS-1925) Docker kill does not allow containers to exit gracefully
[ https://issues.apache.org/jira/browse/MESOS-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190216#comment-14190216 ] Ryan Thomas commented on MESOS-1925: [~tnachen] is there anything more to do in order to get this patch merged? > Docker kill does not allow containers to exit gracefully > > > Key: MESOS-1925 > URL: https://issues.apache.org/jira/browse/MESOS-1925 > Project: Mesos > Issue Type: Improvement > Components: containerization >Affects Versions: 0.20.1 >Reporter: Ryan Thomas >Assignee: Timothy Chen > > The docker implementation uses the docker kill command, this immediately > terminated the container, not allowing it to exit gracefully. > We should be using the docker stop command that will send a kill after a > predetermined amount of time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1925) Docker kill does not allow containers to exit gracefully
[ https://issues.apache.org/jira/browse/MESOS-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175680#comment-14175680 ] Ankur Chauhan commented on MESOS-1925: -- Patch here: https://reviews.apache.org/r/26736/ LGTM > Docker kill does not allow containers to exit gracefully > > > Key: MESOS-1925 > URL: https://issues.apache.org/jira/browse/MESOS-1925 > Project: Mesos > Issue Type: Improvement > Components: containerization >Affects Versions: 0.20.1 >Reporter: Ryan Thomas > > The docker implementation uses the docker kill command, this immediately > terminated the container, not allowing it to exit gracefully. > We should be using the docker stop command that will send a kill after a > predetermined amount of time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1925) Docker kill does not allow containers to exit gracefully
[ https://issues.apache.org/jira/browse/MESOS-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171600#comment-14171600 ] Ryan Thomas commented on MESOS-1925: Patch here: https://reviews.apache.org/r/26709/ > Docker kill does not allow containers to exit gracefully > > > Key: MESOS-1925 > URL: https://issues.apache.org/jira/browse/MESOS-1925 > Project: Mesos > Issue Type: Improvement > Components: containerization >Affects Versions: 0.20.1 >Reporter: Ryan Thomas > > The docker implementation uses the docker kill command, this immediately > terminated the container, not allowing it to exit gracefully. > We should be using the docker stop command that will send a kill after a > predetermined amount of time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1925) Docker kill does not allow containers to exit gracefully
[ https://issues.apache.org/jira/browse/MESOS-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171593#comment-14171593 ] Ryan Thomas commented on MESOS-1925: Thanks. I went with just a 30 second timeout for the stop (the default is 10) - though I think some time in the future we may want to make this configurable. > Docker kill does not allow containers to exit gracefully > > > Key: MESOS-1925 > URL: https://issues.apache.org/jira/browse/MESOS-1925 > Project: Mesos > Issue Type: Improvement > Components: containerization >Affects Versions: 0.20.1 >Reporter: Ryan Thomas > > The docker implementation uses the docker kill command, this immediately > terminated the container, not allowing it to exit gracefully. > We should be using the docker stop command that will send a kill after a > predetermined amount of time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-1925) Docker kill does not allow containers to exit gracefully
[ https://issues.apache.org/jira/browse/MESOS-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171583#comment-14171583 ] Timothy Chen commented on MESOS-1925: - Let me know if you have any questions working on the patch. > Docker kill does not allow containers to exit gracefully > > > Key: MESOS-1925 > URL: https://issues.apache.org/jira/browse/MESOS-1925 > Project: Mesos > Issue Type: Improvement > Components: containerization >Affects Versions: 0.20.1 >Reporter: Ryan Thomas [Atlassian] > > The docker implementation uses the docker kill command, this immediately > terminated the container, not allowing it to exit gracefully. > We should be using the docker stop command that will send a kill after a > predetermined amount of time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
