[jira] [Commented] (MESOS-2670) Update existing lambdas to meet style guide
[ https://issues.apache.org/jira/browse/MESOS-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601958#comment-14601958 ] Joris Van Remoortere commented on MESOS-2670: - [~adam-mesos]We've been using this ticket to do some lambda conversions, but the original intent of this ticket is satisfied. We can close it. > Update existing lambdas to meet style guide > --- > > Key: MESOS-2670 > URL: https://issues.apache.org/jira/browse/MESOS-2670 > Project: Mesos > Issue Type: Task >Reporter: Joris Van Remoortere >Assignee: haosdent > Labels: c++11 > > There are already some lambdas in C++11 specific files. Modify these to meet > the updated style guide. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2670) Update existing lambdas to meet style guide
[ https://issues.apache.org/jira/browse/MESOS-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601955#comment-14601955 ] Joris Van Remoortere commented on MESOS-2670: - [~adam-mesos]We've been using this ticket to do some lambda conversions, but the original intent of this ticket is satisfied. We can close it. > Update existing lambdas to meet style guide > --- > > Key: MESOS-2670 > URL: https://issues.apache.org/jira/browse/MESOS-2670 > Project: Mesos > Issue Type: Task >Reporter: Joris Van Remoortere >Assignee: haosdent > Labels: c++11 > > There are already some lambdas in C++11 specific files. Modify these to meet > the updated style guide. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2670) Update existing lambdas to meet style guide
[ https://issues.apache.org/jira/browse/MESOS-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599107#comment-14599107 ] Adam B commented on MESOS-2670: --- [~jvanremoortere] [~benjaminhindman] Now that the above patches have been committed, is there anything left to do before we can close this ticket? > Update existing lambdas to meet style guide > --- > > Key: MESOS-2670 > URL: https://issues.apache.org/jira/browse/MESOS-2670 > Project: Mesos > Issue Type: Task >Reporter: Joris Van Remoortere >Assignee: haosdent > Labels: c++11 > > There are already some lambdas in C++11 specific files. Modify these to meet > the updated style guide. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2670) Update existing lambdas to meet style guide
[ https://issues.apache.org/jira/browse/MESOS-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14549259#comment-14549259 ] Benjamin Hindman commented on MESOS-2670: - commit b26a2e1a716fdc775c301fab15f3fa991b070867 Author: haosdent huang Date: Mon May 18 14:20:39 2015 -0700 Update some existing lambdas to meet style guide. Review: https://reviews.apache.org/r/34018 commit d46c0d7eb1295ef4a3a2494ca2f323c067f91f45 Author: haosdent huang Date: Mon May 18 14:16:26 2015 -0700 Update some existing lambdas to meet style guide. Review: https://reviews.apache.org/r/34017 > Update existing lambdas to meet style guide > --- > > Key: MESOS-2670 > URL: https://issues.apache.org/jira/browse/MESOS-2670 > Project: Mesos > Issue Type: Task >Reporter: Joris Van Remoortere >Assignee: haosdent > Labels: c++11 > > There are already some lambdas in C++11 specific files. Modify these to meet > the updated style guide. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2670) Update existing lambdas to meet style guide
[ https://issues.apache.org/jira/browse/MESOS-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14536853#comment-14536853 ] haosdent commented on MESOS-2670: - According [~jvanremoortere] advice, replace the 'lambda::bind' expressions match these rules: * Binds to a static function without any side-effects. * Is self contained (i.e. does not rely on contextual parameters) * Does not bind in any arguments. (i.e. only uses lambda::_N for arguments) * Is only called in 1 place OR is so small that it is ok to repeat the code. Patch: https://reviews.apache.org/r/34017/ https://reviews.apache.org/r/34018/ > Update existing lambdas to meet style guide > --- > > Key: MESOS-2670 > URL: https://issues.apache.org/jira/browse/MESOS-2670 > Project: Mesos > Issue Type: Task >Reporter: Joris Van Remoortere >Assignee: haosdent > Labels: c++11 > > There are already some lambdas in C++11 specific files. Modify these to meet > the updated style guide. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2670) Update existing lambdas to meet style guide
[ https://issues.apache.org/jira/browse/MESOS-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527781#comment-14527781 ] haosdent commented on MESOS-2670: - Thank you very much. > Update existing lambdas to meet style guide > --- > > Key: MESOS-2670 > URL: https://issues.apache.org/jira/browse/MESOS-2670 > Project: Mesos > Issue Type: Task >Reporter: Joris Van Remoortere >Assignee: haosdent > Labels: c++11 > > There are already some lambdas in C++11 specific files. Modify these to meet > the updated style guide. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2670) Update existing lambdas to meet style guide
[ https://issues.apache.org/jira/browse/MESOS-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527015#comment-14527015 ] Joris Van Remoortere commented on MESOS-2670: - [~haosdent] that should be a good way to catch them. Up until now, all C++11 lambdas have been in C++11 compilation dependent code. For example in the libprocess c++11 directory. This is a great starter ticket for you! I'm glad you found it. I will look at your review when I get a chance :-) > Update existing lambdas to meet style guide > --- > > Key: MESOS-2670 > URL: https://issues.apache.org/jira/browse/MESOS-2670 > Project: Mesos > Issue Type: Task >Reporter: Joris Van Remoortere >Assignee: haosdent > Labels: c++11 > > There are already some lambdas in C++11 specific files. Modify these to meet > the updated style guide. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2670) Update existing lambdas to meet style guide
[
https://issues.apache.org/jira/browse/MESOS-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525760#comment-14525760
]
haosdent commented on MESOS-2670:
-
Patch: https://reviews.apache.org/r/33794/
[~benjaminhindman] I use "[.]\s(" to find all the lambda usages, but I am not
sure if this is a correct way to cover all lambda in source code.
> Update existing lambdas to meet style guide
> ---
>
> Key: MESOS-2670
> URL: https://issues.apache.org/jira/browse/MESOS-2670
> Project: Mesos
> Issue Type: Task
>Reporter: Joris Van Remoortere
> Labels: c++11
>
> There are already some lambdas in C++11 specific files. Modify these to meet
> the updated style guide.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-2670) Update existing lambdas to meet style guide
[
https://issues.apache.org/jira/browse/MESOS-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525751#comment-14525751
]
haosdent commented on MESOS-2670:
-
Should we change "lambda::function" and "lambda::bind" to "[]() {}"
> Update existing lambdas to meet style guide
> ---
>
> Key: MESOS-2670
> URL: https://issues.apache.org/jira/browse/MESOS-2670
> Project: Mesos
> Issue Type: Task
>Reporter: Joris Van Remoortere
> Labels: c++11
>
> There are already some lambdas in C++11 specific files. Modify these to meet
> the updated style guide.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
