[jira] [Commented] (MESOS-3350) Create a protobuf VersionInfo to store mesos version information
[
https://issues.apache.org/jira/browse/MESOS-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072378#comment-15072378
]
Marco Massenzio commented on MESOS-3350:
[~vinodkone], [~bmahler]: Do you guys think this is still useful?
If yes, happy to implement it - please let me know what you think.
(if not, I'll just close it).
Thanks.
> Create a protobuf VersionInfo to store mesos version information
>
>
> Key: MESOS-3350
> URL: https://issues.apache.org/jira/browse/MESOS-3350
> Project: Mesos
> Issue Type: Improvement
>Reporter: haosdent
>Assignee: Marco Massenzio
> Labels: tech-debt
>
> Currently we use string to store mesos version in protobuf. In
> [MESOS-1841-reviews|https://reviews.apache.org/r/37024/], [~marco-mesos]
> think it would be better to create a protobuf struct which named VersionInfo
> like:
> {code}
> message VersionInfo {
> option string git_sha = 1;
> option string build_user = 2;
> x
> }
> {code}
> So that we could use this struct everywhere (expose informations to http
> endpoint, replace the version string in MasterInfo).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-3350) Create a protobuf VersionInfo to store mesos version information
[
https://issues.apache.org/jira/browse/MESOS-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14725741#comment-14725741
]
Marco Massenzio commented on MESOS-3350:
Can you also please add a link to the original review w/ comments (and maybe
the original Jira that generated that one)?
thanks!
> Create a protobuf VersionInfo to store mesos version information
>
>
> Key: MESOS-3350
> URL: https://issues.apache.org/jira/browse/MESOS-3350
> Project: Mesos
> Issue Type: Improvement
>Reporter: haosdent
>Assignee: Marco Massenzio
> Labels: tech-debt
>
> Currently we use string to store mesos version in protobuf. It would be
> better to create a protobuf struct which named VersionInfo like:
> {code}
> message VersionInfo {
> option string git_sha = 1;
> option string build_user = 2;
> x
> }
> {code}
> So that we could use this struct everywhere (expose informations to http
> endpoint, replace the version string in MasterInfo).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-3350) Create a protobuf VersionInfo to store mesos version information
[
https://issues.apache.org/jira/browse/MESOS-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14726760#comment-14726760
]
haosdent commented on MESOS-3350:
-
Sure, sorry forgot this before.
> Create a protobuf VersionInfo to store mesos version information
>
>
> Key: MESOS-3350
> URL: https://issues.apache.org/jira/browse/MESOS-3350
> Project: Mesos
> Issue Type: Improvement
>Reporter: haosdent
>Assignee: Marco Massenzio
> Labels: tech-debt
>
> Currently we use string to store mesos version in protobuf. It would be
> better to create a protobuf struct which named VersionInfo like:
> {code}
> message VersionInfo {
> option string git_sha = 1;
> option string build_user = 2;
> x
> }
> {code}
> So that we could use this struct everywhere (expose informations to http
> endpoint, replace the version string in MasterInfo).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
